7 Commits

Author	SHA1	Message	Date
Stefan Metzmacher	387f126d07	s3:smbd: remove static from release_file_oplock() ... It will be used in close.c in the next commit. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15125 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>	2022-09-20 00:34:35 +00:00
Stefan Metzmacher	a4dd4d5f0f	s3:smbd: maintain all SHARE_MODE_LEASE_* flags not only _READ ... Remember SMB2 Create is the only was to upgrade a lease. The strategy is that opening of a file will always result in storing the total lease bits. But we're lazy clearing the flags on close. We'll only clear them by traversing all entries when we break a NONE or when opening a new handle. We don't do any decision on SHARE_MODE_LEASE_{HANDLE,WRITE}, maybe we'll do in future, but at least it should be much more sane for debugging now! BUG: https://bugzilla.samba.org/show_bug.cgi?id=15125 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>	2022-09-20 00:34:35 +00:00
Stefan Metzmacher	aa7df0fb9f	s3:smbd: add smb_vfs_assert_allowed() to kernel oplock code ... Kernel oplocks can block in the same way vfs operations can do. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15125 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>	2022-09-20 00:34:35 +00:00
Stefan Metzmacher	76da56aa65	s3:smbd: inline fsp_lease_type_is_exclusive() logic into contend_level2_oplocks_begin_default ... SMB2_LEASE_WRITE is the indication for an exclusive lease, the fact that a SMB2_LEASE_WRITE can't exists without SMB2_LEASE_READ is not important here. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15125 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>	2022-08-19 18:41:34 +00:00
Stefan Metzmacher	96e2a82760	s3:smbd: only clear LEASE_READ if there's no read lease is left ... If contend_level2_oplocks_begin_default() skips break it's own lease, we should not clear SHARE_MODE_LEASE_READ in share_mode_data->flags. Otherwise that lease won't see any lease break notifications for writes from other clients (file handles not using the same lease key). So we need to count the number existing read leases (including the one with the same lease key) in order to know it's safe to clear SMB2_LEASE_READ/SHARE_MODE_LEASE_READ. Otherwise the next run (likely from another client) will get the wrong result from file_has_read_lease(). BUG: https://bugzilla.samba.org/show_bug.cgi?id=15148 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Aug 18 19:41:33 UTC 2022 on sn-devel-184	2022-08-18 19:41:33 +00:00
Stefan Metzmacher	7592aad4d7	s3:smbd: share_mode_flags_set() takes SMB2_LEASE_* values ... We currently only ever pass SMB2_LEASE_READ and both have the same value of 0x1, so for now it's only cosmetic, but that will change soon. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15148 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>	2022-08-18 18:45:34 +00:00
David Mulder	4f0a8e5b21	smbd: Move oplock.c -> smb2_oplock.c ... Signed-off-by: David Mulder <dmulder@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org>	2022-04-07 17:37:29 +00:00