1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-28 07:21:54 +03:00
Commit Graph

9598 Commits

Author SHA1 Message Date
Tim Potter
e25aa22a8f Merge:
> Exit path cleanup for cli_samr_enum_dom_users()
(This used to be commit 655c1e0351)
2003-02-24 02:12:39 +00:00
Andrew Bartlett
ded88da1ea Add const
(This used to be commit ffaa608be0)
2003-02-24 02:11:32 +00:00
Andrew Bartlett
e68684aa65 Fix 2 off-by-one bugs in the use of malloc()ed strings and safe_strcpy().
safe_strcpy() isn't particularly safe (this has been noted before) as it does
not take the size of the buffer, but instead the size of the buffer *minus 1*

The locking.c fix was causing segfaults on machines running with
--enable-developer, and was tracked down thanks to the fact that vance's build
farm machine runs with such an option, and smbtorture's DIR1 test hits this
bug very well.

(The --enable-developer code writes to the last byte of the string, to check
for incorrect use of safe_strcpy()).

Andrew Bartlett
(This used to be commit e908fd164d)
2003-02-24 01:13:31 +00:00
Simo Sorce
bd0bbde1bb forgot the altered include file
(This used to be commit f3be08472b)
2003-02-23 18:08:07 +00:00
Simo Sorce
bfc5f0ba8e move genparser to use talloc contexts instead of [m|c|re]alloc() and free()s
(This used to be commit 70fce680c0)
2003-02-23 17:40:43 +00:00
Andrew Bartlett
1d1ad2db2e Make sure we set the error code to indicate failure...
Andrew Bartlett
(This used to be commit 5a472e2a3c)
2003-02-22 20:11:29 +00:00
Andrew Bartlett
fa26737f40 See if I can make this look slightly like C. It compiled locally, honest...
Andrew Bartlett
(This used to be commit cfc4cc7768)
2003-02-22 20:01:00 +00:00
Andrew Bartlett
7e110f782a More signed/unsigned fixes (yes, I run with funny compiler options) and
make x_fwrite() match fwrite() in returning a size_t.

Andrew Bartlett
(This used to be commit 2943c69578)
2003-02-22 12:22:06 +00:00
Andrew Bartlett
0dde23a7b2 Fixes from Paul Green and vorlon@debian.org for building shared libraries
(make it possible to build both shared and static) and -lcrypt handling.
(This used to be commit 30510f5007)
2003-02-22 12:19:18 +00:00
Andrew Bartlett
db94beaa41 Fix comment - the other bits of code don't call this any more.
(This used to be commit 523d1429b1)
2003-02-22 12:17:02 +00:00
Andrew Bartlett
ae2f064dc6 Add static
(This used to be commit d0365f20c2)
2003-02-22 12:16:17 +00:00
Andrew Bartlett
e22a1915fe With assuptions about unixsam gone, we can forget about looking up
the user a second time now.

Andrew Bartlett
(This used to be commit a1e27a02f5)
2003-02-22 12:14:08 +00:00
Andrew Bartlett
3e19eda335 Remove 'unixsam' from the default passdb backends.
The intention is to remove the muliple passdb backends, but we need the
'guest' account to always be there.  If the admin adds the guest account to
(say) LDAP, there will only be one backend required for operation.

This helps remove some nasty behaviours with adding accounts to the system
for both the RPC 'create user' and the SAMSYNC code.  Users 'added' with
an 'add user/machine' script won't magicly appear, and machine accounts
'pre-added' to unix, but not the smbpasswd file will not cause mayhem.

This commit also implements somthing tridge discussed with me, the concept
of 'default' passdb operation pointers - so that each backend does not
need it's own stub funcitons wrapping the default tdb privilages/group
mapping code.

This also removes an implicit 'sid->name' and 'name->sid' mapping from our
own local SID space, to winbind usernames.  When adding mapping for NIS/LDAP
non-sam users in future, we need to be careful.

Andrew Bartlett
(This used to be commit 6f32fa2349)
2003-02-22 12:01:05 +00:00
Andrew Bartlett
ab43a25b28 First check if the user is in the passdb, then check Get_Pwnam().
We check passdb becouse the user might have things like a logon script set,
but we have to check the passdb becouse the user might not be in smbpasswd at
all.

This is in preperation for the removal of unixsam as an assuption.

Andrew Bartlett
(This used to be commit 61e3e26958)
2003-02-22 11:34:04 +00:00
Jeremy Allison
4fdb86eb3b When checking is_locked() new WRITE locks conflict with existing READ locks even
if the context is the same. See LOCKTEST7 in smbtorture.
Jeremy.
(This used to be commit b362cc241b)
2003-02-22 01:09:42 +00:00
Jeremy Allison
ca2e995576 New locktest7 code based on patch from "Srikanta Shivanna" <sshivanna@pillardata.com>
Jeremy.
(This used to be commit caf298c380)
2003-02-22 01:08:19 +00:00
Andrew Bartlett
301ebd6324 Fix a DEBUG() formatting, add some more debug to our SID pulling code and
inline the call to prs_copy_all_data_out() so that we can know we are not
overrunning our buffer.

Also check more return values.

Andrew Bartlett
(This used to be commit e3b73d5d65)
2003-02-22 00:54:08 +00:00
Gerald Carter
3d730f89cf i patched the wrong branch! s/unistr2_to_dos/unistr2_to_ascii/
(This used to be commit 513fb2ddd8)
2003-02-21 20:00:46 +00:00
Gerald Carter
ab985b983f couple of merges from APP_HEAD
* performance optimization in enumprinterdataex() when keyname is empty
  * fix a few typos in comments
  * reload services after addprinter_command()

dump registry data in ascii when the key is REG_SZ or REG_MULTI_SZ
(This used to be commit fde6ef7cc6)
2003-02-21 17:08:43 +00:00
Gerald Carter
193f9200aa patch from Hal Roberts check for a valid [f]chmod_acl function pointer before calling it. Fixes seg fault in audit VFS module
(This used to be commit 5e115d4381)
2003-02-21 16:15:30 +00:00
Jim McDonough
23553b48e6 Fix IRIX build...void fn can't return another void fn
(This used to be commit df3c7c9cbb)
2003-02-21 14:35:02 +00:00
Jim McDonough
db721d24c5 rename 'winbind backend' to 'idmap backend'. Put paramter in security section...does this make sense?
(This used to be commit 822083f73e)
2003-02-21 13:25:10 +00:00
Jeremy Allison
2935d15376 Added comments to make it clearer when we're assigning a pointer that it
must not be freed afterwards.
Jeremy.
(This used to be commit 80bad908c0)
2003-02-21 06:25:39 +00:00
Tim Potter
6a46281dbb Ignore errors on python_clean target.
(This used to be commit 3805a9c5d5)
2003-02-21 05:51:10 +00:00
Tim Potter
e1c987abf2 Doesn't anyone run ./configure.developer anymore?
(This used to be commit 09be123c6c)
2003-02-21 05:07:51 +00:00
Tim Potter
7eff9dd5ef Fix another compiler warning.
(This used to be commit 1ea27d7987)
2003-02-21 05:06:49 +00:00
Tim Potter
38cb0a122f Fixed another compiler warning.
(This used to be commit d15b7425d4)
2003-02-21 04:53:39 +00:00
Tim Potter
9383d61f6c Fixed compiler warning.
(This used to be commit b3f9cf8c1c)
2003-02-21 04:47:24 +00:00
Tim Potter
696895d5b1 Added enumdomusers command.
(This used to be commit 30353da3e9)
2003-02-21 04:28:32 +00:00
Tim Potter
ae8d3538c7 Exit path cleanup for cli_samr_enum_dom_users()
(This used to be commit 0bc1dfc68b)
2003-02-21 04:26:58 +00:00
Tim Potter
4834c61ebc Fix for only specifying one command with -c
(This used to be commit 7418351427)
2003-02-21 04:25:04 +00:00
Martin Pool
1fc2976e14 Doxygen janitor
(This used to be commit 3679975629)
2003-02-21 03:05:55 +00:00
Jim McDonough
5bec7f5fca From aliguori@us.ibm.com:
This patch adds the architecture for an IDMAP backend system including a new
smb.conf parameter "winbind backend".  Right now, the only valid value is "tdb"
but I'm currently working on an LDAP backend.
(This used to be commit 35e4448dcb)
2003-02-20 22:46:37 +00:00
Jelmer Vernooij
8d8a8c9633 Make init_module() and thus smb_load_module() return an int.
modules/developer.c: init_module() should return an int
(This used to be commit 7f59703550)
2003-02-20 22:26:28 +00:00
Jeremy Allison
1009ef3e37 Added Volkers "print server role" patch.
Jeremy.
(This used to be commit e81d72ac22)
2003-02-20 22:09:57 +00:00
Jelmer Vernooij
9d913a62ad Remove obsolete files
(This used to be commit f035cba2cf)
2003-02-20 19:10:19 +00:00
Jeremy Allison
14401bb368 Ensure tdb error code is set for corrupt and i/o errors before calling
the log function. This allows the log function to take action.
Jeremy.
(This used to be commit 0fa310cbc3)
2003-02-20 18:54:12 +00:00
Andrew Bartlett
d7b4f389e9 For a number of months now, support for being a domain member without also
running winbind has been broken.  This fixes that, by removing assumptions
about being able to call sid_to_uid() at will.  This whole area needs
revising when we get groups into the PDB.

Andrew Bartlett
(This used to be commit 980eda74b7)
2003-02-20 12:01:39 +00:00
Andrew Bartlett
512405321a Like for NTLM logins, lookup the 'winbind' user first, then the 'local' user.
This needs to change, to be a SID->UID lookup from the PAC.

Andrew Bartlett
(This used to be commit 4071ed06a0)
2003-02-20 10:50:09 +00:00
Andrew Bartlett
215ff67a03 for some (very weird) reason, the domain I was testing aginst would not
return a DN for the user.  Make sure we don't segfault.

Andrew Bartlett
(This used to be commit 9fdedeff6a)
2003-02-20 10:43:21 +00:00
Martin Pool
f8d9cf2726 Doc
(This used to be commit 5d7d400d6c)
2003-02-20 04:01:25 +00:00
Martin Pool
9061aae9b4 (Merge from APPLIANCE_HEAD)
CR1829: Fix memory leak when unpacking 'B' buffers in Python.

(PyList_Append creates a new reference to the added object, and so we
have to release the existing one.)
(This used to be commit 55e114f596)
2003-02-20 03:33:20 +00:00
Jeremy Allison
673cdea310 Fix inspired by Stefan (metze) Metzmacher - cache the sidtype also.
Jeremy.
(This used to be commit 634f20dff6)
2003-02-19 22:30:57 +00:00
Simo Sorce
29b94266df correct init for vfs.conn, thanks Stefan
(This used to be commit 162683d2b5)
2003-02-19 22:26:19 +00:00
Jim McDonough
de88e704ce libads/krb5_setpw.c
(This used to be commit 4c52d7bd93)
2003-02-19 20:37:34 +00:00
Jim McDonough
f15ed71fbb Can't return SAFE_FREE...put on its own line.
(This used to be commit 9f1a4809b5)
2003-02-19 15:46:15 +00:00
Jim McDonough
ffcee0c95e Correct way to keep fucntion from proto.h
(This used to be commit 762b072efb)
2003-02-19 15:22:46 +00:00
Jim McDonough
ad03d0a4f8 Fix segv in net ads join...an extra & was the culprit
(This used to be commit 9874b233d5)
2003-02-19 15:03:04 +00:00
Alexander Bokovoy
02cb49bffa Improve detection of iconv(3) for various platforms. M4 code is similar to what I use in Midgard for past few years, modified for Samba needs.
(This used to be commit 747d2d70a9)
2003-02-19 13:24:06 +00:00
Andrew Bartlett
6540693fea Missed one use of SETENV. (Compat macro no longer needed, as we have a
replace.c function).
(This used to be commit adad4c66fc)
2003-02-19 12:19:52 +00:00