1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-28 17:47:29 +03:00

15779 Commits

Author SHA1 Message Date
Jeremy Allison
915cfb48f0 r11433: Fix for bug #3223 - ensure we're root before doing
any potential lib/smbldap.c calls.
Jeremy.
2007-10-10 11:05:16 -05:00
Jeremy Allison
7edb26e765 r11428: Fix bug #3192 by actually hooking up the dfree caching
function. Oops.
Jeremy.
2007-10-10 11:05:15 -05:00
Jeremy Allison
4cd8e2a96b r11420: Fix issue pointed out by Dina Fine <dina@exanet.com>. We can
only tell at parse time from the wire if an incoming name
has wildcards or not. If it's a mangled name and we demangle
the demangled name may contain wildcard characters. Ensure
these are ignored.
Jeremy.
2007-10-10 11:05:15 -05:00
Jeremy Allison
71c037dfbb r11389: Attempt to fix bug #3212 - ignore bogus OS/2 EA set values on
trans2_mkdir/trans2_open/trans2_setfilepathingo.
Jeremy.
2007-10-10 11:05:14 -05:00
Jeremy Allison
3d8faf42e8 r11383: Patch from Alex Masterov <alex@infobit.ru> to fix
XATTR calls on *BSD systems (bug #3218).
Jeremy.
2007-10-10 11:05:14 -05:00
Volker Lendecke
440e7b3342 r11381: Correctly connect to 445 and 139 after a successful getdcname.
Volker
2007-10-10 11:05:14 -05:00
Jeremy Allison
7fb0587261 r11379: Remove external dependencies from sharemodes library.
Jeremy.
2007-10-10 11:05:14 -05:00
Paul Green
eee397ea15 r11375: Update to the latest config.guess and config.sub files. 2007-10-10 11:05:14 -05:00
Volker Lendecke
d20388750d r11368: Remove a memleak that just cost me half an hour: If we terminate inside a
message handler, the list of messages from retrieve_all_messages is not
properly freed. Not important, just confusing :-)

Volker
2007-10-10 11:05:14 -05:00
Jeremy Allison
238b35d2e6 r11346: Fix for bug found by Dina Fine. If in case sensitive mode then
the mangle cache is no good (3 letter extension could be wrong
case - so don't demangle in this case - leave as mangled and
allow the mangling of the directory entry read (which is done
case insensitively) to match instead. This will lead to more
false positive matches but we fail completely without it.
Jeremy.
2007-10-10 11:05:13 -05:00
Jeremy Allison
e959a5be39 r11344: I don't think share mode conflicts occur on deleting
a directory when you've got permissions. Need to write
a smbtorture test for this.
Jeremy.
2007-10-10 11:05:13 -05:00
Jeremy Allison
1134abbbb3 r11341: Put directory opens into the share mode db so we
can treat them similarly to file opens (delete on
close, share mode violations etc.). This fixes bug
#3216 I will up the default hash size on the locking
db in a later commit as this means more entries.
Jeremy.
2007-10-10 11:05:13 -05:00
Jeremy Allison
aeca4efa11 r11338: Move knowledge of \\ needed into rpc_client/cli_netlogon
(this is the way it's been done in other functions). Instead
of moving this into the IDL, I think the best solution would
be to write a wrapper function around any call that needs
this (this is what we already do for many of the calls).
Jeremy.
2007-10-10 11:05:13 -05:00
Jeremy Allison
f313757e36 r11336: Start to get my control back :-). Volker, I think
Andrew Bartlett is right - making lsa code do it the
netlogon way, not vica-versa.
Jeremy.
2007-10-10 11:05:13 -05:00
Gerald Carter
f5f40633bc r11332: eventlog API uses NTSTATUS, not WERROR for return codes 2007-10-10 11:05:13 -05:00
Volker Lendecke
48a9e35208 r11328: Actually verify that the bind on a pipe succeeded with a samr_connect or
lsa_openpolicy and fall back appropriately. In particular an ntlmssp bind
failure can not be detected before the first real rpc request, at least
according to abartlet :-)

Works for me against w2k3, w2k and nt4. Sooner or later I should test against
samba4 ... :-)

Volker
2007-10-10 11:05:13 -05:00
Volker Lendecke
37267d5ab0 r11327: Make user domain settable by pdbedit 2007-10-10 11:05:12 -05:00
Volker Lendecke
9741818d2c r11326: Fix alignment in getdc response 2007-10-10 11:05:12 -05:00
Volker Lendecke
0603e1c845 r11324: Re-formatting before I can get a very *narrow* focus on the bugs in here. ;-)
We can only tell if the bind succeeded on the first real RPC call. So we have
to decide according to success of samrconnect whether we have to fall
back. Similarly for lsaopenpolicy.

Volker
2007-10-10 11:05:12 -05:00
Volker Lendecke
770ad2a8a7 r11323: Fix usage of rpccli_netlogon_getdcname. Add some debug messages.
Volker
2007-10-10 11:05:11 -05:00
Volker Lendecke
8d7713431e r11320: Fix error handling for rpccli_netlogon_getdcname. Jeremy, the other functions
in cli_netlogon look similarly suspicious.

Volker
2007-10-10 11:05:11 -05:00
Volker Lendecke
6948f748f6 r11319: read_buf_len and write_buf_len are no longer used, remove them.
Volker
2007-10-10 11:05:11 -05:00
Gerald Carter
c495059de1 r11301: why would you look for printf in -lnsl[_s]? Fixing configure checks 2007-10-10 11:05:11 -05:00
Gerald Carter
88a33c4cf8 r11296: removing unused variable and ifdef'd out code 2007-10-10 11:05:11 -05:00
Gerald Carter
e0bf0581f0 r11295: new service hashing code has assumign that the service
name stored in the array was normalized.  This was causing
records to not be deleted on a reload.  As a result,
I was getting the wrong path for various services.
Seems to be ok after this change.

Also converted canonicalize_servicename() to just
use strupper_m() rather than doing the conversion itself.
Jeremy, i think this should be ok but please check.

also cleaned up some things in the hash service code
and added debug messages for sanity purposes.
2007-10-10 11:05:11 -05:00
Gerald Carter
747fba4dbf r11292: Missed merge from Samba 2.2 many years ago....
Don't count open pipes in the num_files_open on a connection.
conn_idle_all() handles this by looking for open rpc handles
If there are no open handles, we can close the IPC$ share.
2007-10-10 11:05:10 -05:00
Volker Lendecke
f4c310d556 r11286: Fix a potential segfault 2007-10-10 11:05:10 -05:00
Jeremy Allison
f68ff32630 r11283: Move to using sival_int from sival_ptr. Part of bug #2922.
Jeremy.
2007-10-10 11:05:10 -05:00
Gerald Carter
8c63d6d8a7 r11280: BUG 3201: make sure request structure is cleared prior to sending the request to winbindd (prevents the WB_RECURSE flags from accidentially getting set 2007-10-10 11:05:10 -05:00
Gerald Carter
dd28582efb r11275: patch from Chris to remove the empty struct in libmsrpc.h (fix build with Sun compiler) 2007-10-10 11:05:10 -05:00
Jeremy Allison
83d0cda858 r11269: Ensure the new canonicalize_servicename() is mb safe.
MB service names may contain embedded ' ' characters.
Jeremy.
2007-10-10 11:05:10 -05:00
Volker Lendecke
d07343e0c4 r11266: Speed up loading smb.conf for large numbers of share definitions. The problem
was a O(n^2) loop: Whenever a service definition was found, we linearly
searched the already loaded share definitions, the patch adds an internal tdb
for this. For a smb.conf with 2000 shares this speeds up loading by about a
factor of 50.

Might be a fix for bug #1117.

Thanks to Michael Adam <ma@sernet.de>,

Volker
2007-10-10 11:05:10 -05:00
Jeremy Allison
f46d847065 r11256: Remove use of long long and strtoll in libsmbclient (we
can't assume long long is always there). Removed unused
var in new a/c rename code.
long long still used in eventlog code but Jerry has promised
to fix that.
Jeremy.
2007-10-10 11:05:09 -05:00
Volker Lendecke
10fb32ec52 r11253: Fix an annoying timeout when no nmbd is around 2007-10-10 11:05:09 -05:00
Volker Lendecke
1ce6d12898 r11251: Fix a comment 2007-10-10 11:05:09 -05:00
Günther Deschner
db38ed6be6 r11242: use LDAP bitwise machting rule when searching for groups in ADS.
This avoids that each time a full-group-dump is requested from ADS; the
bitwise match allows to only query those groups we are interested in.

The ADS LDAP server changed to RFC compliant behaviour when decoding the ldap
filter with extensible match in the latest SPs (fixes). From the patch:

/* Workaround ADS LDAP bug present in MS W2K3 SP0 and W2K SP4 w/o
  * rollup-fixes:
  *
  * According to Section 5.1(4) of RFC 2251 if a value of a type is it's
  * default value, it MUST be absent. In case of extensible matching the
  * "dnattr" boolean defaults to FALSE and so it must be only be present
  * when set to TRUE.
  *
  * When it is set to FALSE and the OpenLDAP lib (correctly) encodes a
  * filter using bitwise matching rule then a buggy AD fails to decode
  * the extensible match. As a workaround set it to TRUE and thereby add
  * the dnAttributes "dn" field to cope with those older AD versions.
  * It should not harm and won't put any additional load on the AD since
  * none of the dn components have a bitmask-attribute.
  *
  * Thanks to Ralf Haferkamp for input and testing */

Guenther
2007-10-10 11:05:09 -05:00
Gerald Carter
18400f9662 r11240: * fix invalid read reported by valgrind in the
spoolss backchannel connection by rewriting
  spoolss_connect_to_client().  Ensure that we
  save the cli_state* in the rpc_pipe_client struct.

* fix typo in debug message in cli_start_connection"
2007-10-10 11:05:09 -05:00
Jeremy Allison
7e1318e09b r11237: Fix acl evaluation bug found by Marc Cousin <mcousin@sigma.fr>
We should only check the S_IWGRP permissions if we haven't already
seen an owning group SMB_ACL_GROUP_OBJ ace entry. If there is an
SMB_ACL_GROUP_OBJ ace entry then the group bits in st_gid are
the same as the SMB_ACL_MASK bits, not the SMB_ACL_GROUP_OBJ
bits. Thanks to Marc Cousin <mcousin@sigma.fr> for pointing
this out.
Jeremy.
2007-10-10 11:05:09 -05:00
Jim McDonough
ee91eb9a39 r11236: Implement user rename for smbpasswd and ldap backends. Some cleanup on
tdb as well to make naming consistent.
2007-10-10 11:05:08 -05:00
Gerald Carter
f6f78877b4 r11235: fix segfault in addprinter due to mixing talloc() and malloc()'d memory 2007-10-10 11:05:08 -05:00
Jeremy Allison
797b9f47e9 r11233: Forgot to add the statvfs file. Oops.
Jeremy.
2007-10-10 11:05:08 -05:00
Jeremy Allison
af85458067 r11232: Added ab's POSIX statvfs vfs call. Sorry for the delay ab.
Jeremy.
2007-10-10 11:05:08 -05:00
Jim McDonough
cda5a81bbe r11230: Remove the '//' i was using to test something...oops 2007-10-10 11:05:08 -05:00
Jim McDonough
de3d0094b7 r11229: an even bigger speedup spotted by Volker. string_to_sid() is now taking 1/5th
the time it used to.  Replace strcasecmp with invididual char checks for
"S-" sid prefix.
2007-10-10 11:05:07 -05:00
Jim McDonough
e5cc94f13f r11228: Speed up string_to_sid by removing next_token calls, thus eliminating
the need for allocating memory to duplicate the string.
2007-10-10 11:05:07 -05:00
Gerald Carter
34c3fd77b3 r11227: patch from brian moran to fix typo in eventlog message file registry value name 2007-10-10 11:05:06 -05:00
Lars Müller
3944dfbff4 r11224: Add feature to get our configuration from config.log into installman.sh.
This allows us to install for example smbsh.1 only if SMBWRAPPER is set.

Removed also one rm call as we copy and do not append to the same file
in the next step.  There is no file permission risk as we chmod 0644 in
any case later.

Replaced one basename call by shell substitution.
2007-10-10 11:05:06 -05:00
Günther Deschner
908ac0c9ec r11213: Fix the build
Guenther
2007-10-10 11:05:06 -05:00
Jeremy Allison
49ef8b88a3 r11190: Fix enhancement request #3192.
This does 2 things.
1). Makes dfree command a per-share parameter (it should be anyway IMHO).
2). Adds a "dfree cache time" parameter in seconds that specifies how long a
dfree command output should be cached for. Default is zero (no caching).
Jeremy.
2007-10-10 11:05:06 -05:00
Günther Deschner
a8d5d6b845 r11183: add small helper function to return a PAC_LOGON_INFO.
Guenther
2007-10-10 11:05:06 -05:00