1
0
mirror of https://github.com/samba-team/samba.git synced 2025-02-04 17:47:26 +03:00

2726 Commits

Author SHA1 Message Date
Jeremy Allison
e7d2e311a2 r12234: Reduce the race condition for renames by holding the lock
longer. Instigated by complaints on the fix for #3303 from
SATOH Fumiyasu <fumiyas@miraclelinux.com>.
Jeremy.
(This used to be commit 855f5f8c32aa530dbad244805a40200824724618)
2007-10-10 11:05:50 -05:00
Jeremy Allison
ab7a4f7e8e r12213: Final fix for #3303 - send rename messages to smbd's
that have open file handles to allow them to correctly
implement delete on close. There is a further correctness
fix I'm intending to add to this to cope with different share
paths, but not right now...
Jeremy.
(This used to be commit 932e337db8788e75344e1c7cf1ef009d090cb039)
2007-10-10 11:05:49 -05:00
Jeremy Allison
7d2771e758 r12203: Add the share path into the sharemode db. This involves
revving the minor version number for libsmbsharemodes (we
now have a new _ex interface that takes the share path
as well as the filename). Needed for #3303. Some code written
by SATOH Fumiyasu <fumiya@samba.gr.jp> included in the changes
to locking/locking.c. The smbstatus output is a bit of a mess
and needs overhauling...
Jeremy.
(This used to be commit 9d93af713f8520ca506730dd32aa2b994937eaba)
2007-10-10 11:05:49 -05:00
Jeremy Allison
fa4df827d0 r12194: Ensure that when we set a connection path we've canonicalized
the name (must be abolute - start with /, must not end in /,
must have ./ and ../ removed). Of course for realpath resolved
paths this won't be the case but for others we need this name
to be canonicalized. This name is going into the sharemode db
for #3303 so needs to be in a normalized format.
Jeremy.
(This used to be commit 22e3300911809692b595f49e87d91e3111923e6a)
2007-10-10 11:05:48 -05:00
Volker Lendecke
661c5c741a r12163: Change lookup_sid and lookup_name to return const char * instead of char *,
use a temporary talloc_ctx for clarity.

Volker
(This used to be commit b15815c804bf3e558ed6357b5e9a6e3e0fac777f)
2007-10-10 11:05:46 -05:00
Jeremy Allison
78fa625d25 r12160: The filename parameter to get_share_mode_lock is going
to become very important as we fix #3303, so make sure
we don't accidently set it here.
Jeremy.
(This used to be commit d1a9d0587cd9a391f0193ca76cb319803c6e019f)
2007-10-10 11:05:46 -05:00
Lars Müller
f6a46f3329 r12076: Ensure setmntent() returns with != NULL in the disk_quotas() Linux
version.

The IRIX 6.2 version is still without this check as I'm not sure if
setmntent() is implemented in the same way.
(This used to be commit 519ed7ca0ecffbc341c7516758a678af59f98586)
2007-10-10 11:05:43 -05:00
Volker Lendecke
05ac2de0df r12051: Merge across the lookup_name and lookup_sid work. Lets see how the build farm
reacts :-)

Volker
(This used to be commit 9f99d04a54588cd9d1a1ab163ebb304437f932f7)
2007-10-10 11:05:43 -05:00
Jeremy Allison
d1f91f7c72 r12043: It's amazing the warnings you find when compiling on a 64-bit
box with gcc4 and -O6...
Fix a bunch of C99 dereferencing type-punned pointer will break
strict-aliasing rules errors. Also added prs_int32 (not uint32...)
as it's needed in one place. Find places where prs_uint32 was being
used to marshall/unmarshall a time_t (a big no no on 64-bits).
More warning fixes to come.
Thanks to Volker for nudging me to compile like this.
Jeremy.
(This used to be commit c65b752604f8f58abc4e7ae8514dc2c7f086271c)
2007-10-10 11:05:42 -05:00
Jeremy Allison
defe1f3aa8 r11945: Make us follow the newly documented pathname processing rules:
"As a special case for directories with large numbers of files, if the
case options are set as follows, "case sensitive = yes", "case
preserve = no", "short preserve case = no" then the "default case"
option will be applied and will modify all filenames sent from the client
when accessing this share."
This is needed as fixing the case preserve rules to only apply to
new filenames broke the large directory fix. Glad we caught this
before release. Thanks to jht for this one.
Jeremy.
(This used to be commit abc21cc7322d695cf77b6fb18f4ecdb16288c19b)
2007-10-10 11:05:38 -05:00
Jeremy Allison
e5b9a027ff r11943: Don't reset attrs to zero in EA get - we are adding
to the attr list not resetting it.
Jeremy.
(This used to be commit 8ee569626be7ebf3b6ebf71e1becdd091b9e893a)
2007-10-10 11:05:38 -05:00
Volker Lendecke
1bfb5b734b r11909: Implement 'reset on zero vc'. This kills other connections when a session
setup comes in with the vc (virtual connection) field set to zero. This is
done by Windows, probably you can tweak that by some registry key.

	This boolean option controls whether an incoming session setup
	should kill other connections coming from the same IP. This matches
        the default Windows 2003 behaviour.

	Setting this parameter to yes becomes necessary when you have a flaky
	network and windows decides to reconnect while the old connection
	still has files with share modes open. These files become inaccessible
	over the new connection.

	The client sends a zero VC on the new connection, and Windows 2003
	kills all other connections coming from the same IP. This way the
	locked files are accessible again.

	Please be aware that enabling this option will kill connections behind
	a masquerading router.

Volker
(This used to be commit 5629ca16235f0aa21fea3afd9e414309e4e1374e)
2007-10-10 11:05:34 -05:00
Jeremy Allison
056f06915e r11861: Fix inspired by Thomas Neumann <t.neumann@iku-ag.de> to ensure that
default case applies only to new files and correctly examines 8.3
and long names.
Jeremy.
(This used to be commit ba931a015132f7e8fffa52c617cd8345a1da35d2)
2007-10-10 11:05:31 -05:00
Günther Deschner
90603cb3cd r11846: Destroy the TALLOC_CTX on error in the Kerberos session setup and give a
more precise inline comment why PAC verification may fail.

Guenther
(This used to be commit 43b57715e9b44a0a0c7cc7fe3674a5fd4369e78b)
2007-10-10 11:05:29 -05:00
Jeremy Allison
394f87b914 r11767: Doesn't need to be exported.
Jeremy.
(This used to be commit 52b6f0db2e4a209641187255bd8815c8d03a5315)
2007-10-10 11:05:27 -05:00
Jeremy Allison
4c8fc93905 r11718: Filter stored DOS attributes by SAMBA_ATTRIBUTES_MASK (0x7f).
Jeremy.
(This used to be commit 61444049e1543b364eea2ee79743287c75d37db5)
2007-10-10 11:05:25 -05:00
Gerald Carter
a4d729bdfa r11661: Store the INFO3 in the PAC data into the netsamlogon_cache.
Also remove the mem_ctx from the netsamlogon_cache_store() API.

Guenther, what should we be doing with the other fields in
the PAC_LOGON_INFO?
(This used to be commit 8bead2d2825015fe41ba7d7401a12c06c29ea7f7)
2007-10-10 11:05:23 -05:00
Paul Green
5a06869da7 r11657: Tiny improvement to debug error message in dir_check_ftype.
(This used to be commit 46674ca21d9c257bc48af97e313b49118c7b478d)
2007-10-10 11:05:23 -05:00
Gerald Carter
9d9fe2d58d r11655: Two small fixes
* remove redundant call to sub_set_smb_name() in session setup code.
* Fix lockup when running 'wbinfo -t' on a Samba PDC.  Cause
  was new authenticated session setup from winbindd which
  resulted in a mangled username (machine_) that was not found
  in the local files and so was queiued up to nss_winbindd.
  Deadlock....
  So now make sure to keep the trailing '$' for machine account
  names when calling sub_set_smb_name().
(This used to be commit b0a2d43b603c2e230da6ada73587696605102e8f)
2007-10-10 11:05:23 -05:00
Jeremy Allison
6d5757395a r11511: A classic "friday night check-in" :-). This moves much
of the Samba4 timezone handling code back into Samba3.
Gets rid of "kludge-gmt" and removes the effectiveness
of the parameter "time offset" (I can add this back
in very easily if needed) - it's no longer being
looked at. I'm hoping this will fix the problems people
have been having with DST transitions. I'll start comprehensive
testing tomorrow, but for now all modifications are done.
Splits time get/set functions into srv_XXX and cli_XXX
as they need to look at different timezone offsets.
Get rid of much of the "efficiency" cruft that was
added to Samba back in the day when the C library
timezone handling functions were slow.
Jeremy.
(This used to be commit 414303bc0272f207046b471a0364fa296b67c1f8)
2007-10-10 11:05:19 -05:00
Jeremy Allison
c9effb004c r11451: Fix -O1 "might be using uninitialized" errors.
Jeremy.
(This used to be commit cab76c3c33883aad444eefb6562ab1b27d9ca88a)
2007-10-10 11:05:16 -05:00
Jeremy Allison
a3d66dfef7 r11448: Move decl before code.
Jeremy.
(This used to be commit f22822790cdbbe7d5a237421c1eda73a504e488d)
2007-10-10 11:05:16 -05:00
Jeremy Allison
86909281c8 r11428: Fix bug #3192 by actually hooking up the dfree caching
function. Oops.
Jeremy.
(This used to be commit 7edb26e7657fc01710abe563b941779749409ef2)
2007-10-10 11:05:15 -05:00
Jeremy Allison
6baec64a73 r11420: Fix issue pointed out by Dina Fine <dina@exanet.com>. We can
only tell at parse time from the wire if an incoming name
has wildcards or not. If it's a mangled name and we demangle
the demangled name may contain wildcard characters. Ensure
these are ignored.
Jeremy.
(This used to be commit 4cd8e2a96b98ff711905e8c6f416b22440c16062)
2007-10-10 11:05:15 -05:00
Jeremy Allison
3a5c37bfd1 r11389: Attempt to fix bug #3212 - ignore bogus OS/2 EA set values on
trans2_mkdir/trans2_open/trans2_setfilepathingo.
Jeremy.
(This used to be commit 71c037dfbb0b51e750f2e14533b03d9932778cb0)
2007-10-10 11:05:14 -05:00
Jeremy Allison
f9b7505429 r11346: Fix for bug found by Dina Fine. If in case sensitive mode then
the mangle cache is no good (3 letter extension could be wrong
case - so don't demangle in this case - leave as mangled and
allow the mangling of the directory entry read (which is done
case insensitively) to match instead. This will lead to more
false positive matches but we fail completely without it.
Jeremy.
(This used to be commit 238b35d2e6e21d0e07d500d446f08ec128ea7720)
2007-10-10 11:05:13 -05:00
Jeremy Allison
c0dad16e0f r11344: I don't think share mode conflicts occur on deleting
a directory when you've got permissions. Need to write
a smbtorture test for this.
Jeremy.
(This used to be commit e959a5be393eb59b8987eb6967a2ee5d11978f41)
2007-10-10 11:05:13 -05:00
Jeremy Allison
533da83852 r11341: Put directory opens into the share mode db so we
can treat them similarly to file opens (delete on
close, share mode violations etc.). This fixes bug
#3216 I will up the default hash size on the locking
db in a later commit as this means more entries.
Jeremy.
(This used to be commit 1134abbbb3fd8e8b88e1a5817aae106476a4c126)
2007-10-10 11:05:13 -05:00
Jeremy Allison
bd9b6a249a r11283: Move to using sival_int from sival_ptr. Part of bug #2922.
Jeremy.
(This used to be commit f68ff32630ee3b06b69bac59674ecc1496880a47)
2007-10-10 11:05:10 -05:00
Jeremy Allison
0feff5b604 r11237: Fix acl evaluation bug found by Marc Cousin <mcousin@sigma.fr>
We should only check the S_IWGRP permissions if we haven't already
seen an owning group SMB_ACL_GROUP_OBJ ace entry. If there is an
SMB_ACL_GROUP_OBJ ace entry then the group bits in st_gid are
the same as the SMB_ACL_MASK bits, not the SMB_ACL_GROUP_OBJ
bits. Thanks to Marc Cousin <mcousin@sigma.fr> for pointing
this out.
Jeremy.
(This used to be commit 7e1318e09bd4b155707020142b08776a546a646e)
2007-10-10 11:05:09 -05:00
Jeremy Allison
eb7a808f98 r11233: Forgot to add the statvfs file. Oops.
Jeremy.
(This used to be commit 797b9f47e98bed500dc3dd6ec8de51a0ec3e2bd7)
2007-10-10 11:05:08 -05:00
Jeremy Allison
a5b339c799 r11232: Added ab's POSIX statvfs vfs call. Sorry for the delay ab.
Jeremy.
(This used to be commit af8545806770a7530eecc184bdd230ca14999884)
2007-10-10 11:05:08 -05:00
Günther Deschner
ad7cd4096f r11213: Fix the build
Guenther
(This used to be commit 908ac0c9eccd1ba368a6305fee9673770fc74a53)
2007-10-10 11:05:06 -05:00
Jeremy Allison
c6aea6ef2d r11190: Fix enhancement request #3192.
This does 2 things.
1). Makes dfree command a per-share parameter (it should be anyway IMHO).
2). Adds a "dfree cache time" parameter in seconds that specifies how long a
dfree command output should be cached for. Default is zero (no caching).
Jeremy.
(This used to be commit 49ef8b88a3e12883148eb28d8e86fb07dbc3d12d)
2007-10-10 11:05:06 -05:00
Günther Deschner
ad93243f23 r11183: add small helper function to return a PAC_LOGON_INFO.
Guenther
(This used to be commit a8d5d6b845efb62e73e281549528376f3ee74211)
2007-10-10 11:05:06 -05:00
Jeremy Allison
8d7c886671 r11137: Compile with only 2 warnings (I'm still working on that code) on a gcc4
x86_64 box.
Jeremy.
(This used to be commit d720867a788c735e56d53d63265255830ec21208)
2007-10-10 11:05:02 -05:00
Gerald Carter
bb68761a50 r11060: merging new eventlog code from trunk
(This used to be commit 1bcf7e82ede63a851a244162a3b939373787b693)
2007-10-10 11:04:59 -05:00
Jeremy Allison
a1eb525504 r10979: After discussions on IRC about profile shares,
added new parameter : map readonly = [yes|no|permissions]
If yes: map inverse of user "w" bit to mean readonly.
If no: never set DOS readonly bit.
If permissions: check file permissions for user and set readonly
bit if the current user cannot write.
If store dos attributes is set to yes then this parameter
is ignored.
Jeremy.
(This used to be commit da4238d18c7a57d1264db8517fb027a10a11baed)
2007-10-10 11:04:59 -05:00
Jeremy Allison
97a321e557 r10974: Get closer to trying to fix #1825 (PcoketPC spnego bug). Ensure we
set keylen to zero if no spnego.
Jeremy.
(This used to be commit 57ed94e6e4a095422496d92a0095dc48cfecdd68)
2007-10-10 11:04:58 -05:00
Jeremy Allison
4a190ec27b r10947: Fix bugs #3133 and #1828 - SPNEGO not working with PocketPC 2003.
Our sessionsetup code now handles raw NTLMSSP connects, so we can go
back to doing what W2K3 does here which is to send no OID's in
the negprot reply when not in a security=ads mode.
Jeremy.
(This used to be commit 38a70185b7ca20677026103d40f61608e7ad0c90)
2007-10-10 11:04:57 -05:00
Jeremy Allison
c5260e733c r10943: Unused variable. Bug #3160 from jason@ncac.gwu.edu
Jeremy.
(This used to be commit 5647a5d4b0b7e9083963bfe899e9e0f348ec8bf2)
2007-10-10 11:04:57 -05:00
Jeremy Allison
bd87876a8b r10930: Fix erroneous debug spotted by Herb.
Jeremy.
(This used to be commit b2e22e7d128dc22d62f56fda294dc7abc076dc64)
2007-10-10 11:04:56 -05:00
Gerald Carter
111f8e5995 r10921: BUG 3070: fix crash bug in qfsinfo when retrieving quota info
(This used to be commit 1599fc38ab2f2beb5d1a240941b879603ce27ae6)
2007-10-10 11:04:56 -05:00
Gerald Carter
9e1cf0d51c r10901: BUG 3145: Fix build issue regarding quota support on Solaris
(This used to be commit b7de9a6c6963e7d3bb1a05ed15600dd50a8f4a08)
2007-10-10 11:04:55 -05:00
Jeremy Allison
e950ef44c4 r10888: We've already checked 'CAN_WRITE' so we don't need to do it again.
Jeremy.
(This used to be commit 1c52bf875cfdacb058aa6f54ab27b9f7e2d178dc)
2007-10-10 11:04:55 -05:00
Jeremy Allison
3ecf9119d5 r10885: Fix bug where read-only share files are always seen as
read-only. Noticed by Andrew Bartlett.
Jeremy
(This used to be commit a33f4f0d2afe28ca0e3ab6c9ecfcdbaa267a7fbe)
2007-10-10 11:04:55 -05:00
Gerald Carter
8ec32e008a r10822: updating copyright info
(This used to be commit ef3845366bc883e735b2008243b7c05a403f42ca)
2007-10-10 11:04:55 -05:00
Jeremy Allison
8a1aa2c003 r10750: Ensure we match W2K3 in forcing DOS errors in a couple of cases.
Jeremy.
(This used to be commit 62ba3454251daf59071a6b2663035b04c5438647)
2007-10-10 11:04:53 -05:00
Jeremy Allison
5b455c1755 r10749: Remove one more Samba4 smbtorture RAW-OPEN difference from W2K3.
Jeremy.
(This used to be commit 0e8cf8eef59e38ba9a79f6c688abe9f1ac3bf64d)
2007-10-10 11:04:51 -05:00
Jeremy Allison
94fe079be7 r10744: Fix for the second incarnation of bug #3088, pushed by Alex Masterov
<alex@infobit.ru>. A fcbopen specific part of the code was erroneously
being called as part of the mainline open. Note, that this patch
superceeds and replaces the fix that Volker added for this bug
(which he added a Samba4 torture test for ) :

"Fix a race condition in Samba 3. If two files are opened simultaneously with
NTCREATEX_DISP_CREATE (create if not exists, else fail) they might end up with
two or more times NT_STATUS_OK as EEXIST is not correctly handled."

Jeremy.
(This used to be commit 5d7ab9a17e793c05409a16675ac2aa2861c4f89e)
2007-10-10 11:04:51 -05:00