1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-13 13:18:06 +03:00
Commit Graph

36411 Commits

Author SHA1 Message Date
Andrew Bartlett
aad2c19da7 s3-lib Remove unused str_ascii_charnum() 2011-04-14 12:34:51 +10:00
Andrew Bartlett
9d62ee2a81 s3-lib Move strisnormal to it's only user in mangle_hash.c 2011-04-14 12:31:18 +10:00
Günther Deschner
165521e20d s3: only include smb profiling where needed.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Apr 14 01:31:39 CEST 2011 on sn-devel-104
2011-04-14 01:31:39 +02:00
Günther Deschner
1b4d27d45a s3-waf: add --with-profiling-data configure option.
Guenther
2011-04-14 00:47:57 +02:00
Günther Deschner
bae2ce8054 s3: fix the build of --with-profiling-data.
Guenther
2011-04-14 00:47:57 +02:00
Günther Deschner
321587e44a s3-includes: only include acl prototypes when needed.
Guenther
2011-04-14 00:47:57 +02:00
Günther Deschner
c4331f6fcf s3-includes: absolutely no need to globally include debugparse.h
Guenther
2011-04-14 00:47:57 +02:00
Günther Deschner
b4e4b60719 s3-includes: include lib/util/debug.h headers in includes.h not smb.h
Guenther
2011-04-14 00:47:57 +02:00
Günther Deschner
76d4ede6db s3-includes: remove unused schema_types enum.
Guenther
2011-04-14 00:47:57 +02:00
Günther Deschner
e7821116d1 s3-includes: move struct pipe_open_rec to srvsvc rpc server.
Guenther
2011-04-14 00:47:57 +02:00
Jeremy Allison
a21be2c3c8 Fix WAF build for sids2xids.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Apr 14 00:33:53 CEST 2011 on sn-devel-104
2011-04-14 00:33:53 +02:00
Volker Lendecke
845d4d43c7 s3: Add a test for sid2xids
Signed-off-by: Jeremy Allison <jra@samba.org>
2011-04-13 14:13:25 -07:00
Volker Lendecke
32bd64359c s3: Add some debug to winbindd_sids_to_xids
Signed-off-by: Jeremy Allison <jra@samba.org>
2011-04-13 14:13:25 -07:00
Volker Lendecke
ddfeccc6e4 s3: Use wbcSidsToUnixIds in create_local_token
Signed-off-by: Jeremy Allison <jra@samba.org>
2011-04-13 14:13:25 -07:00
Volker Lendecke
44f7fc4fdf s3: Export WINBINDD_SIDS_TO_XIDS via the winbind pipe
Signed-off-by: Jeremy Allison <jra@samba.org>
2011-04-13 14:13:25 -07:00
Volker Lendecke
a671885f49 s3: Add wbint_Sids2UnixIDs idl & implementation
Signed-off-by: Jeremy Allison <jra@samba.org>
2011-04-13 14:13:25 -07:00
Volker Lendecke
80f873853f s3: Make idmap_find_domain public
Signed-off-by: Jeremy Allison <jra@samba.org>
2011-04-13 14:13:25 -07:00
Volker Lendecke
74ea52e351 s3: Add is_domain_online
Signed-off-by: Jeremy Allison <jra@samba.org>
2011-04-13 14:13:25 -07:00
Volker Lendecke
63446c2c2a s3: Add winbindd_lookupsids
Signed-off-by: Jeremy Allison <jra@samba.org>
2011-04-13 14:13:24 -07:00
Volker Lendecke
490c52c9fc s3: Add wb_lookupsids
Signed-off-by: Jeremy Allison <jra@samba.org>
2011-04-13 14:13:24 -07:00
Volker Lendecke
091fd0f0f7 s3: Add wbint_LookupSids
This will be called from wb_lookupsids to query remote DCs via lsa

Signed-off-by: Jeremy Allison <jra@samba.org>
2011-04-13 14:13:24 -07:00
Volker Lendecke
ef9d2b15e0 s3: Make parse_sidlist public
Signed-off-by: Jeremy Allison <jra@samba.org>
2011-04-13 14:13:24 -07:00
Volker Lendecke
58e26c2589 s3: Simplify parse_sidlist
Signed-off-by: Jeremy Allison <jra@samba.org>
2011-04-13 14:13:24 -07:00
Jeremy Allison
df269c0834 Don't print "success" message after error message in change_file_owner_to_parent(). Remove "goto" in change_dir_owner_to_parent(). 2011-04-13 14:13:24 -07:00
Günther Deschner
c3d8991164 s3-build: finally remove references to ndr and dcerpc headers that were included globally.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Apr 13 23:07:05 CEST 2011 on sn-devel-104
2011-04-13 23:07:05 +02:00
Günther Deschner
9824e2e5ee s3-rpc_client: add and use rpc_client/rpc_client.h.
Guenther
2011-04-13 22:23:59 +02:00
Günther Deschner
d2d976d835 s3-netapi: remove two shadowed variables.
Guenther
2011-04-13 22:23:59 +02:00
Günther Deschner
4b3fe5247a s3-cli_pipe: fix timeout in rpc_pipe_open_tcp_port().
Make sure we use a timeout of 60 seconds, not 60 milliseconds...

This prevented us from successfully using the ncacn_ip_tcp client in a lot of
places, I guess.

Guenther

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Apr 13 18:59:19 CEST 2011 on sn-devel-104
2011-04-13 18:59:19 +02:00
Günther Deschner
8b8014198c s3-util_sock: very brief documentation for open_socket_out().
The most important bit is to document that timeout is in MILLIseconds, not
seconds.

Guenther
2011-04-13 18:13:34 +02:00
Volker Lendecke
015511d12a s3: Make send_nt_replies() static
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Apr 13 16:25:29 CEST 2011 on sn-devel-104
2011-04-13 16:25:29 +02:00
Volker Lendecke
6a77b52169 s3: Fix Coverity ID 2470: STRAY_SEMICOLON
Signed-off-by: Günther Deschner <gd@samba.org>

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Apr 13 12:57:43 CEST 2011 on sn-devel-104
2011-04-13 12:57:43 +02:00
Andrew Bartlett
53e0bada43 build: Bring DYNCONFIG into samba-util library to avoid symbol duplication
When this was depended on directly as a subsystem, it ended up in
multiple libraries.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Apr 13 08:39:35 CEST 2011 on sn-devel-104
2011-04-13 08:39:35 +02:00
Andrew Bartlett
d309499b9e s3-build Remove distinct LOCALEDIR subsystem
This is no different to the rest of dynconfig, and so should be dealt
with there.

Andrew Bartlett
2011-04-13 15:51:52 +10:00
Andrew Bartlett
4158e9a7e5 s3-charcnv: Move convert_string() et al to lib/util/charset
This is the first step to this being the common convert_string
implementation.

Andrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13 14:47:08 +10:00
Andrew Bartlett
1d4fb073ec s3-selftest Add workaround for RAP test failure
The rap.sam test reads 0xFFFFFFFF as a string in the level 2
r->HomeDir attribute, which once we start validating ASCII strings
fails.  This restores a unchecked dos charset for this test only,
until it is determined if the client or server RAP code is at fault.

Andrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13 14:47:08 +10:00
Andrew Bartlett
17ccff973a lib/util: Make string_replace from s3 common
The s4 implementation didn't do multibyte strings, so was only good
for '/' which is known to be safe in all multibyte charsets.

Andrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13 14:47:07 +10:00
Andrew Bartlett
b2e37d9ce1 lib/util ucs2_align is identical, put it in common
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13 14:47:07 +10:00
Andrew Bartlett
2eea91957c lib/util Move simple string routines into common code.
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13 14:47:07 +10:00
Andrew Bartlett
9941dfe9f6 lib/util/charset Move source3/lib/util_unistr.c to the common code.
This file (largely) contains functions to deal with UTF16 strings.

Andrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13 14:47:07 +10:00
Andrew Bartlett
ce2f217bd2 s3-lib Move strdup_w to it's only user in mangle_hash.c
Andrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13 14:47:07 +10:00
Andrew Bartlett
e3138f2ffe s3-lib Move isvalid83_w to mangle_hash.c
This means that there is no need for the 'valid.dat' table to be
loaded by anything other than smbd, so the unloader is also removed.

The concept of a 'valid dos character' has been replaced by the hash2
mangle method.

Andrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13 14:47:07 +10:00
Andrew Bartlett
d458f6b3bd s3-lib make static and remove more _w functions
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13 14:47:07 +10:00
Andrew Bartlett
a82fba3499 s3-lib Remove unused #define
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13 14:47:07 +10:00
Andrew Bartlett
ba2b7f72c0 s3-lib Remove unused skip_unibuf()
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13 14:47:07 +10:00
Andrew Bartlett
8fcda44a1f s3-lib: Remove unused _w functions.
In general we don't manipulate UTF16 strings internally, particularly
as they are also multibyte, so are no easier to work with than UTF8.

Andrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13 14:47:07 +10:00
Andrew Bartlett
5cfb0bdfd8 s3-lib Correct comment in strlen_w()
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13 14:47:07 +10:00
Andrew Bartlett
43deb9745b s3-lib Remove more unused fstring.c functions
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13 14:47:07 +10:00
Andrew Bartlett
c8a5fa3fa9 s3-charcnv: make pull_ucs2 static
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13 14:47:07 +10:00
Andrew Bartlett
b6a8418ff6 s3-lib: Remove unused pull_ucs2_fstring()
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13 14:47:06 +10:00
Andrew Bartlett
5694ba507c libcli/ldap pull LIBCLI_LDAP_MESSAGE and LIBCLI_LDAP_NDR into a library
This reduces symbol duplication

Andrew Bartlett
2011-04-13 11:47:36 +10:00
Volker Lendecke
4edc98eb9e s3: For net ads join, create a krb5.conf
Signed-off-by: Günther Deschner <gd@samba.org>

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Apr 12 14:10:05 CEST 2011 on sn-devel-104
2011-04-12 14:10:05 +02:00
Volker Lendecke
da5e5a6a83 s3: Initialize output in libnet_Join
Signed-off-by: Günther Deschner <gd@samba.org>
2011-04-12 13:24:24 +02:00
Volker Lendecke
feb3cdee36 s3: Retry the join with the short name
Signed-off-by: Günther Deschner <gd@samba.org>
2011-04-12 13:24:24 +02:00
Günther Deschner
510e61871c s3-util: separate out cmdline helpers.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Apr 12 13:06:27 CEST 2011 on sn-devel-104
2011-04-12 13:06:27 +02:00
Günther Deschner
9c6f78aae1 s3: add some forward declarations.
Guenther
2011-04-12 12:20:43 +02:00
Günther Deschner
7ea03840fc s3-netapi: use dcerpc_try_samr_connects().
Guenther
2011-04-12 12:20:43 +02:00
Günther Deschner
3acd6bde58 s3-netapi: use libnetapi_get_binding_handle().
Guenther
2011-04-12 12:20:43 +02:00
Günther Deschner
0eece6202c s3-netapi: add libnetapi_get_binding_handle().
Guenther
2011-04-12 12:20:43 +02:00
Günther Deschner
f102748061 s3-librpc: let librpc/rpc/dcerpc.h include ndr and generated dcerpc headers.
Guenther
2011-04-12 12:20:43 +02:00
Günther Deschner
64b664155b s3-rpc_client: move rpc_cli_transport structs and protos to rpc_transport.h
Guenther
2011-04-12 12:20:43 +02:00
Andreas Schneider
e3c3b4daa4 s3-printing: Use become_user_by_session() function.
We create a fake connection here and don't have an vuid. So work with
the session_info directly here.

Signed-off-by: Jeremy Allison <jra@samba.org>

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Apr 11 22:56:12 CEST 2011 on sn-devel-104
2011-04-11 22:56:12 +02:00
Andreas Schneider
b137156acb s3-smbd: Added a become_user_by_session() function.
This uses the provided session_info instead of searching the user via
the vuid. This is useful to work with fake connnection you need to
create if someone connects directly to a rpc service.

Signed-off-by: Jeremy Allison <jra@samba.org>
2011-04-11 22:10:22 +02:00
Andreas Schneider
27cb378283 s3-smbd: Added a change_to_user_by_session() function.
Signed-off-by: Jeremy Allison <jra@samba.org>
2011-04-11 22:10:21 +02:00
Volker Lendecke
d1ded271b6 s3: Wrap creating the svcctl keys in a transaction
This makes the startup of smbd in make test much quicker and thus more reliable
(cherry picked from commit f1aa38b414e97d8687d0bebf65baa384f75301b4)

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Apr 11 22:09:58 CEST 2011 on sn-devel-104
2011-04-11 22:09:58 +02:00
Volker Lendecke
a5495e70cc s3: Make reg_backend_db.h includable by itself
(cherry picked from commit 6ba31d3bd29dd11b1b98859f4d8a65d9be7dac60)
2011-04-11 21:22:44 +02:00
Volker Lendecke
5cd6d93fa1 s3: Fix Coverity ID 2472, UNINIT
Signed-off-by: Günther Deschner <gd@samba.org>

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Apr 11 17:14:35 CEST 2011 on sn-devel-104
2011-04-11 17:14:35 +02:00
Volker Lendecke
d2d1d17323 s3: Fix Coverity ID 2473, UNINIT
Signed-off-by: Günther Deschner <gd@samba.org>
2011-04-11 16:30:19 +02:00
Volker Lendecke
0958695022 s3: Fix timeout calculation in event_add_to_poll_args
In the initial phase nmbd does not yet have timed events. This led to nmbd
not correctly registering its names in make test and certainly everywhere
else.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Apr 11 14:35:45 CEST 2011 on sn-devel-104
2011-04-11 14:35:45 +02:00
Björn Baumbach
e6cf92c574 s3-modules: Fix debug message
Print child descriptor instead of parent.

Signed-off-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Apr 11 11:48:42 CEST 2011 on sn-devel-104
2011-04-11 11:48:42 +02:00
Jeremy Allison
af45636166 Fix bug 8072 - PANIC: create_file_acl_common frees handle two times.
Caused by premature optimisation storing the parent ACL on the
module handle instead of (correctly) on the file fsp. Previous
code wasn't reentrant safe. This is less optimal but doesn't
crash in the specific case :-).

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Apr  9 02:05:15 CEST 2011 on sn-devel-104
2011-04-09 02:05:15 +02:00
Jeremy Allison
c6c17242d2 Subtle change. Microsoft SMB2 tests return different access mask than for SMB1 with raw.acls. 2011-04-08 16:18:56 -07:00
Michael Adam
58a0c8a9e0 s3:net idmap check: fix output of an invalid record
Only print the value number for hwm, version and seqnum keys.

Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Apr  8 17:29:31 CEST 2011 on sn-devel-104
2011-04-08 17:29:31 +02:00
Gregor Beck
6db4fc15df s3-net: "idmap check" ignore __db_sequence_number__
Signed-off-by: Michael Adam <obnox@samba.org>
2011-04-08 16:44:57 +02:00
Michael Adam
9705dab835 s3:net rpc trust: fix two C++ implicit void * cast warnings
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Thu Apr  7 17:52:28 CEST 2011 on sn-devel-104
2011-04-07 17:52:28 +02:00
Michael Adam
32d816d59b s3:passdb:pdb_ipa: fix a C++ implicit void * cast warnings 2011-04-07 17:08:16 +02:00
Michael Adam
838e2dd1f1 s3:net idmap check: fix a couple of c++ implicit void * cast warnings 2011-04-07 17:08:16 +02:00
Gregor Beck
7d040434dc s3-net: fix the usage output of "net idmap check"
Signed-off-by: Michael Adam <obnox@samba.org>
2011-04-07 13:13:27 +02:00
Andrew Bartlett
e78d4652fa Revert "s3-test: disable ktest for now"
This reverts commit 77820d59fe.

I beleive this is now reliable, after the changes to wait for an
actual connection at startup and to use the fake DNS file.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Apr  7 07:20:03 CEST 2011 on sn-devel-104
2011-04-07 07:20:03 +02:00
Andrew Tridgell
77820d59fe s3-test: disable ktest for now
the ktest tests are currently flakey. Once andrew has found the
problem they can be re-enabled

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Apr  7 03:36:36 CEST 2011 on sn-devel-104
2011-04-07 03:36:36 +02:00
Dmitry Butskoy
2db094fc32 Fix bug 6966 - "allow trusted domains = no" not respected in winbind.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Apr  6 23:37:27 CEST 2011 on sn-devel-104
2011-04-06 23:37:27 +02:00
Sumit Bose
3626579cc2 s3: Fix tldap_make_mod_blob_int() debug messages
Signed-off-by: Günther Deschner <gd@samba.org>

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Apr  6 13:10:30 CEST 2011 on sn-devel-104
2011-04-06 13:10:30 +02:00
Sumit Bose
2bafb4ccbb s3-net: Add delete op for net trust utility
Signed-off-by: Günther Deschner <gd@samba.org>
2011-04-06 12:25:46 +02:00
Sumit Bose
11c342724f s3-net: Add net trust utility
Signed-off-by: Günther Deschner <gd@samba.org>
2011-04-06 12:25:42 +02:00
Sumit Bose
6681e451c9 s3-pdb_ipa: Create DN for new object
Signed-off-by: Günther Deschner <gd@samba.org>
2011-04-06 11:53:57 +02:00
Sumit Bose
1cbe59e174 s3-pdb_ipa: Add ipasam_create_dom_group()
Signed-off-by: Günther Deschner <gd@samba.org>
2011-04-06 11:53:56 +02:00
Sumit Bose
afdc9055b5 s3-net: add IPA provision
Signed-off-by: Günther Deschner <gd@samba.org>
2011-04-06 11:53:56 +02:00
Sumit Bose
2ee1d09f33 s3-pdb_ipa: Add ipasam_create_user()
Signed-off-by: Günther Deschner <gd@samba.org>
2011-04-06 11:53:56 +02:00
Sumit Bose
c47df017dd s3-pdb_ipa: Detect IPA server
Signed-off-by: Günther Deschner <gd@samba.org>
2011-04-06 11:53:56 +02:00
Sumit Bose
ca22befb9c s3-pdb_ipa: Use new smbldap_make_mod_blob() without a return value
Signed-off-by: Günther Deschner <gd@samba.org>
2011-04-06 11:53:56 +02:00
Sumit Bose
f3b1a68f5f s3-smbldap: make octet_strings/DATA_BLOBs const.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-04-06 11:53:56 +02:00
Günther Deschner
02c6940964 s3-ipasam: rename of smbldap_make_mod_blob to _smbldap_make_mod_blob.
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
2011-04-06 11:53:56 +02:00
Günther Deschner
c4974eec01 s3-smbldap: support storing octet_strings/DATA_BLOBs.
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
2011-04-06 11:53:56 +02:00
Sumit Bose
db76adc308 s3-pdb_ipa: Fix indentation
Signed-off-by: Günther Deschner <gd@samba.org>
2011-04-06 11:53:56 +02:00
Andrew Tridgell
49ab2df28a lib/crypto: rename the SHA256_ functions to samba_SHA256_
this prevents a symbol duplication with the openssl library, which may
be linked in via a secondary library dependency

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-04-06 08:12:19 +02:00
Andrew Tridgell
5adf85e6af tstream: make npa_tstream a private library
this prevents symbol duplication of the npa_tstream symbols

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-04-06 08:12:19 +02:00
Andrew Tridgell
a8da13cd5c lib: make asn1_util a private library
this prevents symbol duplication of the asn1 symbols in the service
and ntvfs subsystems

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-04-06 08:12:19 +02:00
Andrew Tridgell
15576da63a lib: moved data_blob.c into samba-util-common
this avoids a duplication of the data_blob symbols some binaries
(eg. smbtorture)

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-04-06 08:12:19 +02:00
Andrew Bartlett
d84a8d5343 s3-selftest Add tests to show kerberos works across a password change
It is important that a machine account password change does not
invalidate existing tickets.

This is only for the default kerberos method with a password in
secrets.tdb.  The keytab based methods are still not tested.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Apr  6 05:24:48 CEST 2011 on sn-devel-104
2011-04-06 05:24:48 +02:00
Andrew Bartlett
0415a5736e s3-librpc Fix creation of in-memory keytab for previous password
We set the current password twice, rather than the current and old
password.

Andrew Bartlett
2011-04-06 12:34:58 +10:00
Andrew Bartlett
48646ee69a s3-auth: Make server_info const in create_local_token()
Andreas Schneider <asn@samba.org> correctly points out that this input
parameter should now be const, and that found a bug where I used then
used it incorrectly as a talloc context.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Apr  6 00:33:31 CEST 2011 on sn-devel-104
2011-04-06 00:33:31 +02:00
Andrew Bartlett
663dc94e63 auth: Move auth_session_info into IDL
This changes auth_session_info_transport to just be a wrapper, rather
than a copy that has to be kept in sync.

As auth_session_info was already wrapped in python, this required
changes to the existing pyauth wrapper and it's users.

Andrew Bartlett
2011-04-05 23:46:04 +02:00
Jeremy Allison
b6a30be702 Fix bug #7080 - Quota only shown when logged as root.
Remove the final incorrect uses of conn->session_info->utok.uid.
When we're in the "admin users" list, then this value is not set
to zero.

Inspired by the comment on this bug by Dmitry Butskoy <dmitry@butskoy.name>.

I'll create a different fix for 3.5.x.

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Apr  5 21:53:59 CEST 2011 on sn-devel-104
2011-04-05 21:53:59 +02:00
Björn Jacke
dca465fa53 s3/vfs_gpfs: s/syncops/gpfs
as pointed out by Metze in bug #8031

Autobuild-User: Björn Jacke <bj@sernet.de>
Autobuild-Date: Tue Apr  5 18:08:42 CEST 2011 on sn-devel-104
2011-04-05 18:08:42 +02:00
Günther Deschner
a7ba4b5baa s3-waf: fix typo in ctdb checks.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Apr  5 17:20:19 CEST 2011 on sn-devel-104
2011-04-05 17:20:19 +02:00
Volker Lendecke
fe35ff2bf9 s3: Make vlp printing work by default
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Apr  5 13:12:14 CEST 2011 on sn-devel-104
2011-04-05 13:12:14 +02:00
Volker Lendecke
0f08e9d922 s3: Fix print_spool_end
We have to use the spoolss pipe instance opened in print_spool_open, otherwise
the spoolss server won't be able to find the right printer and job.
2011-04-05 12:26:29 +02:00
Andrew Bartlett
2d22bbf2c0 s3-selftest Look only under source3 for smb.conf files
This test looks for any .conf file with [global] in it, and assumes
it's a Samba3 format smb.conf file.  If 'make test' has been run in
the top level build, it was finding the smb.conf files it generated.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Apr  4 23:50:06 CEST 2011 on sn-devel-104
2011-04-04 23:50:06 +02:00
Andrew Bartlett
ff9b6682a0 s3-auth Rename user_session_key -> session_key to match auth_session_info 2011-04-05 06:32:07 +10:00
Andrew Bartlett
17d8f0ad30 s3-auth use create_local_token() to transform server_info -> session_info
Before a auth_serversupplied_info struct can be used for
authorization, the local groups and privileges must be calculated.
create_local_token() now copies the server_info, and then sets the
calulated token and unix groups.

Soon, it will also transform the result into an expanded struct
auth_session_info.  Until then, the variable name (server_info vs
session_info provides a clue to the developer about what information
has been entered in the structure).

By moving the calls to create_local_token within the codebase, we
remove duplication, and ensure that the session key (where modified)
is consistently copied into the new structure.

Andrew Bartlett
2011-04-05 06:32:07 +10:00
Jeremy Allison
2ec48260ee Move SET_STAT_INVALID call added by Volker as fix for bug 8042 - Newly create files are always failed with NT_STATUS_FILE_IS_A_DIRECTORY
Ensure we do this for all cases where the stat fails.

Jeremy

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Apr  4 20:08:45 CEST 2011 on sn-devel-104
2011-04-04 20:08:45 +02:00
Jeremy Allison
074239ac2e Note that check_parent_exists() doesn't change the contents of smb_fname (add const). 2011-04-04 10:15:16 -07:00
Gregor Beck
a217ec64ec s3-net: add command "net idmap check"
This is a tool to check the consistency of an idmap tdb database.

The default mode is to scan the database and list invalid entries,
e.g. records with an invalid format, or records which are valid
but for which the reverse mapping entry is missing.

With the "--repair" switch, one can enter an interactive
repair mode which will prompt for each invalid entry found
with the option to delete, skip or edit the record.

There is also a non-interactive repair mode triggered by "--auto"
which will remove all records with invalid content and fill up
mappings which are missing the reverse entry.

The "--test" parameter lets "net idmap check" only list the
changes that would be written and not actually commit them to
the database.

The "--lock" option allows to lock the database already in the
first reading traverse, in order to remove the race when the
database has to be closed and reopened again before writing
the changes.

Signed-off-by: Michael Adam <obnox@samba.org>

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Mon Apr  4 18:21:09 CEST 2011 on sn-devel-104
2011-04-04 18:21:09 +02:00
Gregor Beck
8fc8c88007 s3: add function srprs_quoted to parse strings written with cbuf_print_quoted 2011-04-04 15:57:36 +02:00
Gregor Beck
9272614d9d s3: add function cbuf_print_quoted 2011-04-04 15:57:36 +02:00
Gregor Beck
340f20ddb0 s3: add function dbwrap_traverse 2011-04-04 15:57:35 +02:00
Gregor Beck
84019ea528 s3: add function dbwrap_trans_traverse 2011-04-04 15:57:35 +02:00
Gregor Beck
10cec2f0ec s3: fix cbuf_swapptr 2011-04-04 15:57:35 +02:00
Michael Adam
b7e330a2b3 s3:idmap_tdb2: fix build of tdb2
The include of system/filesys.h was removed from includes.h. ...
2011-04-04 15:57:34 +02:00
Andrew Bartlett
a3ef974d30 s3-rpc_server Remove comment, yes the key is correct.
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Apr  4 13:31:52 CEST 2011 on sn-devel-104
2011-04-04 13:31:52 +02:00
Andrew Bartlett
77e67163da s3-auth consolidate create_local_token() into make_server_info_krb5()
This ensures that all callers don't need to each add builtin groups
and privileges to the user's token

Andrew Bartlett
2011-04-04 19:48:58 +10:00
Andrew Bartlett
841d0bc9e8 s3-selftest Remove more instances of /tmp in test_smbclient_s3.sh 2011-04-04 19:48:58 +10:00
Andrew Bartlett
6351dee4d8 s3-selftest Add testing of kerberos login
This uses a pre-calculated credentials cache, that should be valid
until 2036.

Andrew Bartlett
2011-04-04 19:48:57 +10:00
Volker Lendecke
e53dfebba0 s3: Remove some unused code
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Apr  3 18:32:51 CEST 2011 on sn-devel-104
2011-04-03 18:32:51 +02:00
Volker Lendecke
32296a2c36 s3: Add a quick test for bug 8042
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Apr  3 16:13:21 CEST 2011 on sn-devel-104
2011-04-03 16:13:21 +02:00
Volker Lendecke
2b94169cda s3: Fix bug 8042: File creation on OS/X
With a case insensitive file system the stat cache lookup leaked the parent
directorys stat information from unix_convert into the smb_filename. This led
open_file_ntcreate to believe it just created a directory.

In the case where we do the search we already invalidate the stat struct.

Thanks to TAKAHASHI Motonobu for insisting! :-)

Volker

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Apr  3 14:54:27 CEST 2011 on sn-devel-104
2011-04-03 14:54:27 +02:00
Larry Reid
76f7c2a254 Fix for servers that don't put a path separator at the end of the service.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Apr  3 10:33:42 CEST 2011 on sn-devel-104
2011-04-03 10:33:42 +02:00
Michael Adam
d143bc444c s3:waf: add cluster support / ctdb checks.
The checks are roughtly taken from the autoconf ctdb checks.

I was not able to implement checks with CHECK_DECL, CHECK_TYPE,
CHECK_HEADER and friends, because the ctdb headers seem to need too
special a setup of includes and defines in order to compile.
So I used CHECK_CODE() in all checks.

In the long run, this should be changed.

I supported a --with-ctdb-dir options to allow for building
against a ctdb that is not installed into /usr (e.g. against
a local git checkout). In order to implement this, I had to
hand includes in to the CHECK_CODE function.
Here I found a problem with CHECK_CODE (or even the core waf
conf.check() function: The CHECK_CODE function does not
expand the includes it gets (i.e. '#' is not expanded to the
base dir, and relative paths are left relative). But the core
check() function seems to ignore all include paths that are
not absolute paths. Hence in particular the usual default '# .'
for the includes is useless. So I preprocessed the list of includes
for the cluster checks. But I assume that it would be useful
to move this expansion into CHECK_CODE or even into the core
waf check function.

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Sat Apr  2 03:26:55 CEST 2011 on sn-devel-104
2011-04-02 03:26:55 +02:00
Jeremy Allison
00224d06c3 Fix bug #7987 - ACL can get lost when files are being renamed.
There is no reason for smbd with Windows ACLs to use chmod
or fchmod unless it's a file opened with UNIX extensions or
with posix pathnames.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Apr  2 02:40:43 CEST 2011 on sn-devel-104
2011-04-02 02:40:43 +02:00
Marc A. Dahlhaus
ac216c130e Fix bug #8047 - mdns registration doesn't work if "interfaces" is used in smb.conf
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Apr  1 23:15:34 CEST 2011 on sn-devel-104
2011-04-01 23:15:33 +02:00
Volker Lendecke
1272758f8f s3: Fix Coverity ID 1137: CONSTANT_EXPRESSION_RESULT
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Apr  1 09:35:19 CEST 2011 on sn-devel-104
2011-04-01 09:35:19 +02:00
Volker Lendecke
d9b03cb4f0 s3: Fix Coverity ID 1136: CONSTANT_EXPRESSION_RESULT 2011-04-01 08:50:06 +02:00
Michael Adam
1877508856 s3:configure: allow building without SCHEDULE_FOR_DELETION with --enable-old-ctdb
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Thu Mar 31 18:55:38 CEST 2011 on sn-devel-104
2011-03-31 18:55:38 +02:00
Michael Adam
7b9648c086 s3:configure: introduce "--enable-old-ctdb" to enable enforcing build against old ctdb 2011-03-31 18:10:22 +02:00
Michael Adam
69aead60e2 s3:configure: add check for new CTDB_CONTROL_SCHEDULE_FOR_DELETION 2011-03-31 18:10:22 +02:00
Michael Adam
e9e23cc948 s3:configure: rework logic of ctdb/clustering checks 2011-03-31 18:10:22 +02:00
Michael Adam
a9b04e4a79 s3:configure: remove unused variable CTDB_CFLAGS 2011-03-31 18:10:22 +02:00
Michael Adam
0943d39cd6 s3:configure: fix a comment. 2011-03-31 18:10:22 +02:00
Michael Adam
3a3c118a7e s3:dbwrap_ctdb: in ctdb_delete, send a SCHEDULE_FOR_DELETION control to local ctdbd
This way, the record will be scheduled for fast vacuuming.

This is sent with the NOREPLY flag, so ctd should not sent
a reply packet and samba does not expect one. Hence, it
is not important for the success of the db_ctdb_delete command
whether or not the ctdbd we are running against supports the
SCHEDULE_FOR_DELETION control.
2011-03-31 18:10:22 +02:00
Michael Adam
0e240bd6a9 s3:ctdb: pass the ctdb control flags to the ctdb daemon when sending the control
The only flag that is currently used is the NOREPLY flag to indicate that
the client expects no reply packet. This needs to get passed down to the
ctdb daemon so that it really does not send a reply.
2011-03-31 18:10:22 +02:00
Michael Adam
6cc8457cd5 s3:ctdb: samba can now handle the NOREPLY flag
Revert "samba3 can't handle NOREPLY yet"

This reverts commit 9bf211db6d.
2011-03-31 18:10:22 +02:00
Michael Adam
fd41b4f1a6 s3:ctdb: correctly handle cstatus if CTDB_CTRL_FLAG_NOREPLY is set. 2011-03-31 18:10:22 +02:00
Sumit Bose
34ea813553 s3-net: Do not use uninitialized value
s3-net: Do not use uninitialized value

Signed-off-by: Andreas Schneider <asn@samba.org>

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Thu Mar 31 18:09:57 CEST 2011 on sn-devel-104
2011-03-31 18:09:57 +02:00
Andreas Schneider
d9ad60f0dc s3-winbindd: Use the correct enums for samr_QueryDomainInfo. 2011-03-31 17:20:25 +02:00
Andrew Tridgell
e395b5bd3c s3-torture: a very simple test for convert_string_error()
this is a very simple test based on the example volker gave in
1e50f9a5. A more sophisticated test will also be worthwhile, but this
at least gives us a basic test while changes are being made
2011-03-31 12:51:24 +02:00
Volker Lendecke
6a9043d2f0 s3: Fix a typo
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Mar 31 12:50:53 CEST 2011 on sn-devel-104
2011-03-31 12:50:53 +02:00
Jeremy Allison
f9a2f4f47c Fix bug #7996 - sgid bit lost on folder rename.
Refuse to set dos attributes into unix mode bits on such a
folder.
2011-03-30 18:01:19 -07:00
Holger Hetterich
cf5ed92bb7 SMBTA: make vfs_smb_traffic_analyzer aware of the sendfile and recvfile functionality and store the results as common read/write results. 2011-03-30 18:01:19 -07:00
Günther Deschner
0e46e09122 s3-samr: make getgrgid() failure a little more visible in _samr_CreateDomAlias().
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Mar 31 01:00:42 CEST 2011 on sn-devel-104
2011-03-31 01:00:42 +02:00
Günther Deschner
e54f292a4f s3-idmap: fix the build of idmap_hash on FreeBSD.
Guenther
2011-03-31 00:14:01 +02:00
Günther Deschner
a730dff783 s3-libndr: add ../librpc/ndr/libndr.h include in some places.
Guenther
2011-03-31 00:14:01 +02:00