1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-31 17:18:04 +03:00
Commit Graph

12317 Commits

Author SHA1 Message Date
Gerald Carter
8829553b16 fix MS-DFS (my bug) stupid return code error that cose me more time
that I would like to admit.
(This used to be commit 082b1cf06f)
2003-08-10 06:45:04 +00:00
Gerald Carter
c1bc3a7841 fix for BUG #267 (problem with supplementary groups).
Use winbindd to get the group list if possible since we already
know it from netsamlogon_cache.tdb. More effecient than letting
libc call getgrent() to get seconary groups.

Tested by Ken Cross.
(This used to be commit 3c537c906f)
2003-08-09 23:12:35 +00:00
Gerald Carter
4b5257b5b0 fix 2 bugs:
1)  don't ask trusted DC's for a list of trusted domains.  This causes
      us to treat non-transitive ones as if they were transitive.  Not
      needed anyways

  2)  Fix dc lookup bug where we would always try to use DNS to resolve
      the DC's for a domain (even if it was a trusted NT4 domain).
(This used to be commit 4d3acce506)
2003-08-08 23:53:13 +00:00
Jeremy Allison
ac8c6e4746 Format tidyup.
Jeremy.
(This used to be commit 049e77d636)
2003-08-08 23:09:09 +00:00
Jeremy Allison
9df23b22cf Turn on client ntlmv2 by default.
Jeremy.
(This used to be commit 729b468f7e)
2003-08-08 22:19:09 +00:00
Jeremy Allison
38b3ee6467 RPC fix from Ronan Waide <waider@waider.ie>. Tested with rpcecho.
Jeremy.
(This used to be commit 68590b9e22)
2003-08-08 17:08:35 +00:00
Gerald Carter
56bb027696 need to be able to connect to a domain member as a local account; don't always map to the domain name
(This used to be commit 20b6e64da2)
2003-08-08 05:11:11 +00:00
Gerald Carter
2a091c4e89 need to make sure that the connection struct mem_ctx is initialized and destroyed
(This used to be commit e0c061b94d)
2003-08-08 05:10:12 +00:00
Jeremy Allison
a83bac7571 Shadow copy API - Original work by "Ken Cross" <kcross@nssolutions.com>, adapted
into a patch by "Stefan (metze) Metzmacher" <metze@metzemix.de>.
Jeremy.
(This used to be commit ce5c91d35d)
2003-08-07 21:47:46 +00:00
Jeremy Allison
3bbe9c0869 An oplock break reply from the client causes the sequence number to be
updated by 2 if there is no open reply outstanding, else by one....
Yes - this makes no sense....
Jeremy.
(This used to be commit b43ce1ff61)
2003-08-07 05:36:08 +00:00
Jeremy Allison
110abf10d2 Turns out I had my packet sequences wrong for oplock break code.
I was storing the mid of the oplock break - I should have been
storing the mid from the open. There are thus 2 types of deferred
packet sequence returns - ones that increment the sequence number
(returns from oplock causing opens) and ones that don't (change notify
returns etc). Running with signing forced on does lead to some
interesting tests :-).
Jeremy.
(This used to be commit 85907f02ce)
2003-08-07 02:59:52 +00:00
Jeremy Allison
4461109416 Cosmetic fix from waider@waider.ie.
Jeremy.
(This used to be commit cb326c2dbf)
2003-08-07 01:04:57 +00:00
Jeremy Allison
8d94de787e Patch from waider@waider.ie to print out Port Type.
Jeremy.
(This used to be commit 8516baf58d)
2003-08-07 00:55:35 +00:00
Jeremy Allison
ef65d26556 Ensure smbclient obeys -s smb.conf option.
Jeremy.
(This used to be commit 7950f7d6b2)
2003-08-06 22:45:46 +00:00
Jeremy Allison
e602bca52f Reversed replacement. Oops.
Jeremy.
(This used to be commit 520bee397d)
2003-08-06 21:31:11 +00:00
Jeremy Allison
33f6eb9a17 Anal formatting tidyup :-).
Jeremy.
(This used to be commit 9c01974713)
2003-08-06 20:01:31 +00:00
Jeremy Allison
17a713d1b9 Get rid of MAXPATHLEN, move to standard PATH_MAX.
Jeremy.
(This used to be commit 455ed2d51d)
2003-08-06 19:30:42 +00:00
Gerald Carter
44e6c30f71 fix bug #208; have to get the gid of the user's primary group for %G
(This used to be commit 575483a1ef)
2003-08-06 19:16:17 +00:00
Gerald Carter
df2337692a rework winbindd_accountdb_init() to reduce error messages in the log
(This used to be commit d98a68e0eb)
2003-08-06 18:01:39 +00:00
Volker Lendecke
923cb1b731 When doing 'net groupmap add', default to algorithmic mapping for the rid.
Volker
(This used to be commit 7ce94d39ad)
2003-08-06 09:24:11 +00:00
Tim Potter
74be920b0e Spelling.
(This used to be commit 7d009ebf66)
2003-08-06 01:14:51 +00:00
Gerald Carter
269bcd91a3 oops; fix typo. Noticed by gcc warning
(This used to be commit 4c36ef65e5)
2003-08-06 00:06:37 +00:00
Gerald Carter
055b7df499 fix bug #245; local_lookupsid() needed to make a getpwuid() call to get the username instead of making up unix_user.##
(This used to be commit b947fc3eed)
2003-08-05 23:24:14 +00:00
Volker Lendecke
a4954bd3d2 Changes to make gss-spnego ntlmssp client work against W2k AD.
Now I know where the mechListMIC changes came from: Ethereal ;-)

Volker
(This used to be commit 4e9eed1273)
2003-08-04 13:10:43 +00:00
Tim Potter
05540b48f0 Fix unused variable warning.
(This used to be commit 73d02e3a2b)
2003-08-04 06:16:03 +00:00
Tim Potter
cdf562f5b2 Memory leak fix for create_rpc_bind_req()
(This used to be commit 4d26feabd7)
2003-08-04 02:51:30 +00:00
Tim Potter
5216cb0f36 More patches from Brett:
- remove 'if(mem_ctx)' tests prior to 'talloc_destroy' call to make
consistent with other modules; 'talloc_destroy' already test for NULL
anyway.

  - initialize PyObject* result pointers to NULL in function
declarations; enables removal of redundant NULL assignments.

  - use local scope TALLOC_CTX in lsa_lookup_names to prevent unbounded
memory growth during python policy object lifetime.

  - change context name string used in lsa_lookup_sids from
'lsa_open_policy' to 'lsa_lookup_sids' (cut'npaste oversight from
previous patch)

  - change docstring to match module name (apparently another cut'npaste
situation)
(This used to be commit 98cac74c67)
2003-08-04 00:50:00 +00:00
Tim Potter
5d070d89a8 Fix memory leak in py_smb_set_setdesc()
Consistency fixups in py_smb_query_secdesc()

Thanks to Brett A. Funderburg for these patches.
(This used to be commit 6c33189e50)
2003-08-04 00:48:49 +00:00
Jeremy Allison
99a4bb07a9 Fix up #defines around utmp_host and utmp_name. Noticed by Cord.Hockemeyer@uni-graz.at
Jeremy.
(This used to be commit 07c5ecb945)
2003-08-03 18:50:00 +00:00
Jeremy Allison
8d992a7102 Output message saying "signed connect" instead of just connect when signing
is active.
Jeremy.
(This used to be commit c6674fa628)
2003-08-03 07:20:05 +00:00
Jeremy Allison
a8646708e3 Fix oplock break detection code on incoming oplock break responses. This
fixes signing for oplocks.
Jeremy.
(This used to be commit 69c56ee8bc)
2003-08-03 07:12:46 +00:00
Gerald Carter
b1fc491251 make sure to initialize the backend methods when enumerating sequence numbers; reported by Ken Cross
(This used to be commit 10c7a1af67)
2003-08-02 18:15:33 +00:00
Jeremy Allison
b925d197f5 Ensure we don't leak any sign records on cancel of pending requests.
Jeremy.
(This used to be commit 9a8ffc239c)
2003-08-02 08:48:01 +00:00
Jeremy Allison
9482f14b2c Only look for mid sign records on incoming packets for oplock break replies.
Otherwise we find spurious mid sign records on reply_ntcancel calls (they cancel
by mid). That took a *lot* of tracking down. I still need to remove the mid
records from the sign state on reply_ntcancel to avoid leaking memory....
Jeremy.
(This used to be commit 270bf20fe3)
2003-08-02 08:38:34 +00:00
Jeremy Allison
099bd33a99 More fixes for client and server side signing. Ensure sequence numbers
are updated correctly on returning an error for server trans streams.
Ensure we turn off client trans streams on error.
Jeremy.
(This used to be commit 3a789cb7f0)
2003-08-02 07:07:38 +00:00
Jeremy Allison
a202afb881 Leave the packet sequence checkers enabled whilst I track down a smbclient -> smbd
sequence number problem.
Jeremy.
(This used to be commit 844898dbd8)
2003-08-02 03:12:39 +00:00
Jeremy Allison
760e58cf80 Add the same signing code to the server. Ensure we use identical session
numbers and MIDs when in trans/trans2/nttrans code.
Jeremy.
(This used to be commit 901544b29b)
2003-08-02 03:06:07 +00:00
Jeremy Allison
2443f7ffa2 Correct fix (removed the earlier band-aid) for what I thought was a signing
bug with w2k. Turns out that when we're doing a trans/trans2/nttrans call
the MID and send_sequence_number and reply_sequence_number must remain constant.
This was something we got very wrong in earlier versions of Samba. I can now
get a directory listing from WINNT\SYSTEM32 with the older earlier parameters
for clilist.c
This still needs to be fixed for the server side of Samba, client appears to
be working happily now (I'm doing a signed smbtar download of an entire W2K3
image to test this :-).
Jeremy.
(This used to be commit 2093a3130d)
2003-08-02 00:29:45 +00:00
Jeremy Allison
72a8b31303 Fix the option processing for smbtar. Does no one check this !
Jeremy.
(This used to be commit c4af1ec735)
2003-08-01 21:09:10 +00:00
Herb Lewis
bfb312800f add tests for IRIX attr functions
(This used to be commit ea57a57db0)
2003-08-01 19:45:12 +00:00
Jim McDonough
8c64504f7c Update my copyrights according to my agreement with IBM
(This used to be commit a2bd8f0bfa)
2003-08-01 15:30:44 +00:00
Jim McDonough
9f2e6167d2 Update my copyrights according to my agreement with IBM
(This used to be commit c9b209be2b)
2003-08-01 15:21:20 +00:00
Jim McDonough
f210ee9b99 Fix copyright statements for various pieces of Anthony Liguori's work.
(This used to be commit 15d2bc4785)
2003-08-01 14:47:39 +00:00
Gerald Carter
10ba66164d fix cut-n-paste error found by abartlet
(This used to be commit 042492b862)
2003-08-01 13:28:13 +00:00
Volker Lendecke
f5b5a9793a Add ntlmssp client support to ntlm_auth. Find the corresponding cyrus sasl
module under http://samba.sernet.de/cyrus-gss-spnego.diff

Volker
(This used to be commit a82f6a0096)
2003-08-01 07:59:23 +00:00
Volker Lendecke
66ba34188c Fix a memory leak. I did not check all the calls to winbindd_request, but
we might leak the extra_data somewhere else as well.

Volker
(This used to be commit 5d379345fa)
2003-08-01 07:46:42 +00:00
Volker Lendecke
a34ba76435 locking.c now refers to map_nt_error_from_unix, so link it in with
smbstatus and smbcontrol

Volker
(This used to be commit c2c901e06b)
2003-08-01 07:45:02 +00:00
Jeremy Allison
d574b612e4 Finish reformatting.
Jeremy.
(This used to be commit 5ef75fa366)
2003-08-01 06:29:16 +00:00
Jeremy Allison
ef915c8eaf Final fix for the bug tridge found. Only push locks onto a blocking lock
queue if the posix lock failed with EACCES or EAGAIN (this means another
lock conflicts). Else return an error and don't queue the request.
Jeremy.
(This used to be commit 43fbc18fdc)
2003-08-01 06:10:30 +00:00
Jeremy Allison
7e39e87ce0 Reformat lots of clitar code as I hate the style so much :-).
Jeremy.
(This used to be commit 77f2a91549)
2003-08-01 01:03:05 +00:00
Jeremy Allison
14f207be92 Reformat clitar option processing - getting ready to fix it for popt...
Jeremy.
(This used to be commit 94b30e7b4a)
2003-08-01 00:41:57 +00:00
Andrew Tridgell
f1e71ed1b9 CVAL_NC() doesn't need the (unsigned) fix and breaks the IRIX build
Thanks to Herb for pointing this out!
(This used to be commit 87ede8d310)
2003-07-31 23:22:21 +00:00
Gerald Carter
0da36b22ff only honor the first OID in the sessetup snego negotiate. Deviates
from RFC but I'm smelling a client bug here.

	/* only look at the first OID for determining the mechToken --
	   accoirding to RFC2478, we should choose the one we want
	   and renegotiate, but i smell a client bug here..

	   Problem observed when connecting to a member (samba box)
	   of an AD domain as a user in a Samba domain.  Samba member
	   server sent back krb5/mskrb5/ntlmssp as mechtypes, but the
	   client (2ksp3) replied with ntlmssp/mskrb5/krb5 and an
	   NTLMSSP mechtoken.                 --jerry              */
(This used to be commit 731420b03d)
2003-07-31 19:01:22 +00:00
Alexander Bokovoy
f86708be99 Return proper error when it is impossible to change quota flags
(This used to be commit 44bae9da9e)
2003-07-31 17:08:38 +00:00
Volker Lendecke
c13fac26c5 Fix off-by-one found by valgrind.
Volker
(This used to be commit bc39c9b57f)
2003-07-31 15:53:59 +00:00
Volker Lendecke
34b15df02d spnego.c has function definitions. Prototype them.
Anybody familiar with Makefile.in could you please look at this?
This is probably the wrong way to fix this.

Volker
(This used to be commit 9a04750dea)
2003-07-31 15:53:26 +00:00
Volker Lendecke
deb62c1410 Fixes for memory leaks in gss spnego handling by aliguori.
Volker
(This used to be commit 946695242f)
2003-07-31 10:24:10 +00:00
Volker Lendecke
2f81ccefa2 This fixes an error I must have made when playing with spnego.c found
by aliguori: NegTokenInit.mechListMIC is an Octet String.

Second: add a free_spnego_data function.

Both thanks to aliguori.

Volker
(This used to be commit 6c252440fb)
2003-07-31 10:23:13 +00:00
Volker Lendecke
62ef886bee Apply some const
(This used to be commit 692ff44ba3)
2003-07-31 10:21:13 +00:00
Gerald Carter
3543399eac make sure the domain sid is set when enumerating trusted domains
(we don't always get it back)
(This used to be commit 6e8f23d1b1)
2003-07-31 06:37:37 +00:00
Gerald Carter
0d087e3ba2 working on transtive trusts issue:
* use DsEnumerateDomainTrusts() instead of LDAP search.
    wbinfo -m now lists all trusted downlevel domains and
    all domains in the forest.

Thnigs to do:

  o Look at Krb5 connection trusted domains
  o make sure to initial the trusted domain cache as soon
    as possible
(This used to be commit 0ab00ccaed)
2003-07-31 05:43:47 +00:00
Tim Potter
48c01deb30 Whoops - this is probably better shell syntax.
(This used to be commit 4644085b68)
2003-07-31 04:28:43 +00:00
Tim Potter
04b4c100c3 Turn on automatic winbindd support for FreeBSD and see what the compile farm
thinks of it.
(This used to be commit e6210295e4)
2003-07-31 04:27:41 +00:00
Andrew Tridgell
ddf3c6d5cc This is a critical bug fix for a data corruption bug. If you
maintain another tree then please apply!

On non-X86 machines out byte-order macros fails for one particular
value. If you asked for IVAL() of 0xFFFFFFFF and assigned it to a 64
bit quantity then you got a 63 bit number 0x7FFFFFFFFFFFFFFF rather
than the expected 0xFFFFFFFF. This is due to some rather bizarre and
obscure sign extension rules to do with unsigned chars and arithmetic
operators (basically if you | together two unsigned chars you get a
signed result!)

This affected a byte range lock using the large lockingX format and a
lock of offset 0 and length 0xFFFFFFFF. Microsoft Excel does one of
these locks when opening a .csv file. If the platform you run on does
not then handle locks of length 0x7FFFFFFFFFFFFFFF then the posix lock
fails and the client is given a lockingX failure. This causes the .csv
file to be trunated!!
(This used to be commit 886661c377)
2003-07-31 04:01:32 +00:00
Jeremy Allison
ba12e6bb5f Wrap calls to change_oem_password() in become_root()/unbecome_root() pairs
to allow UNIX password change scripts to work correctly. This is safe as
the old password has been checked as correct before invoking this.
Jeremy.
(This used to be commit 1734d43eb5)
2003-07-31 01:33:44 +00:00
Jeremy Allison
aa7f82c5cc Turn the 'doing_signing' variable on - fix bug where it was only being set
on when signing was mandatory.
Jeremy.
(This used to be commit 7c58673a10)
2003-07-31 00:30:01 +00:00
Jeremy Allison
29ca70cd34 Add a command line option (-S on|off|required) to enable signing on client
connections. Overrides smb.conf parameter if set.
Jeremy.
(This used to be commit 879309671d)
2003-07-30 23:49:29 +00:00
Jeremy Allison
d6ee1d167c Save us from possibly uninitialised variable (caught by gcc).
Jeremy.
(This used to be commit f3f29665bd)
2003-07-30 23:33:56 +00:00
Jeremy Allison
9c49c46948 Fix bug we discovered in W2K client signing on secondary trans2 packets.
Use W2K parameters. tpot please re-test smbclient with your problem
directory.
Jeremy.
(This used to be commit 677d3a3c4c)
2003-07-30 19:00:52 +00:00
Jeremy Allison
5ab2b1e921 Eliminate valgrind error when client gets bad sig on list. Some reformatting.
Jeremy.
(This used to be commit b8f6b83646)
2003-07-30 18:57:37 +00:00
Gerald Carter
c856d9274b add a few more tidy ups. Now onto winbindd
(This used to be commit f8abdd23e1)
2003-07-30 17:37:46 +00:00
Gerald Carter
de1a998622 add support for DsEnumerateDomainTrusted for enumerating all the
trusted domains in a forest.
(This used to be commit c691c7f7d9)
2003-07-30 17:29:00 +00:00
Jeremy Allison
316c77ed0b Don't revert something until you've seen if volker has already fixed it :-).
Jeremy.
(This used to be commit d57d9b99df)
2003-07-30 16:34:14 +00:00
Jeremy Allison
f5799f2db2 Comment out mutex until I get dependencies sorted out...
Jeremy
(This used to be commit 382d1732ca)
2003-07-30 15:30:36 +00:00
Volker Lendecke
9dbc000ecd bin/net needs server_mutex as kerberos_verify now uses it.
Volker
(This used to be commit ee09db891a)
2003-07-30 08:05:34 +00:00
Jeremy Allison
1b89b58475 Put mutex around access of replay cache for krb5 tickets. krb5 replay cache
is not multi-process safe.
Jeremy.
(This used to be commit 9e0534a1b6)
2003-07-29 21:32:36 +00:00
Herb Lewis
edabf75a54 split replace into replace and replace1 to allow setenv to be used by
nsswitch modules. Add required libraries to get rid of undefined
functions for libns_winbind.so and libns_wins.so
(This used to be commit cec5bf5f99)
2003-07-29 20:11:18 +00:00
Jeremy Allison
6070a519c2 Fix bug #226. Stop unmangle of name into a wildcard name from deleting more
than was intended.
Jeremy.
(This used to be commit e2742e0d89)
2003-07-29 19:16:59 +00:00
Alexander Bokovoy
428653ef72 Add NT quotas support. Users allowed now to manage quotas on systems with sysquotas interface detected (Linux at least) using native Windows tools. Also move default quota support for NT quotas to VFS module default_quota. Code by Metze
(This used to be commit e856a96c2c)
2003-07-29 18:07:13 +00:00
Jeremy Allison
79a5d2e31b Finish tridge's patch as referenced here :
make sure we don't allow the creation of directories containing
wildcard characters. I've only put this in mkdir at the moment, but I
suspect this will apply to all places that can create new filenames.

We need to allow the opening of existing filenames that contain
wildcards, but not allow the creation of new ones.

Jeremy.
(This used to be commit 7f111e545d)
2003-07-29 17:34:20 +00:00
Jeremy Allison
b40d1a2a76 Typo on my part. I typed KRB5_KDB_BAD_ENCTYPE when I meant to type KRB5_BAD_ENCTYPE.
Heimdal has the latter, not the former.
Jeremy.
(This used to be commit e8425df77c)
2003-07-29 17:03:51 +00:00
Jim McDonough
15188bcb02 Fix the build on Heimdal. KRB5_KDB_BAD_ENCTYPE doesn't exist on Heimdal, and
it's a different rc than KRB5_BAD_ENCTYPE (which exists on both MIT and
Heimdal).  This will just make the debug show up at level 3 always.

Jeremy, you may want to revisit this, but it's probably not worth the hassle.
(This used to be commit 4ff322ccf9)
2003-07-29 16:34:31 +00:00
Volker Lendecke
7730b658a1 This adds gss-spnego to ntlm_auth. It contains some new spnego support
from Jim McDonough. It is to enable cyrus sasl to provide the
gss-spnego support. For a preliminary patch to cyrus sasl see

http://samba.sernet.de/cyrus-gss-spnego.diff

Volker
(This used to be commit 45cef8f66e)
2003-07-29 15:00:38 +00:00
Tim Potter
4db6b05e13 Typo fix for bug 258.
(This used to be commit a4e342c20c)
2003-07-29 02:34:18 +00:00
Jeremy Allison
05875e573c Improved debug messages whilst trying to track down kerb issues.
Jeremy.
(This used to be commit 29dd71ddea)
2003-07-29 00:31:44 +00:00
Tim Potter
4e4e1de9cb More memory leak fixes from Brett! It turns out PyDict_SetItemString
didn't behave exactly as I thought it did.  If you create an item using a
PyFoo_FromBar function you must decrement the reference to that object
afterwards (or use Py_BuildValue).
(This used to be commit 2a960963fb)
2003-07-29 00:15:23 +00:00
Tim Potter
17c6789df1 Memory leak fixes from Brett A. Funderburg - don't use the connection talloc
context for data that is only needed on a per-call basis.
(This used to be commit 3cb39ddee4)
2003-07-29 00:08:05 +00:00
Tim Potter
84d98dd460 Add debug output api's from lsa/spoolss modules to smb module. Patch
from Brett A. Funderburg.
(This used to be commit 2cedaff044)
2003-07-29 00:05:17 +00:00
John Terpstra
d82199a61b Corrected description of SWAT FLAGS since they have changed as a result of the
cleanup of loadparm and swat.c
(This used to be commit 6956eb9a0b)
2003-07-28 05:49:51 +00:00
John Terpstra
8dea1bb932 Cleanup of loadparm and swat to correctly display all parameters as required.
No change to what is displayed has been made at this time. I do intend to
change the display order before 3.0.0 ships.
(This used to be commit de7d3063d9)
2003-07-28 05:47:15 +00:00
John Terpstra
b4918ea2be Add buttons to Printers View
(This used to be commit 805c33b089)
2003-07-27 19:49:23 +00:00
John Terpstra
d758d693fe Clarified what the SWAT FLAGS mean and what they do.
Note: The comments in this file regarding the FLAGS has been in need of
maintenance for some time.
(This used to be commit a0d2fa0f25)
2003-07-27 17:24:24 +00:00
Andrew Bartlett
5e2235843e Fix comment
(This used to be commit 2c395a3904)
2003-07-27 10:25:44 +00:00
Andrew Bartlett
ed7cb84dea the testsuite lib needs dummyroot too.
(This used to be commit e09a7c767e)
2003-07-27 03:43:41 +00:00
Andrew Bartlett
5ab880d684 Use the specified workgroup in 'net ads'. (Defaults to lp_workgroup()).
Andrew Bartlett
(This used to be commit e6cc5ca780)
2003-07-27 03:42:10 +00:00
Andrew Bartlett
5b84b13a1e Allow the stat cache to better handle invalid multibyte strings, by using
strdup_upper().  This function may fail - and we can just drop out of using
the cache in that case.  (Rather than panicing).

This also should get us closer to supporting all of the weird 'longer/shorter'
on uppercase/lowercase.

Andrew Bartlett
(This used to be commit d4c9261725)
2003-07-27 03:40:45 +00:00
Andrew Bartlett
1478bcd847 Try again to fix up 'session request' name exchange. This time we actualy
get the names...

Andrew Bartlett
(This used to be commit 7c9e204f7e)
2003-07-27 03:29:40 +00:00
Andrew Bartlett
abcac3d186 If we strupper_m after the alpha_strcpy() we know that it is less likaly
to contain multibyte charcters, as these should have been stripped.

Andrew Bartlett
(This used to be commit 0f7c1dda22)
2003-07-27 02:43:22 +00:00
Andrew Bartlett
224a9f35b8 When removing an 'unused' function, it helps to remove the 'unused' callers...
Andrew Bartlett
(This used to be commit 605a89493e)
2003-07-27 02:42:22 +00:00
Andrew Bartlett
4b3e0268b5 Use push_ucs2_allocate(), rather than convert_string_allocate() directly.
Remove strdup_upper/strdup_lower from their old file, now that they have
been moved to charcnv.c

Note that string_replace assumes that s is a pstring.  (doco change only)

Andrew Bartlett
(This used to be commit 6c9056029b)
2003-07-27 02:40:06 +00:00
Andrew Bartlett
455bb6de90 Some small fixes to our charset conversion code:
- Treat the NMB names in the 'session request' packet as 'ASCII'.  This means
   that we do not get invalid multibyte from the wire, even if we truncate
   in the conversion.  (Otherwise we panic when we try to strupper_m it).

 - Remove acnv_uxu2(), as it was duplicated by push_ucs2_allocate()
 - Remove acnv_dosu2(), as it is not used.

 - In push_ucs2(), with the STR_UPPER flag, do the case conversion *after*
   the UCS2 conversion, when it we know that the length can't change.  Also
   faster, as we don't need to do another 2 UCS2 conversions.

Andrew Bartlett
(This used to be commit 912035af11)
2003-07-27 02:28:25 +00:00
Jeremy Allison
9fc34cafa2 Ensure all code paths set add_script.
Jeremy.
(This used to be commit 0021c83ff6)
2003-07-27 00:20:45 +00:00
John Terpstra
50548f4ddc Format tidy up.
(This used to be commit 79d6e72af5)
2003-07-26 17:46:47 +00:00
John Terpstra
168beb5360 Added buttons to change view mode. Fixes bug #212
(This used to be commit 37d2eed445)
2003-07-26 16:56:38 +00:00
Gerald Carter
ca4dc16f85 fix typo in debug
(This used to be commit ed61628d8b)
2003-07-26 12:01:35 +00:00
Jeremy Allison
0c4358889e Correctly detect an "add user script" - check that *lp_adduser_script() != '\0',
not lp_adduser_script() != NULL.
Jeremy.
(This used to be commit 2eac65ebe7)
2003-07-26 01:21:06 +00:00
Jeremy Allison
559439e1f4 Start the packet signing engine in the kerberos case in the same place
as the ntlmssp case.
Jeremy.
(This used to be commit 79e0bf8298)
2003-07-25 23:43:22 +00:00
Jeremy Allison
4632786cfb W00t! Client smb signing is now working correctly with krb5 and w2k server.
Server code *should* also work (I'll check shortly). May be the odd memory
leak. Problem was we (a) weren't setting signing on in the client krb5 sessionsetup
code (b) we need to ask for a subkey... (c). The client and server need to
ask for local and remote subkeys respectively.
Thanks to Paul Nelson @ Thursby for some sage advice on this :-).
Jeremy.
(This used to be commit 3f9e3b6070)
2003-07-25 23:15:30 +00:00
Gerald Carter
37d77e3d6c Fix bug #184; set max_pw_age in account_pol to -1 so the default is never to expire
(This used to be commit 833bc5c060)
2003-07-25 19:57:26 +00:00
Gerald Carter
6ec2213bdb domain in schannel bind credentials must be the dest domain, not ours
(This used to be commit e12f6a8c13)
2003-07-25 18:00:57 +00:00
Gerald Carter
c916e5e390 fix case where no realm or workgroup means to use our own
(This used to be commit 6edc7e0a74)
2003-07-25 16:42:34 +00:00
Gerald Carter
5a6661100b fix user_in_list to work with winbind groups again; my bug
(This used to be commit 850f4fafdb)
2003-07-25 16:03:46 +00:00
Gerald Carter
6bf70229ae fix some error returns and strings; patch from metze
(This used to be commit 948b1b138c)
2003-07-25 14:35:17 +00:00
Tim Potter
7d833de662 More printf portability fixes. Got caught out by some gcc'isms last
time.  )-:
(This used to be commit 59dae1da66)
2003-07-25 04:24:40 +00:00
Andrew Bartlett
c9305f1c64 Schannel, once setup, may be used on *ANY* TCP/IP connection until the
connection that set it up has been shut down.

(Also, pipes still connected, and reconnections to the same pipe (eg SAMR)
may continue to use that session key until their TCP/IP connection is shut
down)

Allow further testing by printing out the session key, and allowing it's input
into rpcclient.

Next step is automatic storage in a TDB.

Andrew Bartlett
(This used to be commit fa4d7be161)
2003-07-25 01:26:19 +00:00
Tim Potter
ff5f4d66a5 Make wbinfo -p work again. Fixes bug 251.
(This used to be commit ad4dd4909f)
2003-07-25 01:18:10 +00:00
Tim Potter
2a7f874c4a Jean-Baptiste Marchand on the ethereal list used some auditing tricks to
discover names for the SAMR specific permissions that were previously unknown.

The existing constant names differ from what win2k calls them but since they
aren't heavily used in Samba at the moment I'll leave them as they are.

Jean-Baptiste's data is at:

http://ethereal.ntop.org/lists/ethereal-dev/200307/msg00314.html
(This used to be commit ae77e9e554)
2003-07-25 00:39:06 +00:00
Tim Potter
77373f1f8e More printf fixes - size_t is long on some architectures.
(This used to be commit ba4d334b82)
2003-07-24 23:46:27 +00:00
Jeremy Allison
60097e0d8d Fix from matt.zinkevicius@hp.com to stop files being created on read-only
shares in some circumstances.
Jeremy.
(This used to be commit b826e8c898)
2003-07-24 19:10:52 +00:00
Jeremy Allison
ceb68ee051 Fix packet signing with asynchronous oplock breaks. Removed bad error message
due to w2k bug. I think this code is now working.... Need more testing of course
but works on all the obvious cases I can think of.
Jeremy.
(This used to be commit a6e537f661)
2003-07-24 19:05:32 +00:00
Alexander Bokovoy
27db257734 Add a macro to check whether module-specific data set already or not. Returns True or False. Should support further encapsulation of VFS-specific structs
(This used to be commit 180e617f54)
2003-07-24 14:23:54 +00:00
Alexander Bokovoy
ae6a63fa46 Rise debug level to 5 for not-found-nt-quota message (quota setting for user wasn't found)
(This used to be commit 422dffdc40)
2003-07-24 11:37:11 +00:00
Jeremy Allison
a9c0fcfa37 Some fclose -> x_fclose found by Tony Jago.
Jeremy.
(This used to be commit 919078cf39)
2003-07-24 07:02:55 +00:00
Jeremy Allison
0c9433c031 Ensure everywhere we defer an incoming SMB request (blocking lock queue,
in oplock break state, change notify queue) we also push the MID onto
the deferred signing queue. Tomorrow I will test this with valgrind and
oplock tests.
Jeremy.
(This used to be commit 33a377f372)
2003-07-24 06:56:56 +00:00
Jeremy Allison
08634e26e4 SMB signing is now working with change notify. Need to fix the disconnect
when bad signature received, plus check the oplock breaks....
Jermey.
(This used to be commit dd83931a00)
2003-07-24 06:19:37 +00:00
Jeremy Allison
79e2d7c24e Server side NTLM signing works - until the first async packet. Working on this
next....
Jeremy.
(This used to be commit eff74a1fcc)
2003-07-24 04:25:37 +00:00
Tim Potter
9832cd8617 Some more [ug]id_t printf fixes.
(This used to be commit 165d1ae556)
2003-07-24 00:01:10 +00:00
Tim Potter
b32da5a1c7 Ensure a prototype is generated for smb_snprintf()
Final bit for bug 187.
(This used to be commit 13840704f5)
2003-07-23 23:30:46 +00:00
Gerald Carter
3a00cedc01 connect to the right realm or domain for trusted AD domains
(This used to be commit 83376671c5)
2003-07-23 19:58:01 +00:00
Gerald Carter
3a5dc7c2ec convert snprintf() calls using pstrings & fstrings
to pstr_sprintf() and fstr_sprintf() to try to standardize.
lots of snprintf() calls were using len-1; some were using
len.  At least this helps to be consistent.
(This used to be commit 9f835b85dd)
2003-07-23 12:33:59 +00:00
Andrew Tridgell
490fcdd199 fixed segv in calls to pstrcpy() in cliprint.c
(This used to be commit 36bc2b99b4)
2003-07-23 10:09:29 +00:00
Tim Potter
3f3e2a8f49 Fix out of date comment.
(This used to be commit 2e5bd16654)
2003-07-23 07:14:33 +00:00
Tim Potter
80b46fd6cf Move a function to avoid a warning.
(This used to be commit a3b4c57503)
2003-07-23 06:37:51 +00:00
Tim Potter
c085ace063 Typo in comment.
(This used to be commit 6a9bfcd3b8)
2003-07-23 06:11:38 +00:00
Jeremy Allison
e79e26eb00 Don't check in two places for signing turned off...
Jeremy.
(This used to be commit f4b02e52e2)
2003-07-23 06:04:20 +00:00
Tim Potter
8991cecd54 A fix for bug 174. I'm pushing this to the tree to test it on one of
the build farm machines that I don't have direct access to (hpntc9I).
(This used to be commit b019658233)
2003-07-23 03:59:57 +00:00
Tim Potter
0c72828e3d Fix two memory leaks in the smb module:
- free talloc context when cli_query_secdesc() fails

 - dispose of cli_state when python cli_state_object is garbage collected
(This used to be commit 36052f95ff)
2003-07-23 01:26:46 +00:00
Gerald Carter
c51ffbbdaa removing unused function
(This used to be commit b8394a107d)
2003-07-22 15:08:34 +00:00
Gerald Carter
d22a90c64f bumping version string
(This used to be commit e4cd21222d)
2003-07-22 15:02:39 +00:00
Alexander Bokovoy
dca325f4f2 Fix comment
(This used to be commit 04f1577a39)
2003-07-22 14:43:05 +00:00
Tim Potter
c9bc4b27b7 Another round of uid/gid/pid format string changes I missed the
first time.
(This used to be commit 6616485dba)
2003-07-22 06:52:39 +00:00
Tim Potter
80c1f1d865 Fixup a bunch of printf-style functions and debugs to use unsigned long when
displaying pid_t, uid_t and gid_t values.  This removes a whole lot of warnings
on some of the 64-bit build farm machines as well as help us out when 64-bit
uid/gid/pid values come along.
(This used to be commit f93528ba00)
2003-07-22 04:31:20 +00:00
Tim Potter
06345b8116 Use %p for a pointer type in a printf-style format string. Also casting
a pointer to a uint32 value is incorrect on a 64-bit architecture.
(This used to be commit afed2cbbcc)
2003-07-22 01:18:24 +00:00
Tim Potter
274f1f8806 Replace the eight (!) copies of dummy become/unbecome root with a single one.
(This used to be commit 8b818ce381)
2003-07-22 00:20:53 +00:00
Tim Potter
63537d0add Use lp_idmap_[ug]id() instead of lp_winbind_[ug]id()
(This used to be commit cfb86b4503)
2003-07-22 00:16:39 +00:00
Tim Potter
71a93a1551 Metze's AD/LDAP detection patches mainly to do with library detection.
Tested on a large combination of operating systems and versions.
Hopefully the build farm will find any remaining nasties if they
exist.
(This used to be commit 2e42fa3d72)
2003-07-21 23:42:45 +00:00
Richard Sharpe
f746a68030 Clarify a debug log a little. The path might not exist, so say so.
(This used to be commit 8409cf3e47)
2003-07-21 20:20:09 +00:00
Rafal Szczesniak
b3064ac5d6 This creates passdb backend files automatically when adding first account.
An extra message notifying that needed file didn't exist is displayed.
There's still a little catch with tdb backend, but it's better than it was,
from end-user's point of view.

This fixes #198


rafal
(This used to be commit b0be700605)
2003-07-20 21:43:41 +00:00
Rafal Szczesniak
bbd4c98b06 Typo fixes.
(This used to be commit 85df8213fc)
2003-07-20 14:50:38 +00:00
Volker Lendecke
7756b4088d Fix memleak
(This used to be commit defc71d4cb)
2003-07-19 11:28:15 +00:00