1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-27 03:21:53 +03:00
Commit Graph

39 Commits

Author SHA1 Message Date
Stefan Metzmacher
ee8d777bbf CVE-2016-0771: s4:dns_server: fix idl for dns_txt_record
From RFC 1035:

    3.3.14. TXT RDATA format

        +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
        /                   TXT-DATA                    /
        +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+

    where:

    TXT-DATA        One or more <character-string>s.

    TXT RRs are used to hold descriptive text.  The semantics of the text
    depends on the domain where it is found.

Each record contains an array of strings instead of just one string.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11128
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11686

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2016-03-10 06:52:24 +01:00
Stefan Metzmacher
7e301c76ce s4:dns_server: add some const to dns_server_process_update/dns_update_allowed arguments
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
2014-11-18 04:17:09 +01:00
Kai Blin
229f8b324a dns: Fix a compile warning by casting explicitly
Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2014-10-30 06:52:04 +01:00
Stefan Metzmacher
491715399f s4:dns_server: handle tombstones in handle_one_update()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10749

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2014-08-26 09:13:06 +02:00
Stefan Metzmacher
3ff025a02c s4:dns_server: use .wType = DNS_TYPE_TOMBSTONE instead of ZERO_STRUCT()
The result is the same, but it is clearer.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10749

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2014-08-26 09:13:06 +02:00
Stefan Metzmacher
0689e795e0 s4:dns_server: split out dns_common_replace()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10749

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2014-08-26 09:13:06 +02:00
Stefan Metzmacher
d0f424a23d s4:dns_server: map LDB_ERR_NO_SUCH_OBJECT to WERR_DNS_ERROR_NAME_DOES_NOT_EXIST
This is the correct fix for commit 8b24c43b38
and Bug: https://bugzilla.samba.org/show_bug.cgi?id=9559

With this change we have a consistent behavior between internal server
and the bind dlz module. We keep a dangling LDAP object without
dnsRecord attribute arround forever. This will be fixed in the following
commits.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10749

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2014-08-26 09:13:06 +02:00
Kai Blin
f31bda6715 dns: Use new DNS debugclass in DNS server
Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-By: Amitay Isaacs <amitay@gmail.com>
2013-05-16 21:40:15 +10:00
Stefan Metzmacher
9583366d1e s4:dns_server: remove wrong and unused dsdb_check_access_on_dn() check
metze
2012-09-12 16:51:29 +02:00
Andrew Bartlett
61a07df824 dns_server: Attempt to SET and UNSET the sessionInfo to match the incoming user
This avoids re-opening the DB as the correct user, but applies all the right ACLs
and resulting owner.

This needs a bit more testing...

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Kai Blin <kai@samba.org>
2012-09-12 16:51:29 +02:00
Kai Blin
cf3aab61fa s4 dns: Improve logging of delegated dns updates 2012-09-12 16:51:29 +02:00
Kai Blin
8ba8020586 s4 dns: Make debug output less noisy
Autobuild-User(master): Kai Blin <kai@samba.org>
Autobuild-Date(master): Fri Sep  7 00:31:56 CEST 2012 on sn-devel-104
2012-09-07 00:31:56 +02:00
Kai Blin
319b239dc4 s4 dns: Check if signing user is allowed to update records
This should fix bug #9142
2012-09-06 22:43:05 +02:00
Kai Blin
5e492f8d32 s4 dns: Allow configuring signed updates
Autobuild-User(master): Kai Blin <kai@samba.org>
Autobuild-Date(master): Wed Sep  5 20:42:46 CEST 2012 on sn-devel-104
2012-09-05 20:42:46 +02:00
Kai Blin
558fa4c45a s4 dns: Revert erroneous push from wrong branch
I've pushed the wrong branch for this, sorry about that.

Autobuild-User(master): Kai Blin <kai@samba.org>
Autobuild-Date(master): Wed Sep  5 14:10:54 CEST 2012 on sn-devel-104
2012-09-05 14:10:54 +02:00
Kai Blin
2311a2c9f5 s4 dns: Allow configuring signed updates
Autobuild-User(master): Kai Blin <kai@samba.org>
Autobuild-Date(master): Wed Sep  5 10:45:22 CEST 2012 on sn-devel-104
2012-09-05 10:45:22 +02:00
Christian Ambach
18c152f8aa lib/param: move enum dns_update_settings to lib/param 2012-08-06 18:07:52 +02:00
Volker Lendecke
0b2743c71e s4-dns: Fix some typos
Signed-off-by: Kai Blin <kai@samba.org>
2012-05-30 00:37:54 +02:00
Volker Lendecke
da74d5462d s4-dns: Remove some break; statements
We fall through implicitly, and that pattern is used elsewhere in Samba as
well.

Signed-off-by: Kai Blin <kai@samba.org>
2012-05-30 00:37:54 +02:00
Kai Blin
60eb1621d2 s4 dns: Allow updating PTR records.
Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Fri Mar 30 19:26:52 CEST 2012 on sn-devel-104
2012-03-30 19:26:52 +02:00
Kai Blin
533b2e6612 s4 dns: Allow changing the dns operation flags in handlers 2012-03-27 16:03:16 +02:00
Kai Blin
26a0e7a3f5 s4 dns: Test deleting records and fix a small bu
Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Sun Mar 11 02:27:45 CET 2012 on sn-devel-104
2012-03-11 02:27:45 +01:00
Kai Blin
1e6ef242ec s4 dns: Be less chatty during tests 2012-03-11 00:31:38 +01:00
Kai Blin
98ae3592ad s4 dns: Support TXT updates, add tests 2012-03-11 00:31:37 +01:00
Amitay Isaacs
78446b42b7 s4-dns: Fix handling of TXT DNS Record 2012-03-02 00:24:50 +11:00
Kai Blin
b1fdf4065e s4 dns: Allow updates based on smb.conf setting
Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Sat Dec 17 04:19:40 CET 2011 on sn-devel-104
2011-12-17 04:19:40 +01:00
Kai Blin
afa98bdc51 s4 dns: Add some debug output 2011-12-17 02:46:08 +01:00
Kai Blin
d8a499a27b s4 dns: Actually handle the update request 2011-12-17 02:46:08 +01:00
Kai Blin
c191ad7e13 s4 dns: Implement RFC-compatible update prescan 2011-12-17 02:46:08 +01:00
Kai Blin
02c9e18094 s4 dns: Update prerequisite checking conforming to RFC 2011-12-17 02:46:08 +01:00
Kai Blin
c01efc1207 s4 dns: Update requests with QCLASS != IN or ALL trigger NOTIMPLEMENTED errors
Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Fri Dec  9 03:32:28 CET 2011 on sn-devel-104
2011-12-09 03:32:28 +01:00
Kai Blin
509acc71dd s4 dns: More explicitly use the first question of an update packet only 2011-12-09 01:59:28 +01:00
Kai Blin
3fbb76c119 s4 dns: Get rid of const qualifier for prereqs, we do need to allocate those 2011-12-09 01:59:28 +01:00
Matthias Dieter Wallnöfer
821c962d2a s4:dns_server/dns_update.c - remove unreachable statements 2010-11-29 14:48:13 +01:00
Kai Blin
72c8ccd408 s4 dns: Implement update record prescan logic
Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Sat Oct 23 10:58:18 UTC 2010 on sn-devel-104
2010-10-23 10:58:18 +00:00
Kai Blin
005a65660d s4 dns: Add stub checking if updates are allowed 2010-10-23 10:17:06 +00:00
Kai Blin
1e670dff6a s4 dns: Add a prerequisites check for updates 2010-10-23 10:17:06 +00:00
Kai Blin
cfa47965fe s4 dns: Switch to WERROR 2010-10-23 10:17:06 +00:00
Kai Blin
682a2e93da s4 dns: Split up the code into multiple files for easier development 2010-10-23 10:17:06 +00:00