1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-27 03:21:53 +03:00
Commit Graph

19861 Commits

Author SHA1 Message Date
Jeremy Allison
7e40933d7b r16245: Cope with string being zero len. Klocwork bug #410.
Jeremy.
(This used to be commit afe2d4c493)
2007-10-10 11:17:27 -05:00
Jeremy Allison
8f2d6e4852 r16243: Fix Klocwork bugs #581 and #706, ensure we check
the end of array first in the loop. Reformat to
modern standards.
Jeremy.
(This used to be commit 66275bd3bc)
2007-10-10 11:17:27 -05:00
Jeremy Allison
f9147c4e40 r16241: Fix Klocwork #106 and others like it.
Make 2 important changes. pdb_get_methods()
returning NULL is a *fatal* error. Don't try
and cope with it just call smb_panic. This
removes a *lot* of pointless "if (!pdb)" handling
code. Secondly, ensure that if samu_init()
fails we *always* back out of a function. That
way we are never in a situation where the pdb_XXX()
functions need to start with a "if (sampass)"
test - this was just bad design, not defensive
programming.
Jeremy.
(This used to be commit a0d368197d)
2007-10-10 11:17:27 -05:00
Jeremy Allison
a1e0a0e928 r16230: Fix Klocwork #861 and others. localtime and asctime
can return NULL. Ensure we check all returns correctly.
Jeremy.
(This used to be commit 6c61dc8ed6)
2007-10-10 11:17:26 -05:00
Günther Deschner
2b99951e75 r16222: Fix DEBUG statements.
Guenther
(This used to be commit 5ecfaf7d50)
2007-10-10 11:17:26 -05:00
Günther Deschner
e8b4c92f32 r16221: No need for friednly error messages at log level 10.
Guenther
(This used to be commit 58a7c09003)
2007-10-10 11:17:26 -05:00
Gerald Carter
b32d2ecf9c r16219: BUG 3836, 3837, 3004: compile warning fixes from Jason Mader.
(This used to be commit 6c1f1c091f)
2007-10-10 11:17:26 -05:00
Jeremy Allison
2e8b3ca0cb r16216: Add debug messages to make it possible to try and
debug why a job pause or resume command is not being
done.
Jeremy.
(This used to be commit e6aacb1426)
2007-10-10 11:17:26 -05:00
Jeremy Allison
a5da0a72e1 r16213: Fix Klocwork #852. iface_n_ip can potentially
return NULL. Ensure we don't deref.
Jeremy.
(This used to be commit c2f0ea2ff2)
2007-10-10 11:17:26 -05:00
Jeremy Allison
d4a80fdf38 r16209: Klocwork bug #66, ensure no null deref.
Jeremy.
(This used to be commit 79e693798c)
2007-10-10 11:17:25 -05:00
Jeremy Allison
069397c63e r16207: Ensure we don't allocate an OID string unless
we know we don't have an error. Klocwork #6.
Jeremy.
(This used to be commit 2c1a2d7b40)
2007-10-10 11:17:25 -05:00
Gerald Carter
6cb8d09710 r16206: Don Meyer <dlmeyer@uiuc.edu> pointed out that RHEL4 rpms use 'Epoch: 0' so work around that
(This used to be commit 304b7913cd)
2007-10-10 11:17:25 -05:00
Gerald Carter
e6b64f6157 r16205: Fix 'make install' when srcdir != builddir
(This used to be commit 44d4bab991)
2007-10-10 11:17:25 -05:00
Volker Lendecke
0372e03722 r16204: Fix Klocwork # 14
localtime() can return NULL.

Volker
(This used to be commit 07c5dcb863)
2007-10-10 11:17:25 -05:00
Volker Lendecke
a47ffac30d r16203: Fix potentially writing one result of strtok beyond the end of alt_path.
Found by Klocwork, ID 653.

Volker
(This used to be commit 4cb8cf221f)
2007-10-10 11:17:25 -05:00
Jeremy Allison
92db75b4a2 r16202: Fix Klocwork #3. Strange - was already fixed in HEAD.
Jeremy.
(This used to be commit 319f80bbf0)
2007-10-10 11:17:25 -05:00
Volker Lendecke
edcffcbe28 r16201: Fix Klocwork 439
(This used to be commit b369d0891a)
2007-10-10 11:17:24 -05:00
Jeremy Allison
c0e4753cfc r16199: Fix Klocwork #1 - ensure we test the first
strtok for NULL.
Jeremy.
(This used to be commit 98751e8190)
2007-10-10 11:17:24 -05:00
Volker Lendecke
4d1688bf6b r16198: Fix Klocwork 1023
(This used to be commit 3a7d01afbe)
2007-10-10 11:17:24 -05:00
Volker Lendecke
8fa2907efd r16197: Fix Klocwork id 1338
(This used to be commit 963ae5bd14)
2007-10-10 11:17:24 -05:00
Volker Lendecke
15e26314b6 r16196: A bit of defensive programming:
Klocwork ID 1773 complained about oldest being dereferenced in line 2275 where
it could be NULL. I think you can construct extreme racy conditions where this
actually could happen.

Volker
(This used to be commit b5602cc4f1)
2007-10-10 11:17:24 -05:00
Gerald Carter
668727d035 r16195: starting development for 3.0.24pre1
(This used to be commit 1b64f9a48b)
2007-10-10 11:17:24 -05:00
Gerald Carter
e52615f957 r16193: fix packaging dependency on RH platforms for the Unicode::MapUTF8 perl module (caused by upgarde in smbldap-tools)
(This used to be commit abca3b12e7)
2007-10-10 11:17:24 -05:00
Günther Deschner
395aa679f0 r16192: Fix timeformats in the winbind response struct.
(pam_winbind users were forced to change a password inappropriately)

Guenther
(This used to be commit 65643d3172)
2007-10-10 11:17:23 -05:00
Günther Deschner
1628d33ba0 r16190: Fix more memleaks.
Guenther
(This used to be commit dfebcc8e19)
2007-10-10 11:17:23 -05:00
Günther Deschner
2828356be3 r16187: Fix memleak.
Guenther
(This used to be commit e7d2b84aba)
2007-10-10 11:17:23 -05:00
Volker Lendecke
3ea740f5e5 r16156: Fix storing NULL in the wrong place. Klocwork id's 127 and 128.
Volker
(This used to be commit 7674a4f836)
2007-10-10 11:17:23 -05:00
Jeremy Allison
685aed3fb4 r16155: Janitor for jelmer.
Fix typo in DEBUG()
Jeremy.
(This used to be commit da768bf9c2)
2007-10-10 11:17:23 -05:00
Günther Deschner
ee1105754c r16154: Fix winbind function table typo.
Guenther
(This used to be commit aeff1f0c47)
2007-10-10 11:17:23 -05:00
Volker Lendecke
ab710c9e25 r16153: Fix possible NULL dereference found by Klocwork # 252
(This used to be commit 128260527b)
2007-10-10 11:17:23 -05:00
Volker Lendecke
780f121462 r16150: Fix possible NULL dereference found by Klocwork ID # 17
(This used to be commit 3159bd3a4e)
2007-10-10 11:17:22 -05:00
Volker Lendecke
21eeddb80d r16141: Dummy commit to make the build farm re-test against Samba4 16140
(This used to be commit a1fcacf756)
2007-10-10 11:17:22 -05:00
Alexander Bokovoy
21706838f5 r16138: By default, rootsbindir relies on SBINDIR so import it here
(This used to be commit a18af427d7)
2007-10-10 11:17:22 -05:00
Alexander Bokovoy
c403a5525c r16136: By default, rootsbindir relies on SBINDIR so import it here
(This used to be commit 5ffb424641)
2007-10-10 11:17:22 -05:00
Gerald Carter
f337a089d1 r16131: fix RedHat 9 spec files
(This used to be commit 1ffb0f06ad)
2007-10-10 11:17:22 -05:00
Gerald Carter
7112413350 r16130: fix a shell portability issue for Solaris sh in installman.sh
(This used to be commit 9be3e07884)
2007-10-10 11:17:22 -05:00
Jeremy Allison
3b469083be r16126: Janitor for Volker..... This looks correct to me.
Jeremy.

Fix a parsing error that became apparent in 'make test': If we have no
group
rids in the info3 we set the array buffer pointer to "1" but fail to
actually
ship the array.

Volker.
(This used to be commit ee1b9207d3)
2007-10-10 11:17:22 -05:00
Günther Deschner
38060f70a5 r16122: As we use 'inetOrgPerson' as structural objectclass for new accounts for
eDir, we already add 'sn' as required attribute on LDAP add
operations.

When we modify an entry, we need to request 'sn' as well in our
attribute lists, so that we don't try to add it a second time.

Guenther
(This used to be commit e018ea3d1d)
2007-10-10 11:17:21 -05:00
Günther Deschner
d28456fe22 r16121: Fix a eDir related memory leak.
Guenther
(This used to be commit 322f1664df)
2007-10-10 11:17:21 -05:00
Günther Deschner
97f496a0e3 r16117: Make winbindd work again in security=ads.
We still used the old HOST/* UPN to get e.g. users, now we need
samaccountname$@REA.LM.

Guenther
(This used to be commit f6516a799a)
2007-10-10 11:17:21 -05:00
James Peach
c12c557a13 r16116: Hoist the slow CLOCK_REALTIME message inside the branch so we never
confuse an uninitialised __profile_clock with CLOCK_REALTIME. Flip the
condition argument to SMB_WARN around so that it's correct (though
completely non-intuitive).
(This used to be commit 60b5f9618b)
2007-10-10 11:17:21 -05:00
Günther Deschner
bf7a5433b4 r16115: Make "net ads changetrustpw" work again.
(adapt to the new UPN/SPN scheme).

Guenther
(This used to be commit 8fc70d0df0)
2007-10-10 11:17:21 -05:00
Günther Deschner
33c918b11a r16114: Make winbindd's group enumeration (set|get|endgrent) work again (when
enabled).

Do not bail out when a group just has 0 members.

Jeremy, please check, this has been removed with r13915.

Guenther
(This used to be commit 3a738a855d)
2007-10-10 11:17:21 -05:00
Jeremy Allison
088c571df8 r16112: Added Volker's fix for extra odd byte at the end
of UNIX_BASIC infolevel. Checked client implementations
(cifsfs and libsmb) and they ignore it. Thanks Volker.
Jeremy.
(This used to be commit 6cd1cb5c9d)
2007-10-10 11:17:20 -05:00
James Peach
8882d08b6b r16111: Patch from Björn JACKE <samba@j3e.de>.
This fixes a problem where the clock definition for clock_gettime() is
present at compile time, but is not available on the running system. In
this case, we fall back to less-preferred clocks until we find one that
we can use.
(This used to be commit fc6ed6a1aa)
2007-10-10 11:17:20 -05:00
Paul Green
b7eaff26dc r16103: Properly rebuild timelimit on systems with executable extensions.
Paul
(This used to be commit f5be3e12e2)
2007-10-10 11:17:20 -05:00
Günther Deschner
9467e6f41a r16080: Re-add accidentially excluded in-forest domain trusts (fixes bug #3823).
Guenther
(This used to be commit 8759a00fed)
2007-10-10 11:17:20 -05:00
Gerald Carter
564529b91a r16079: How embarassing. :-( Broke the build.
I will *always* compile before checking in...
I will *always* compile before checking in...
I will *always* compile before checking in...
I will *always* compile before checking in...
I will *always* compile before checking in...
(This used to be commit f3bd1c8c7d)
2007-10-10 11:17:20 -05:00
Gerald Carter
6b1b66904d r16078: Patch from Aleksey Fedoseev <fedoseev@ru.ibm.com> to correctly
set the type of 'acl compatibility from string to integer
after the changes in r14207.
(This used to be commit b01f289f1a)
2007-10-10 11:17:20 -05:00
Jeremy Allison
f897e7094f r16076: Fix for machine password timeout overflow from Shlomi Yaakobovich
<Shlomi@exanet.com>.
Jeremy.
(This used to be commit 5cd234a1ff)
2007-10-10 11:17:19 -05:00