1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-27 14:04:05 +03:00

17189 Commits

Author SHA1 Message Date
Volker Lendecke
ea3a4142a0 r17585: Don't let ads_status throw away the error information.
Thanks to Michael Adam <ma@sernet.de>.

Volker
2007-10-10 11:38:41 -05:00
Volker Lendecke
f6194cf4b2 r17584: Some C++ Warnings 2007-10-10 11:38:41 -05:00
Volker Lendecke
990da03f09 r17583: Change internal cli_session_setup functions to NTSTATUS.
Volker
2007-10-10 11:38:40 -05:00
Volker Lendecke
fd6e3f133b r17573: Fix typo 2007-10-10 11:38:40 -05:00
Volker Lendecke
acf237b3cd r17572: Fix the build 2007-10-10 11:38:40 -05:00
Volker Lendecke
94817a8ef5 r17571: Change the return code of cli_session_setup from BOOL to NTSTATUS
Volker
2007-10-10 11:38:39 -05:00
Volker Lendecke
eb45de167d r17569: Make 'max smbd processes' more robust. Counting on the child to decrement a
tdb entry is not the most reliable way to count children correctly.

This increments the number of children after a fork and decrements it upon
SIGCLD. I'm keeping a list of children just for consistency checks, so that we
at least get a debug level 0 message if something goes wrong.

Volker
2007-10-10 11:38:39 -05:00
Volker Lendecke
2a66abca02 r17568: Reformatting -- more than 100 cols is too much :-) 2007-10-10 11:38:39 -05:00
Volker Lendecke
c4e10afadb r17557: Change net_join_domain to return NTSTATUS instead of int.
Thanks to Michael Adam <ma@sernet.de>.

Volker
2007-10-10 11:38:39 -05:00
Volker Lendecke
ea83001d3e r17556: Remove duplicate entries. Thanks to Michael Adam <ma@sernet.de>
Volker
2007-10-10 11:38:39 -05:00
Volker Lendecke
4199b5d226 r17555: Cleanup 2007-10-10 11:38:39 -05:00
Volker Lendecke
761cbd52f0 r17554: Cleanup 2007-10-10 11:38:38 -05:00
Volker Lendecke
4a7b06860c r17552: Attempt to fix tdb transactions on IRIX 2007-10-10 11:38:38 -05:00
Volker Lendecke
d44599de3a r17551: Move some DEBUG to d_printf in interactive functions and return
NO_LOGON_SERVERS if no domain controller was found.

Thanks to Michael Adam <ma@sernet.de>.

Volker
2007-10-10 11:38:38 -05:00
Volker Lendecke
6bf5e7080a r17550: Fix a few bugs in the tdb_multikey code. Thanks to tridge for pointing them
out.

Volker
2007-10-10 11:38:38 -05:00
Jeremy Allison
ff2f1202b7 r17541: When returning a trans2 request, if the "max data
bytes returned" is less than the amount we want
to send, return what we can and set STATUS_BUFFER_OVERFLOW
(doserror ERRDOS,ERRbufferoverflow). Required by
OS/2 to handle EA's that are too large. It's hard
to test this in Samba4 smbtorture as the max data
bytes returned is hard coded at 0xffff (as it is
in the Samba3 client libraries also). I used a
custom version of Samba4 smbtorture to test this
out. Might add a "max data bytes" param to make
this testable in the build farm. Confirmed by
"Guenter Kukkukk (sambaos2)" <sambaos2@kukkukk.com>
and Andreas Taegener <atsamba11@eideltown.de>
that this fixes the issue.
Jeremy.
2007-10-10 11:38:38 -05:00
Volker Lendecke
cf7c83d462 r17536: Add a debug message citing the reason why an LDAP connection failed, inspired
by Christian M Ambach <CAMBACH1@de.ibm.com>.

Volker
2007-10-10 11:38:37 -05:00
Volker Lendecke
0f483cf66c r17535: Reformatting, this had many tabs instead of ^$ 2007-10-10 11:38:37 -05:00
Jeremy Allison
2ba0d93d53 r17496: net groupmap add could add uninitialized sid_name_type
entries to the group mapping db. Ensure this can't happen.
Jeremy.
2007-10-10 11:38:37 -05:00
Volker Lendecke
c0ff2afe06 r17477: Add talloc_asprintf_len and make use of it.
Volker
2007-10-10 11:38:37 -05:00
Volker Lendecke
f0f0e893ca r17470: This is the group mapping rewrite announced a few days ago. I'm afraid it's
more than 1000 lines of patch, but doing it in smaller pieces is hardly
possible.

Anybody interested please look over this. The patch is not really interesting,
just look at the new groupdb/mapping.c file.

Jerry, one entry for the 3.0.24 release notes: smbd will refuse to start if we
have overlapping mappings in group_mapping.tdb. With the old db a unix gid can
be mapped to two different SIDs. This will be refused with the new code.

Volker
2007-10-10 11:38:36 -05:00
Simo Sorce
c7d115a7d0 r17469: remove unused variable 2007-10-10 11:38:36 -05:00
Volker Lendecke
4ebfc30a28 r17468: To minimize the diff later on, pre-commit some changes independently: Change
internal mapping.c functions to return NTSTATUS instead of BOOL.

Volker
2007-10-10 11:38:36 -05:00
Volker Lendecke
244b25ae49 r17465: Get rid of add_initial_entry. In the two places it was called in it seemed a
bit pointless to me.

Volker
2007-10-10 11:38:36 -05:00
Jeremy Allison
c8e6f7e41c r17464: Ensure we use a hash16 data type, not a string,
for storing offline hashes.
Jeremy.
2007-10-10 11:38:36 -05:00
Volker Lendecke
f9856f6490 r17463: A bit of cleanup work:
Remove some unused code: pdb_find_alias is not used anymore, and nobody I
think has ever used the pdb_nop operations for group mapping. smbpasswd and
tdb use the default ones and ldap has its own.

Make the functions pdb_getgr* return NTSTATUS instead of BOOL. Nobody right
now really makes use of it, but it feels wrong to throw away information so
early.

Volker
2007-10-10 11:38:36 -05:00
Simo Sorce
954593bd41 r17462: Fix a cut&paste bug that caused us to return a null SID on some error conditions 2007-10-10 11:38:35 -05:00
Jeremy Allison
f8584a4758 r17461: Ensure we never save a NULL SID mapping. || should be &&.
Found by Whitfield school.
Jeremy.
2007-10-10 11:38:35 -05:00
Volker Lendecke
a1c3774e01 r17460: First step at fixing the build breakage with the groupmapping test. On Linux,
F_RDLCK is defined to 0, for example NetBSD has it at 1.

Still does not work fully though. Still investigating.

This might also be interesting to Samba4.

Volker
2007-10-10 11:38:35 -05:00
Simo Sorce
b8578bfab6 r17459: As by Jerry's word commit this without his review.
This patch add some missing async functions to
solve UID/GID -> SID requests not just out of the cache,
but down the remote idmap if necessary.

This patch solves the problem of servers not showing users/groups names
for allocated UID/GIDs when joined to a group of servers that share a
prepopulated idmap backend.

Also correctly resolve UID/GIDs to SIDs when looking ACLs from the
windows security tab on teh same situation.

Simo.
2007-10-10 11:38:35 -05:00
Volker Lendecke
68db058fdf r17457: Add a test to do some operations on group mapping.
Volker
2007-10-10 11:38:35 -05:00
Günther Deschner
8c1198c159 r17454: Adding dfs_EnumEx for rpcclient (Samba4 IDL to follow).
Guenther
2007-10-10 11:38:35 -05:00
Günther Deschner
f9bef1f08f r17453: Fix msdfs RPC management (this broke with the autogenerated dfs rpcs).
* Remove "unknown" from dfs_Enum (samba4 dfs IDL updates to follow).

* When encountering an unsupported infolevel the rpc server must reply
with a dfs_info_0 structure and WERR_OK (observed from w2k3 when talking
to nt4).

Guenther
2007-10-10 11:38:34 -05:00
Volker Lendecke
e4b8c79a9d r17452: Some C++ warnings 2007-10-10 11:38:34 -05:00
Volker Lendecke
873a5a1211 r17451: Change pdb_getgrsid not to take a DOM_SID but a const DOM_SID * as an
argument.

Volker
2007-10-10 11:38:34 -05:00
Volker Lendecke
4f6605a488 r17446: Fix some C++ warnings and two memleaks found by Coverity, IDs 304 and 305.
Volker
2007-10-10 11:38:34 -05:00
Jeremy Allison
06aea05c52 r17439: Fix logic error in checking TALLOC return. Spotted by Volker.
Jeremy.
2007-10-10 11:38:33 -05:00
Jeremy Allison
85841a0198 r17431: Fix bug #4003, reported by dale-keyword-samba.c7b741@codefu.org.
NTcancel doesn't send a reply, so in this case the signing
sequence number is only incremented by 1, not 2.
Jeremy.
2007-10-10 11:38:33 -05:00
Volker Lendecke
6915adb978 r17425: Add the multi-key wrapper. If it's necessary to add general blobs as keys,
this can trivially be added later.

Volker
2007-10-10 11:38:33 -05:00
Simo Sorce
c065341d3f r17408: Let us use netgroups even without a NIS domain but just using files 2007-10-10 11:38:32 -05:00
Jeremy Allison
b5f0b1b644 r17407: Don't do strchr_m twice when once will do.
Jeremy.
2007-10-10 11:38:32 -05:00
Volker Lendecke
255475901c r17406: We need to do a translation of winbind separator -> '\\' in
lookup_name_smbconf, otherwise

force user = domain+administrator

can not work. Also attempt to fix the 'valid users = domain+group' bug at the
same time.

Volker
2007-10-10 11:38:32 -05:00
Volker Lendecke
250b9f3531 r17404: Is this XP (extreme programming)? :-)
With lp_workgroup we end up with remote names again...

Volker
2007-10-10 11:38:32 -05:00
Gerald Carter
63325b3687 r17403: add a helpful debug msg 2007-10-10 11:38:32 -05:00
Jeremy Allison
1e1fcb5eb2 r17402: Added lookup_name_smbconf() to be called when looking
up names from smb.conf. If the name is unqualified it
causes the lookup to be done in WORKGROUP\name, then
"Unix [users|groups]"\name rather than searching the
domain. Should fix the problems with "force user"
selecting a domain user by preference.
Jeremy.
2007-10-10 11:38:31 -05:00
Gerald Carter
92ccdec33f r17401: BUG 3855: remove bits of XML and SQL checks from aclocal.m4 2007-10-10 11:38:31 -05:00
Volker Lendecke
d12b08fc61 r17399: Some C++ warnings 2007-10-10 11:38:31 -05:00
Jeremy Allison
16ebccbc58 r17393: Remove Volker's ASSERT that num_groupsids > 0.
For guest connection they may well be zero.
This should fix up the buildfarm (fingers
crossed).
Jeremy.
2007-10-10 11:38:31 -05:00
Jeremy Allison
6d822b8567 r17392: Commit Volker's fix for the valid users problem.
Let's look at the build farm now... :-).
Jeremy.
2007-10-10 11:38:31 -05:00
Jeremy Allison
65003e1b25 r17391: Revert the second part of the valid users fix - the
netlogon code uses pdb_get_group_sid() which could
return a S-1-1-22 unix sid. Who knew.... :-(.
I'm going to test Volker's fix instead. Once
3.0.23b is out we *have* to rip out the pdb_set_group_sid()
code....
Jeremy.
2007-10-10 11:38:31 -05:00