sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-13 13:18:06 +03:00
Code
72,382 Commits 60 Branches 1,145 Tags 452 MiB
eb0e276f3a
Commit Graph

1829 Commits

Author SHA1 Message Date
Stefan Metzmacher
eb0e276f3a talloc/testsuite: avoid memory leak reported by valgrind 
metze

Signed-off-By: Andrew Tridgell <tridge@samba.org>

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Apr  8 10:15:41 CEST 2011 on sn-devel-104
 2011-04-08 10:15:40 +02:00
Stefan Metzmacher
f9fdef870e talloc/testsuite: test more talloc_pool related things 
metze

Signed-off-By: Andrew Tridgell <tridge@samba.org>
 2011-04-08 09:28:10 +02:00
Stefan Metzmacher
2146ffd764 talloc: include valgrind headers if available 
metze

Signed-off-By: Andrew Tridgell <tridge@samba.org>
 2011-04-08 09:28:10 +02:00
Stefan Metzmacher
73cc85ac90 talloc: add TC_INVALIDATE_POOL marco 
metze

Signed-off-By: Andrew Tridgell <tridge@samba.org>
 2011-04-08 09:28:10 +02:00
Stefan Metzmacher
9c9f208598 talloc: add TC_UNDEFINE_GROW_CHUNK() marco 
metze

Signed-off-By: Andrew Tridgell <tridge@samba.org>
 2011-04-08 09:28:10 +02:00
Stefan Metzmacher
6126c3506d talloc: add TC_INVALIDATE_SHRINK_CHUNK() marco 
This invalidates the unused bytes if we shrink memory.

metze

Signed-off-By: Andrew Tridgell <tridge@samba.org>
 2011-04-08 09:28:10 +02:00
Stefan Metzmacher
4895f55f06 talloc: add TC_INVALIDATE_FULL_CHUNK() macro 
This makes it easier to mark a talloc pointer as
invalid.

metze

Signed-off-By: Andrew Tridgell <tridge@samba.org>
 2011-04-08 09:28:10 +02:00
Stefan Metzmacher
efbb35824e talloc: use VALGRIND_MAKE_MEM_UNDEFINED() before memmove() 
metze

Signed-off-By: Andrew Tridgell <tridge@samba.org>
 2011-04-08 09:28:10 +02:00
Stefan Metzmacher
1e70439f77 talloc: optimize talloc_free() and talloc_realloc() for talloc pools 
metze

Signed-off-By: Andrew Tridgell <tridge@samba.org>
 2011-04-08 09:28:10 +02:00
Stefan Metzmacher
73330f8436 talloc: add TC_POOL_FIRST_CHUNK() macro 
metze

Signed-off-By: Andrew Tridgell <tridge@samba.org>
 2011-04-08 09:28:10 +02:00
Stefan Metzmacher
13fab67995 talloc: add TC_POOL_SPACE_LEFT() macro 
metze

Signed-off-By: Andrew Tridgell <tridge@samba.org>
 2011-04-08 09:28:10 +02:00
Stefan Metzmacher
4084cb723c talloc: add TC_ALIGN16() macro 
metze

Signed-off-By: Andrew Tridgell <tridge@samba.org>
 2011-04-08 09:28:10 +02:00
Stefan Metzmacher
d39940113a talloc: use TC_HDR_SIZE instead of sizeof(struct talloc_chunk) 
As this includes the padding to 16 bytes.

metze

Signed-off-By: Andrew Tridgell <tridge@samba.org>
 2011-04-08 09:28:09 +02:00
Andrew Tridgell
49ab2df28a lib/crypto: rename the SHA256_ functions to samba_SHA256_ 
this prevents a symbol duplication with the openssl library, which may
be linked in via a secondary library dependency

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2011-04-06 08:12:19 +02:00
Andrew Tridgell
a8da13cd5c lib: make asn1_util a private library 
this prevents symbol duplication of the asn1 symbols in the service
and ntvfs subsystems

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2011-04-06 08:12:19 +02:00
Andrew Tridgell
15576da63a lib: moved data_blob.c into samba-util-common 
this avoids a duplication of the data_blob symbols some binaries
(eg. smbtorture)

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2011-04-06 08:12:19 +02:00
Matthias Dieter Wallnöfer
513574afd7 talloc - some documentation changes 
- Fix some typos
- Document better the differences in the behaviour between talloc 1.X and 2.X.
  Previously this seemed a bit spongy to me.

Reviewed-by: Jelmer + Tridge

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Mon Apr  4 11:05:42 CEST 2011 on sn-devel-104
 2011-04-04 11:05:42 +02:00
Andrew Tridgell
4a98d6ce96 debug: default debug to stderr 
if setup_logging() hasn't been called then default to sending debug to
stderr

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2011-04-04 10:30:29 +10:00
Volker Lendecke
644222a1e3 debug: Restore the s3-style check in check_log_size() 
This has caused me considerable grief.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Mar 31 19:42:38 CEST 2011 on sn-devel-104
 2011-03-31 19:42:38 +02:00
Andrew Bartlett
620921b36b lib/util/charset Add tests for strcasecmp_m(), talloc_strupper() et al 
This adds tests for:
 strncasecmp_m
 strcasecmp_m
 strupper_talloc_n
 strlower_talloc
 strhaslower
 strhasupper

The tests can certainly be improved with pre-calculated upper and
lower case text, but this at least puts them though their paces.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Mar 31 14:24:22 CEST 2011 on sn-devel-104
 2011-03-31 14:24:22 +02:00
Volker Lendecke
466da70d77 charconv: Use talloc_tos() in the S3 build 
In S3 we put a talloc_pool on top of the stack so that an allocation from
talloc_tos() normally is just a pointer increment.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Mar 31 09:14:01 CEST 2011 on sn-devel-104
 2011-03-31 09:14:01 +02:00
Jeremy Allison
7cd5a79cd4 Arg. I hate the "if (xxx) return foo" all on one line style of code. 
Fix the talloc leaks I introduced by not spotting these returns.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Mar 31 05:19:34 CEST 2011 on sn-devel-104
 2011-03-31 05:19:33 +02:00
Jeremy Allison
21193c8eeb Don't burn 2k of stack on every iconv, use the heap when it's a slow call. 
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Mar 31 04:09:09 CEST 2011 on sn-devel-104
 2011-03-31 04:09:09 +02:00
Andrew Bartlett
b3ffcf888c lib/util/charset smb_panic() on incorrect use of strlen_m_ext 
This may save a developer some time in the future.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Mar 31 02:40:31 CEST 2011 on sn-devel-104
 2011-03-31 02:40:31 +02:00
Andrew Bartlett
7fe9bb8c84 lib/util/charset Add tests for strlen_m_ext() and convert_string_talloc() 
This convers a few more cases for convert_string_talloc() and
introduces tests for strlen_m_ext() across complex multibyte strings.

Andrew Bartlett
 2011-03-31 10:53:24 +11:00
Andrew Bartlett
d4f3a380e4 lib/util/charset Add wrapper to allow testing of strlen_m_ext() 
This allows test routines to force in particular character sets, and
not rely on the smb.conf.

Andrew Bartlett
 2011-03-31 10:53:24 +11:00
Andrew Bartlett
46db53b159 lib/util/charset correct calculation of UTF8 character sizes 
Characters between 0x800 0x0FFFF are 3 bytes long.

Andrew Bartlett
 2011-03-31 10:52:42 +11:00
Jeremy Allison
c109a70531 Fix convert_string() to take a *converted_size arg. and return a bool. 
Makes these interfaces much harder to misuse and easier to ensure error
checking.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Mar 30 23:59:37 CEST 2011 on sn-devel-104
 2011-03-30 23:59:37 +02:00
Andrew Bartlett
43e364e61b lib/util/charset Add tests for convert_string_talloc_handle() 
Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Mar 30 13:02:47 CEST 2011 on sn-devel-104
 2011-03-30 13:02:47 +02:00
Andrew Bartlett
a64958a880 lib/util Move base64 functions into lib/util/base64.c 
Andrew Bartlett
 2011-03-30 12:17:05 +02:00
Andrew Bartlett
c395209791 lib/util/charset Remove pointless static bool initialised 2011-03-30 12:17:05 +02:00
Volker Lendecke
0080f944b4 tdb: Fix Coverity ID 2238: SECURE_CODING 2011-03-30 09:58:32 +02:00
Matthias Dieter Wallnöfer
6723e90d52 talloc - improve doxygen comment of "talloc_move" 
Express better that this should be a pointer of a pointer.

Reviewed-by: Tridge
 2011-03-30 08:45:58 +02:00
Günther Deschner
b2af281e50 s3-messages: only include messages.h where needed. 
Guenther
 2011-03-30 01:13:09 +02:00
Günther Deschner
96487959e9 lib/util/util_pw: share more code between lib/util/util_pw.c and source3/lib/username.c 
Guenther
 2011-03-30 01:13:06 +02:00
Günther Deschner
64421129b6 lib/util/util_pw: share sys_get{pw,gr} group of calls. 
Guenther
 2011-03-30 01:13:06 +02:00
Günther Deschner
f4868ab646 lib/util/util_pw: temporary rename of getpwnam_alloc and getpwuid_alloc. 
Guenther
 2011-03-30 01:13:06 +02:00
Andrew Tridgell
af31bf6bf5 debug: ignore debug_set_logfile() with a blank string 
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue Mar 29 07:03:58 CEST 2011 on sn-devel-104
 2011-03-29 07:03:58 +02:00
Andrew Tridgell
8d2d0ef0eb lib: removed a spurios declaration of 'logfile' 
we don't have a global logfile variable any more

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2011-03-29 06:17:03 +02:00
Volker Lendecke
25397de589 tdb: Fix Coverity ID 2192: NO_EFFECT 
(ret < 0) can never be true
 2011-03-27 22:22:12 +02:00
Volker Lendecke
a431394ce3 s3: Fix Coverity ID 958: BAD_SIZEOF 
This is supposed to wipe out the md5 context, not only the first bytes of it.

Others, please check!
 2011-03-27 22:22:10 +02:00
Andrew Tridgell
f0922147fe charcnv: ensure convert_string_error doesn't conflict with s3 function 
use _handle for handle based functions

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Fri Mar 25 05:22:24 CET 2011 on sn-devel-104
 2011-03-25 05:22:24 +01:00
Andrew Bartlett
b5616adc8a lib/util/charset rename iconv_convenience to iconv_handle 
This better reflects what this structure is

Andrew Bartlett
 2011-03-25 04:37:06 +01:00
Andrew Tridgell
2643a7ba6b charcnv: added convert_string_error() 
this will allow us to remove conv_silent

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2011-03-25 04:37:06 +01:00
Andrew Tridgell
aaae4123b9 unistr: moved some UCS2 macros into util_unistr 
we need to move towards eliminating smb_ucs2_t. This moves a couple of
the related macros into the only file they are used in

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2011-03-25 04:37:06 +01:00
Andrew Tridgell
5a20325c86 libcli: created smb_constants.h 
this starts the (long!) process of moving some of the SMB constants
into common files. This just moves the FLAGS2_ defines, which are
needed for common string routines (for FLAGS2_UNICODE_STRINGS)
 2011-03-25 04:37:06 +01:00
Andrew Tridgell
bfce962c8f tdb: rename convert_string() to tdb_convert_string() 
this prevents a conflict with the convert_string() in samba
 2011-03-25 04:37:06 +01:00
Andrew Tridgell
980064b76d lib: remove unused pieces of string_wrappers.h 2011-03-25 04:37:06 +01:00
Andrew Tridgell
8cd4a38d72 lib: move the string wrappers from source3/include to common lib/util 
this will allow the common charcnv library to use the string wrappers

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2011-03-25 04:37:06 +01:00
Andrew Tridgell
15e84a9a09 charcnv: removed the allow_badcharcnv and allow_bad_conv options to convert_string*() 
we shouldn't accept bad multi-byte strings, it just hides problems

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Mar 24 01:47:26 CET 2011 on sn-devel-104
 2011-03-24 01:47:26 +01:00