1
0
mirror of https://github.com/samba-team/samba.git synced 2025-12-18 08:23:51 +03:00
Commit Graph

16 Commits

Author SHA1 Message Date
Andrew Tridgell
e3d00fa47d reverted this patch till I sort out the craziness with UNIHDR -
Andrew Tridgell
b9eff31b14 This removes the 3rd argument from init_unistr2(). There were 240
calls to init_unistr2() in the code and every one of them got the 3rd
argument incorrect, so I thought it best just to remove the argument.

The incorrect usage was caused by callers using strlen() to determine
the length of the string. The 3rd argument to init_unistr2() was
supposed to be the character length, not the byte length of the
string, so for non-english this could come out wrong.

I also removed the bogus 'always allocate at least 256 bytes'
hack. There may be some code that relies on this, but if there is then
the code is broken and needs fixing.
-
Tim Potter
69bb58b92e Pass level keyword down to cli_spoolss_getform() -
Tim Potter
45562b8603 Fixed dodgy arguments to PyArg_ParseTupleAndKeywords() -
Tim Potter
c9c2aac903 addform(), setform():
- call get_level_value() utility function
  - removed unused keyword args
  - clean up handling of name arg to cli call

deleteform():

  - removed unused keyword args
-
Tim Potter
2f86f01b88 Return enumerated forms as a hash of hashes instead of a list of hashes. -
Tim Potter
d35cad359d More cleanups.
- removed dodgy fprintf() error handling

 - return an error string from open_pipe_creds() so the appropriate
   exception can be raised by the caller

 - reformatting
-
Tim Potter
986d868837 Renamed functions that are methods of a printer handle object from
spoolss_* to spoolss_hnd_* to make things a bit clearer.
-
Tim Potter
5071fd8fe0 Removed unused arg to deleteform. -
Tim Potter
ecba275cf7 Fixed setform and addform functions. -
Tim Potter
ed0a6480f7 Converted drivers, forms and ports functions to use new conversion routines
and exception throwing.
-
Tim Potter
1e48f872a4 Aborted experiment to avoid namespace pollution and prototype hell and
moved to 'make proto' based solution.
-
Tim Potter
992cbfe98b Converted to #include *.c format. -
Tim Potter
2c935bc1ea #include "py_conv.h" -
Tim Potter
7c4bcc48aa Moved form related functions as methods in the policy handle object. -
Tim Potter
d35770d06f Initial version. -