1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
Commit Graph

45 Commits

Author SHA1 Message Date
Matthew DeVore
c2ac923c6a s3: safe_string: do not include string_wrappers.h
Rather than have safe_string.h #include string_wrappers.h, make users of
string_wrappers.h include it explicitly.

includes.h now no longer includes string_wrappers.h transitively. Still
allow includes.h to #include safe_string.h for now so that as many
modules as possible get the safety checks in it.

Signed-off-by: Matthew DeVore <matvore@google.com>
Reviewed-by: David Mulder <dmulder@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2020-08-28 00:56:34 +00:00
Ralph Boehme
9471508391 s3: remove now unneeded call to cmdline_messaging_context()
This was only needed as dbwrap_open() had a bug where it asked for the ctdb
connection before initializing messaging. The previous commit fixed that so we
can now safely remove the calls to cmdline_messaging_context() from all tools
that don't use messaging.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13925

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Oct 24 09:33:47 UTC 2019 on sn-devel-184
2019-10-24 09:33:47 +00:00
Christof Schmitt
095123df94 s3:eventlogadm: Use cmdline_messaging_context
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
2018-09-07 17:26:16 +02:00
Richard Sharpe
57941aa044 s3: utils: Convert all uses of uint32/16/8 to _t.
Signed-off-by: Richard Sharpe <rsharpe@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu May  7 04:53:39 CEST 2015 on sn-devel-104
2015-05-07 04:53:39 +02:00
Volker Lendecke
c51300ad89 lib: load_case_tables() -> smb_init_locale()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2015-03-24 00:00:20 +01:00
Volker Lendecke
4e05717559 s3: Fix Coverity ID 242754 Dereference null return value 2012-05-10 09:11:57 +02:00
Gregor Beck
4eb4f75371 s3:eventlogadm make a transaction for addsource
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25 14:23:03 +02:00
Gregor Beck
c6224e46aa s3:eventlogadm reimplement addsource using reg_api
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25 14:22:17 +02:00
Michael Adam
7557ba1eb2 s3:eventlogadm: use lp_load_global() 2011-07-28 11:17:36 +02:00
Andrew Bartlett
3d15137653 s3-talloc Change TALLOC_ARRAY() to talloc_array()
Using the standard macro makes it easier to move code into common, as
TALLOC_ARRAY isn't standard talloc.
2011-06-09 12:40:08 +02:00
Günther Deschner
4ac4ad2108 s3-utils: fix another -Wunused-but-set-variable build warning.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue May 31 05:18:42 CEST 2011 on sn-devel-104
2011-05-31 05:18:42 +02:00
Andrew Bartlett
c615ebed6e s3-lib Replace StrCaseCmp() with strcasecmp_m()
strcasecmp_m() never needs to call to talloc, and via next_codepoint()
still has an ASCII fast-path bypassing iconv() calls.

Andrew Bartlett
2011-05-18 16:12:08 +02:00
Jeremy Allison
7d6ebe0de7 More const fixes. Remove CONST_DISCARD. 2011-05-06 01:44:07 +02:00
Günther Deschner
0a250f4946 registry: create and use shared libcli/registry/util_reg.h header.
Guenther
2011-03-30 01:13:07 +02:00
Andreas Schneider
34e8a50e5a s3-util: Moved eventlog_add_source to admin util.
This function is only used in the admin util.

Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:32:00 +01:00
Michael Adam
847a19df94 s3:registry: extract reg_eventlog prototypes to header of their own
and use them only where needed.
2010-05-25 10:35:26 +02:00
Michael Adam
d335f292ce s3:registry: extract the reg_backend_db prototypes into their own header.
And use them only where needed.
2010-05-25 10:35:25 +02:00
Günther Deschner
fe31b67d5e s3-registry: only include registry headers when really needed.
Guenther
2010-05-18 01:15:38 +02:00
Günther Deschner
d2d7174394 s3-eventlog: move all eventlog headers to lib/eventlog and only include where required.
Guenther
2010-05-06 13:41:51 +02:00
Holger Hetterich
6ec6fa0ac4 s3: eventlogadm.c: add -s option to use alternative config file.
Update the manpage accordingly.
2010-02-15 08:31:44 +01:00
Volker Lendecke
6aef5e591f Fix bug 6546: Avoid accessing buf[-1] if NUL byte comes from fgets 2009-11-30 21:48:59 +01:00
Günther Deschner
537ac20a92 s3-eventlogadm: Fix Coverity #938: UNINIT.
Guenther
2009-09-16 10:29:43 +02:00
Günther Deschner
de7f0a70c8 s3-eventlogadm: use struct eventlog_Record_tdb for storing entries in tdbs.
Guenther
2009-02-04 17:47:07 +01:00
Günther Deschner
c53e3bfa7d s3-eventlogadm: add command to dump stored tdb entries.
Guenther
2009-02-03 16:06:57 +01:00
Günther Deschner
b94946697d s3-eventlog: pass down talloc context to parse_logentry().
Guenther
2009-02-03 15:45:09 +01:00
Günther Deschner
8fb6b18bac s3-eventlog: allow to open eventlog tdbs readonly.
Guenther
2009-02-03 15:44:06 +01:00
Jeremy Allison
07e0094365 Fix all warnings in source3 with gcc4.3.
Jeremy.
2008-12-31 18:06:57 -08:00
Günther Deschner
1c7e4e8a2a Fix the build of eventlogadm.
Guenther
(This used to be commit 57a5628abf)
2008-04-13 18:28:24 +02:00
Jeremy Allison
7faee02d0d Remove the char[1024] strings from dynconfig. Replace
them with malloc'ing accessor functions. Should save a
lot of static space :-).
Jeremy.
(This used to be commit 52dc5eaef2)
2007-12-10 11:30:37 -08:00
Jeremy Allison
de7fd585b1 The usual !pstring...
Jeremy.
(This used to be commit b676262a78)
2007-12-04 16:56:18 -08:00
Volker Lendecke
450ca80b57 add talloc_stackframe() to eventlogadm
Thanks to Günther Kukkukk for noticing
(This used to be commit 9751cc222c)
2007-11-23 14:39:21 +01:00
Jeremy Allison
30191d1a57 RIP BOOL. Convert BOOL -> bool. I found a few interesting
bugs in various places whilst doing this (places that assumed
BOOL == int). I also need to fix the Samba4 pidl generation
(next checkin).
Jeremy.
(This used to be commit f35a266b3c)
2007-10-18 17:40:25 -07:00
Andrew Tridgell
153cfb9c83 r23801: The FSF has moved around a lot. This fixes their Mass Ave address.
(This used to be commit 87c91e4362)
2007-10-10 12:28:27 -05:00
Jeremy Allison
d824b98f80 r23779: Change from v2 or later to v3 or later.
Jeremy.
(This used to be commit 407e6e695b)
2007-10-10 12:28:20 -05:00
Herb Lewis
55ed1d5945 r20261: merge 20260 from samba_3_0_24
clean up a bunch of no previous prototype warnings
(This used to be commit c60687db11)
2007-10-10 12:16:37 -05:00
Jeremy Allison
c7d2deb151 r16656: Fix #3894 and #3895 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit ddf35ad692)
2007-10-10 11:19:06 -05:00
Jeremy Allison
b2ddb4626c r16640: Fix bug #3886 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 76cc25a37e)
2007-10-10 11:19:05 -05:00
Derrell Lipman
9c15bd311d r13212: r12414@cabra: derrell | 2006-01-28 17:52:17 -0500
lp_load() could not be called multiple times to modify parameter settings based
 on reading from multiple configuration settings.  Each time, it initialized all
 of the settings back to their defaults before reading the specified
 configuration file.

 This patch adds a parameter to lp_load() specifying whether the settings should
 be initialized.  It does, however, still force the settings to be initialized
 the first time, even if the request was to not initialize them.  (Not doing so
 could wreak havoc due to uninitialized values.)
(This used to be commit f2a24de769)
2007-10-10 11:06:18 -05:00
Jeremy Allison
c8f28c92a7 r12555: Fix more load_case_table swegfaults. Arggg.
What I'd give for a global constructor...
Jeremy.
(This used to be commit c970d7d0a5)
2007-10-10 11:05:59 -05:00
Gerald Carter
6f91e3a862 r12262: * patch from Brian Moran to fix segv in eventlogadm when not eventlogs
are listed in smb.conf
* initialize the local group description in set_alias_info()
(This used to be commit 58f8b42069)
2007-10-10 11:05:51 -05:00
Gerald Carter
7c5d5ddb6d r11763: fix more build breakage
(This used to be commit 5ab76ec8f8)
2007-10-10 11:05:26 -05:00
Gerald Carter
f1195329a7 r11227: patch from brian moran to fix typo in eventlog message file registry value name
(This used to be commit 34c3fd77b3)
2007-10-10 11:05:06 -05:00
Gerald Carter
afca439d19 r11136: patches from Brian Moran for eventlogadm utility
(This used to be commit 47b626a8f7)
2007-10-10 11:05:02 -05:00
Gerald Carter
c246649e3d r11123: * patches from Brian Moran for creating new eventlog
source keys
* my patches to get registry utility functions linking
  with eventlogadm tool
(This used to be commit 24e7663086)
2007-10-10 11:05:00 -05:00
Gerald Carter
5292f1c2f3 r11065: rename wr_eventlog to eventlogadm
(This used to be commit 9a63b52efa)
2007-10-10 11:04:59 -05:00