Andrew Tridgell
a106fefcfb
librpc: fixed the GUID_compare() function
...
When comparing two unsigned values you can't just subtract
them.
Imagine you are comparing: "uint32_t u1" and "uint32_t u2". If you use
"u1 - u2" and u2 is zero, then the signed integer result will depend
on the top bit of u1.
This error occurs in a few places in Samba. For DRS replication it
resulted in corrupt uptodateness vectors.
2009-12-21 23:41:07 +11:00
Günther Deschner
be95cb6f83
spoolss: more mork on SetPrinterInfo() levels.
...
Guenther
2009-12-17 10:43:31 +01:00
Günther Deschner
64e588f868
spoolss: add spoolss_DriverInfo7.
...
Guenther
2009-12-16 16:09:41 +01:00
Volker Lendecke
0d10efe1fd
s3: Allow up to 20480 entries in LookupSids, as mandated by the official IDL
...
Seen in the wild by putting >1000 users into BUILTIN\Users
2009-12-14 17:00:12 +01:00
Brian Lu
a3b7e84a65
librpc/ndr: avoid comparison_fn_t to fix the openchange build on solaris
...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2009-12-14 11:08:45 +01:00
Matthieu Patou
8f8613dcef
idl: introduce new file: dfsblobs.idl
...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2009-12-14 10:58:32 +01:00
Stefan Metzmacher
05effef1aa
librpc/ndr: add missing prototypes for relative_short functions
...
metze
2009-12-14 10:58:31 +01:00
Günther Deschner
e316624ddb
spoolss: fix spoolss_PrinterData size calculation.
...
Currently we were crashing in EnumPrinterDataEx when an e.g. an empty (NULL)
string for a separator file was returned.
Guenther
2009-12-14 10:39:34 +01:00
Günther Deschner
5ae61cfbc2
spoolss: trivial fix for spoolss_FormInfo2 IDL.
...
Guenther
2009-12-14 10:38:53 +01:00
Matthieu Patou
f0054da041
librpc/ndr: add support for relative_short pointers
...
relative_short is like relative but instead of having the offset coded on 4 bytes
it's coded on 2 bytes. Such things happen in GET_DFS_REFERAL messages.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2009-12-12 10:21:22 +01:00
Günther Deschner
835e7d6c98
spoolss: remove unused spoolss_StringArray2.
...
Guenther
2009-12-10 17:48:50 +01:00
Günther Deschner
fa413d167b
s3: re-run make samba3-idl.
...
Guenther
2009-12-10 17:48:49 +01:00
Günther Deschner
0ecb7f6ab2
spoolss: use spoolss_KeyNames in spoolss_EnumPrinterKey.
...
Guenther
2009-12-10 17:48:49 +01:00
Günther Deschner
cf2561473f
spoolss: add spoolss_KeyNames union.
...
Guenther
2009-12-10 17:48:49 +01:00
Andrew Tridgell
3ce800dcbe
libndr: added a GUID_to_ndr_blob() helper function
...
This can be used in many places that deal with GUIDs
2009-12-10 17:51:28 +11:00
Andrew Tridgell
effff54426
librpc: split out a separate GUID_from_ndr_blob() function
...
This will simplify many of the places that deal with NDR formatted
GUIDs
2009-12-10 17:51:26 +11:00
Günther Deschner
fb3b0987f7
spoolss: add more spoolss architectures to IDL.
...
Guenther
2009-12-08 16:20:51 +01:00
Günther Deschner
1b6c444557
spoolss: fix spoolss_DriverInfo8 IDL.
...
found by RPC-SPOOLSS torture teset.
Guenther
2009-12-08 11:51:16 +01:00
Günther Deschner
08823166a1
spoolss: rework spoolss_GetPrinterDataEx and spoolss_SetPrinterDataEx.
...
Guenther
2009-12-07 14:42:12 +01:00
Günther Deschner
f32ccc321a
spoolss: hand-marshall the spoolss_StringArray2 struct for spoolss_EnumPrinterKey.
...
This call is just driving me nuts :-)
Guenther
2009-12-03 01:04:02 +01:00
Günther Deschner
5f60855ba2
samba-spoolss: use spoolss_StringArray2 in spoolss_EnumPrinterKey.
...
This should finally resolve the endian issues we were seeing on sparc and is
much cleaner for spoolss clients and servers.
Guenther
2009-12-02 14:56:17 +01:00
Günther Deschner
292af4fc04
spoolss: add spoolss_StringArray2.
...
The difference to spoolss_StringArray is that in spoolss_StringArray2 the string
array is put into a subcontext of _ndr_size.
Guenther
2009-12-02 14:37:02 +01:00
Günther Deschner
91bb065977
s3-spoolss: move MAXDEVICENAME to spoolss idl.
...
Guenther
2009-12-02 14:36:36 +01:00
Günther Deschner
b852a3494a
drsuapi: fix build warning of NDR size calculation of drsuapi_DsReplicaObjectIdentifier3Binary.
...
The generated size actually does not include the size of the binary itself.
Guenther
2009-12-01 00:36:50 +01:00
Matthias Dieter Wallnöfer
2e7ccdcb66
security.idl - Add some more wellknown SIDs/RIDs
2009-11-27 22:36:59 +01:00
Günther Deschner
23d77be6cb
misc: mark winreg_Data little-endian except for a REG_DWORD_BIG_ENDIAN.
...
Guenther
2009-11-27 16:16:00 +01:00
Günther Deschner
79f82998b1
pidl: fix handling of output arguments in s3 client stubs.
...
a20e095 used (uint8_t) instead of (uint8_t *).
Guenther
2009-11-27 16:15:33 +01:00
Stefan Metzmacher
49553d066b
librpc: rerun "make idl"
...
metze
2009-11-26 11:47:42 +01:00
Günther Deschner
800d6b7820
s3-spoolss: move more defines out of nt_printing.h to spoolss.idl where they belong.
...
Guenther
2009-11-23 12:20:24 +01:00
Günther Deschner
366946f29b
spoolss: fix spoolss_EnumPrinterKey IDL.
...
Guenther
2009-11-23 11:44:43 +01:00
Stefan Metzmacher
ae4795de69
librpc: rerun "make idl"
...
metze
2009-11-20 13:48:37 +01:00
Stefan Metzmacher
4b6c03a108
librpc/ndr: remember the highest offset we parsed with relative pointer buffers
...
ndr_*_pull_blob_all() will now work if relative pointers are used.
metze
2009-11-20 13:48:35 +01:00
Nadezhda Ivanova
a97460d657
Fixed incorrect SID for RAS Servers.
2009-11-17 17:10:23 +02:00
Stefan Metzmacher
2fb6acd2d7
librpc: rerun "make idl"
...
metze
2009-11-17 09:00:49 +01:00
Stefan Metzmacher
66198b085a
netlogon.idl: fix ndr_pull_netr_DatabaseRedo()
...
We can't use subcontext_size() here, as
change_log_entry_size is encoded after the subcontext.
metze
2009-11-17 09:00:48 +01:00
Andrew Bartlett
fd5174e88c
lib/util Split data_blob_hex_string() into upper and lower
...
Rather than have a repeat of the bugs we found at the plugfest where
hexidecimal strings must be in upper or lower case in particular
places, ensure that each caller chooses which case they want.
This reverts most of the callers back to upper case, as things were
before tridge's patch. The critical call in the extended DN code is
of course handled in lower case.
Andrew Bartlett
2009-11-12 16:34:01 +11:00
Volker Lendecke
e181b88978
Revert "s3: Do not reference ndr_table_<pipe> in the cli_ routines directly"
...
This reverts commit daa964013bc5d036f4da571ce22c0052ef40943a.
2009-11-08 19:43:47 +01:00
Volker Lendecke
47455b4d1a
Revert "s3: Do not reference the ndr_tables in the server calls directly"
...
This reverts commit 98fb71782e05ae72cd6abeb38b6e0b96a50c1761.
2009-11-08 19:43:46 +01:00
Volker Lendecke
82c35e460e
Revert "s3: Do not reference ndr_table when calling rpc_srv_register"
...
This reverts commit 494b2aff8826947e3bd556aecb175746163da485.
2009-11-08 19:43:46 +01:00
Volker Lendecke
494b2aff88
s3: Do not reference ndr_table when calling rpc_srv_register
2009-11-08 13:12:15 +01:00
Volker Lendecke
98fb71782e
s3: Do not reference the ndr_tables in the server calls directly
...
This involves storing the interface table in the pipes_struct
2009-11-08 13:12:14 +01:00
Volker Lendecke
daa964013b
s3: Do not reference ndr_table_<pipe> in the cli_ routines directly
2009-11-08 13:12:13 +01:00
Volker Lendecke
5cdee7ae05
s3: Do the printing for DEBUGLEVEL>=10 centrally
...
12 insertions(+), 10651 deletions(-)
I think that says it all :-)
2009-11-07 11:07:37 +01:00
Günther Deschner
8be9ec604e
security: re-run make samba3-idl after IDL change.
...
Guenther
2009-11-03 23:47:57 +01:00
Nadezhda Ivanova
8324dbcb11
Removed the default DACL from token, as we will not be using it.
2009-11-03 10:45:01 +02:00
Volker Lendecke
dd0e16b1d5
uuid.c: Remove some dead code
2009-11-01 23:50:04 +01:00
Stefan (metze) Metzmacher
25f96a4058
Add in Metze's new code to ndr encode the user.DOSATTRIB
...
blobs. Next I'll change the create timestamp and dos attribute
code to use this.
2009-10-28 15:42:47 -07:00
Günther Deschner
1f9d06a1b0
lsa: add LSA_TRUSTED_DOMAIN access masks.
...
Guenther
2009-10-28 12:37:38 +01:00
Günther Deschner
80d8b2e180
lsa: add LSA_SECRET access masks.
...
Guenther
2009-10-28 12:37:21 +01:00
Andrew Tridgell
3f5d535972
idl-drsblobs: mark some more reserved values as value(0)
...
This prevents valgrind errors when we store these blobs in a database
2009-10-22 12:47:53 +11:00