1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-14 19:24:43 +03:00

5710 Commits

Author SHA1 Message Date
Jeremy Allison
96ff4b8ee2 Ensure we always have a valid pointer on unmarshalling an SD with zero
ace entries.
Jeremy.
(This used to be commit 274c0f5028d41175222dfaaf446e3ed8f5687a5f)
2001-06-26 06:31:55 +00:00
Tim Potter
0c563186fb Put an 0x in front of a hex number.
(This used to be commit a48d480ce986ff1c00f2c17f30f23723ce0bb044)
2001-06-26 06:26:05 +00:00
Tim Potter
742609a21d Fixed bug introduced by changeover of security descriptor code from
malloc() to talloc().  Previously, creating an ACL containing zero ACEs
would return a non-NULL pointer to zero bytes of memory.  The talloc() code
would return a NULL pointer making the ACL a NULL ACL instead of an empty
one.  The difference is a NULL ACL allows all access and an empty ACL
denies all access.

We solve this by calling talloc(ctx, sizeof(SEC_ACE) * num_aces + 1).
Heh.
(This used to be commit 89eaaafe7d266788609fab6951fd912c441b3a26)
2001-06-26 06:11:40 +00:00
Jeremy Allison
629a59fe85 Always use DOMAIN\user first that this is the more specific case.
Jeremy.
(This used to be commit 52143c08536a5f5d888b78b4769c06f7a0a2992b)
2001-06-26 06:06:42 +00:00
Andrew Tridgell
f73122e79d fixed build
don't rush commits :)
(This used to be commit 442bf5cc9e6de7888f9a8cc06050f73ef880c4d9)
2001-06-26 05:38:24 +00:00
Andrew Tridgell
8a0480b137 fall back to "unsigned" for uint32 on systems that don't have one
(This used to be commit 4d0c3167099f461b46fafaa3a35b14babbadcb93)
2001-06-26 05:21:49 +00:00
Andrew Bartlett
90498a10c7 Remove warning about trapdoor systems for non-root mode.
Andrew Bartlett
(This used to be commit b33000cdc0cafd4888c3f07c56050626743abd14)
2001-06-26 03:45:45 +00:00
Jeremy Allison
9f447adbec Ensure numeric group or user names don't get misinterpreted.
Jeremy.
(This used to be commit e88da9dcc79801028127bcbe328af001b58e653a)
2001-06-25 21:29:33 +00:00
Jeremy Allison
b0be9cd768 Added Andrew's pam password change stuff. Needs some testing but looks good !
Jeremy.
(This used to be commit e94957d548745649ce04423dc6f16bbe3dd4f869)
2001-06-25 20:44:04 +00:00
Jeremy Allison
31ab8ae3ff Fixed stupid typo that would stop trusted domains working.
Jeremy.
(This used to be commit fa721b4adfbcac4827251b02f6af7f0b5211c104)
2001-06-25 19:08:30 +00:00
Tim Potter
6e0605c3ab Cosmetic fixups found while playing with the server manager. Added support
for NET_SRV_SET_INFO rpc call which is made when double-clicking on a
computer in the server manager and changing the description.  We always
return NT_STATUS_NOPROBLEMO as NT doesn't seem to decode any error messages
passed back.

Maybe the changed comment string could be stored in a tdb and regurgitated
instead of the "server string" smb.conf parameter?
(This used to be commit d936ffedd90fe442f990c9ac2e172877f28d7230)
2001-06-25 06:13:27 +00:00
Andrew Tridgell
dae746c639 got rid of the date headers off all text docs
(This used to be commit 9d02041f0095d77753bd96bf070459547ec1339d)
2001-06-25 03:36:09 +00:00
Andrew Tridgell
b95a294a08 fixed usage of socklen_t and also tidied up SIG_ATOMIC_T, using a typedef instead of a define
(This used to be commit e2ecff419fdc0a0dc7551b33b377dc11061ef2a3)
2001-06-25 02:53:13 +00:00
Andrew Tridgell
413ad23faf make sure we have BOOL in autoconf usage of util_sec.c
(This used to be commit 72f63f5144ececdef31c659ab645eb71a88943b5)
2001-06-25 01:20:47 +00:00
Andrew Tridgell
53ca6d33ce added a -L option to smbpasswd to force it to run locally so we can test smbpasswd as non-root
(This used to be commit ab635202655712a05b812ff40550d00d00552853)
2001-06-25 01:15:17 +00:00
Andrew Tridgell
8b79a473fa - make the regresison test mode code build in by default. This should
allow us to have test targets without special configure options
- fixed make proto so that it actually does something
(This used to be commit 55109a752578e9389d853cb27ec17c2114ecff77)
2001-06-25 00:46:34 +00:00
Simo Sorce
cc6bf9a06f fixed error
using wrong pointer to test and free s/str/s/
(This used to be commit 7e5a9860fad92fee79bcc20f2ea2a3728080dba2)
2001-06-24 01:41:38 +00:00
Jeremy Allison
08bda36755 Log debug before and after netbios names copied so we know if they've been
changed.
Jeremy.
(This used to be commit f8c121c69c9561f011a0e08a9d0beaf1cefd1667)
2001-06-23 20:01:23 +00:00
Simo Sorce
2b8e2f16c3 uhm some pointer went wrong
(This used to be commit d0acacfc9df86abab24420f1807b4d5253e8c285)
2001-06-23 15:27:04 +00:00
Simo Sorce
5be670074e handle P_LIST parameters
(This used to be commit 26ab608c91c7357df3a79bc34111194f115de005)
2001-06-23 15:01:34 +00:00
Simo Sorce
6ad1fcc279 fix compiler warnings
(This used to be commit 1959864490e79756257ba10431b188de78b8c8a7)
2001-06-23 14:58:38 +00:00
Simo Sorce
d56e091694 fix compiler warnings
(This used to be commit 7420e2f7898f1d141ba2af3eda07a67862fee842)
2001-06-23 14:13:32 +00:00
Jeremy Allison
37eb0d6c74 Added other_safe_chars to alpha_strcpy(). Needs testing but is a better
fix for the problem.
Jeremy.
(This used to be commit e059fffd03a1382fb2b7059b6de369d9fc765a17)
2001-06-23 07:22:16 +00:00
Jeremy Allison
7133aed083 Better fix for client name vulnarability.
Jeremy.
(This used to be commit 17c3faa367328d186d10f59f08549de0c608b16a)
2001-06-23 00:22:14 +00:00
Jeremy Allison
fe136fe623 Fix for multibyte default service parameter from TAKAHASHI Motonobu, Samba Users Group Japan
Jeremy
(This used to be commit a2da1f91c1b08414592d5f014c8539575d0e9637)
2001-06-22 22:05:47 +00:00
Jeremy Allison
5ba566efb7 Fixed logic bug in timeout processing spotted by Ying Chen <ying@almaden.ibm.com>.
Jeremy.
(This used to be commit 08c168242364bf4d415f49d134e507a7e234611b)
2001-06-22 20:56:52 +00:00
Jeremy Allison
17d5d660b5 Fix for race condition found by Herb where we can end up with a NULL dbf.
Jeremy.
(This used to be commit 5cbb2106735ad0533198a83d62541cabd7beed20)
2001-06-22 19:46:38 +00:00
Jeremy Allison
b08ee8995d Fix from "Jim McDonough" <jmcd@us.ibm.com>" - when we use open_file_shared(),
we need to close with close_file().
Jeremy.
(This used to be commit 5b2ffd160f3b4b9607bb6fd6db1644af9254ad9e)
2001-06-22 18:58:35 +00:00
Andrew Tridgell
868d010aa1 added the ability to test smbd safely as an ordinary user. The way it works is
that libsmb/ creates a local tcp socket then launches smbd as a subprocess
attached to that socket. smbd thinks it is being launched from inetd.

to use it do the following:

- compile with -DSMB_REGRESSION_TEST
- run like this (also works with smbtorture etc)
    export SMBD_TEST=1
    export LIBSMB_PROG=bin/smbd
    smbclient //server/share -Uuser%pass

obviously you need to setup a smb.conf etc. Using --prefix to configure
is useful.

The aim of all this stuff is to add a decent set of regression tests
to the build farm, so we know if smbd actually runs correctly on all the
platforms, not just builds. We can run smbtorture, masktest, locktest etc,
plus a bunch of smbclient scripts and any new tests we write.

This doesn't help much with nmbd (at least not yet) but its a good start.
(This used to be commit 7e8e6ae9a88c4d2587eb4e7f0501cd71bd36ebb2)
2001-06-22 15:14:45 +00:00
Gerald Carter
3281f6f076 sync this function with 2.2 (single check for NULL parameter)
(This used to be commit 3ab50e648d682080308d2db6bdb71eef0e303988)
2001-06-22 14:18:27 +00:00
Jeremy Allison
9a89a5b4fa Removed unused (and potentially crash-causing) free function.
Jeremy.
(This used to be commit 54ea00fa870f258b885b18e8684caa8488948607)
2001-06-22 02:37:52 +00:00
Andrew Tridgell
8e886b875b add an ignore on proto.h
(This used to be commit 0dc9227156823f6a44e6a0260e091b972057baa3)
2001-06-22 02:34:34 +00:00
Andrew Tridgell
15bf58b257 auto-build proto.h if its not there, but don't make it depend
on anything. Delete proto.h from CVS
(This used to be commit 8a37df73ec4d8d1a7db60a49cd5d7d22c4704a88)
2001-06-22 02:33:27 +00:00
Tim Potter
df07df9ffc Cleanup of cli_lsa_enum_trust_dom(). talloc() doesn't like attempts to
allocate 0 bytes.
(This used to be commit 465994cfbca72649474345bc057d436961cccf97)
2001-06-22 02:15:02 +00:00
Tim Potter
147af5f318 Spelling fix.
(This used to be commit 5f4889beb9311fd3912c3dfccf18fc9ab22b964c)
2001-06-22 01:58:19 +00:00
Andrew Tridgell
1cce779d77 the BAD_PTR idea in talloc.h is actually a bad idea - it means callers have no way of telling if the call really failed
(This used to be commit 7a96ca313e2f6b5ad8a713babd3cac0bbcc4c399)
2001-06-22 01:56:16 +00:00
Tim Potter
024250d6ca Use cli_read_one() for reading DCE/RPC reply fragments. We need to check
for and ignore ERRmoredata errors as the client library doesn't support
32-bit error messages.

Added some annotations for the RPC pipe code to make it a bit clearer
maybe.
(This used to be commit f179e0ff61794073aedcf77544865ad2f18c6e6d)
2001-06-22 01:19:45 +00:00
Tim Potter
ff5a18ad3e Merged cli_read_one() function for reading DCE/RPC reply fragments.
(This used to be commit 9e074bc2bf2df34048b67457623bb8219fb1e4d6)
2001-06-22 01:09:40 +00:00
Jeremy Allison
100a54e221 Andrew - please look this over. I've fixed a long standing (maybe 4-5
years old) bug when chainging a sessionsetup_and_X and tcon together.
The wrong username was being entered into the tdb, even though the
correct user was used for accessing files. This is related to the fact
that authorise_login() is not used for sessionsetup, but only for tcon
auths.
Jeremy.
(This used to be commit 0187cd6aef7586d7ad4bdc70c50f3f2e7c69519c)
2001-06-22 00:57:59 +00:00
Andrew Tridgell
6fdffd9b6c added some comments to make the cli read code clearer
(This used to be commit bbfbe03cc6166c23c42a704b5acaa19cbdbc39ce)
2001-06-22 00:42:53 +00:00
Simo Sorce
2e20f1147c use next_token instead of strtok.
single elemnts of list cannot be longer than a pstring (1024B now)
(This used to be commit 72b749ec89fa3642c0b3330a5331be645f84e24c)
2001-06-21 23:33:12 +00:00
Jeremy Allison
460c906190 Ok - I misspoke.... mmap returns MAP_FAILED, not neccessarily -1 :-).
Jeremy.
(This used to be commit 2d1c6d1f6b55a0a78eb8afbe16d2ad8b3253a220)
2001-06-21 19:56:25 +00:00
Jeremy Allison
99c506325f When mmap fails it returns -1 *NOT NULL*.
This got regressed somehow.....
Jeremy.
(This used to be commit b77c8b536d4b6d2162f4932227f01cffb730c645)
2001-06-21 19:50:21 +00:00
Jeremy Allison
3a6019b0eb Merging Gerry's spoolss changes.
Jeremy.
(This used to be commit 6b4a70cd8285c1e4d452e3af7df070b4c446ff54)
2001-06-21 17:46:14 +00:00
Gerald Carter
57d93d21f3 merge from 2.2
(This used to be commit 5932471a03e74ef7fcc71e22dbb52c530332a713)
2001-06-21 14:27:41 +00:00
Andrew Tridgell
91b8a8d1d2 next_token() was supposed to be a reentrant replacement for strtok(),
but the code suffered from bitrot and is not now reentrant. That means
we can get bizarre behaviour
i've fixed this by making next_token() reentrant and creating a
next_token_nr() that is a small non-reentrant wrapper for those lumps
of code (mostly smbclient) that have come to rely on the non-reentrant
behaviour
(This used to be commit 674ee2f1d12b0afc164a9e9072758fd1c5e54df7)
2001-06-21 09:10:42 +00:00
Andrew Tridgell
4ff011d88e Added STR_NOALIGN flags to clistr and srvstr fns. Yes, NT actually does
send unaligned unicode strings sometimes!
Fixed our handling of the workgroup name tacked on the end of the
NT1 negprot response (a unaligned unicode)
fixed a couple of places where we should be using the message_end fns instead
of pre-calculated buffer lengths
(This used to be commit 86613493a9b2e56523153486931d0bf8d39beb7a)
2001-06-21 05:38:28 +00:00
Jeremy Allison
fda0f83d75 Following info from TAKAHASHI Motonobu <monyo@samba.gr.jp>,
Samba Users Group Japan, ensure that we don't use dos_to_unix(xx,True),
but always use dos_to_unix(xx,False) to prevent overwriting.
Jeremy.
(This used to be commit 244aec8ea623fec828add3ab09c5003bf32bd5c7)
2001-06-21 01:01:15 +00:00
Jeremy Allison
3f1254bee1 Fixed W2K SP2 joining a Samba PDC hosted domain.
Jermey.
(This used to be commit 05a2911403a0710d994a618e72743205a3b0b87a)
2001-06-20 19:55:59 +00:00
Jeremy Allison
6fb063b4d5 Warning fix from Andrew Bartlett.
Jeremy.
(This used to be commit 87f647715d9fba9f8d25da0bde005a8d8858c2ae)
2001-06-20 17:49:38 +00:00