sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-25 23:21:54 +03:00
Code
74,417 Commits 60 Branches 1,144 Tags 452 MiB
ee34c25c8a
Commit Graph

37457 Commits

Author SHA1 Message Date
Stefan Metzmacher
2b8e148084 s3:client: close the socket if receive_smb_raw() fails 
metze
 2011-07-08 14:09:08 +02:00
Stefan Metzmacher
0ecd15abe6 s3:client: use cli_nt_error() in order to avoid cli_errstr() 
metze
 2011-07-08 14:09:08 +02:00
Stefan Metzmacher
f5b0bbf108 s3:client: avoid cli_errstr() where we already have an NTSTATUS 
metze
 2011-07-08 14:09:07 +02:00
Stefan Metzmacher
5cc279eb34 s3:clitar: avoid usage of cli_errstr() 
metze
 2011-07-08 14:09:07 +02:00
Stefan Metzmacher
06247a7a09 s3:libsmb: remove use of cli_errstr() in SMBC_server_internal() 
metze
 2011-07-08 14:09:07 +02:00
Stefan Metzmacher
a7b9c628af s3:auth_server: use cli->is_guestlogin instead of parsing cli->inbuf. 
cli->inbuf is not the valid response buffer of the session setup response.

metze
 2011-07-08 14:09:07 +02:00
Stefan Metzmacher
ce751946dd s3:auth: remove unused variable 
metze
 2011-07-08 14:09:06 +02:00
Stefan Metzmacher
f0085eedf0 s3:auth_unix: remove unused var 
metze
 2011-07-08 13:51:46 +02:00
Stefan Metzmacher
dbfb88aef3 s3:smb2_server: add some comments about change_to_user() and change_to_root_user() 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Jul  8 13:45:46 CEST 2011 on sn-devel-104
 2011-07-08 13:45:46 +02:00
Andrew Bartlett
cda8686940 lib/param: Merge struct loadparm_service into common 
This is handled by a common header and a .c file that is included into
both loadparm.c files.

In the process, _lp functions were renamed to lp__ to allow the common
function definition declarations to be used by source3 and source4
(which have different macro definitions).

The only parameter to change type is 'strict_locking' which was a
bool, and is now an int, to accommodate the 'Auto' value from source3.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Jul  8 12:35:56 CEST 2011 on sn-devel-104
 2011-07-08 12:35:56 +02:00
Andrew Bartlett
cf406f7e7d s3-param use common struct parmlist_entry to hold parametric options 
This will allow struct loadparm_service to be shared in future.

Andrew Bartlett
 2011-07-08 11:23:23 +02:00
Andrew Bartlett
3ab3159f75 s3-param check for aliases with both p_class and offset 
This bug was found when comparing with the source4 loadparm code.

Andrew Bartlett
 2011-07-08 11:23:23 +02:00
Andrew Bartlett
6e6aaacedb lib/util Move bitmap.c to lib/util 2011-07-08 11:23:23 +02:00
Andrew Bartlett
6b2749f8a9 param: Add hooks to s3 parm_struct and the parameters void * pointer 
This is to that the pyparam hooks can use the hooks to connect with
the s3 loadparm system.  This now also includes per-service
parameters.

Andrew Bartlett
 2011-07-08 11:23:23 +02:00
Andrew Bartlett
198ad4df31 s3-lib use True and False in bitmap.c 2011-07-08 11:23:23 +02:00
Andrew Bartlett
60f353a144 s3-param: calculate default_server_announce at runtime 2011-07-08 11:23:23 +02:00
Andrew Bartlett
fad3c763f7 s3-param Remove lp_set_passdb_backend() 2011-07-08 11:23:23 +02:00
Volker Lendecke
76c73dbb22 s3-zfsacl: Fix a debug message 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Jul  8 11:22:55 CEST 2011 on sn-devel-104
 2011-07-08 11:22:55 +02:00
Stefan Metzmacher
ef64048038 s3:wscript_build: remove unused variable 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Jul  8 02:43:22 CEST 2011 on sn-devel-104
 2011-07-08 02:43:21 +02:00
Stefan Metzmacher
960310b68d s3:selftest: run SMB2-BASIC 
metze
 2011-07-08 01:22:22 +02:00
Stefan Metzmacher
67ac266ae8 s3:torture: add SMB2-BASIC 
Based on the initial patch from Volker Lendecke <vl@samba.org>.

metze
 2011-07-08 01:22:22 +02:00
Stefan Metzmacher
fdd6c4e673 s3:libsmb: add smb2cli_query_directory*() 
Based on the initial patch from Volker Lendecke <vl@samba.org>.

metze
 2011-07-08 01:22:21 +02:00
Stefan Metzmacher
548f7d3f36 s3:libsmb: add smb2cli_write*() 
Based on the initial patch from Volker Lendecke <vl@samba.org>.

metze
 2011-07-08 01:22:21 +02:00
Stefan Metzmacher
22859b0e89 s3:libsmb: add smb2cli_read*() 
Based on the initial patch from Volker Lendecke <vl@samba.org>.

metze
 2011-07-08 01:22:21 +02:00
Stefan Metzmacher
d82be9588a s3:libsmb: add smb2cli_flush*() 
Based on the initial patch from Volker Lendecke <vl@samba.org>.

metze
 2011-07-08 01:22:20 +02:00
Stefan Metzmacher
40ecdeb3fb s3:libsmb: add smb2cli_close*() 
Based on the initial patch from Volker Lendecke <vl@samba.org>.

metze
 2011-07-08 01:22:20 +02:00
Stefan Metzmacher
2abc34cb4a s3:libsmb: add smb2cli_create*() 
Based on the initial patch from Volker Lendecke <vl@samba.org>.

metze
 2011-07-08 01:22:20 +02:00
Stefan Metzmacher
f21720773f s3:libsmb: add smb2cli_tcon*() and smb2cli_tdis*() 
Based on the initial patch from Volker Lendecke <vl@samba.org>.

metze
 2011-07-08 01:22:19 +02:00
Stefan Metzmacher
4efc85c6f1 s3:libsmb: add smb2cli_sesssetup*() and smb2cli_logoff*() 
Based on the initial patch from Volker Lendecke <vl@samba.org>.

metze
 2011-07-08 01:22:18 +02:00
Stefan Metzmacher
ab913d1768 s3:libsmb: add smb2cli_negprot*() 
Based on the initial patch from Volker Lendecke <vl@samba.org>.

metze
 2011-07-08 01:22:17 +02:00
Stefan Metzmacher
a0cf7bae60 s3:libsmb: add basic smb2 client infrastructure 
Based on the initial patch from Volker Lendecke <vl@samba.org>.

metze
 2011-07-08 01:22:17 +02:00
Jeremy Allison
8dc7029561 Fix bug #8293 - SMB2 doesn't rotate the log files often enough. 
Move the num_requests field out of the smb1 struct into the generic
struct smbd_server_connection struct. Use it to count SMB2 requests
as well as SMB1 and ensure that check_log_size() is called every 50
SMB2 requests.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Jul  8 01:14:53 CEST 2011 on sn-devel-104
 2011-07-08 01:14:53 +02:00
Stefan Metzmacher
eea210eba7 s3:smb2_server: call change_to_root_user() or smbd_smb2_request_check_tcon() 
For all requests which don't operate on a tcon, we should call
change_to_root_user(), to match the SMB1 behavior.

For SMB1 we do the following operations without AS_USER:

/* 0x70 */ { "SMBtcon",reply_tcon,0},
/* 0x71 */ { "SMBtdis",reply_tdis,DO_CHDIR},
/* 0x72 */ { "SMBnegprot",reply_negprot,0},
/* 0x73 */ { "SMBsesssetupX",reply_sesssetup_and_X,0},
/* 0x74 */ { "SMBulogoffX",reply_ulogoffX, 0}, /* ulogoff doesn't give a valid TID */
/* 0x75 */ { "SMBtconX",reply_tcon_and_X,0},
...
/* 0x2b */ { "SMBecho",reply_echo,0},
...
/* 0xa4 */ { "SMBntcancel",reply_ntcancel, 0 },

For SMB2tdis we still call smbd_smb2_request_check_tcon()
as close_cnum() calls change_to_root_user() when needed.

metze

Signed-off-by: Jeremy Allison <jra@samba.org>
 2011-07-07 14:17:17 -07:00
Björn Baumbach
80c65416c1 s3-client: Remove use of cli_errstr() 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2011-07-07 19:16:28 +02:00
Björn Baumbach
11426758d7 s3-libsmb: Remove use of cli_errstr() 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2011-07-07 19:16:28 +02:00
Björn Baumbach
98e0f9d1ed s3-torture: run_shortname_test: Remove uses of cli_errstr() 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2011-07-07 19:16:28 +02:00
Björn Baumbach
684095b0a2 s3-torture: run_simple_posix_open_test: Remove uses of cli_errstr() 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2011-07-07 19:16:28 +02:00
Stefan Metzmacher
840a1c7445 s3-torture: use nt_errstr() for cli_unlink() error handling 
Use nt_errstr() instead of cli_errstr() for error handling on
cli_unlink() calls.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2011-07-07 19:16:28 +02:00
Björn Baumbach
60873a9e48 s3-torture: introduce check_both_error() 
Check if the server produced the expected dos or nt error code like
check_error(), but without a cli_state struct.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2011-07-07 19:16:28 +02:00
Stefan Metzmacher
3cdf962d1e s3:libsmb: finally remove unused cli_state->outbuf 
metze
 2011-07-07 19:16:28 +02:00
Stefan Metzmacher
0f006751ec s3:libsmb: remove unused clistr_push_fn() 
metze
 2011-07-07 19:16:28 +02:00
Stefan Metzmacher
30574a73d8 s3:libsmb: remove unused clistr_pull_fn() 
metze
 2011-07-07 19:16:28 +02:00
Stefan Metzmacher
fc992e7029 s3:torture/scanner: use trans2_bytes_push_str() in scan_nttrans() 
metze
 2011-07-07 19:16:28 +02:00
Stefan Metzmacher
02171ee0f0 s3:torture/scanner: use trans2_bytes_push_str() in scan_trans2() 
metze
 2011-07-07 19:16:28 +02:00
Stefan Metzmacher
072a27fd9f s3:libsmb: use trans2_bytes_push_str() in cli_tcon_andx_create() for the plaintext password 
This makes sure we push the string always in DOS charset.

metze
 2011-07-07 19:16:28 +02:00
Stefan Metzmacher
5b1ac1bcc3 s3:libsmb: use trans2_bytes_push_str() in cli_set_ea_path() 
metze
 2011-07-07 19:16:28 +02:00
Stefan Metzmacher
cea9245909 s3:libsmb: use trans2_bytes_push_str() in cli_dfs_get_referral() 
metze
 2011-07-07 19:16:28 +02:00
Stefan Metzmacher
2453164317 s3:libsmb: use a talloc_stackframe in cli_dfs_get_referral() 
metze
 2011-07-07 19:16:27 +02:00
Stefan Metzmacher
b77becdb55 s3:libsmb: use trans2_bytes_push_str/bytes() in cli_list_trans_*() 
metze
 2011-07-07 19:16:27 +02:00
Stefan Metzmacher
d921200e75 s3:libsmb: use clistr_pull_talloc() for short_name in interpret_long_filename() 
metze
 2011-07-07 19:16:27 +02:00
Stefan Metzmacher
af66c64e95 s3:libsmb: interpret_long_filename() short_name is always UNICODE 
metze
 2011-07-07 19:16:27 +02:00
Stefan Metzmacher
eaeeb5ce0e s3:libsmb: add trans2_bytes_push_bytes() 
metze
 2011-07-07 19:16:27 +02:00
Stefan Metzmacher
ed99caded2 s3:libsmb: make trans2_bytes_push_str() non-static 
We should use this and get rid of clistr_push().

metze
 2011-07-07 19:16:27 +02:00
Stefan Metzmacher
9a350ca3b6 s3:utils: avoid cli_nt_error()/cli_errstr() if we already have the status 
metze
 2011-07-07 19:16:27 +02:00
David Disseldorp
e5955903fd s3-printing: remove tdb migration invalid printer name checks 
WERR_INVALID_PRINTER_NAME only needed to be handled when printing tdb
migration used spoolss, with winreg such errors are no longer possible.

Signed-off-by: Günther Deschner <gd@samba.org>

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Jul  7 19:15:34 CEST 2011 on sn-devel-104
 2011-07-07 19:15:34 +02:00
Günther Deschner
cfc3b6e5f7 s3-printing: make sure to first migrate the printers then the security descriptor. 
Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
 2011-07-07 18:06:02 +02:00
David Disseldorp
5dd8185d85 s3-printing: fill info2_mask in printer migration 
Also fix possibly uninitialised status return from
printing_tdb_migrate_printer().
 2011-07-07 18:06:02 +02:00
Günther Deschner
57bbb32c64 s3-printing: remove spoolss pipe from migration library, only using winreg finally. 
Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
 2011-07-07 18:06:02 +02:00
Günther Deschner
8f3d5f5333 s3-printing: use winreg interface for migration, instead of spoolss. 
Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
 2011-07-07 18:06:02 +02:00
Günther Deschner
72b1f8be56 s3-printing: safe a ton of roundtrips by reusing existing winreg binding_handles. 
Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
 2011-07-07 18:06:02 +02:00
Günther Deschner
0a1ec73b96 s3-printing: use winreg_internal functions. 
Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
 2011-07-07 18:06:01 +02:00
Günther Deschner
ada5380d20 s3-printing: add winreg_internal functions. 
Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
 2011-07-07 18:06:01 +02:00
Günther Deschner
a762eda519 s3-printing: add winreg_printer_binding_handle and remove most of srv_spoolss_util.c. 
Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
 2011-07-07 18:06:01 +02:00
Günther Deschner
f2be8378b9 s3-printing: add rpc_client/cli_winreg_spoolss.c 
Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
 2011-07-07 18:06:01 +02:00
Günther Deschner
a0fc64a88e s3-waf: make LIBCLI_SPOOLSS a shared library 
Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
 2011-07-07 18:06:01 +02:00
Günther Deschner
43cf3a28dc s3-printing: move spoolss_create_default_devmode/secdesc to init_spoolss.h 
Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
 2011-07-07 18:06:01 +02:00
Günther Deschner
74e416031b s3-printing: move driver_info_ctr_to_info8 to init_spoolss.h 
Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
 2011-07-07 18:06:01 +02:00
Günther Deschner
dd5375b4a1 s3-printing: move os2 related functions to printing/nt_printing_os2.c. 
Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
 2011-07-07 18:06:01 +02:00
Volker Lendecke
eba5d0b641 s3: Remove a use of cli_errstr 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Jul  7 18:04:26 CEST 2011 on sn-devel-104
 2011-07-07 18:04:26 +02:00
Andreas Schneider
1caa7a852c s3-waf: Fix linking bugs causing segfaults. 
As auth_util.c is linked several times the static variables have
different address on different calls. This leads to segfaults.

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Thu Jul  7 16:50:05 CEST 2011 on sn-devel-104
 2011-07-07 16:50:05 +02:00
Gregor Beck
cd83c1d958 s3:testparm: avoid spurious warnings about dos mode mapping and create mask if store dos attributes is set 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Jul  7 12:49:01 CEST 2011 on sn-devel-104
 2011-07-07 12:49:00 +02:00
Stefan Metzmacher
8a2290667c s3:libsmb: use clistr_pull_talloc() in cli_qfilename() 
metze
 2011-07-06 17:18:14 +02:00
Stefan Metzmacher
a1df729f7b s3:libsmb: let cli_qfileinfo[_recv]() return recv_flags2 
metze
 2011-07-06 17:18:13 +02:00
Stefan Metzmacher
2b0cc3c412 s3:libsmb: use clistr_pull_talloc() in cli_get_fs_volume_info() 
metze
 2011-07-06 17:18:13 +02:00
Stefan Metzmacher
27736bed83 s3:libsmb: the SMB_QUERY_FS_VOLUME_INFO response needs at least 18 data bytes 
metze
 2011-07-06 17:18:13 +02:00
Stefan Metzmacher
bc98d004c9 s3:libsmb: don't use cli->inbuf in cli_dfs_get_referral() 
The rdata buffer returned by cli_trans() doesn't belong to
cli->inbuf, so don't use it.

metze
 2011-07-06 17:18:13 +02:00
Stefan Metzmacher
af61f6fce6 s3:libsmb: fix error handling in cli_dfs_get_referral() 
We should not return NT_STATUS_OK on error.

metze
 2011-07-06 17:18:12 +02:00
Stefan Metzmacher
f9601a9180 s3:sharesec: return an error if get_share_security() returns NULL 
This indicates an error, as it uses get_share_security_default()
if no security descriptor is configured.

Jeremy, please check.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Jul  6 15:40:23 CEST 2011 on sn-devel-104
 2011-07-06 15:40:23 +02:00
Michael Adam
93ad34c4ad s3:test: catch more errors in test_access_check() in the smbclient_s3 test 
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Jul  6 14:07:13 CEST 2011 on sn-devel-104
 2011-07-06 14:07:13 +02:00
Michael Adam
4af8615da8 s3:registry: update copyright for the registry db implementation 2011-07-06 12:55:25 +02:00
Stefan Metzmacher
310fff02a6 s3:sharesec: also initialize pgranted if get_share_security() returns NULL 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Jul  6 12:54:30 CEST 2011 on sn-devel-104
 2011-07-06 12:54:30 +02:00
Volker Lendecke
2dfc898d1a s3: Follow the TALLOC_FREE convention in source3 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Jul  6 11:01:05 CEST 2011 on sn-devel-104
 2011-07-06 11:01:05 +02:00
Volker Lendecke
6fcb3bbdae s3: Fix Coverity ID 2586 -- NO_EFFECT 
tsocket_address_bsd_sockaddr returns ssize_t, and on some systems socklen_t is
unsigned. So (len < 0) could never have turned true.

Volker
 2011-07-06 09:50:02 +02:00
Volker Lendecke
7d96a4594b s3: Remove cli_errstr from cmd_posix_open 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Jul  6 09:45:11 CEST 2011 on sn-devel-104
 2011-07-06 09:45:11 +02:00
Volker Lendecke
c33a5a659c s3: Fix error logic in posix_open 2011-07-06 08:35:27 +02:00
Volker Lendecke
c1fdec7efc s3: Remove a few uses of cli_errstr 2011-07-06 08:35:27 +02:00
Volker Lendecke
26782fbbf3 s3: make cli_resolve_path return NTSTATUS 
This looks larger than it is. No parameters needed changing.
 2011-07-06 08:35:27 +02:00
Andrew Bartlett
dd491d8d8c s3-build We no longer require to redefine _SAMBA_BUILD_ 2011-07-06 05:32:59 +02:00
Andrew Bartlett
7891848357 libcli/smb move FILE_TYPE constants in common 
This allows us to remove another _SAMBA_BUILD_ conditional

Andrew Bartlett
 2011-07-06 05:32:59 +02:00
Andrew Bartlett
6543987139 libcli/smb move enum protocol_types to a common header 2011-07-06 05:32:51 +02:00
Christian Ambach
9a3e2d1c02 s3:smbd fix a compile warning on AIX 5.3 
use the correct alias instead of FD directly

Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Tue Jul  5 19:51:42 CEST 2011 on sn-devel-104
 2011-07-05 19:51:42 +02:00
Christian Ambach
14544cede5 s3:build fix autoconf build on AIX 5.3 
using ZLIB_LIBS as dependency made AIX make fail trying to
find -lz as build target
 2011-07-05 18:41:24 +02:00
Christian Ambach
3d6dafcce1 s3:lib fix non-empty blank lines 2011-07-05 18:41:24 +02:00
Christian Ambach
f3088d135d s3:modules fix non-empty blank lines 2011-07-05 18:41:24 +02:00
Volker Lendecke
f924913259 s3: Remove some unused variables 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Jul  5 18:40:11 CEST 2011 on sn-devel-104
 2011-07-05 18:40:11 +02:00
Volker Lendecke
4deca5d728 s3: Fix bug 8102 
We can't allow open with access that has been denied via the share
security descriptor

Signed-off-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Jul  5 16:21:54 CEST 2011 on sn-devel-104
 2011-07-05 16:21:53 +02:00
Volker Lendecke
720fa46f94 s3: Calculate&store the maximum share access mask 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2011-07-05 13:28:08 +02:00
Volker Lendecke
1c022d2e41 s3: Return "granted" from share_access_check 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2011-07-05 13:28:03 +02:00
Michael Adam
399c0dba01 s3:registry: remove unused function regdb_key_is_base_key() 
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Mon Jul  4 21:11:32 CEST 2011 on sn-devel-104
 2011-07-04 21:11:32 +02:00
Michael Adam
86f8eb98fe s3:registry: replace use of deprecated talloc_destroy by talloc_free. 2011-07-04 20:02:10 +02:00
Michael Adam
17b091b7c7 s3:registry: remove superfluous check for success of talloc_stackframe() 2011-07-04 20:02:10 +02:00
Michael Adam
cc384c1596 s3:registry: add debug-level-10 verbosity to regdb_upgrade_v2_v3_fn() 2011-07-04 20:02:10 +02:00
Michael Adam
340be35b9b s3:registry: adapt a debug message to be more systematic 2011-07-04 20:02:10 +02:00
Michael Adam
c8c5d8c89e s3:registry: set registry version to 3 and add upgrade code 
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
 2011-07-04 20:02:09 +02:00
Michael Adam
f36ee63df2 s3:registry: add db_context argument to regdb_upgrade_v1_to_v2() 2011-07-04 20:02:09 +02:00
Michael Adam
1621aab139 s3:registry: wrap the whole db upgrade in one transaction 
The purpose of this is to prepare for multiple upgrade steps
to be performed in a single transaction, so that no change
at all is made to that database if one step fails.

Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
 2011-07-04 20:02:09 +02:00
Michael Adam
caf9c99969 s3:registry: change regdb_store_regdb_version() to take db_context argument. 2011-07-04 20:02:09 +02:00
Michael Adam
2273650ca8 s3:registry: fix a comment typo 2011-07-04 20:02:09 +02:00
Michael Adam
a8360712e1 s3:registry: remove unused regdb_delete_sorted_subkeys() 
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
 2011-07-04 20:02:09 +02:00
Michael Adam
a0f83ecbb9 s3:registry: don't delete the unused subkeys cache record any more 
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
 2011-07-04 20:02:09 +02:00
Michael Adam
50add4091a s3:registry: remove the code to create and search the sorted subkeys cache records 
This is not needed any more.

Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
 2011-07-04 20:02:09 +02:00
Michael Adam
18973fa109 s3:registry: adapt the comment explaining the definition of the existence of a key. 
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
 2011-07-04 20:02:09 +02:00
Michael Adam
a255630358 s3:registry: regdb_key_exists now checks only for the list-of-subkeys-record 
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
 2011-07-04 20:02:08 +02:00
Michael Adam
9e2b2c1fcc s3:registry: rewrite init_registry_key_internal 
This rewrites init_registry_key_internal() to correctly also create
base keys. It makes use of the existing create functions instead of
duplicating the code.

Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
 2011-07-04 20:02:08 +02:00
Michael Adam
747c67cf30 s3:registry: add regdb_create_basekey() 
Function to create a base key in the registry db, i.e. one that
has no parent key.

Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
 2011-07-04 20:02:08 +02:00
Michael Adam
144c8d77d8 s3:registry: add regdb_create_subkey_internal() taking additional db context argument 
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
 2011-07-04 20:02:08 +02:00
Michael Adam
15a50ef8f8 s3:registry: add new mode to regdb_store_subkey_list() for handing in NULL parent key 
Standard behaviour is to concatenate parent and key path (parent\key).
This new mode allows for storing subkey lists for base keys using a NULL
parent argument.

Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
 2011-07-04 20:02:08 +02:00
Michael Adam
fc4d79d41a s3:registry: create the empty list of subkeys of the new key in regdb_create_subkey 
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
 2011-07-04 20:02:08 +02:00
Michael Adam
322eaf1e9e s3:registry: refactor creation of subkey list out into regdb_store_subkey_list() 
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
 2011-07-04 20:02:08 +02:00
Michael Adam
394ca1446e s3:registry: remove redundant write of zero-lentgh subkey list record 
In this case, the zero-lenght list has already been written in step #2.

Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
 2011-07-04 20:02:08 +02:00
Michael Adam
eb797bd206 s3:registry: don't update the sorted subkeys cache any more in regdb_store_keys_internal2() 
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
 2011-07-04 20:02:08 +02:00
Michael Adam
5b01a34ad7 s3:registry: don't skip base key in existence check in regdb_store_keys_internal() 
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
 2011-07-04 20:02:08 +02:00
Michael Adam
da2e64b63f s3:registry: don't skip base keys from existence check in regdb_create_subkey() 
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
 2011-07-04 20:02:07 +02:00
Michael Adam
6b99aa496f s3:registry: don't skip base keys from existence check in regdb_delete_subkey() 
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
 2011-07-04 20:02:07 +02:00
Christian Ambach
ad4a10dd05 s3:smb2 fix smbd crash on premature end of smb2 conn (Bug 8286) 
when smbd tries to clean up locks after a premature end of a smb2
connection, lock_db has already been freed and so it crashes

this patch changes the order in which items are freed so that
lock_db is still around when it is needed

Jeremy, Metze, please check

Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Mon Jul  4 20:00:26 CEST 2011 on sn-devel-104
 2011-07-04 20:00:26 +02:00
Volker Lendecke
0bec150ab1 s3: Fix an enum/int mixup 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Jul  4 18:47:59 CEST 2011 on sn-devel-104
 2011-07-04 18:47:59 +02:00
Stefan Metzmacher
7c96e96e98 s3:smb2_server: there's no reason to check the session id twice on a smb2_tcon request 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Jul  4 17:34:13 CEST 2011 on sn-devel-104
 2011-07-04 17:34:13 +02:00
Stefan Metzmacher
601b138e92 s3:smb2_create: call 'return' after smbd_server_connection_terminate() 
This is not strictly needed in the fork process model, but we hopefully
support other models in future.

metze
 2011-07-04 16:21:45 +02:00
Andrew Bartlett
e17ab20227 s3-build add tevent depencency on libsmb 
This may assist the build on FreeBSD 8.2

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Jul  4 16:19:10 CEST 2011 on sn-devel-104
 2011-07-04 16:19:10 +02:00
Günther Deschner
ff94539f27 s3-printing: open up a winreg pipe handle for the migration code. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Jul  4 15:06:41 CEST 2011 on sn-devel-104
 2011-07-04 15:06:41 +02:00
Andrew Bartlett
0ac4f64928 s3-build link passdb modules against libpassdb 
This ensures that they don't include a duplicate copy of
pdb_interface.c functions, because they will instead link the library.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Jul  4 12:24:50 CEST 2011 on sn-devel-104
 2011-07-04 12:24:50 +02:00
Andrew Bartlett
6b97a3b1ff s3-build allow_undefined_symbols=False is the default now 2011-07-04 19:03:52 +10:00
Andrew Bartlett
5d4b197418 s3-auth libauth no longer requires undefined symbols 2011-07-04 18:58:32 +10:00
Andrew Bartlett
c599d075cb s3-lib Move event_add_idle() to source3/lib/events.c 
This allows libauth not to depend on smbd_base.

Andrew Bartlett
 2011-07-04 18:53:59 +10:00
Andrew Bartlett
b8b504a484 s3-samr Send IP address only to PAM remote hostname hook on password set 
The previous behaviour was to attempt to do a reverse hostname lookup,
where enabled.  This new behaviour matches the new behaviour in the
modules called by auth stack.

Andrew Bartlett
 2011-07-04 18:28:46 +10:00
Andreas Schneider
2a01842da8 s3: RIP 'struct client_address'. 
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
 2011-07-04 18:28:45 +10:00
Andreas Schneider
2bcbeea05e s3-rpc_server: Remove client_id and server_id from pipes struct. 
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
 2011-07-04 18:28:43 +10:00
Andreas Schneider
aee04ef330 s3-smbd: Remove client_address from smbd_server_connection struct. 
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
 2011-07-04 18:28:40 +10:00
Andreas Schneider
b2511a280a s3-smbd: Remove obsolete smbd_set_server_fd(). 
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
 2011-07-04 18:28:36 +10:00
Andreas Schneider
cbec251f9a s3-vfs: Replace client_id in exand msdfs. 
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
 2011-07-04 18:28:34 +10:00
Andreas Schneider
c0f1c179b9 s3-vfs: Replace client_id in smbta. 
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
 2011-07-04 18:28:32 +10:00
Andreas Schneider
2f92ffb1a4 s3-smbd: Replace client_id in smbd session setup. 
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
 2011-07-04 18:28:30 +10:00
Andreas Schneider
ea2917c7a2 s3-smbd: Replace client_id in smbd session. 
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
 2011-07-04 18:28:28 +10:00
Andreas Schneider
73d28912a4 s3-smbd: Replace client_id in smbd service. 
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
 2011-07-04 18:28:26 +10:00
Andreas Schneider
ae05a7aec6 s3-smbd: Replace client_id in smbd reply. 
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
 2011-07-04 18:28:24 +10:00
Andreas Schneider
ad0f765a09 s3-smbd: Exit cleanly if we can't create an address string. 
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
 2011-07-04 18:28:21 +10:00
Andreas Schneider
d99acd26a2 s3-smbd: Replace client_id in smbd connection. 
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
 2011-07-04 18:28:18 +10:00
Andreas Schneider
a513086c2a s3-smbd: Replace client_id in smbd process. 
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
 2011-07-04 18:28:16 +10:00
Andreas Schneider
726b6c6e52 s3-epmapper: Replace server_id in the epmapper. 
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
 2011-07-04 18:28:14 +10:00
Andreas Schneider
784035fd53 s3-spoolss: Replace client_id in the spoolss server. 
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
 2011-07-04 18:28:12 +10:00