Volker Lendecke
0e7d1aae2f
Fix a memleak in secrets_fetch_afs_key
...
Coverity ID 570
(This used to be commit 0f52dc3f7eae7e87b8a71bd099b99b0b3e76a387)
2008-06-07 08:51:35 +02:00
Volker Lendecke
8c98f5af6f
Fix a memleak in secrets_fetch_trust_account_password_legacy
...
Coverity ID 571
(This used to be commit a551773e34af1c118f77784a285e1b885da8655d)
2008-06-07 08:50:02 +02:00
Volker Lendecke
32452565be
Fix a memleak in fetch_ldap_pw
...
Fix Coverity ID 572, also fix the error check for secrets_fetch failing
(This used to be commit 2663c81a782fd4394a9feaaaa987c7f6d38ca5da)
2008-06-07 08:48:13 +02:00
Tim Prouty
fb37f15600
Cleanup size_t return values in callers of convert_string_allocate
...
This patch is the second iteration of an inside-out conversion to cleanup
functions in charcnv.c returning size_t == -1 to indicate failure.
(This used to be commit 6b189dabc562d86dcaa685419d0cb6ea276f100d)
2008-05-20 22:40:13 +02:00
Volker Lendecke
16198dc51e
Convert dbwrap_trans_delete to NTSTATUS
...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit dead193f46c2b19955ab3e5ac5ba343694f4858a)
2008-04-01 14:04:22 +02:00
Volker Lendecke
fcdfff1cc8
Convert dbwrap_trans_store to NTSTATUS
...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit 5f4de856af1abe63b13059bbe1615cb5877770d0)
2008-04-01 14:04:22 +02:00
Stefan Metzmacher
a5f3911d70
passdb/secrets: add secrets_db_ctx() to get the db_context
...
metze
(This used to be commit 986bc7e8b260265da019b67ec751509eb589d24b)
2008-04-01 14:04:20 +02:00
Stefan Metzmacher
4b2ce410a5
passdb/secrets: use db_open_trans()
...
metze
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit b61b8ca4944f399216d8e67a48ea7d259258b432)
2008-03-27 18:14:57 +01:00
Stefan Metzmacher
3b0592bc15
passdb/secrets: it's enough to use traverse_read() in secrets_trusted_domains()
...
metze
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit 729f7b9ff30e81537a7257daeaa1728c7ae96853)
2008-03-27 18:14:56 +01:00
Volker Lendecke
28244425b2
Convert secrets.c to use dbwrap
...
(This used to be commit 9d30e5991c6fe77ef5fd505efb756554bbe77256)
2008-03-11 17:09:19 +01:00
Volker Lendecke
1ebfc66b2c
Use a separate tdb for mutexes
...
Another preparation to convert secrets.c to dbwrap: The dbwrap API does not
provide a sane tdb_lock_with_timeout abstraction. In the clustered case the DC
mutex is needed per-node anyway, so it is perfectly fine to use a local mutex
only.
(This used to be commit f94a63cd8f94490780ad9331da229c0bcb2ca5d6)
2008-03-10 21:08:45 +01:00
Volker Lendecke
d634ab06b3
Convert secrets_lock_trust_account_password to talloc
...
This is preparing the conversion of secrets.c to ctdb
(This used to be commit 1307f0130c47b8d740d2b7afe7a5d8d1a655e2a2)
2008-03-10 21:08:45 +01:00
Volker Lendecke
b175ffa702
Make use of talloc_asprintf_strupper_m in secrets.c
...
(This used to be commit 3ac4f935c074af768d0b83514f86d010c387817a)
2008-03-10 09:52:08 +01:00
Volker Lendecke
2e8d375346
Avoid some pointless checks
...
secrets_init() makes sure that the tdb is initialized
(This used to be commit 8725dbc8888cf7a1d3d9d1205678fcd3ca3c6350)
2008-03-10 09:51:58 +01:00
Volker Lendecke
c2cd0e3c54
Use talloc_tos() in secrets_init
...
(This used to be commit 27065382d9b692b5885265c9d60ffb7ec7748c38)
2008-03-10 09:51:51 +01:00
Günther Deschner
7ec5bfc49f
More paranoid checks for secrets_init() success.
...
Guenther
(This used to be commit 5e60852bae61be72dee9d5b93c59ac900aba73ae)
2008-02-09 02:05:39 +01:00
Günther Deschner
c0d33508ff
Add secrets_shutdown().
...
Guenther
(This used to be commit dd3fbd93b6e5fe8b5e3a3727a64a38d5ae46fcbf)
2008-01-07 12:48:21 +01:00
Günther Deschner
d0cd32e2c8
Add and use some keystr functions using talloc_tos() in secrets api.
...
Guenther
(This used to be commit 6ccbf67a0c6f117978df55d4e2565d34fddf9317)
2007-12-19 11:15:17 +01:00
Volker Lendecke
900288a2b8
Replace sid_string_static by sid_string_dbg in DEBUGs
...
(This used to be commit bb35e794ec129805e874ceba882bcc1e84791a09)
2007-12-15 22:09:36 +01:00
Michael Adam
fe969f9a7f
Refactor the lagacy part of secrets_fetch_trust_account_password() out
...
into a new function secrets_fetch_trust_account_password_legacy() that
does only try to obtain the hashed version of the machine password directly
from secrets.tdb.
Michael
(This used to be commit 91da12b751b3168dc40049f3e90c10d840393efc)
2007-12-13 10:15:18 +01:00
Michael Adam
b99a6b0e8c
Remove two unneeded functions.
...
secrets_store_trust_account_password() and trust_password_delete()
are the write access functions to the SECRETS/$MACHINE.ACC/domain keys
in secrets.tdb, the md4 hashed machine passwords. These are not used
any more: Current code always writes the clear text password.
Michael
(This used to be commit 4788fe392427901f6b1c505e3a743136ac8a91ca)
2007-12-13 10:15:13 +01:00
Michael Adam
2ade25279c
Fix logic and prevent segfaults in secrets trustdom tdb pack code.
...
New size calculation logic in tdb_trusted_dom_pass_pack()
and tdb_sid_pack() used accumulated sizes as successive offsets
to buffer pointer.
Michael
(This used to be commit 9c24713b402978e74dc8691be5cab71d8666eb41)
2007-12-12 09:47:41 -08:00
Michael Adam
b0469d0b69
Fix secrets_store_trusted_domain_password() after pstring removal.
...
Jeremy, this small "&" sign has given me a headache... :-)
Michael
(This used to be commit 7590b12a994cc3c5f299ce7f3299c76adad1c599)
2007-12-12 09:47:28 -08:00
Jeremy Allison
bcf033b38e
Change tdb_unpack "P" to return a malloc'ed string rather
...
than expect a pstring space to put data into.
Fix the (few) callers.
Jeremy.
(This used to be commit 7722a7d2c63f84b8105aa775b39f0ceedd4ed513)
2007-12-03 14:54:06 -08:00
Jeremy Allison
66298d8080
More pstring elimination.
...
Jeremy.
(This used to be commit 15074de938539e7a9c527d9a6d81792adc2ac3d0)
2007-11-20 17:18:16 -08:00
Volker Lendecke
33d8317571
static pstring removal
...
(This used to be commit 5490e2d77233f594a42cb32eda8215014db544e3)
2007-11-05 03:16:58 +01:00
Jeremy Allison
30191d1a57
RIP BOOL. Convert BOOL -> bool. I found a few interesting
...
bugs in various places whilst doing this (places that assumed
BOOL == int). I also need to fix the Samba4 pidl generation
(next checkin).
Jeremy.
(This used to be commit f35a266b3cbb3e5fa6a86be60f34fe340a3ca71f)
2007-10-18 17:40:25 -07:00
Gerald (Jerry) Carter
e5a951325a
[GLUE] Rsync SAMBA_3_2_0 SVN r25598 in order to create the v3-2-test branch.
...
(This used to be commit 5c6c8e1fe93f340005110a7833946191659d88ab)
2007-10-10 15:34:30 -05:00
Michael Adam
85811b273d
r24991: Kill all those lots of trailing whitespaces from secrets.c.
...
These red bars in vi really hurt my eyes... :-o
Michael
(This used to be commit 2e99e141c3254fe072756697b8db3cbd4e4f1db4)
2007-10-10 12:30:31 -05:00
Andrew Tridgell
5e54558c6d
r23784: use the GPLv3 boilerplate as recommended by the FSF and the license text
...
(This used to be commit b0132e94fc5fef936aa766fb99a306b3628e9f07)
2007-10-10 12:28:22 -05:00
Jeremy Allison
d824b98f80
r23779: Change from v2 or later to v3 or later.
...
Jeremy.
(This used to be commit 407e6e695b8366369b7c76af1ff76869b45347b3)
2007-10-10 12:28:20 -05:00
Volker Lendecke
4570f1c52a
r22125: Fix a warning
...
(This used to be commit 1c0ceb5fe217bd7210072869a1313c7ac67ff118)
2007-10-10 12:19:14 -05:00
Stefan Metzmacher
bc2b6436d0
r22009: change TDB_DATA from char * to unsigned char *
...
and fix all compiler warnings in the users
metze
(This used to be commit 3a28443079c141a6ce8182c65b56ca210e34f37f)
2007-10-10 12:19:00 -05:00
Stefan Metzmacher
6e2a411795
r21981: as we use tdb_trans_store(), we should also use tdb_trans_delete()
...
metze
(This used to be commit 2d2f8099684c4516ed685e5bb2a21541d53645ac)
2007-10-10 12:18:55 -05:00
Volker Lendecke
f56da0890f
r21831: Back out r21823 for a while, this is going into a bzr tree first.
...
Volker
(This used to be commit fd0ee6722ddfcb64b5cc9c699375524ae3d8709b)
2007-10-10 12:18:37 -05:00
Volker Lendecke
aa6055debd
r21823: Let secrets_store_machine_password() also store the account name. Not used
...
yet, the next step will be a secrets_fetch_machine_account() function that
also pulls the account name to be used in the appropriate places.
Volker
(This used to be commit f94e5af72e282f70ca5454cdf3aed510b747eb93)
2007-10-10 12:18:36 -05:00
Volker Lendecke
e6ccc787d9
r21819: Wrap all steps in secrets_store_machine_password into one single
...
transaction. Succeed all or store nothing.
Volker
(This used to be commit 4efc7b45985e807532214959c1872cd6e7865ab8)
2007-10-10 12:18:36 -05:00
Volker Lendecke
c55d05b03c
r21818: Remove some unused code
...
(This used to be commit f88eab91c43570e4da7a4a6cd117e7b7ebf53331)
2007-10-10 12:18:36 -05:00
Volker Lendecke
b906886e9e
r20824: Send access to the trusted domain passwords through the pdb backend, so that
...
in the next step we can store them in LDAP to be replicated across DCs.
Thanks to Michael Adam <ma@sernet.de>
Volker
(This used to be commit 3c879745cfc39be6128b63a88ecdbfa3d9ce6c2d)
2007-10-10 12:17:10 -05:00
Volker Lendecke
69272c9b04
r20644: Make some functions static, thanks to Michael Adam <ma@sernet.de> for the hint.
...
(This used to be commit f1f5d035db067b85e55b1c4009407b47dedcf975)
2007-10-10 12:17:01 -05:00
Simo Sorce
4225f9a4bd
r20116: Start merging in the work done to create the new idmap subsystem.
...
Simo.
(This used to be commit 50cd8bffeeed2cac755f75fc3d76fe41c451976b)
2007-10-10 12:16:25 -05:00
Jelmer Vernooij
4e7d11449a
r18654: Rename "struct uuid" => "struct GUID" for consistency.
...
(This used to be commit 5de76767e857e9d159ea46e2ded612ccd6d6bf19)
2007-10-10 11:52:19 -05:00
Jeremy Allison
fbdcf2663b
r16945: Sync trunk -> 3.0 for 3.0.24 code. Still need
...
to do the upper layer directories but this is what
everyone is waiting for....
Jeremy.
(This used to be commit 9dafb7f48ca3e7af956b0a7d1720c2546fc4cfb8)
2007-10-10 11:19:14 -05:00
Volker Lendecke
8fa2907efd
r16197: Fix Klocwork id 1338
...
(This used to be commit 963ae5bd144b90e71331a88029698a1a6dc52190)
2007-10-10 11:17:24 -05:00
Jeremy Allison
f897e7094f
r16076: Fix for machine password timeout overflow from Shlomi Yaakobovich
...
<Shlomi@exanet.com>.
Jeremy.
(This used to be commit 5cd234a1fff1e9d025eea6600649e56c997eafc2)
2007-10-10 11:17:19 -05:00
Jeremy Allison
a835b9500a
r15888: Fix bug #3804 from jason@ncac.gwu.edu
...
Invalid comparisons.
Jeremy.
(This used to be commit 9890a31c5f4a8911b0f56eee67cfbcc46f15ee43)
2007-10-10 11:17:12 -05:00
Volker Lendecke
e17302200c
r15101: Little step towards getting Samba4 tdb into 3: tdb_lock_bystring does not
...
have the timeout argument in Samba4. Add a new routine
tdb_lock_bystring_with_timeout.
Volker
(This used to be commit b9c6e3f55602fa505859a4b2cd137b74105d685f)
2007-10-10 11:16:23 -05:00
Volker Lendecke
b3d058a0ec
r14103: Fix a memleak found by valgrind (!!)
...
(This used to be commit b880602c4c1b13fbb5931b8e00c22209a722e0d5)
2007-10-10 11:11:12 -05:00
Volker Lendecke
56a99b1d1c
r14102: Fix Coverity bug # 70
...
(This used to be commit 56dc19879c6514cbdd0b1fd186c8bdeb61bf151a)
2007-10-10 11:11:12 -05:00
Jeremy Allison
e096440b74
r14088: Fix Coverity bug #20 . Don't deref possible null.
...
Jeremy.
(This used to be commit 7f3ace5481e55ef845da28b9c0613a2ea0de0de4)
2007-10-10 11:11:11 -05:00