1
0
mirror of https://github.com/samba-team/samba.git synced 2025-07-30 19:42:05 +03:00
Commit Graph

17 Commits

Author SHA1 Message Date
120c09b125 From Steve Danneman @ Isilon.
Attached is the companion patch to
(037b9689d9), which
made handling of WINBINDD_LIST_GROUPS asynchronous.

Because most all of the list_groups code was reusable, I abstracted it,
and implemented both list_groups and list_users on top of it.

On my large test domain a "wbinfo -u" call went from 70 seconds to 30
seconds with this patch.  Plus, the parent process is no longer blocked
from receiving new requests during that time.

Steven Danneman | Software Development Engineer
Isilon Systems    P +1-206-315-7500     F +1-206-315-7501
www.isilon.com
(This used to be commit 5188f28611)
2008-06-26 14:02:39 -07:00
1a1fc2f814 Fix two c++ warnings
(This used to be commit 3b1dae7c31)
2008-05-25 13:53:45 +02:00
96653e1ff7 Make WINBINDD_LIST_GROUPS handler asynchronous.
Previously WINBINDD_LIST_GROUPS requests (ex: wbinfo -g) were handled by the
winbindd parent process in a sequential fashion.  This patch, delegates the work
to the winbindd children so that the request is handled much faster in large
domain topologies, and doesn't block the parent from receiving new requests.

The core group enumeration and conversion that was handled in
winbindd_list_groups() has been moved into winbindd_dual_list_groups() to be
done by the child.

The parent winbindd_list_groups() simply calls each of the children
asynchronously.

listgroups_recv() aggregates the final group list that will be returned to the
client and tracks how many of the children have returned their lists.

The domain name of the child is passed back through the callbacks to be used in
debugging messages.

There are also several fixes to typos in various comments.
(This used to be commit 037b9689d9)
2008-05-22 13:55:57 -05:00
497eb77099 Small whitespace cleanup + check for null returns on talloc_strdup.
Jeremy.
(This used to be commit 654484b9a2)
2008-02-05 16:51:46 -08:00
f3603d5a5a Convert add_sid_to_array() add_sid_to_array_unique() to return NTSTATUS.
Michael
(This used to be commit 6b2b9a60ef)
2008-01-09 01:47:10 +01:00
2e07c2ade8 s/sid_to_string/sid_to_fstring/
least surprise for callers
(This used to be commit eb523ba776)
2007-12-15 22:47:30 +01:00
14ef4cdec1 Replace sid_string_static with sid_to_string
This adds 28 fstrings on the stack, but I think an fstring on the stack is
still far better than a static one.
(This used to be commit c7c885078b)
2007-12-15 22:09:37 +01:00
d899b8c56a Use sid_to_string directly
It seems a bit pointless to do a fstrcpy(dst, sid_string_static(src))
(This used to be commit c221c246b1)
2007-12-15 22:09:36 +01:00
900288a2b8 Replace sid_string_static by sid_string_dbg in DEBUGs
(This used to be commit bb35e794ec)
2007-12-15 22:09:36 +01:00
c436c5aa0f Improve a debug message.
Michael
(This used to be commit 1ea3ec9271)
2007-12-06 01:51:53 +01:00
1e9e1b6fca r25568: move idmap related functions into their own file.
the final goal is to have 3 child dispatch tables
'domain', 'idmap' and 'locator' instead of one.

metze
(cherry picked from commit 97c63f1b95)
(This used to be commit a1c354866c)
2007-10-22 08:46:10 +02:00
e5cedc7611 r25567: make do_async() non static
metze
(cherry picked from commit badc714d7f)
(This used to be commit d623b2fa71)
2007-10-22 08:46:09 +02:00
30191d1a57 RIP BOOL. Convert BOOL -> bool. I found a few interesting
bugs in various places whilst doing this (places that assumed
BOOL == int). I also need to fix the Samba4 pidl generation
(next checkin).
Jeremy.
(This used to be commit f35a266b3c)
2007-10-18 17:40:25 -07:00
e5a951325a [GLUE] Rsync SAMBA_3_2_0 SVN r25598 in order to create the v3-2-test branch.
(This used to be commit 5c6c8e1fe9)
2007-10-10 15:34:30 -05:00
2f6fbb1c53 r25568: move idmap related functions into their own file.
the final goal is to have 3 child dispatch tables
'domain', 'idmap' and 'locator' instead of one.

metze
(This used to be commit 97c63f1b95)
2007-10-10 12:31:14 -05:00
adf5ac6f60 r25567: make do_async() non static
metze
(This used to be commit badc714d7f)
2007-10-10 12:31:14 -05:00
28aa4bff8d r25154: move winbindd code into winbindd/
metze
(This used to be commit 3ac7566ae1)
2007-10-10 12:30:46 -05:00