1
0
mirror of https://github.com/samba-team/samba.git synced 2025-02-05 21:57:51 +03:00

21634 Commits

Author SHA1 Message Date
Simo Sorce
51d296f251 r21607: While committing I saw I had not newline terminated this string ... 2007-10-10 12:18:16 -05:00
Simo Sorce
5b4838f62a r21606: Implement escaping function for ldap RDN values
Fix escaping of DN components and filters around the code
Add some notes to commandline help messages about how to pass DNs

revert jra's "concistency" commit to nsswitch/winbindd_ads.c, as it was
incorrect.
The 2 functions use DNs in different ways.

- lookup_usergroups_member() uses the DN in a search filter,
and must use the filter escaping function to escape it
Escaping filters that include escaped DNs ("\," becomes "\5c,") is the
correct way to do it (tested against W2k3).

- lookup_usergroups_memberof() instead uses the DN ultimately as a base dn.
Both functions do NOT need any DN escaping function as DNs can't be reliably
escaped when in a string form, intead each single RDN value must be escaped
separately.

DNs coming from other ldap calls (like ads_get_dn()), do not need escaping as
they come already escaped on the wire and passed as is by the ldap libraries

DN filtering has been tested.
For example now it is possible to do something like:
'net ads add user joe#5' as now the '#' character is correctly escaped when
building the DN, previously such a call failed with Invalid DN Syntax.

Simo.
2007-10-10 12:18:16 -05:00
Jeremy Allison
5ed61d5af6 r21605: Fix small typo noticed by Raúl Sánchez Siles <rss@barracuda.es>.
Jeremy.
2007-10-10 12:18:16 -05:00
Jeremy Allison
4a04555e23 r21604: I got this wrong also in libsmb :-(.
Jeremy.
2007-10-10 12:18:15 -05:00
Jeremy Allison
29761173ee r21603: Horrible backwards compatibility hack as an old server bug
allowed a CIFS client bug to remain unnoticed :-(.
I suck.
Jeremy.
2007-10-10 12:18:15 -05:00
Volker Lendecke
5ef0286b56 r21581: Add an error code I just got 2007-10-10 12:18:15 -05:00
Jeremy Allison
645b0438dd r21577: Remove unneeded #define (part of earlier patch that was
removed).
Jeremy.
2007-10-10 12:18:15 -05:00
Jeremy Allison
b81c5c6adc r21576: Patch based on work from Todd Stecher <todd.stecher@isilon.com>
to allow client to fragment large SPNEGO blobs (large krb5
tickets). Tested against W2K3R2. Should fix bug #4400.
Jeremy.
2007-10-10 12:18:14 -05:00
Jeremy Allison
8d45f1f3b5 r21569: Fix bug reported by Martin Zielinski <mz@seh.de>
where return value was incorrectly initialized.
Jeremy.
2007-10-10 12:18:14 -05:00
Jeremy Allison
b7d91ec1b2 r21566: If we're going to be broken, at least be *consistently*
broken :-). This will do until Simo fixes the escape
calls properly.
Jeremy.
2007-10-10 12:18:14 -05:00
Jelmer Vernooij
9a9b942167 r21565: Import ndrdump (doesn't compile yet, needs table support functions). 2007-10-10 12:18:14 -05:00
Volker Lendecke
4423880ff4 r21563: Fix a memleak: We only need dispinfo structs for "our" and for the builtin
domain. Without this patch we leaked a DISPINFO for the (NULL) domain per
samr_connect*() call.

Volker
2007-10-10 12:18:14 -05:00
Jelmer Vernooij
952f648d81 r21562: Regenerate gen_ndr after pidl changes. 2007-10-10 12:18:13 -05:00
Günther Deschner
76ba11d777 r21561: It makes absolutely no sense to call krb5_kt_resolve() two times
directly after another.

Guenther
2007-10-10 12:18:13 -05:00
Günther Deschner
28ce79629b r21560: Convert name_to_fqdn to BOOL.
Guenther
2007-10-10 12:18:13 -05:00
Günther Deschner
7b18a4730d r21558: Safe more indent, again no code changes.
Guenther
2007-10-10 12:18:13 -05:00
Günther Deschner
8ff0903a17 r21557: indent only fix. No code change.
Guenther
2007-10-10 12:18:13 -05:00
Günther Deschner
020601ea0a r21556: Remove superfluos return check in ads_keytab_verify_ticket().
Guenther
2007-10-10 12:18:13 -05:00
Lars Müller
95d2297974 r21552: Ensure to check for proto_exists before linking any binary. No make
proto should be required before creating any binary from now on.

Remove proto_exists from the all, pam_smbpass, and pam_bindind rule.
2007-10-10 12:18:12 -05:00
Volker Lendecke
f63189907e r21551: Ok, this is more subtle. More tomorrow :-) 2007-10-10 12:18:12 -05:00
Volker Lendecke
fad2ee8aa3 r21550: make disp_info_list static to get_samr_dispinfo_by_sid(), add a comment :-) 2007-10-10 12:18:12 -05:00
Volker Lendecke
0aceda68a8 r21549: Only create DISP_INFO structs for domain handles, the others don't need
them. It just does not make sense to do a querydispinfo on an alias handle...

This fixes a memleak: Every samr_connect*() call leaked a DISP_INFO for the
(NULL) sid.

More cleanup pending: Essentially, we only need the DISP_INFO cache for the
get_global_sam_sid() domain. BUILTIN is fixed and small enough, and there are
no other domains around where enumerations could happen.

This also removes the explicit builtin_domain flags. I don't think this is
worth it. If this makes a significant difference, then we have a *VERY* tuned
RPC layer...

Jeremy, please check this. If it's ok, we might want to merge it across.

Volker
2007-10-10 12:18:12 -05:00
Herb Lewis
b5fd72282d r21548: prevent segv (reference to -1 element of array) 2007-10-10 12:18:12 -05:00
Volker Lendecke
e795865d58 r21547: Fix from Michael Adam <ma@sernet.de>: Refuse registry shares without path.
Thanks,

Volker
2007-10-10 12:18:11 -05:00
Herb Lewis
934163782b r21546: remove duplicate lines 2007-10-10 12:18:11 -05:00
Günther Deschner
bc04004c18 r21543: Fix 64bit build warning.
Guenther
2007-10-10 12:18:11 -05:00
Günther Deschner
5889f588ee r21540: Fix Bug #3713 and readd reporting what the profiles tool does (when
called with the -v option).

Patch from William Jojo <jojowil@hvcc.edu>.

Guenther
2007-10-10 12:18:11 -05:00
Günther Deschner
a6c249b592 r21537: Avoid to trigger the confusing "cached entry differs." warning when
there is just no cache around for a user.

Guenther
2007-10-10 12:18:11 -05:00
Günther Deschner
7edbb636f7 r21536: Fix copy/paste typo.
Guenther
2007-10-10 12:18:11 -05:00
Jeremy Allison
773001870d r21530: Don't code with jet-lag and Volker looking over your
shoulder.... Correct fix for warning :-)
Jeremy.
2007-10-10 12:18:10 -05:00
Jeremy Allison
34675624e2 r21529: Fix warning from bad cast.
Jeremy.
2007-10-10 12:18:10 -05:00
Gerald Carter
1635bac800 r21526: Fix stray character in sys_memalign() that is only
is the case where we don't have memalign() or posix_memalign().
2007-10-10 12:18:10 -05:00
Gerald Carter
0d2b80c6c4 r21525: Go ahead and checkin the mlock() & memalign() fixes so
others don't get stuck with the winbindd hang.
Still waiting on additional confirmation from Guenther
that this fixes thes issues he was observing as well.
But it's been running in my local tree for a day without
problems.
2007-10-10 12:18:10 -05:00
Günther Deschner
82f1da8117 r21517: Fix build warnings.
Guenther
2007-10-10 12:18:09 -05:00
Lars Müller
c02921e95d r21509: Merge lp_passdb_backend() from rev 21506 to 3_0_25.
Slightly change the DEBUG 0 message as suggested by Volker on
samba-technical.
2007-10-10 12:18:09 -05:00
Simo Sorce
a5354aa9a0 r21508: Fix memleak in new idmap_tdb, thanks Herb.
Jerry please check.

Simo.
2007-10-10 12:18:09 -05:00
Gerald Carter
6a69caf690 r21507: Fix some "cannot access LDAP when no root" bugs.
The two culprits were

* pdb_get_account_policy()
* pdb_get_group_sid()
2007-10-10 12:18:09 -05:00
Lars Müller
5cd9a2e258 r21506: Allow old pre 3.0.22 multi passdb backend configurations to work with
post 3.0.23.

This implementation considers spaces in ldapsam configs.  Such configs
are trunkated after the closing quote.
2007-10-10 12:18:09 -05:00
Gerald Carter
52e6a2ceab r21505: make sure mlock()'d memory is aligned on a page boundary 2007-10-10 12:18:08 -05:00
Günther Deschner
c3005c48cd r21500: Fix inappropriate creation of a krb5 ticket refreshing event when a user
changed a password via pam_chauthtok. Only do this if

a) a user logs on using an expired password (or a password that needs to
be changed immediately) or

b) the user itself changes his password.

Also make sure to delete the in-memory krb5 credential cache (when a
user did not request a FILE based cred cache).

Finally honor the krb5 settings in the first pam authentication in the
chauthtok block (PAM_PRELIM_CHECK). This circumvents confusion when
NTLM samlogon authentication is still possible with the old password after
the password has been already changed (on w2k3 sp1 dcs).

Guenther
2007-10-10 12:18:08 -05:00
Jeremy Allison
4a74d042c9 r21483: Fix use of uninitialized variable.
Jeremy.
2007-10-10 12:18:08 -05:00
Jeremy Allison
42a846b3df r21482: Use IPC$ not ipc$ for consistency.
Jeremy.
2007-10-10 12:18:07 -05:00
Jeremy Allison
90bdcce765 r21481: No one said anything, so I'm disallowing anything
but explicit shares in "default service" :-).
Jeremy.
2007-10-10 12:18:07 -05:00
Jeremy Allison
71dd02cc16 r21480: Make fd_open match fd_close be translating
errno into an NTSTATUS immediately.
Jeremy.
2007-10-10 12:18:07 -05:00
Jeremy Allison
6be078da26 r21478: Add 65k length limit for split SPNEGO blobs.
Jeremy
2007-10-10 12:18:07 -05:00
Jeremy Allison
08998b74a5 r21474: Ensure trustdom_cache_shutdown() gets called
on terminate. Pointed out by Herb.
Jeremy.
2007-10-10 12:18:07 -05:00
Alexander Bokovoy
5876bedda5 r21467: Add GPFS-provided DMAPI support based on their GPL library 2007-10-10 12:18:06 -05:00
Jelmer Vernooij
e73a418b5b r21462: Fix EnumValue (?) 2007-10-10 12:18:06 -05:00
Volker Lendecke
e7e6b8b5e0 r21461: Not strictly necessary, as data_blob() panics if it can't allocate. But I'd
see this as a design flaw in data_blob() and it made me look in that routine.

Jeremy, revert or merge please :-)

Volker
2007-10-10 12:18:06 -05:00
Jeremy Allison
aa69f2481a r21460: Fix for server-side processing of SPNEGO auth
fragmented into "max xmit" size security blob
chunks. Bug #4400. Needs limits adding, and also
a client-side version.
Jeremy.
2007-10-10 12:18:06 -05:00