1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Commit Graph

25 Commits

Author SHA1 Message Date
Alexander Bokovoy
eb029b32e9 s4: libcli/finddcs_cldap: continue processing CLDAP until all addresses are used
This is a subtle bug that causes CLDAP pings to fail if SRV records
discovered cannot be resolved or connection to them cannot be
established. The code that fires up CLDAP ping will silently cancel
the whole tevent request without going to the next server in the queue.

This may happen, for example, when connection to IPv6 addresses couldn't
be established, or when IPv4 address is not online or blocked by
firewall.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11284

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
2015-05-20 19:29:30 +02:00
Volker Lendecke
d672535551 libcli: Fix improper use of tevent_req_simple_recv_ntstatus
tevent_req_simple_recv_ntstatus is just for the simple return without
anything to do after it.

Signed-off-by: Volker Lendecke <vl@samba.org>

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-08-12 17:25:58 +12:00
Stefan Metzmacher
a42c49c93a s4:libcli/finddcs_cldap: allow io->in.server_address as hostname
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
2012-12-02 23:24:58 +01:00
Stefan Metzmacher
c4d51d8d17 s4:libcli/finddcs_cldap: try all NBT#1C addresses
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
2012-12-02 23:19:28 +01:00
Matthias Dieter Wallnöfer
ad19aa6331 s4:libcli/finddcs_cldap.c - let "finddcs_cldap" work either with the IP address or the domain name
This will be useful for a new "samba-tool domain info" command.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-11-26 10:26:52 +01:00
Stefan Metzmacher
88bcdbb16a s4:finddcs_cldap: debug the correct server address instead of NULL
metze
2011-11-10 14:59:10 +01:00
Stefan Metzmacher
60d9afa806 s4:finddcs_cldap: talloc free old memory before allocating a new netlogon struct
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sat Oct 22 04:55:54 CEST 2011 on sn-devel-104
2011-10-22 04:55:53 +02:00
Stefan Metzmacher
7e4e4d0909 s4:finddcs_cldap: close the socket when it's not used anymore
The amount of possible fd's might be restricted, so close them early.

metze
2011-10-22 03:20:09 +02:00
Stefan Metzmacher
40dc29bca7 s4:finddcs_cldap: finddcs_cldap_recv() returns NTSTATUS
We need to convert the errno based error to NTSTATUS
before calling tevent_req_error (via tevent_req_nterror).

metze
2011-10-22 03:11:57 +02:00
Matthieu Patou
950f1218b3 s4-cldap: fix cldap_socket_init to always specify the dest if local is NULL
Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Sat Oct 22 00:02:00 CEST 2011 on sn-devel-104
2011-10-22 00:01:59 +02:00
Stefan Metzmacher
b787b6e1bd libcli/cldap: don't pass tevent_context to cldap_socket_init()
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Oct 10 23:23:07 CEST 2011 on sn-devel-104
2011-10-10 23:23:07 +02:00
Stefan Metzmacher
2cd76b0931 libcli/cldap: pass tevent_context to cldap_netlogon_send()
metze
2011-10-10 21:50:26 +02:00
Matthias Dieter Wallnöfer
34c5bdc1c3 s4:libcli/finddc.h - fix header dependancies
And optimise includes
2010-12-12 20:06:24 +01:00
Andrew Tridgell
ce203c001d s4-cldap: fixed debug message to match content
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Sat Nov  6 04:26:45 UTC 2010 on sn-devel-104
2010-11-06 04:26:45 +00:00
Andrew Tridgell
158ae8a148 s4-cldap: print all the DNS servers found
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-11-05 23:42:09 +11:00
Andrew Tridgell
bda626da81 s4-finddcs: better debug messages to help track down DNS problems
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-10-15 09:32:03 +00:00
Andrew Bartlett
5742f5115c libcli/security Use common security.h
This includes dom_sid.h and security_token.h and will be moved
to the top level shortly.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Oct 12 03:35:36 UTC 2010 on sn-devel-104
2010-10-12 03:35:36 +00:00
Andrew Tridgell
a360428588 s4-finddcs: allow override of server IP address
this will be used to implement --ipaddress option to net commands

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
2010-09-25 10:38:45 -07:00
Andrew Tridgell
1555659e78 s4-cldap: improved debug msgs in finddcs_cldap() 2010-09-19 13:36:02 -07:00
Andrew Tridgell
50f56c6a82 s4-finddcs: added some debug messages on failure 2010-09-19 11:29:32 -07:00
Andrew Tridgell
beb9c6be70 s4-finddcs: ensure we free previous cldap requests before starting a new one 2010-09-15 15:39:36 +10:00
Andrew Tridgell
6012f31115 s4-finddcs: show required server type bits on failure
when we skip a DC because it doesn't have the required server type
bits, show what bits we wanted

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-09-15 15:39:36 +10:00
Andrew Tridgell
59d415f43f s4-finddc: use NBT lookup for a 1C name if joining a short domain name
once we get the 1C lookup reply, use a CLDAP query to find the details
for the server

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-09-15 15:39:36 +10:00
Andrew Tridgell
58d59a08ad s4-libcli: change finddcs.h -> finddc.h
this prevents conflicts with old generated files and we can only even
return one DC with this interface.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-09-15 15:39:35 +10:00
Andrew Tridgell
898674cb1c s4-finddcs: added finddcs_cldap()
this finds DCs with a specified set of server_type bit using SRV
lookups and CLDAP

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-09-15 15:39:35 +10:00