1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-26 10:04:02 +03:00

22 Commits

Author SHA1 Message Date
Garming Sam
952bc3cad0 Remove a number of NT_STATUS_HAVE_NO_MEMORY_AND_FREE macros from the codebase.
Following the current coding guidelines, it is considered bad practice to return from
within a macro and change control flow as they look like normal function calls.

Change-Id: I133eb5a699757ae57b87d3bd3ebbcf5b556b0268
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2014-03-05 16:33:21 +01:00
Volker Lendecke
490418d636 gpo: Fix CID 1034880 Resource leak
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>

Autobuild-User(master): Ira Cooper <ira@samba.org>
Autobuild-Date(master): Mon Nov 11 22:59:10 CET 2013 on sn-devel-104
2013-11-11 22:59:10 +01:00
Volker Lendecke
4d97b5dcca gpo: Fix CID 1034881 Resource leak
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
2013-11-11 21:04:09 +01:00
Andreas Schneider
aa6cc31ef9 s4-policy: Fix memory leaks in push_recursive().
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22 16:36:14 +01:00
Andreas Schneider
7b5fb7d9e8 replace: Add don't include unistd.h directly and add uid_wrapper. 2011-10-27 13:32:02 +02:00
Jelmer Vernooij
c0fe5e095d s4/libpolicy: Install header file. 2011-08-21 03:22:05 +02:00
Amitay Isaacs
6cce5fd43e s4-policy: Use the correct local directory for stat.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-03 14:25:57 +10:00
Matthias Dieter Wallnöfer
9d4dc69627 s4:lib/policy/gp_filesys.c - remove dead code
Found out by Solaris cc
2010-09-10 22:45:50 +02:00
Andrew Tridgell
6b266b85cf s4-loadparm: 2nd half of lp_ to lpcfg_ conversion
this converts all callers that use the Samba4 loadparm lp_ calling
convention to use the lpcfg_ prefix.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-16 18:24:27 +10:00
Matthias Dieter Wallnöfer
58715dd365 s4:libpolicy - fix printf output specifiers to suppress warning 2010-06-20 20:34:48 +02:00
Matthias Dieter Wallnöfer
26bcbf6e35 s4:libpolicy - Solaris compatibility fix 2010-06-20 20:25:00 +02:00
Wilco Baan Hofman
04133225c1 Refactor policy filesystem code.
* It now uses reusable code to download the GPT.
 * It creates a list before copying for better error handling.
 * String_replace is now used instead of manually replacing '\\' with '/'
   for local paths.
 * A security check has been added for file names with "../".
 * It adheres to the 80 column rule, if at all possible.

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-06-20 17:19:13 +02:00
Wilco Baan Hofman
b9b85d6b0e Fix memory allocation with error handling.
Also moved pypolicy.c headers around so as not to generate compile warnings

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-06-20 17:19:13 +02:00
Wilco Baan Hofman
d61f0240ee Fix 'magic' numbers to be strlen(something)
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-06-20 17:19:12 +02:00
Wilco Baan Hofman
3fe793fce7 Remove iconv convenience in used functions, which were deleted in commit f9ca9e46ad24036bf00cb361a6cef4b2e7e98d7d
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-06-20 17:19:12 +02:00
Wilco Baan Hofman
5434171296 Fix set GPT security descriptor to match windows' behaviour.
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-06-20 17:19:12 +02:00
Wilco Baan Hofman
299531ce32 Add preliminary NT ACL support for GPT (GPO on filesystem).
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-06-20 17:19:11 +02:00
Wilco Baan Hofman
41fae89daf Add gpo create functionality. Also fix gPLink handling bugs
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-06-20 17:19:11 +02:00
Wilco Baan Hofman
32ee6f8cfd Fix mode_t in mkdir.
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-06-20 17:19:11 +02:00
Wilco Baan Hofman
2b761c3def Optimize the backslash logic in the path traversal.
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-06-20 17:19:11 +02:00
Wilco Baan Hofman
f24f472d44 Fix error in logic, making recursion work past the first level.
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-06-20 17:19:11 +02:00
Wilco Baan Hofman
3b11a53304 Add fetch function for GPO which fetches all relevant files from the sysvol share.
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-06-20 17:19:11 +02:00