sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-05 21:57:51 +03:00
Code
49,139 Commits 60 Branches 1,146 Tags
Commit Graph

12 Commits

Author SHA1 Message Date
Steven Danneman
778a5414b1 Fix bug 5419: memory leak in ads_do_search_all_args() when enumerating 1000s of entries 
The ads_do_search_all_args() function attempts to string together several
LDAPMessage structures, returned across several paged ldap requests, into a
single LDAPMessage structure.  It does this by pulling entries off the second
LDAPMessage structure and appending them to the first via the OpenLDAP specific
ldap_add_result_entry() call.

The problem with this approach is it skips non-entry messages such as the
result, and controls.  These messages are leaked.

The short term solution as suggested by Volker is to replace the ads_*_entry()
calls with ads_*_message() calls so we don't leak any messages.

This fixes the leak but doesn't remove the dependence on the OpenLDAP specific
implementation of ldap_add_result_entry().
(This used to be commit f1a5405409c396df394611e2a234522572d2860a)
 2008-04-26 08:11:20 -07:00
Günther Deschner
b076a7e802 Add ads_get_joinable_ous(). 
Guenther
(This used to be commit 5bbceac88159ef6ff83d9cc62c77c7af2116967d)
 2008-01-03 18:15:59 +01:00
Jeremy Allison
30191d1a57 RIP BOOL. Convert BOOL -> bool. I found a few interesting 
bugs in various places whilst doing this (places that assumed
BOOL == int). I also need to fix the Samba4 pidl generation
(next checkin).
Jeremy.
(This used to be commit f35a266b3cbb3e5fa6a86be60f34fe340a3ca71f)
 2007-10-18 17:40:25 -07:00
Gerald (Jerry) Carter
e5a951325a [GLUE] Rsync SAMBA_3_2_0 SVN r25598 in order to create the v3-2-test branch. 
(This used to be commit 5c6c8e1fe93f340005110a7833946191659d88ab)
 2007-10-10 15:34:30 -05:00
Günther Deschner
c252b04abf r23834: Allow to pass an ADS_STRUCT pointer down to the dump function callback in 
libads.

Guenther
(This used to be commit 311bbbafa6d860b7b632beac6d9249b0a2fafb86)
 2007-10-10 12:28:32 -05:00
Günther Deschner
83564b43e3 r22800: Add GPO_SID_TOKEN and an LDAP function to get tokensids from the tokenGroup attribute. 
Guenther
(This used to be commit e4e8f840605dfdf92ca60cc8fc6a4c85336565fb)
 2007-10-10 12:21:59 -05:00
Günther Deschner
9c170fce26 r22797: We are only interested in the DACL of the security descriptor, so search with 
the SD_FLAGS control.

Guenther
(This used to be commit 648df57e53ddabe74052e816b8eba95180736208)
 2007-10-10 12:21:57 -05:00
Günther Deschner
53ac6a5abf r22465: Last attempt to fix the build before dinner. 
Guenther
(This used to be commit f6ade770bdd3e2b14e8db367c40167f49d6c6fa0)
 2007-10-10 12:19:36 -05:00
Günther Deschner
04724b8451 r22463: Add prototype. 
Guenther
(This used to be commit 4984af2c66754e9b6eed3020b3056ccf14d19617)
 2007-10-10 12:19:35 -05:00
Andrew Tridgell
78f2900a16 r18869: two build fixes for systems without ldap 
the first is to not enable the ldap ldb backend just yet. This will
need configure tests to conditionally include. We should be able to
use the m4 files from lib/ldb/

The 2nd is to fix libads/gpo.o not to publicly prototype a function
that needs ldap.h
(This used to be commit 1cf17edc14ebd379b982b589a66e86316ef7087b)
 2007-10-10 12:14:39 -05:00
Jeremy Allison
664c3f4166 r18663: Fix one more uuid -> GUID. 
Jeremy.
(This used to be commit e568271af2b5c20cff70b72b8ab4b1b704122b40)
 2007-10-10 12:00:44 -05:00
Volker Lendecke
ee0e397d6f r18019: Fix a C++ warnings: Don't use void * in libads/ for LDAPMessage anymore. 
Compiled it on systems with and without LDAP, I hope it does not break the
build farm too badly. If it does, I'll fix it tomorrow.

Volker
(This used to be commit b2ff9680ebe0979fbeef7f2dabc2e3f27c959d11)
 2007-10-10 11:39:49 -05:00