1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-24 21:34:56 +03:00
Commit Graph

45 Commits

Author SHA1 Message Date
Jelmer Vernooij
ddcab787c4 Rename dos_errstr() to win_errstr() for consistency with Samba 4. 2008-11-01 17:19:26 +01:00
Jeremy Allison
e5692d4cbe Remove SEC_ACCESS. It's a uint32_t.
Jeremy.
2008-10-09 09:49:03 -07:00
Jeremy Allison
dc3a0acdaa Ensure all pointers are initialized. Without this we can crash when looking up a non-existant uid.
Jeremy.
2008-09-17 12:02:13 -07:00
Michael Adam
8829b424fe svcctl: use MODULESDIR instead of LIBDIR for the svcctl script directory.
Michael
(This used to be commit bb19634138)
2008-08-15 23:19:58 +02:00
Volker Lendecke
2b7fca9e79 Revert "Fix a memleak in svcctl_init_keys()"
This reverts commit b1afb31f3c.

This one is very strange: I need to investigate why valgrind showed it as
leaking, and why in my initial tests this did not fail.
(cherry picked from commit 24730f5981)
(This used to be commit b1e8e5d173)
2008-06-18 16:31:35 +02:00
Volker Lendecke
04e697891b Fix a memleak in svcctl_init_keys()
(This used to be commit 675bb53398)
2008-06-17 16:09:22 +02:00
Marc VanHeyningen
e06aa46b9f Coverity fixes
(This used to be commit 3fc85d2259)
2008-03-17 20:52:25 +01:00
Michael Adam
8ba088516a Fix segfault in svcctl_get_secdesc(): prevent premature TALLOC_FREE.
This crash was triggered by (e.g.) net rpc service status.
This patch prevents premature freeing of memory and creates a
common exit point to the function.

Michael
(This used to be commit f1fb9fd6f1)
2008-02-18 17:41:19 +01:00
Michael Adam
5cd707f82c Add a check for success of fetch_reg_values().
Michael
(This used to be commit ba69097f37)
2008-02-18 17:41:19 +01:00
Michael Adam
1638941ba2 Fix a comment typo.
Michael
(This used to be commit 00e2dd36b3)
2008-02-18 17:41:19 +01:00
Michael Adam
59c0aa3afd Fix two debug messages.
Michael
(This used to be commit 35e23368dd)
2008-01-21 22:49:45 +01:00
Volker Lendecke
99b86e4a26 Some C++ fixes
(This used to be commit 5c392c4c6e)
2007-12-21 09:58:21 +01:00
Jeremy Allison
e3efe7cd7e More static fstring elimination.
Jeremy.
(This used to be commit b4dfec09e8)
2007-12-17 18:00:43 -08:00
Jeremy Allison
7faee02d0d Remove the char[1024] strings from dynconfig. Replace
them with malloc'ing accessor functions. Should save a
lot of static space :-).
Jeremy.
(This used to be commit 52dc5eaef2)
2007-12-10 11:30:37 -08:00
Jeremy Allison
a0f7c3f481 Remove pstring from services/*.c
Jeremy.
(This used to be commit 33aa866195)
2007-11-20 17:57:47 -08:00
Jeremy Allison
30191d1a57 RIP BOOL. Convert BOOL -> bool. I found a few interesting
bugs in various places whilst doing this (places that assumed
BOOL == int). I also need to fix the Samba4 pidl generation
(next checkin).
Jeremy.
(This used to be commit f35a266b3c)
2007-10-18 17:40:25 -07:00
Gerald (Jerry) Carter
e5a951325a [GLUE] Rsync SAMBA_3_2_0 SVN r25598 in order to create the v3-2-test branch.
(This used to be commit 5c6c8e1fe9)
2007-10-10 15:34:30 -05:00
Volker Lendecke
f708132de7 r25561: Make use of [un]marshall_sec_desc
Minor cleanup only
(This used to be commit 4dc4364b68)
2007-10-10 12:31:13 -05:00
Volker Lendecke
ff0947fbed r24949: Remove some static buffers
(This used to be commit df648d47ff)
2007-10-10 12:30:29 -05:00
Herb Lewis
c7b9f06647 r24290: fix debug statments to match function name
(This used to be commit 5ee0bfde50)
2007-10-10 12:29:25 -05:00
Andrew Tridgell
153cfb9c83 r23801: The FSF has moved around a lot. This fixes their Mass Ave address.
(This used to be commit 87c91e4362)
2007-10-10 12:28:27 -05:00
Jeremy Allison
d824b98f80 r23779: Change from v2 or later to v3 or later.
Jeremy.
(This used to be commit 407e6e695b)
2007-10-10 12:28:20 -05:00
Volker Lendecke
ff61853fb3 r20069: Fix logic bug I introduced
(This used to be commit d935ecec98)
2007-10-10 12:16:23 -05:00
Volker Lendecke
ecf90c495e r19991: Sorry for this 2000-liner...
The main thing here is a rewrite of srv_winreg_nt.c. The core functionality
has moved to registry/reg_api.c which is then usable by the rest of Samba as
well.

On that way it fixes creating keys with more than one element in the
path. This did not work before.

Two things that sneaked in (sorry :-) is the change of some routines from
NTSTATUS to WERROR the removed "parent" argument to regkey_open_internal.

Volker
(This used to be commit fea52801de)
2007-10-10 12:16:18 -05:00
Volker Lendecke
1c91cca86e r19947: Change regkey_open_internal to take the parent key and a talloc_ctx as
arguments. This also replaces regkey_close_internal by TALLOC_FREE.

Volker
(This used to be commit a177bbb2d5)
2007-10-10 12:16:14 -05:00
Volker Lendecke
bfad442144 r19780: Ok, regkey_open_internal needs a regkey_close_internal. Giving a talloc ctx is
misleading here. This needs fixing properly :-)

Volker
(This used to be commit f808182346)
2007-10-10 12:15:55 -05:00
Volker Lendecke
e82cd437cc r19778: Make regkey_open_internal take a talloc ctx
(This used to be commit cb7f4211b8)
2007-10-10 12:15:55 -05:00
Gerald Carter
bdfeaf2bcf r17148: the wins service should not accept any controls so that a GUI can grey it out as not remotely manageable
(This used to be commit 859c51cf25)
2007-10-10 11:38:16 -05:00
Jeremy Allison
fbdcf2663b r16945: Sync trunk -> 3.0 for 3.0.24 code. Still need
to do the upper layer directories but this is what
everyone is waiting for....

Jeremy.
(This used to be commit 9dafb7f48c)
2007-10-10 11:19:14 -05:00
Volker Lendecke
58e00365c6 r14132: Fix Coverity bug # 150.
Jerry, you might want to check this.

Thanks

Volker
(This used to be commit 9ec671c2f8)
2007-10-10 11:15:12 -05:00
Gerald Carter
ef3f2c9675 r13393: Do not initialize the lp_svcctl_list() value since it is handled
internally in services_db.c now.  This prevents internal services from
being listed twice (one internal and one external) when no
'svcctl list' parameter is explcitly set in smb.conf
(This used to be commit 6c4ede6cee)
2007-10-10 11:09:58 -05:00
Gerald Carter
e7a1a0ead2 r12914: adding query/set ops for security descriptors on services.
(This used to be commit cefd2d7cb6)
2007-10-10 11:06:07 -05:00
Gerald Carter
31c73b9913 r12281: adding a note about WINS and NetLogon not being remotely manageable
(This used to be commit b86528865a)
2007-10-10 11:05:51 -05:00
Gerald Carter
a489553067 r12173: doing some service control work
* Add a few new error codes for disabled services
* dump some more details about service status in 'net rpc service'
* disable the WINS and NetLogon services if not configured in smb.conf

Still trying to figure out how to disable the start button
on the NetLogon and WINS services.
(This used to be commit c0f54eeebc)
2007-10-10 11:05:47 -05:00
Gerald Carter
65540512df r11830: patch from Rashid N. Achilov <shelton@granch.ru> to add descriptions for some common services
(This used to be commit 69e168197e)
2007-10-10 11:05:29 -05:00
Gerald Carter
77460a9075 r11579: syncing up perf counter code cfrom trunk
(This used to be commit 59c00924b6)
2007-10-10 11:05:21 -05:00
Jeremy Allison
8d7c886671 r11137: Compile with only 2 warnings (I'm still working on that code) on a gcc4
x86_64 box.
Jeremy.
(This used to be commit d720867a78)
2007-10-10 11:05:02 -05:00
Gerald Carter
de0776cdaa r10961: remove unused variables (patch from Jason Mader)
(This used to be commit d6c6562d33)
2007-10-10 11:04:58 -05:00
Gerald Carter
01a1e5cdb0 r10819: merging a couple of fixes from trunk
* only keep the registry,tdb file open when we have an open key handle
* tpot's setup.py fix
* removing files that no longer exist in trunk and copying some
  that were missing in 3.0
(This used to be commit 6c6bf6ca5f)
2007-10-10 11:04:54 -05:00
Gerald Carter
0bf72b6e33 r10781: merging eventlog and svcctl code from trunk
(This used to be commit f10aa9fb84)
2007-10-10 11:04:53 -05:00
Gerald Carter
54abd2aa66 r10656: BIG merge from trunk. Features not copied over
* \PIPE\unixinfo
* winbindd's {group,alias}membership new functions
* winbindd's lookupsids() functionality
* swat (trunk changes to be reverted as per discussion with Deryck)
(This used to be commit 939c3cb5d7)
2007-10-10 11:04:48 -05:00
Gerald Carter
b162a396fe r7624: * removed unmatched tdb_lock_by_string() call (should fix build farm issues)
* comment out services.tdb code until I finish rewriting it
(This used to be commit 707b782228)
2007-10-10 10:57:17 -05:00
Gerald Carter
5b678f7a84 r7610: can successfully stop and start the 'spooler' service by setting the state for the 'disable spoolss' parameter in memory for an individual smbd
(This used to be commit f19c10d0c3)
2007-10-10 10:57:16 -05:00
Gerald Carter
899bc3a07d r7603: * fix a bug in the SERVICE_ALL_ACCESS security mask
* add calls to start and stop a service (to be filled
  in by the backend routines in services/svc_*.c
(This used to be commit 793d28a946)
2007-10-10 10:57:15 -05:00
Gerald Carter
2851e43e48 r7595: start trying to split out the svcctl functions into separate files for better maintenance; add SERVICE_CONTROL_OPS for spoolss service
(This used to be commit 2b0ea30a1a)
2007-10-10 10:57:15 -05:00