1
0
mirror of https://github.com/samba-team/samba.git synced 2025-02-05 21:57:51 +03:00

277 Commits

Author SHA1 Message Date
Volker Lendecke
2646fce633 Fix srvsvc_Net[Get|Set]FileSecurity
There were two bugs in those routines: They did not send INTERNAL_OPEN_ONLY to
open_file_ntcreate() and they did not chdir, so the file could never be found.

While there I decided to remove the become_root() calls and call create_file()
instead of the lower-level routines.
(This used to be commit 669771738422776f8c81086ffea4924b62d72957)
2008-07-27 17:59:15 +02:00
Volker Lendecke
c5401a2a46 Correct calculation of "remark" in srv_srvsvc_nt.c
Very likely the client is not interested in the values for the IPC$ share :-)
(This used to be commit 40ca5764cf4310769c002b8cb6041fe2af4e6d0b)
2008-06-24 10:31:35 +02:00
Jeremy Allison
6811dc3fc2 Allow server manager to close open files selected by id.
Jeremy.
(This used to be commit 7eeed8bb41059ec2bddedb6a71deddeec7f33af2)
2008-05-27 11:25:46 -07:00
Jeremy Allison
d83931cb6e Remove MAX_SESS_ENTRIES and MAX_CONN_ENTRIES limits
as they are no longer needed now we have IDL marshalling.
Change the calculation of the 32-bit fileid we return
to a Windows client. We can't just use the generation
count as it starts at zero for every smbd - and this
command must enumerate all files open across all smbds.
We'd really like combination of process-id + dev + inode +
generation count to be unique, but as we can't fit that
into 32 bits just use 16 bits of pid + generation count.
Jeremy.
(This used to be commit 8b926d5a93d04b828990057ae6f1e090764305c1)
2008-05-22 16:23:07 -07:00
Jeremy Allison
508d0310e7 Revert "Arggh. Got the path/user the wrong way around. IDL is correct :-)."
This reverts commit 1078b5c53ae9d6f9532eecebf9cf4a1712200b7e.

This message doesn't match the actual change.
(This used to be commit a65abb49cf8d291c7deb659912c0df34ec37da02)
2008-05-22 16:20:25 -07:00
Jeremy Allison
8c926ed0ea Arggh. Got the path/user the wrong way around. IDL is correct :-).
Jeremy.
(This used to be commit 1078b5c53ae9d6f9532eecebf9cf4a1712200b7e)
2008-05-22 16:19:26 -07:00
Jeremy Allison
ac65ed4aad Arggh. Got the path/user the wrong way around. IDL is correct :-).
Jeremy.
(This used to be commit 2281274480d8cf9e773874301dbbc7bf06346901)
2008-05-22 14:36:09 -07:00
Jeremy Allison
537dc11bf4 Fix 2 bugs with displaying open file state. Firstly
the IDL is documented incorrectly in the MS-DOCS.
Username and path need to be reversed (yes I will
raise this with MS). Secondly, we need to check
access_mask for the permissions, not share_access
(share_access are the deny modes).
Jeremy.
(This used to be commit bdaad19f90e991aba2afccfa13afbbfe2ac7baaf)
2008-05-22 14:28:13 -07:00
Jeremy Allison
3f76504d92 Remove a couple of uses of SMB_VFS_GET_NT_ACL(), use
SMB_VFS_FGET_NT_ACL instead. I'd like to ultimately
remove SMB_VFS_GET_NT_ACL.
Jeremy.
(This used to be commit 4221937b68e2414295279b27c5f12a80f826ed4b)
2008-05-09 11:14:45 -07:00
Jeremy Allison
00b2cdf75e Yay ! Remove a VFS entry. Removed the set_nt_acl() call,
this can only be done via fset_nt_acl() using an open
file/directory handle. I'd like to do the same with
get_nt_acl() but am concerned about efficiency
problems with "hide unreadable/hide unwritable" when
doing a directory listing (this would mean opening
every file in the dir on list).
Moving closer to rationalizing the ACL model and
maybe moving the POSIX calls into a posix_acl VFS
module rather than having them as first class citizens
of the VFS.
Jeremy.
(This used to be commit f487f742cb903a06fbf2be006ddc9ce9063339ed)
2008-05-08 18:09:07 -07:00
Jeremy Allison
b430b38220 Remove the "stat_open()" function, flag, and all associated code. It was only
being (correctly) used in the can_read/can_write checks for hide unreadable/unwritable
and this is more properly done using the functions in smbd/file_access.c.
Preparing to do NT access checks on all file access.
Jeremy.
(This used to be commit 6bfb06ad95963ae2acb67c4694a98282d3b29faa)
2008-05-02 17:22:10 -07:00
Günther Deschner
a3991c9ef4 Fix SRVSVC ShareInfo level 502 server side handling.
Guenther
(This used to be commit 776facabf6f09f643d6dc526aa83f8db517465f9)
2008-04-01 00:26:32 +02:00
Günther Deschner
9afc225b37 Fix SRVSVC ShareInfo max_users handling server side.
Guenther
(This used to be commit b4d944e724f7ae2a97ba788b185aba7b7308b475)
2008-04-01 00:26:32 +02:00
Günther Deschner
dbe34cf0ae Fix _srvsvc_NetShareSetInfo.
Guenther
(This used to be commit 2fd90b62d7e61fa0c23f8f41e9f12fc16f29a8b1)
2008-04-01 00:26:32 +02:00
Volker Lendecke
35cab4a8c2 Fix Coverity ID 548
Günther, please check -- in all infolevels we do a comment=talloc_strdup

Thanks,

Volker
(This used to be commit e2021c5b5710768968ae724220eb1e3f47c9e639)
2008-03-21 10:28:33 +01:00
Günther Deschner
7c8e66210d Add my copyright.
Guenther
(This used to be commit 4689057f63599ebaf9ce658ca3b3168b2bbe531f)
2008-03-21 04:16:22 +01:00
Günther Deschner
1dc52e8fbf Move MAX.*ENTRY definitions out of old rpc srvsvc parsing code.
Guenther
(This used to be commit 4e36657275caa77bc9712fe627aeb6fe4aefc151)
2008-03-21 04:16:21 +01:00
Günther Deschner
08213f706e Use pidl for _srvsvc_NetSessEnum().
Guenther
(This used to be commit 5d14938b14f8e59608771b1899fd473d63f3bde1)
2008-03-21 04:16:21 +01:00
Günther Deschner
a6bbefa1cb Use pidl for _srvsvc_NetConnEnum().
Guenther
(This used to be commit b8714e03e70070b5dfb1a0b15b191dfac0634c44)
2008-03-21 04:16:21 +01:00
Volker Lendecke
5346641c1c Fix an uninitialized variable warning
(This used to be commit 4cc09ec40609484c973361a0cc0f05bfaef1738e)
2008-03-20 16:54:05 +01:00
Günther Deschner
63a6acdfa8 Use pidl for _srvsvc_NetFileEnum.
Guenther
(This used to be commit 6c6700ed7148b73b2ce52fc00020c7e253a577d3)
2008-03-19 02:18:46 +01:00
Michael Adam
16f4e059f7 init_srv_share_info_ctr: fix counting of services.
The number of services was recorded too early leading to
registry shares not showing up in browse lists.

Guenther - please check.

Michael
(This used to be commit 737e470e02d1233fda51e903f27955e45427e95a)
2008-03-12 02:12:34 +01:00
Michael Adam
b371db93bb init_srv_share_info_ctr: Add debug messages.
Michael
(This used to be commit 8b2cc36ffcb3bccb760ec7cb0a22558eab56070d)
2008-03-12 02:12:34 +01:00
Günther Deschner
2a40d67041 Trying to fix resume_handling for srvsvc_NetShareEnumAll.
Guenther
(This used to be commit 874a0ffd7dbd993230c00c503ec6b27fbffb7745)
2008-03-11 11:33:07 +01:00
Günther Deschner
b960bc265b Use pidl for _srvsvc_NetDiskEnum.
Guenther
(This used to be commit 933d546f86b48bfd9f84045ec21efc1c362b4d93)
2008-03-11 10:48:52 +01:00
Günther Deschner
ca354276ca Use pidl for _srvsvc_NetSessDel().
Guenther
(This used to be commit 8a10bc13aee7c34f466fa69773694be97f0e7d85)
2008-03-10 03:43:39 +01:00
Günther Deschner
fa58ebd8f7 Use pidl for _srvsvc_NetGetFileSecurity.
Guenther
(This used to be commit 8b016efeb0bb4cd5d91928952a258fce1b6f97d0)
2008-03-08 23:07:00 +01:00
Günther Deschner
3102609c4b Use pidl for _srvsvc_NetSetFileSecurity.
Guenther
(This used to be commit 64a121c147c825259a06a8cd8de85ec31dd5b4a4)
2008-03-08 23:07:00 +01:00
Günther Deschner
45c91e7d75 Use pidl for _srvsvc_NetShareAdd.
Guenther
(This used to be commit fd3e7728181e7a208706e477905173bec44c982e)
2008-03-08 00:22:44 +01:00
Günther Deschner
9beec265bc Use pidl for _srvsvc_NetNameValidate.
Guenther
(This used to be commit 2e1df306785296979ea064006402254e318e946b)
2008-03-07 23:51:34 +01:00
Günther Deschner
ad3a1b8475 Use pidl for _srvsvc_NetShareDel and _srvsvc_NetShareDelSticky.
Guenther
(This used to be commit 73b6587493d9a987a691ece495db9f42ce562efe)
2008-03-07 23:26:00 +01:00
Günther Deschner
7b75317989 Use pidl for _srvsvc_NetShareGetInfo, _srvsvc_NetShareEnum and srvsvc_NetShareEnumAll.
Fixing resume handling while we are there.

Guenther
(This used to be commit 128637bdd7c37ca166a7d478b33b00c39f0ede62)
2008-03-07 20:59:30 +01:00
Günther Deschner
78b20443c5 Use pidl for _srvsvc_NetRemoteTOD().
Guenther
(This used to be commit 2b4e0f0593c6378cdac4811ded830ca694afac9e)
2008-03-05 10:34:45 +01:00
Günther Deschner
c6c67005a8 Use pidl for _srvsvc_NetShareSetInfo().
Guenther
(This used to be commit 9bfa77edc68a887972b609bfb0aee8bbbc89ce04)
2008-03-05 10:00:31 +01:00
Günther Deschner
eb44792a22 Use pidl for _srvsvc_NetSrvSetInfo().
Guenther
(This used to be commit 75b0bbf790da44c45c679c374dbe09f288f3fb8c)
2008-03-05 09:50:02 +01:00
Günther Deschner
2c3dc9baa5 Use pidl for _srvsvc_NetSrvGetInfo().
Guenther
(This used to be commit 34caa41fa6d44165b470508261c2bde124fc4955)
2008-03-05 09:49:15 +01:00
Günther Deschner
d89877070e Whitespace cleanup in srvsvc server.
Guenther
(This used to be commit 3c0a3f8de742678b56f6b998a014105c05400666)
2008-03-05 09:47:53 +01:00
Andreas Schneider
1751b533f0 Rename the 'hidden' variable to 'administrative share'.
(This used to be commit eff3d3bad5a8860b99375cc0be9dc24f3679e416)
2008-02-29 13:08:04 +01:00
Günther Deschner
b2ed9341ee Fix segfault in _srv_net_file_enum.
Guenther
(This used to be commit 6523a051ded9f7b433fcce2d4c4a5f186b5a28f6)
2008-02-28 10:15:31 +01:00
Andreas Schneider
d85c517b45 Add variable to define if a share should be hidden.
If you create a share on a Windows machine called foo$ then this share is
of the type STYPE_DISKTREE. So it is possible to administrate this kind of
share. Tested on Windows NT and 2003.

In samba we assume that if a share with a $ at the end must be of the type
STYPE_DISKTREE_HIDDEN. This is wrong, so we need a variable in the config
to define if the share should be hidden or not.
(This used to be commit a3da677bf0faed56e6731ee96708a7847a61d118)
2008-02-26 21:34:05 +01:00
Volker Lendecke
5ddb2abf76 Some more talloc_tos()
(This used to be commit 444e35e7df1f13fc285183da8fb41b30ad99a3fa)
2008-01-10 13:19:58 +01:00
Volker Lendecke
7cbdb48475 Remove tiny code duplication
ndr_size_security_descriptor does the same as sec_desc_size
(This used to be commit bc3bd7a8e7c6e9e27acb195c86abb92c0f53112f)
2007-12-29 23:13:26 +01:00
Volker Lendecke
e9b8eb1446 Remove a silly static
(This used to be commit ef75dcc9ffda85d77c8f22d0db702efbf8e642ed)
2007-12-27 22:33:02 +01:00
Volker Lendecke
addf598cde Some C++ warnings
(This used to be commit 5ab82d4f574f2a2e2761e9e414c66a70aeffb05d)
2007-12-21 09:58:20 +01:00
Michael Adam
233eb0e560 Change the prototype of the vfs function get_nt_acl().
Up to now, get_nt_acl() took a files_struct pointer (fsp) and
a file name. All the underlying functions should need and now
do need (after the previous preparatory work), is a connection_struct
and a file name. The connection_struct is already there in the
vfs_handle passed to the vfs functions. So the files_struct
argument can be eliminated.

This eliminates the need of calling open_file_stat in a couple
of places to produce the fsp needed.

Michael
(This used to be commit b5f600fab53c9d159a958c59795db3ba4a8acc63)
2007-12-19 23:08:01 +01:00
Jeremy Allison
7faee02d0d Remove the char[1024] strings from dynconfig. Replace
them with malloc'ing accessor functions. Should save a
lot of static space :-).
Jeremy.
(This used to be commit 52dc5eaef2106015b3a8b659e818bdb15ad94b05)
2007-12-10 11:30:37 -08:00
Jeremy Allison
6b6655edd9 Remove pstrings from everything except srv_spoolss_nt.c.
Jeremy.
(This used to be commit 0002a9e96b0ef78316295a6eb94ff29b64e2f988)
2007-11-27 14:35:30 -08:00
Jeremy Allison
3a452a15b7 Remove pstring from everything in rpc_server except
srv_spoolss_nt.c and srv_srvsvc_nt.c.
They're next :-).
Jeremy.
(This used to be commit 55b4f9d003b036af69085f7b64e0df08c5ba440d)
2007-11-27 11:22:58 -08:00
Jeremy Allison
68be9a8200 More pstring removal. This one was tricky. I had to add
one horror (pstring_clean_name()) which will have to
remain until I've removed all pstrings from the client code.
Jeremy.
(This used to be commit 1ea3ac80146b83c2522b69e7747c823366a2b47d)
2007-11-15 14:19:52 -08:00
Volker Lendecke
15953b82eb Make [f]get_nt_acl return NTSTATUS
(This used to be commit dcbe1bf942d017a3cd5084c6ef605a13912f795b)
2007-11-13 15:47:01 +01:00