1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-28 07:21:54 +03:00
Commit Graph

9363 Commits

Author SHA1 Message Date
Stefan Metzmacher
f0f7070ad7 r16870: copy over the status from the ntvfs request to the smb2 request
so that smb2srv_setup_reply() doesn't push uninitialized data
(found by valgrind)

metze
(This used to be commit 1a1fd2747d)
2007-10-10 14:09:55 -05:00
Stefan Metzmacher
cf901ad491 r16869: - if we know the blob length, we can preallocated the memory
and avoid a realloc in smb2_push_*
- don't overwrite the first data byte

metze
(This used to be commit 7761a2a595)
2007-10-10 14:09:55 -05:00
Stefan Metzmacher
1b45214f31 r16868: init some uninitialized values
(found by valgrind)

metze
(This used to be commit 1bb60b5be4)
2007-10-10 14:09:54 -05:00
Andrew Bartlett
0f215e9947 r16860: Fix (and reactivate) the RPC-SAMR test. We need to allow these sids
to be created as foreign, even if they are in a local domain.

Also we do need the user to exist for the life of the test, as we add
it to a group.

Andrew Bartlett
(This used to be commit ae470ff701)
2007-10-10 14:09:54 -05:00
Andrew Bartlett
6abc3e05b1 r16858: The RPC-SAMR-PASSWORDS test now passes.
Andrew Bartlett
(This used to be commit 8b34bb2689)
2007-10-10 14:09:54 -05:00
Andrew Bartlett
bc3d68af6d r16854: Fix the RPC-SAMR-PASSWORDS test. It failed because we allocated users
in the Builtin domain a SID from the global domain.

Andrew Bartlett
(This used to be commit 9d31b9f047)
2007-10-10 14:09:54 -05:00
Andrew Bartlett
f596c0a4ec r16852: I thought we passed RPC-SAMR-PASSWORDS, but we don't. Disable that
test for now.

Andrew Bartlett
(This used to be commit 9748c3a2f0)
2007-10-10 14:09:54 -05:00
Andrew Bartlett
5768d1298f r16851: Put a clue in as to which domain might have failed, due to the length
of this test.

Andrew Bartlett
(This used to be commit b4d75f01d9)
2007-10-10 14:09:53 -05:00
Andrew Bartlett
90b744247f r16850: Disable NBT-WINSREPLICATION-OWNED until it always passes (currently it still has intermittant failures).
Andrew Bartlett
(This used to be commit 845da45117)
2007-10-10 14:09:53 -05:00
Andrew Bartlett
ba968d6684 r16847: Add the parts of the SAMR test that pass back into 'make test'.
I still need to figure out what causes the rest to fail...

Andrew Bartlett
(This used to be commit aa34bd46cb)
2007-10-10 14:09:53 -05:00
Andrew Bartlett
1d2b6e8712 r16846: Try not to segfault if the domain SID isn't there, or the search
failed.

Andrew Bartlett
(This used to be commit 5d5d49374f)
2007-10-10 14:09:52 -05:00
Jeremy Allison
ec3be5b908 r16843: Confirm that openX uses the same mapping table as getatr.
Jeremy.
(This used to be commit 1c84e57e71)
2007-10-10 14:09:52 -05:00
Volker Lendecke
a5cbc9a01c r16842: Jeremy, I almost don't dare checking this in.....
Volker
(This used to be commit ec36c49c08)
2007-10-10 14:09:50 -05:00
Jelmer Vernooij
4979fd60b6 r16838: Allow compilation by midl. Patch by andrzej.hajda@wp.pl
(This used to be commit 9e38cc9f3f)
2007-10-10 14:09:49 -05:00
Andrew Bartlett
86518acc49 r16835: Remove RPC-SAMR from the test, until I can clear up the unexplained failure.
Andrew Bartlett
(This used to be commit 666ac7e36c)
2007-10-10 14:09:49 -05:00
Stefan Metzmacher
af0a9eb529 r16834: split the level's of smb_search_first/smb_search_next and the levels
of smb_search_data

metze
(This used to be commit 78c201db8a)
2007-10-10 14:09:49 -05:00
Andrew Bartlett
51e0ae33ac r16833: Add a base DN to more search calls, we need to look for an ID over the
whole tree here.

Andrew Bartlett
(This used to be commit 7674306e67)
2007-10-10 14:09:49 -05:00
Andrew Bartlett
1f1b34b3e8 r16832: I should be more careful (and test!) when trying to make compilers and
static checkers happy...

Andrew Bartlett
(This used to be commit ae7ec0d553)
2007-10-10 14:09:49 -05:00
Andrew Bartlett
ebea352760 r16831: Use a valid memory context (found by the IBM checker).
Andrew Bartlett
(This used to be commit 9fdbedafad)
2007-10-10 14:09:48 -05:00
Andrew Bartlett
12dc0ae78c r16830: Fix IBM checker and GCC warnings.
Andrew Bartlett
(This used to be commit 5ef924bc73)
2007-10-10 14:09:48 -05:00
Andrew Bartlett
3ed1e8ff3c r16829: Fix a number of issues raised by the IBM checker, or gcc warnings.
In particular, this removes one use of the LDB_DN_NULL_FAILED macro,
which was being used on more than DNs, had an embedded goto, and
confused the IBM checker.

In the password_hash code, ensure that sambaAttr is not, before
checking the number of values.

In GENSEC, note that this switch value can't occour.  This seems to be
the only way to quiet both the IBM checker and gcc, as well as cope
with possibly invalid inputs.

Andrew Bartlet
(This used to be commit 3e58350ec2)
2007-10-10 14:09:48 -05:00
Andrew Bartlett
5e3ca4a733 r16828: Add RPC-LSA as a test that passes, and remove RAW-ACLs until someone
can fix it.

Andrew Bartlett
(This used to be commit 840b5f0a7f)
2007-10-10 14:09:48 -05:00
Andrew Bartlett
f2e8b3202c r16827: Factor out some code into common samdb functions:
- creation of ForeignSecurityPrincipals
 - template duplication code

Rework much of the LSA server to pass the RPC-LSA test.  Much of the
server code was untested.  In implementing the LSA Accounts feature, I
have opted to have it only create entires when privilages are applied,
and not to delete entries, but to delete the privilages.

We skip some parts of the test, but it is much better than not testing
it at all.

Andrew Bartlett
(This used to be commit 10eeea6da4)
2007-10-10 14:09:48 -05:00
Andrew Bartlett
3aa8a700e6 r16826: Ensure we don't segfault if the remote server fails to set a password
in RPC-SAMR test.

Andrew Bartlett
(This used to be commit 08ec74d620)
2007-10-10 14:09:47 -05:00
Andrew Bartlett
44e6f21393 r16825: Make ldb_sainity_check() set an error string. This makes it much
easier to chase down what modules or application code gets wrong.

Ensure not to leave memory allocated on failure in ldb_search()

Andrew Bartlett
(This used to be commit 0828739951)
2007-10-10 14:09:47 -05:00
Jelmer Vernooij
927cbf74ae r16824: Rename Ethereal -> Wireshark (patch from Joerg Mayer)
(This used to be commit a789aa468b)
2007-10-10 14:09:47 -05:00
Stefan Metzmacher
fbf566b777 r16815: split out search levels which are also used by smb2
metze
(This used to be commit 3b8ecc19fa)
2007-10-10 14:09:47 -05:00
Günther Deschner
91e4f9f6d8 r16801: Adding WERR_DS_DRA_ACCESS_DENIED.
Guenther
(This used to be commit 075242b976)
2007-10-10 14:09:46 -05:00
Günther Deschner
eda5759e45 r16796: Fill in dsr_GetMemberships() / dsr_GetMemberships2().
This intersting call is apparently used to construct the user token,
collect memberships from other DSAs and to retrieve (nested) memberships
of a given group.

Torture test to follow (once I cleaned it up).

Guenther
(This used to be commit ca5e133e8c)
2007-10-10 14:09:46 -05:00
Andrew Bartlett
9da5d4fd69 r16795: Fix crash found by Dave Fenwick <djf@samba.org>.
The session_info was not being attached to the connection, so
subsequent checks in the kludge_acl module were looking at free()ed
memory.

Andrew Bartlett
(This used to be commit 7e9079ac7a)
2007-10-10 14:09:46 -05:00
Andrew Bartlett
3c9281f014 r16794: Make Samba4 pass it's own RPC-SAMR test, at least in part. There are
still a couple of unimplemented functions, but this is far better than
not testing this at all.  In particular, this exercises the
password_hash module.

Specific changes:
 - Add support for SetDomainInfo
 - Add many more info levels to QueryDomainInfo
 - Set a domain comment in RPC-SAMR, and verify it is kept
 - Refactor QueryUserInfo not to always serach for all attributes
 - Add QueryDiplayInfo3 and QueryDomainInfo2 as aliased calls
 - Make OemChangePassword2 search under the samdb_base_dn(), so it
   finds the user when partitions are active.
 - Skip SetSecurity, DisplayIndex, MemberAttributesOfGroup and
  'Multiple' alias operations in RPC-SAMR for Samba4
 - Add RPC-SAMR as a 'slow' RPC test (it is quite slow)

Andrew Bartlett
(This used to be commit 01d25c9d6c)
2007-10-10 14:09:46 -05:00
Rafal Szczesniak
464e352380 r16791: Typo fix in a comment.
rafal
(This used to be commit 48a9f82244)
2007-10-10 14:09:46 -05:00
Simo Sorce
a3f606f6ca r16784: - make some function in ldb static, they not need to be exported anywhere
- fix a bad segfault
  Andrew please make test before committing.

Simo.
(This used to be commit b9b6bb3e89)
2007-10-10 14:09:45 -05:00
Stefan Metzmacher
af04a37ce7 r16776: fix typo
metze
(This used to be commit 249bf24a40)
2007-10-10 14:09:45 -05:00
Andrew Bartlett
d3fee429ae r16774: This patch modifies the tdb API to allow the logging function to be used
as part of ldb.

This allows tdb failures to be passed all the way up to Samba's DEBUG
system, which allowed easier debugging.

Unfortunately I had to extend the tdb API, as the logging function
didn't have a context pointer.

I've worked over the 'debug levels' in TDB.  Most of them were 0,
which didn't seem right, as some were trace-like messages.  We didn't
see any of these previously, except when accessing TDB directly.

Andrew Bartlett
(This used to be commit 58898092c1)
2007-10-10 14:09:45 -05:00
Andrew Bartlett
fcce0991c2 r16773: Fix one more RPC-SAMR test (an alias level), and make it clear that
the unknown value in the samr_GroupInfo structures are the group
attributes.

Andrew Bartlett
(This used to be commit c50095efab)
2007-10-10 14:09:45 -05:00
Andrew Bartlett
937e394334 r16772: Clarify comment.
Andrew Bartlett
(This used to be commit fee0716143)
2007-10-10 14:09:45 -05:00
Andrew Bartlett
8932ab2066 r16771: Add const and some better debug messages.
Andrew Bartlett
(This used to be commit 87cac3529c)
2007-10-10 14:09:44 -05:00
Andrew Bartlett
23f8579e8a r16770: Get closer to having Samba4 pass some of the RPC-SAMR test, by
skipping some checks.

These should be removed, and the code fixed, but currently we are
loosing quality because the test isn't run by default.

Andrew Bartlett
(This used to be commit 1306f60c97)
2007-10-10 14:09:44 -05:00
Andrew Bartlett
6218aef0ca r16769: Working on fixing the RPC-SAMR test against Samba4. This fixes
password changes which only include the LM and NT hash, such as the
original ChangePassword.

It also fixes setting passwords on the BUILTIN domain.

Finally, the msDS-KeyVersionNumber is only incremented if not
explicity set by the modify.

Andrew Bartlett
(This used to be commit e957f6f4c6)
2007-10-10 14:09:44 -05:00
Andrew Bartlett
673cce7817 r16768: Add a simple script to set a user's password. This should grow into a
real smbpasswd command some day.

Andrew Bartlett
(This used to be commit 8d05827966)
2007-10-10 14:09:44 -05:00
Jeremy Allison
5517249fad r16761: Added additional NTSTATUS and DOS error test for "."
This confirms a theory of mine...
Added RAW-SAMBA3BADPATH to selectable options.
Jeremy.
(This used to be commit 4cd7a8ed62)
2007-10-10 14:09:44 -05:00
Volker Lendecke
81d09a7f2e r16759: Jeremy, another little error case for you :-)
For the paths with illegal characters we should return ERRDOS:ERRbadpath in
the DOS error case. We return ERRDOS:ERRinvalidname...

Volker
(This used to be commit c2203068f4)
2007-10-10 14:09:43 -05:00
Volker Lendecke
81d5901044 r16756: Some machines on the build farms sporadically fail the test
/* Test 21 -- Test removal of file after socket close. */

I think it might be because they are too slow to delete the file.

Jeremy, can you check this test does not change semantics in a way you don't
want it?

Volker
(This used to be commit 92aa95f820)
2007-10-10 14:09:43 -05:00
Stefan Metzmacher
946e1c1b87 r16741: add a RPC-LSA-GETUSER test,
which is very useful for analysing a windows machine remotely

with this I found that vista-beta2 doesn't have an 'administrator' account
and mapps any not known user to MACHINENAME\Guest

metze
(This used to be commit 97ae936275)
2007-10-10 14:09:43 -05:00
Stefan Metzmacher
21af3847a6 r16740: just say the directory is empty
metze
(This used to be commit 6326bb901f)
2007-10-10 14:09:43 -05:00
Stefan Metzmacher
2e56d833b4 r16739: test SMB2-GETINFO SMB2-SETINFO by make test
metze
(This used to be commit 0ebb25de56)
2007-10-10 14:09:43 -05:00
Stefan Metzmacher
dd44e2415c r16738: vista beta2 use FILE_CLOSED as error for an invalid file handle
metze
(This used to be commit fa35ddcaf9)
2007-10-10 14:09:42 -05:00
Stefan Metzmacher
d584033c6c r16737: if an error happens report it
metze
(This used to be commit 52ce898cf9)
2007-10-10 14:09:42 -05:00
Stefan Metzmacher
f0c737b924 r16736: - convert unix times to nttime before sending it to the wire...
- return an error code if an error happens

metze
(This used to be commit 9b52322e90)
2007-10-10 14:09:42 -05:00