sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-13 13:18:06 +03:00
Code
70,968 Commits 60 Branches 1,145 Tags 452 MiB
f10cba1a01
Commit Graph

35400 Commits

Author SHA1 Message Date
Volker Lendecke
c52c75338f s3: inline get_uid_from_state 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Jan 28 23:38:16 CET 2011 on sn-devel-104
 2011-01-28 23:38:16 +01:00
Volker Lendecke
e099c91ef9 s3: Lift winbindd_cli_state from fillup_password_policy 2011-01-28 22:54:19 +01:00
Volker Lendecke
fe516a3fb7 s3: Do not use state->mem_ctx in fillup_password_policy 2011-01-28 22:54:19 +01:00
Volker Lendecke
2d174d49cd s3: Lift winbindd_cli_state from winbindd_dual_pam_auth_samlogon 2011-01-28 22:54:19 +01:00
Volker Lendecke
5d4bfc949b s3: Lift winbindd_cli_state from winbindd_raw_kerberos_login 2011-01-28 22:54:19 +01:00
Jeremy Allison
f2900a8b04 We need to reply to SMB2_GETINFO_FILE with a class of SMB2_FILE_STANDARD_INFO on an IPC$ share. 
Otherwise a Win7 client issues this request twice (2xroundtrips)
if we return NOT_SUPPORTED. We do the same for SMB1 in call_trans2qpipeinfo()

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Jan 28 22:53:18 CET 2011 on sn-devel-104
 2011-01-28 22:53:18 +01:00
Günther Deschner
fc16baaf91 s3-net: use struct based dcerpc_spoolss_EnumPrinterData_r() call. 
This is a workaround for a string issue we currently have with argument based
generated dcerpc client code (see bug #7804 for details).

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 28 22:05:20 CET 2011 on sn-devel-104
 2011-01-28 22:05:20 +01:00
Günther Deschner
d4414f08cb s3-rpcclient: use struct based dcerpc_spoolss_EnumPrinterData_r() call. 
This is a workaround for a string issue we currently have with argument based
generated dcerpc client code (see bug #7804 for details).

Guenther
 2011-01-28 21:16:46 +01:00
Günther Deschner
1232fb5a1e s3-rpc_client: remove some more obsolete cli_X.h header files. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 28 11:18:44 CET 2011 on sn-devel-104
 2011-01-28 11:18:44 +01:00
Jeremy Allison
ba6dda1934 Add delete-ln test now we can correctly delete hardlinks. 
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Jan 28 01:24:19 CET 2011 on sn-devel-104
 2011-01-28 01:24:19 +01:00
Jeremy Allison
eec50b21f6 Change "security=share" to downgrade to SMB1 from SMB2, rather than trying to fake it. 2011-01-27 15:26:47 -08:00
Michael Adam
5dd63c6c14 libwbclient: bump the libwbclient SOVER 0 -> 1 due to ABI changes 
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Jan 28 00:25:11 CET 2011 on sn-devel-104
 2011-01-28 00:25:11 +01:00
Michael Adam
14502c5458 s3:registry: fix comments in regdb_store_regdb_version() 2011-01-27 21:43:48 +01:00
Günther Deschner
9d04f2bd68 s3-build: remove another leftover of -I../source4. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Jan 27 13:30:30 CET 2011 on sn-devel-104
 2011-01-27 13:30:30 +01:00
David Disseldorp
eb55338ccd Looking into printer driver issues, I ran across some peculiarities in 
copy_file():
- Firstly, if the source file is zero bytes, NT_STATUS_DISK_FULL is
  returned.
- Secondly, the conditional lseek is confusing. It fires when
  OPENX_FILE_EXISTS_OPEN is set and I can't see why the lseek is
  necessary in this case.
- Finally, the lseek error path also results in NT_STATUS_DISK_FULL.

Proposed fix for first and third point below.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Jan 27 00:59:56 CET 2011 on sn-devel-104
 2011-01-27 00:59:56 +01:00
Andreas Schneider
efde1d870b s3-utils: Fixed a resource leak in net_afs. 
s3-utils: Fixed a resource leak in net_afs.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Jan 27 00:12:47 CET 2011 on sn-devel-104
 2011-01-27 00:12:47 +01:00
Andreas Schneider
4fc75c755d s3-utils: Fixed a resource leak in smbta-util. 
s3-utils: Fixed a resource leak in smbta-util.
 2011-01-26 14:20:37 -08:00
Andreas Schneider
f419c2b091 s3-utils: Fixed possible resource leak in net_usershare. 
s3-utils: Fixed possible resource leak in net_usershare.
 2011-01-26 14:20:37 -08:00
Andreas Schneider
de4ef101c1 s3-utils: Fixed possible resource leak in smbget. 
s3-utils: Fixed possible resource leak in smbget.
 2011-01-26 14:20:37 -08:00
Andreas Schneider
08dc51d3ca s3-utils: Fixed possible resource leak in smbfilter. 
s3-utils: Fixed possible resource leak in smbfilter.
 2011-01-26 14:20:37 -08:00
Andreas Schneider
f6f0dac427 s3-modules: Fixed the for-loop code block. 
s3-modules: Fixed the for-loop code block.
 2011-01-26 14:20:37 -08:00
Andreas Schneider
2c47368d68 s3-lib: Fixed a missing return value in tldap. 
s3-lib: Fixed a missing return value in tldap.
 2011-01-26 14:20:37 -08:00
Kai Blin
278c6f8fc5 errormap: Add unix_to_werror() function 
While this function technically is closest to the
map_nt_status_from_unix() function, I think it is better to keep the new
function in line with our usual fooerror_to_barerror() naming scheme.

Signed-off-by: Kai Blin <kai@samba.org>

Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Wed Jan 26 23:07:24 CET 2011 on sn-devel-104
 2011-01-26 23:07:24 +01:00
Jeremy Allison
67e578ab5a Allow "security = share" with SMB2. We already handle this in smb2/smb2_server.c 
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jan 26 20:37:29 CET 2011 on sn-devel-104
 2011-01-26 20:37:29 +01:00
Jeremy Allison
bb358ecd5a From Metze - make sure we're using the same string length for the hash. 
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jan 26 18:32:15 CET 2011 on sn-devel-104
 2011-01-26 18:32:15 +01:00
Günther Deschner
abb7c07de5 s3-winbind: share a common winbind_samlogon_retry_loop(). 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Jan 26 12:41:14 CET 2011 on sn-devel-104
 2011-01-26 12:41:14 +01:00
Günther Deschner
035a0d2fb3 Revert "s3: These assignments are overwritten immediately" 
This reverts commit 18962ea385.
 2011-01-26 11:55:37 +01:00
Günther Deschner
36cfa1792e Revert "s3-winbind: fix winbindd_dual_pam_auth_samlogon() for NT4 domains." 
This reverts commit cea36aeacf.
 2011-01-26 11:55:36 +01:00
Jeremy Allison
3272e16846 Missed one debug printf of name_hash. Ensure always use %x. 
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jan 26 00:46:28 CET 2011 on sn-devel-104
 2011-01-26 00:46:27 +01:00
Jeremy Allison
44732734cc Fix bug #7863 - Unlink may unlink wrong file when hardlinks are involved. 
Do this by keeping a linked list of delete on close tokens, one for
each filename that identifies a path to the dev/inode. Use the
jenkins hash of the pathname to identify the correct token.
 2011-01-25 14:23:19 -08:00
Jeremy Allison
a65bce4e38 Add uint32_t name_hash argument (currently unused) to get_file_infos(). 
Will be used when we store more than one delete on close token.
 2011-01-25 14:02:18 -08:00
Jeremy Allison
b97f1ce68a Add name_hash into the share mode entry struct (as yet only use for renames to identify a specific path). 2011-01-25 14:01:52 -08:00
Jeremy Allison
76418e23bc Add name_hash to files_struct. Set within fsp_set_smb_fname(). 2011-01-25 13:49:01 -08:00
Günther Deschner
c9f4fad75c idl: add file_id idl. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Jan 25 12:27:00 CET 2011 on sn-devel-104
 2011-01-25 12:27:00 +01:00
Günther Deschner
f0b3c72bcc s3-libndr: remove cmdline_lp_ctx. 
Guenther
 2011-01-25 11:42:46 +01:00
Günther Deschner
dd35fe181c waf: share libndr.so between samba3 and samba4. 
Guenther
 2011-01-25 11:42:46 +01:00
Günther Deschner
7eac3100ea libndr: move ndr_print_bool to ndr_basic.c 
Guenther
 2011-01-25 11:42:46 +01:00
Günther Deschner
62e1c80cf5 s3-waf: add PKGCONFIGDIR. 
Guenther
 2011-01-25 11:42:46 +01:00
Björn Baumbach
07ccc2905d s3-smbclient: Fix cli_errstr() usage (part of bug #7864) 
Convert cli_errstr() to nt_errstr()

Signed-off-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Jan 25 11:41:53 CET 2011 on sn-devel-104
 2011-01-25 11:41:53 +01:00
Björn Baumbach
5d8ada549e s3-masktest: Fix cli_errstr() usage (part of bug #7864) 
Convert cli_errstr() to nt_errstr()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2011-01-25 10:45:22 +01:00
Björn Baumbach
09c612f377 s3-smbclient: Fix cli_errstr() usage (part of bug #7864) 
Convert cli_errstr() to nt_errstr()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2011-01-25 10:45:22 +01:00
Björn Baumbach
99f8f5e594 s3-torture: Fix cli_errstr() usage (part of bug #7864) 
Convert cli_errstr() to nt_errstr()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2011-01-25 10:45:21 +01:00
Günther Deschner
39ea30de0f s3-build: remove source4 include path for autoconf build as well. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Jan 24 17:40:56 CET 2011 on sn-devel-104
 2011-01-24 17:40:56 +01:00
Günther Deschner
99437614fa s3-rpcclient: allow to define validation level for samlogon. 
Guenther
 2011-01-24 16:56:00 +01:00
Günther Deschner
ef0a3903f0 s3-waf: fix lib/addns include path. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Jan 24 16:15:58 CET 2011 on sn-devel-104
 2011-01-24 16:15:58 +01:00
Günther Deschner
c675b1c827 s3-waf: no need anymore to include "source4" globally. 
Guenther
 2011-01-24 15:28:21 +01:00
Stefan Metzmacher
0dc1eee0b8 libcli/ldap: use lib/ldb_compat.h for the s3 build 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Jan 24 14:55:50 CET 2011 on sn-devel-104
 2011-01-24 14:55:50 +01:00
Günther Deschner
cea36aeacf s3-winbind: fix winbindd_dual_pam_auth_samlogon() for NT4 domains. 
After failing the netr_LogonSamLogonEx, we failed to retry with
netr_LogonSamLogon.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Jan 24 12:35:42 CET 2011 on sn-devel-104
 2011-01-24 12:35:42 +01:00
Volker Lendecke
509dd57d68 Revert "s3: Fix an infinite loop" 
This reverts commit 61f7d7cdec.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Jan 24 10:10:43 CET 2011 on sn-devel-104
 2011-01-24 10:10:43 +01:00
Volker Lendecke
61f7d7cdec s3: Fix an infinite loop 
If select returns EBADF (which should NEVER happen), then we loop infinitely
because the select masks seem all active.

I've been given an strace where smbd floods syslog with inotify-related
error messages. The strace shows that select returns EBADF, and we're calling
the inotify event callback. It then complains there's no data on the inotify
fd.

Metze, please check!

We might need to fix this in 3.4 and 3.5 as well. And we need to find the
deeper reason where we close a file descriptor and don't tell the events
system about it.

Volker

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jan 23 10:05:39 CET 2011 on sn-devel-104
 2011-01-23 10:05:39 +01:00
Volker Lendecke
058de59a8e s3: Fix connecting to port-139 only servers 
When the TCP RST came before the 5 msecs timeout kicked in, we
viewed this as final, as state->req_139 was not set yet.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Jan 22 17:42:41 CET 2011 on sn-devel-104
 2011-01-22 17:42:41 +01:00
Günther Deschner
6ee39a2f42 s3-torture: fix uninitialized status code. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 21 16:52:34 CET 2011 on sn-devel-104
 2011-01-21 16:52:34 +01:00
Günther Deschner
6923cc8016 s3-rpc_client: fix dcerpc_try_samr_connects(). 
Only return when both results are ok.

Guenther
 2011-01-21 16:10:15 +01:00
Günther Deschner
e873ce9b65 s3-rpc_client: no need to include gen_ndr/cli_samr.h anymore. 
Guenther
 2011-01-21 16:10:15 +01:00
Günther Deschner
1f26b101ed s3-rpc_client: fix uninitialized variable found by -O3. 
Guenther
 2011-01-21 16:10:15 +01:00
Günther Deschner
5e89574dce s3-waf: remove RPCCLI_SPOOLSS subsystem. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 21 16:06:40 CET 2011 on sn-devel-104
 2011-01-21 16:06:40 +01:00
Günther Deschner
24c51a7d2a s3-build: remove RPCCLI_SPOOLSS subsystem. 
Guenther
 2011-01-21 15:20:22 +01:00
Günther Deschner
cf7a78b64f s3-rpcclient: prefer dcerpc_spoolss_X functions. 
Guenther
 2011-01-21 15:20:22 +01:00
Günther Deschner
e94ffc790e s3-rpc_client: prefer dcerpc_spoolss_X functions. 
Guenther
 2011-01-21 15:20:22 +01:00
Günther Deschner
831f3eec16 s3-lanman: remove trailing whitespace. 
Guenther
 2011-01-21 15:20:22 +01:00
Andreas Schneider
5db115a304 s3-rpc_client: Added dcerpc_try_samr_connects. 
Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Fri Jan 21 15:19:01 CET 2011 on sn-devel-104
 2011-01-21 15:19:01 +01:00
Andreas Schneider
089c25cbbb s3-rpc_client: Rename get_query_dispinfo_params. 2011-01-21 14:34:18 +01:00
Andreas Schneider
e6475f2151 s3-rpc_client: Added dcerpc_samr_chgpasswd_user3. 2011-01-21 14:34:18 +01:00
Andreas Schneider
200772653a s3-rpc_client: Added dcerpc_samr_chng_pswd_auth_crap. 2011-01-21 14:34:18 +01:00
Andreas Schneider
3de564b9b6 s3-rpc_client: Added dcerpc_samr_chgpasswd_user2. 2011-01-21 14:34:17 +01:00
Andreas Schneider
78c4f72c31 s3-rpc_client: Added dcerpc_samr_chgpasswd_user. 2011-01-21 14:34:17 +01:00
Andreas Schneider
8b1ffc770c s3-rpc_client: Added header information to cli_samr.h. 2011-01-21 14:34:17 +01:00
Andreas Schneider
1efa9b1cbd s3-rpc_client: Added header information to cli_lsarpc.h. 2011-01-21 14:34:17 +01:00
Volker Lendecke
9c2fcb689b s3:winbind: Fork multiple children per domain 
This makes us scale better with many simultaneous winbind requests,
some of which might be slow.

This implementation breaks offline logons, as the cached credentials are
maintained in a child (this needs fixing). So, if the offline logons are
active, only allow one DC connection.

Probably the offline logon and the scalable file server cases are
separate enough so that this patch is useful even with the restriction.
 2011-01-21 13:51:27 +01:00
Stefan Metzmacher
7a2fa9fc1c s3:printing: use dcerpc_spoolss_X() functions 
metze

Signed-off-by: Andreas Schneider <asn@samba.org>

Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Fri Jan 21 13:14:49 CET 2011 on sn-devel-104
 2011-01-21 13:14:49 +01:00
Stefan Metzmacher
1f83325261 s3:srv_spoolss: use dcerpc_spoolss_X() functions 
metze

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-21 12:30:22 +01:00
Stefan Metzmacher
e830e37c9c s3:smbd: use dcerpc_spoolss_X() functions 
metze

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-21 12:30:22 +01:00
Stefan Metzmacher
81443447a1 s3:net: use dcerpc_spoolss_X() functions 
metze

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-21 12:30:22 +01:00
Stefan Metzmacher
a34aa148ca s3:libads: use dcerpc_spoolss_X() functions 
metze

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-21 12:30:22 +01:00
Volker Lendecke
1b373d6044 s3: Fix a deadlock between smbd and ctdbd 
Do the notification after we released the share mode lock. Inside notify_fname
we take out another tdb lock. With ctdb also accessing our databases, this can
lead to deadlocks. Putting this notify after the TALLOC_FREE(lck) above we
avoid locking two records simultaneously. Notifies are async and informational
only, so calling the notify_fname without holding the share mode lock should
not do any harm.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Jan 21 12:29:21 CET 2011 on sn-devel-104
 2011-01-21 12:29:21 +01:00
Günther Deschner
8db3258983 s3-spoolss: make it more obvious what winreg_create_printer() does. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 21 11:43:29 CET 2011 on sn-devel-104
 2011-01-21 11:43:29 +01:00
Günther Deschner
621fb88e33 s3-rpcclient: rename duplicate enumkey command to winreg_enumkey. 
Guenther
 2011-01-21 10:58:20 +01:00
Günther Deschner
be884c1bfd s3-spoolss: as smbtorture testing proves: devmode size is the size of the devicemode minus the driverdata extra size. 
Jeremy, please check.

Guenther
 2011-01-21 10:58:20 +01:00
Günther Deschner
9b1878e538 s3-spoolss: disallow storing an invalid devmode size. 
Guenther
 2011-01-21 10:58:20 +01:00
Michael Adam
5780940092 s3:vfs:shadow_copy2: fix indentation in _SHADOW2_NEXT_SMB_FNAME 
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Jan 21 10:57:45 CET 2011 on sn-devel-104
 2011-01-21 10:57:45 +01:00
Volker Lendecke
1c1a842071 s3:vfs:shadow_copy2: Fix shadow-copy module for drag&drop from a snapshot 
We have to return NT_STATUS_NOT_SAME_DEVICE to trigger the Windows client to
start a copy itself. Unbeknownst to us via the ACLs snapshots are read-only, so
a rename would trigger a EACCES. Unfortunately the MacOS/X finder does not do
the smart NOT_SAME_DEVICE fallback that Windows does.
 2011-01-21 10:10:03 +01:00
Christian Ambach
d49d203279 s3:registry correct a debug level 
this is not a level 0 message, move it to 10
 2011-01-21 10:10:03 +01:00
Volker Lendecke
52c0fb359f s3:winbind: Protect against invalid winbindd_cache entries in lookuprids 2011-01-21 10:10:03 +01:00
Gregor Beck
64f8306e8e s3-net: add roundtrip tests for registry import/export 2011-01-21 10:10:03 +01:00
Volker Lendecke
46a3019d36 s3: Fix the code to immediately disconnect from a non-working ctdbd 2011-01-21 10:10:02 +01:00
Rusty Russell
385d925f7e s3:vfs:gpfs: fix logic when gpfs:winattr is false (the default!) 
On my autocluster setup, it's not set.  Maybe it should be?  Otherwise
smbclient and some Windows client programs will get errors like:

        # smbclient //localhost/data -Uadministrator%XXX
        Domain=[VSOFS1] OS=[Unix] Server=[Samba 3.4.2-ctdb-10]
        smb: \> put /etc/resolv.conf resolv.conf
        NT_STATUS_ACCESS_DENIED closing remote file \resolv.conf
        smb: \>

Caused by attempting to update the time on close.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Michael Adam <obnox@samba.org>
 2011-01-21 10:10:02 +01:00
Stefan Metzmacher
b7d6d3b840 s3:librpc: remove prototype of dcerpc_binding_handle_set_ref_alloc() 
This function doesn't exist anymore.

metze
 2011-01-21 07:21:10 +01:00
Jeremy Allison
78b931ce6c Remove all uses of "./" in pathnames - make canonical. This will become important when we need to guarantee canonical names for hashing. 
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Jan 21 02:59:56 CET 2011 on sn-devel-104
 2011-01-21 02:59:56 +01:00
Jeremy Allison
de4b09ca01 Ensure we don't use "./" in findfirst pathnames. Use a directory open of "." instead. 2011-01-20 16:30:28 -08:00
Jeremy Allison
bb54f72b94 Make processing of incoming stream rename paths common between reply_mv and ntrename. Ensure we don't depend on "./" in the streams module. 2011-01-20 16:27:56 -08:00
Stefan Metzmacher
c3ad9bf157 s3:smbd: use anonymous_shared_free() for shared memory signing state 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jan 20 07:48:29 CET 2011 on sn-devel-104
 2011-01-20 07:48:29 +01:00
Stefan Metzmacher
34ea909636 lib/util: s/allocate_anonymous_shared/anonymous_shared_allocate/ 
metze
 2011-01-20 05:31:45 +01:00
Andreas Schneider
4744da8762 s3-param: Fixed code block in max_open_files(). 
When the HAVE_GETRLIMIT and RLIMIT_NOFILE macros are defined the block
isn't closed.

Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Wed Jan 19 23:10:50 CET 2011 on sn-devel-104
 2011-01-19 23:10:50 +01:00
Andreas Schneider
7a97518e12 s3-smbd: Fixed a possible null pointer dereference. 2011-01-19 22:27:48 +01:00
Volker Lendecke
7f87d58900 s3: Add wbinfo --dc-info 
wbinfo --dc-info prints the current DC name and IP address. This helps
diagnosing problems that might happen when a later wbinfo --ping-dc fails.

This patch started out by using the SAF and NBT cache entires, but those are
relatively short-lived. So I decided to invent a new gencache entry with a very
long timeout. We need to go via the gencache because when for some reason a
winbind child process is stuck, we can't query it for the current DC it's
connected to. This must eventually go away again when we have a fully async
winbind.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Jan 19 08:40:28 CET 2011 on sn-devel-104
 2011-01-19 08:40:28 +01:00
Jeremy Allison
1b43996022 Add DELETE-LN test to show bug #7863 - Unlink may unlink wrong file when hardlinks are involved 
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jan 19 03:06:32 CET 2011 on sn-devel-104
 2011-01-19 03:06:32 +01:00
Olly Betts
f8f1711f61 Fix "net usersidlist" not to skip every other user 
Remove double increment from for loop over users in get_user_tokens(),
left over from when this used to be a while loop.  Bug was introduced
in 1e39a619.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jan 19 01:34:29 CET 2011 on sn-devel-104
 2011-01-19 01:34:29 +01:00
Günther Deschner
49969e6aeb s3-winbind: no need to include ../librpc/gen_ndr/cli_lsa.h in 
winbindd/winbindd_msrpc.c.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Jan 19 00:37:46 CET 2011 on sn-devel-104
 2011-01-19 00:37:46 +01:00
Günther Deschner
5efe6566a0 s3-rpc_client: no need to include ../librpc/gen_ndr/ndr_lsa_c.h anymore. 
Guenther
 2011-01-18 23:54:31 +01:00
Günther Deschner
6feed0c9d2 s3-netlogon: no need to include ../librpc/gen_ndr/ndr_lsa_c.h anymore. 
Guenther
 2011-01-18 23:54:31 +01:00
Günther Deschner
6ed4121d54 s3-netlogon: no need to include ../librpc/gen_ndr/cli_samr.h anymore. 
Guenther
 2011-01-18 23:54:31 +01:00
Günther Deschner
430664d769 s3-net: use correct spoolss header in net rpc. 
Guenther
 2011-01-18 23:54:31 +01:00
Günther Deschner
66bc2f9127 s3-net: use correct spoolss header in net_ads.c. 
Guenther
 2011-01-18 23:54:30 +01:00
Jeremy Allison
7754b75065 Fix error where Windows client spoolss returns WERR_INVALID_DATA W_ERROR(0x0000000D) 
on opening a printer. We can't return zero for devmode->size. Guenther please check !

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Jan 18 23:45:33 CET 2011 on sn-devel-104
 2011-01-18 23:45:33 +01:00
Andreas Schneider
93da0aab97 s3-rpc_client: Fixed status check of dcerpc_lsa_lookup_sids_noalloc. 
Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Mon Jan 17 17:35:50 CET 2011 on sn-devel-104
 2011-01-17 17:35:50 +01:00
Andreas Schneider
296a958c57 s3-rpc_client: Fixed return values of dcerpc_lsa_lookup_sids_generic. 2011-01-17 16:50:55 +01:00
Andreas Schneider
ad65605643 s3-auth: Fixed account lockout check. 2011-01-17 16:50:50 +01:00
Volker Lendecke
9b94f36605 s3: Make sure we call wbcAuthenticateUserEx correctly 
There are cases where we fill in params.password.response.lm_data with non-NULL
where params.password.response.lm_length is 0. wbcAuthenticateUserEx does not
like that.

I haven't been able to reproduce this with smbclient yet, I've seen it with a
proprietary smb client implementation.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Jan 17 16:30:11 CET 2011 on sn-devel-104
 2011-01-17 16:30:11 +01:00
Stefan Metzmacher
528bcedbc5 s3:build: don't use librpc/gen_ndr/cli_echo.[ch] anymore 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Jan 17 09:34:12 CET 2011 on sn-devel-104
 2011-01-17 09:34:12 +01:00
Stefan Metzmacher
494e57d913 s3:torture: use dcerpc_echo_X() functions 
metze
 2011-01-17 08:48:25 +01:00
Stefan Metzmacher
85db5c9f8f s3:rpcclient: use dcerpc_echo_X() functions 
metze
 2011-01-17 08:48:25 +01:00
Volker Lendecke
d3abc90401 s3: Avoid a few calls to cli_errstr 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Jan 17 08:47:25 CET 2011 on sn-devel-104
 2011-01-17 08:47:25 +01:00
Volker Lendecke
c7a5933e4b s3: Remove some unused code 2011-01-17 08:03:43 +01:00
Volker Lendecke
6f3e11088c s3: Convert cli_lock64 to cli_smb 2011-01-17 08:03:43 +01:00
Volker Lendecke
dd2f234412 s3: Convert cli_lock to use cli_locktype 2011-01-17 08:03:43 +01:00
Volker Lendecke
0e2854f743 s3: Convert cli_locktype to cli_smb 2011-01-17 08:03:43 +01:00
Volker Lendecke
7b054ecaed s3: Make passing up "result_parent" from cli_smb optional 2011-01-17 08:03:43 +01:00
Volker Lendecke
b33f1147a6 s3: Remove unused cli_send_keepalive 2011-01-17 08:03:42 +01:00
Volker Lendecke
6e684c8460 s3: Remove unused cli_send/receive_trans 2011-01-17 08:03:42 +01:00
Volker Lendecke
cba5a26734 s3: Convert try_trans2 to cli_trans 2011-01-17 08:03:42 +01:00
Volker Lendecke
8ac68fc3cb s3: Convert cli_api to cli_trans 2011-01-17 08:03:42 +01:00
Volker Lendecke
cb412d22eb s3: Make cli_setpathinfo_basic use cli_setpathinfo 2011-01-17 08:03:42 +01:00
Volker Lendecke
21d5485e06 s3: Add cli_setpathinfo 2011-01-17 08:03:42 +01:00
Volker Lendecke
2068b96dce s3: Rename cli_setpathinfo->cli_setpathinfo_basic 2011-01-17 08:03:42 +01:00
Volker Lendecke
2d44a0583b s3: Remove unused cli_send/receive_nt_trans 2011-01-17 08:03:42 +01:00
Volker Lendecke
d5decfbb26 s3: Convert try_nttrans to cli_trans 2011-01-17 08:03:41 +01:00
Volker Lendecke
5dee39b5bf s3: Move dump_ntquota* to smbcquotas.c 2011-01-17 08:03:41 +01:00
Volker Lendecke
a1f541723d s3: Convert cli_set_fs_quota_info to cli_trans 2011-01-17 08:03:41 +01:00
Volker Lendecke
797c027cc8 s3: Convert cli_get_fs_quota_info to cli_trans 2011-01-17 08:03:41 +01:00
Volker Lendecke
483e0447f5 s3: Convert cli_list_user_quota to cli_trans 2011-01-17 08:03:41 +01:00
Volker Lendecke
eb7db50f60 s3: Convert cli_set_user_quota to cli_trans 2011-01-17 08:03:41 +01:00
Volker Lendecke
e2a96711d7 s3: Convert cli_get_user_quota to cli_trans 2011-01-17 08:03:41 +01:00
Volker Lendecke
bc5554bdcc s3: Fix some nonempty blank lines 2011-01-17 08:03:40 +01:00
Volker Lendecke
d9204622e3 s3: Fix a C++ warning 2011-01-17 08:03:40 +01:00
Volker Lendecke
674dcd68a6 s3: Remove cli_send_trans from cli_qpathinfo_alt_name 2011-01-17 08:03:40 +01:00
Volker Lendecke
fc8bfeea31 s3: Remove cli_send_trans from cli_oem_change_password 2011-01-17 08:03:40 +01:00
Volker Lendecke
77f8b004dc s3: Avoid some calls to cli_errstr 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Jan 15 17:18:54 CET 2011 on sn-devel-104
 2011-01-15 17:18:54 +01:00
Volker Lendecke
50b3458261 s3: Convert cli_set_secdesc to cli_trans 2011-01-15 16:34:35 +01:00
Volker Lendecke
4fc5699a79 s3: Fix some nonempty blank lines 2011-01-15 16:34:35 +01:00
Jeremy Allison
dbaeb52ebe Add OPLOCK4 test which explores how Windows copes with oplock and share mode breaks on hard links. 
Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Jan 15 00:59:46 CET 2011 on sn-devel-104
 2011-01-15 00:59:46 +01:00
Volker Lendecke
109cbe37a2 s3: Fix bug 7917: Yet another bug in chain_reply 
Found by Michael Hanscho <samba@micha.priv.at> with a WinCE client.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Jan 14 17:42:05 CET 2011 on sn-devel-104
 2011-01-14 17:42:05 +01:00
Günther Deschner
d7af8753ab s3-waf: fix the build after rpc_winreg removal. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 14 11:38:40 CET 2011 on sn-devel-104
 2011-01-14 11:38:40 +01:00
Christian Ambach
70b4c08c81 s3:vfs aio_fork children do not go away 
on RHEL 5.5, recvmsg() does not return when it is reading
from the socket and the process on the other side closes
its connection. This left aio children around that should
have gone already and were just wasting system resources.

This patch makes the child go away by writing invalid
data to it so that the child exits.

Pair-Programmed-With: Volker Lendecke <vl@samba.org>

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Jan 14 09:57:18 CET 2011 on sn-devel-104
 2011-01-14 09:57:18 +01:00
Christian Ambach
fa07208cee s3:vfs fix children cleanup in aio_fork 
the cleanup loop in aio_fork always stopped operation
on the first inactive child it found. In case lots of
children need to be reaped, it will take multiple runs
before all children are gone
 2011-01-14 09:11:19 +01:00
Paul B. Henson
99a74ff5e6 Fix bug #7909 - map SYNCHRONIZE acl permission statically in zfs_acl vfs module. 
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Jan 13 20:02:32 CET 2011 on sn-devel-104
 2011-01-13 20:02:31 +01:00
Günther Deschner
a556896d1e s3-build: remove RPCCLI_WINREG subsystem. 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>

Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Thu Jan 13 15:06:36 CET 2011 on sn-devel-104
 2011-01-13 15:06:36 +01:00
Günther Deschner
2e54b01bde s3-waf: remove RPCCLI_WINREG subsystem. 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-13 14:16:46 +01:00
Günther Deschner
166504adb7 s3-net_registry: prefer dcerpc_winreg_X functions. 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-13 14:16:39 +01:00
Günther Deschner
da433458e5 s3-net: prefer dcerpc_winreg_X functions. 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-13 14:15:00 +01:00
Günther Deschner
a451c54b3d s3-spoolss: no need to include cli_winreg header anymore. 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-13 14:14:36 +01:00
Günther Deschner
d97eb89c2a s3-rpcclient: prefer dcerpc_winreg_X functions. 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-13 14:14:28 +01:00
Günther Deschner
7e959004d7 s3-build: remove RPCCLI_SRVSVC subsystem. 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-13 14:14:04 +01:00
Günther Deschner
9204e04f27 s3-waf: remove RPCCLI_SRVSVC subsystem. 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-13 14:13:55 +01:00
Günther Deschner
bded49f5d6 s3-rpcclient: prefer dcerpc_srvsvc_X functions. 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-13 14:13:46 +01:00
Günther Deschner
8aa5b067b9 s3-net: prefer dcerpc_srvsvc_X functions. 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-13 14:12:52 +01:00
Günther Deschner
1ea6dd35f4 s3-smbtree: prefer dcerpc_srvsvc_X functions. 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-13 14:12:23 +01:00
Günther Deschner
4189c00cae s3-lanman: prefer dcerpc_srvsvc_X functions. 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-13 14:12:14 +01:00
Günther Deschner
44e048f7a8 s3-libsmbclient: prefer dcerpc_srvsvc_X functions. 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-13 14:11:55 +01:00
Günther Deschner
fccfd29283 s3-smbclient: prefer dcerpc_srvsvc_X functions. 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-13 14:11:29 +01:00
Günther Deschner
1ef94dffe6 s3-libnetapi: prefer dcerpc_srvsvc_X functions. 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-13 14:11:16 +01:00
Günther Deschner
aa4efa154f s3-build: remove RPCCLI_NETLOGON subsystem. 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-13 14:09:38 +01:00
Günther Deschner
9a9ee03ae8 s3-waf: remove RPCCLI_NETLOGON subsystem. 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-13 14:09:27 +01:00
Günther Deschner
5e4b327c4f s3-rpcclient: prefer dcerpc_netr_X functions. 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-13 14:09:18 +01:00
Günther Deschner
c9b3404c68 s3-winbind: prefer dcerpc_netr_X functions. 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-13 14:08:09 +01:00
Günther Deschner
232378c6e5 s3-rpc_client: prefer dcerpc_netr_X functions. 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-13 12:36:54 +01:00
Günther Deschner
1259e93ac0 s3-net: prefer dcerpc_netr_X functions. 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-13 12:23:02 +01:00
Günther Deschner
f3eb5c234e s3-libnet: prefer dcerpc_netr_X functions. 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-13 12:22:28 +01:00
Günther Deschner
425753ebe3 s3-libnetapi: prefer dcerpc_netr_X functions. 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-13 12:21:08 +01:00
Günther Deschner
f9ca6904a4 s3-net: remove some pointless fstrings in "net rpc service". 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-13 12:18:45 +01:00
Günther Deschner
d0c05ab2ec s3-net: restructure "net rpc service" and add open_scm(). 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-13 12:18:13 +01:00
Günther Deschner
3e2821acda s3-net: restructure "net rpc service" and add open_service(). 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-13 12:17:30 +01:00
Günther Deschner
5ad7d6aaa8 s3-build: remove RPCCLI_SVCCTL subsystem. 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-13 12:12:04 +01:00
Günther Deschner
067e548818 s3-waf: remove RPCCLI_SVCCTL subsystem. 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-13 12:11:40 +01:00
Günther Deschner
8e588550b9 s3-svcctl: prefer dcerpc_svcctl_X functions. 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-13 12:11:08 +01:00
Volker Lendecke
8c6b0b61e5 s3: Fix some nonempty blank lines 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Jan 12 19:04:25 CET 2011 on sn-devel-104
 2011-01-12 19:04:24 +01:00
Björn Baumbach
f5af66e67d s3-rpcclient: Fix bug #7880: cmd_spoolss_deletedriver() returned without checking all architectures. 
Continues now with next architecture if no driver is available.

Because of the broken behavior of the rpccli_*() functions,
we need special error code handling.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2011-01-12 17:25:53 +01:00
Günther Deschner
dac7ccee9f s3-net: fix query_service_state() error handling. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Jan 12 15:22:56 CET 2011 on sn-devel-104
 2011-01-12 15:22:56 +01:00
Günther Deschner
9bad150705 s3-net: add missing breaks in switch statement in get_share_info(). 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Jan 12 14:31:05 CET 2011 on sn-devel-104
 2011-01-12 14:31:05 +01:00
Günther Deschner
1cd7f6c0e1 s3-drsuapi: fix error handling after converting to dcerpc_drsuapi_X functions. 
Guenther
 2011-01-12 13:41:16 +01:00
Günther Deschner
415a390ba8 s3-libnetapi: add missing error check after switchting to dcerpc_wkssvc_X functions. 
Guenther
 2011-01-12 13:32:10 +01:00
Günther Deschner
fa5fdb1a4e s3-waf: finally enable large file support. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Jan 12 11:59:22 CET 2011 on sn-devel-104
 2011-01-12 11:59:22 +01:00
Volker Lendecke
35f08a2958 s3: Remove a pointless else 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Jan 12 11:12:56 CET 2011 on sn-devel-104
 2011-01-12 11:12:56 +01:00
Günther Deschner
e2a3ff184e s3-waf: add check for SO_PEERCRED. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Jan 12 02:29:48 CET 2011 on sn-devel-104
 2011-01-12 02:29:48 +01:00
Günther Deschner
4c8b9bee14 s3-waf: add checks for Linux readahead. 
Guenther
 2011-01-12 01:44:22 +01:00
Günther Deschner
4412eb9d00 s3-waf: more fallocate checks stolen from autoconf. 
Guenther
 2011-01-12 01:44:22 +01:00
Günther Deschner
b0f4f6f464 s3-waf: add checks for fallocate fallocate64. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Jan 12 00:56:57 CET 2011 on sn-devel-104
 2011-01-12 00:56:56 +01:00
Günther Deschner
6f39c3b526 s3-build: remove RPCCLI_DRSUAPI subsystem. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Jan 11 23:01:24 CET 2011 on sn-devel-104
 2011-01-11 23:01:24 +01:00
Günther Deschner
9fe0cfef6a s3-waf: remove RPCCLI_DRSUAPI subsystem. 
Guenther
 2011-01-11 22:18:03 +01:00
Günther Deschner
4f057230ca s3-drsuapi: prefer dcerpc_drsuapi_X functions. 
Guenther
 2011-01-11 22:18:02 +01:00
Günther Deschner
a76dde61bc s3-build: remove RPCCLI_INITSHUTDOWN subsystem. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Jan 11 17:59:21 CET 2011 on sn-devel-104
 2011-01-11 17:59:21 +01:00
Günther Deschner
5473d1b81c s3-waf: remove RPCCLI_INITSHUTDOWN subsystem. 
Guenther
 2011-01-11 17:12:04 +01:00
Günther Deschner
d1954ce8e7 s3-initshutdown: prefer dcerpc_initshutdown_X functions. 
Guenther
 2011-01-11 17:12:04 +01:00
Günther Deschner
2a05561e35 s3-build: remove RPCCLI_EVENTLOG subsystem. 
Guenther
 2011-01-11 17:12:04 +01:00
Günther Deschner
6cbe4da599 s3-waf: remove RPCCLI_EVENTLOG subsystem. 
Guenther
 2011-01-11 17:12:03 +01:00
Günther Deschner
fe2b89edee s3-eventlog: prefer dcerpc_eventlog_X functions. 
Guenther
 2011-01-11 17:12:03 +01:00
Günther Deschner
e5c4f69d40 s3-build: remove RPCCLI_WKSSVC subsystem. 
Guenther
 2011-01-11 17:11:48 +01:00
Günther Deschner
7c14048f94 s3-waf: remove RPCCLI_WKSSVC subsystem. 
Guenther
 2011-01-11 17:11:30 +01:00
Günther Deschner
4920390913 s3-wkssvc: prefer dcerpc_wkssvc_X functions. 
Guenther
 2011-01-11 17:09:25 +01:00
Stefan Metzmacher
4f305f438b s3:winbindd: use ndr_wbint_c.h instead of cli_wbint.h 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Jan 11 15:40:22 CET 2011 on sn-devel-104
 2011-01-11 15:40:21 +01:00
Stefan Metzmacher
cbc7db99d0 s3:winbindd: use ndr_dssetup_c.h instead of cli_dssetup.h 
metze
 2011-01-11 13:40:56 +01:00
Stefan Metzmacher
a175473e34 s3:net: use ndr_dssetup_c.h instead of cli_dssetup.h 
metze
 2011-01-11 13:40:55 +01:00
Stefan Metzmacher
f2044d0d11 s3:rpcclient: use ndr_dssetup_c.h instead of cli_dssetup.h 
metze
 2011-01-11 13:40:51 +01:00
Stefan Metzmacher
f936cfe505 s3:rpcclient: use ndr_dfs_c.h instead of cli_dfs.h 
metze
 2011-01-11 13:40:43 +01:00
Andreas Schneider
3f21b971a9 s3-rpc_client: Fixed the dcerpc_lsa_LookupNames4 client_revision. 
The spec states that the ClientRevision value MUST be one of the
following: LSA_CLIENT_REVISION_1 or LSA_CLIENT_REVISION_2.

LSA_CLIENT_REVISION_2 means Windows 2000 and newer.

Signed-off-by: Günther Deschner <gd@samba.org>

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Jan 10 19:05:31 CET 2011 on sn-devel-104
 2011-01-10 19:05:31 +01:00
Andreas Schneider
b1df95cbc5 s3-rpc_client: Fixed the dcerpc_lsa_LookupNames4 lookup_options. 
Use the enum value in dcerpc_lsa_LookupNames4 for _lookup_options.

Signed-off-by: Günther Deschner <gd@samba.org>
 2011-01-10 18:20:55 +01:00
Andreas Schneider
e02916c453 s3-rpc_client: Fixed the dcerpc_lsa_LookupSids3 client_revision. 
The spec states that the ClientRevision value MUST be one of the
following: LSA_CLIENT_REVISION_1 or LSA_CLIENT_REVISION_2.

LSA_CLIENT_REVISION_2 means Windows 2000 and newer.

Signed-off-by: Günther Deschner <gd@samba.org>
 2011-01-10 18:20:55 +01:00
Andreas Schneider
a53e0831d2 s3-rpc_client: Fixed the dcerpc_lsa_LookupSids3 lookup_options. 
Use the enum value in dcerpc_lsa_LookupSids3 for _lookup_options.

Signed-off-by: Günther Deschner <gd@samba.org>
 2011-01-10 18:20:55 +01:00
Andreas Schneider
b17eb8256d s3-netlogon: Move to new dcerpc client funtions. 
Signed-off-by: Günther Deschner <gd@samba.org>
 2011-01-10 18:20:55 +01:00
Andreas Schneider
fd1fff608c s3-rpc_client: Added dcerpc_lsa_lookup_names. 
Signed-off-by: Günther Deschner <gd@samba.org>
 2011-01-10 18:20:55 +01:00
Andreas Schneider
c91e756f8d s3-rpc_client: Added dcerpc_lsa_lookup_sids and dcerpc_lsa_lookup_sids3. 
Signed-off-by: Günther Deschner <gd@samba.org>
 2011-01-10 18:20:55 +01:00
Andreas Schneider
8f14229b28 s3-rpc_client: Added dcerpc_lsa_open_policy2. 
Signed-off-by: Günther Deschner <gd@samba.org>
 2011-01-10 18:20:55 +01:00
Andreas Schneider
2f819505af s3-rpc_client: Added dcerpc_lsa_open_policy. 
Signed-off-by: Günther Deschner <gd@samba.org>
 2011-01-10 18:20:54 +01:00
Volker Lendecke
342bb471dc s3: Remove superfluous ; 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Jan 10 15:26:50 CET 2011 on sn-devel-104
 2011-01-10 15:26:50 +01:00
Günther Deschner
a44f76e2c4 s3-selftest: re-sync with s4-selftest wscript. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Jan 10 13:41:38 CET 2011 on sn-devel-104
 2011-01-10 13:41:38 +01:00
Volker Lendecke
b57721faaf s3: Convert enc_blob_send_receive to cli_trans() 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jan  9 11:40:04 CET 2011 on sn-devel-104
 2011-01-09 11:40:04 +01:00
Volker Lendecke
3274d80ffd s3: Fix two incompatible pointer type warnings on Solaris 2011-01-09 10:21:41 +01:00
Volker Lendecke
bdff4591ca s3: Fix some warnings in the zfsacl module 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Jan  8 13:42:20 CET 2011 on sn-devel-104
 2011-01-08 13:42:20 +01:00
Volker Lendecke
61b2ac9121 s3: Avoid a ton of registry writes at startup 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Jan  8 12:39:09 CET 2011 on sn-devel-104
 2011-01-08 12:39:09 +01:00
Volker Lendecke
849816d0df s3: Fix a type error 2011-01-08 11:30:18 +01:00
Volker Lendecke
5a3bc194ad s3: Fix some nonempty blank lines 2011-01-08 11:30:17 +01:00
David Disseldorp
3e61c97a7e s3-printing: remove printer_list_need_refresh 
printer_list_need_refresh() was used previously to ensure one smbd
process did not attempt to update the printer_list tdb during or soon
after update by another smbd.

It is no longer needed, as pcap updates are now only performed by the
parent smbd process following startup, SIGHUP, config update or printcap
cache time expiry.
 2011-01-07 15:37:39 -08:00
David Disseldorp
ff577762b9 s3-printing: remove old entries in pcap_cache_replace 
Callers of pcap_cache_replace() assume the existing printcap cache is
replaced by the new values provided. This is not currently the case,
old entries should be removed.
 2011-01-07 15:37:39 -08:00
David Disseldorp
0b188e7784 s3-printing: Initiate pcap reload from parent smbd 
Since commit 7022554, smbds share a printcap cache (printer_list.tdb),
therefore ordering of events between smbd processes is important when
updating printcap cache information. Consider the following two process
example:
1) smbd1 receives HUP or printcap cache time expiry
2) smbd1 checks whether pcap needs refresh, it does
3) smbd1 marks pcap as refreshed
4) smbd1 forks child1 to obtain cups printer info
5) smbd2 receives HUP or printcap cache time expiry
6) smbd2 checks whether pcap needs refresh, it does not (due to step 3)
7) smbd2 reloads printer shares prior to child1 completion (stale pcap)
8) child1 completion, pcap cache (printer_list.tdb) is updated by smbd1
9) smbd1 reloads printer shares based on new pcap information

In this case both smbd1 and smbd2 are reliant on the pcap update
performed on child1 completion.
The prior commit "reload shares after pcap cache fill" ensures that
smbd1 only reloads printer shares following pcap update, however smbd2
continues to present shares based on stale pcap data.

This commit addresses the above problem by driving pcap cache and
printer share updates from the parent smbd process.
1) smbd0 (parent) receives a HUP or printcap cache time expiry
2) smbd0 forks child0 to obtain cups printer info
3) child0 completion, pcap cache (printer_list.tdb) is updated by smbd0
4) smbd0 reloads printer shares
5) smbd0 notifies child smbds of pcap update via message_send_all()
6) child smbds read fresh pcap data and reload printer shares

This architecture has the additional advantage that only a single
process (the parent smbd) requests printer information from the printcap
backend.

Use time_mono in housekeeping functions As suggested by Björn Jacke.
 2011-01-07 15:37:39 -08:00
David Disseldorp
04248c2cfa s3-printing: reload shares after pcap cache fill 
Since commit eada8f8a, updates to the cups pcap cache are performed
asynchronously - cups_cache_reload() forks a child process to request
cups printer information and notify the parent smbd on completion.

Currently printer shares are reloaded immediately following the call to
cups_cache_reload(), this occurs prior to smbd receiving new cups pcap
information from the child process. Such behaviour can result in stale
print shares as outlined in bug 7836.

This fix ensures print shares are only reloaded after new pcap data has
been received.

Pair-Programmed-With: Lars Müller <lars@samba.org>
 2011-01-07 15:37:39 -08:00
Björn Baumbach
617e342a14 s3-nmbd: Fix bug #7875 
nmbd --port didn't work

Signed-off-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Jan  7 17:44:08 CET 2011 on sn-devel-104
 2011-01-07 17:44:08 +01:00
Günther Deschner
286c3d6d8e s3-waf: add NMBDSOCKETDIR variable. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan  7 16:33:55 CET 2011 on sn-devel-104
 2011-01-07 16:33:55 +01:00
Günther Deschner
5c9eca6fc4 s3-build: fix classic build after libcli netlogon changes. 
Guenther
 2011-01-07 15:02:24 +01:00
Günther Deschner
3294ccbb6d netlogon: move netlogon helpers to ../libcli/netlogon. 
Guenther
 2011-01-07 15:02:24 +01:00
Günther Deschner
75c8e42938 s3-waf: rename LIBCLI_NETLOGON subsystem to LIBRPCCLI_NETLOGON. 
Guenther
 2011-01-07 15:02:24 +01:00
Günther Deschner
358c8ec292 s3-waf: rearrange waf recurses in main wscript_build. 
Guenther
 2011-01-07 15:02:24 +01:00
Günther Deschner
ccf15ebcc3 s3-waf: cleanup wscript_build a little. 
Guenther
 2011-01-07 15:02:24 +01:00
Günther Deschner
0a7d6dc8a8 s3-waf: recurse into ../lib/smbconf. 
Guenther
 2011-01-07 15:02:23 +01:00
Volker Lendecke
3e0915f271 s3: Make nmbd socket dir configurable 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Jan  7 14:14:19 CET 2011 on sn-devel-104
 2011-01-07 14:14:19 +01:00
Volker Lendecke
2672101cc4 s3: Remove some unused code 2011-01-07 13:28:07 +01:00
Volker Lendecke
dab6a35f4c s3: Limit the number of unexpected clients to 200 
DoS protection like the max winbind clients. Settable by
nmbd:unexpected_clients
 2011-01-07 13:28:07 +01:00
Volker Lendecke
0cff82e054 s3: Limit the number of unexpected packets per client to 10 
Non-reading clients could maliciously make nmbd allocate memory
 2011-01-07 13:28:07 +01:00
Volker Lendecke
5f4ff3bfbd s3: Use the new nbt_getdc in winbindd_cm 2011-01-07 13:28:07 +01:00
Volker Lendecke
b4041b59b2 s3: Use the new nbt_getdc in dsgetdcname() 2011-01-07 13:28:06 +01:00
Volker Lendecke
f9520008df s3: Add nbt_getdc 
This is a getdc version that uses /tmp/.nmbd/unexpected
 2011-01-07 13:28:06 +01:00
Volker Lendecke
1137cf8e6f s3: Fix a valgrind error 2011-01-07 13:28:06 +01:00
Volker Lendecke
126b1806b8 s3: Factor out parse_getdc_response 2011-01-07 13:28:06 +01:00
Volker Lendecke
0376d03e6d s3: Lift my_mailslot from prep_getdc_request 2011-01-07 13:28:05 +01:00
Volker Lendecke
6ba4bddb61 s3: Make name_query use /tmp/.nmbd/unexpected 2011-01-07 13:28:05 +01:00
Volker Lendecke
a32f021d66 s3: Make node_status_query use /tmp/.nmbd/unexpected 2011-01-07 13:28:04 +01:00
Volker Lendecke
77a9b0e265 s3: Add nb_trans_send/recv 
This does an async port 137 transaction: It connects to /tmp/.nmbd/unexpected,
sends out the query and then waits for a reply on both the socket as well as
data from /tmp/.nmbd/unexpected. Every packet is passed through a validator. If
that returns true, the packet received is finally accepted.
 2011-01-07 13:28:04 +01:00
Volker Lendecke
cbd5e4e16b s3: Add sock_packet_read 
Read packets from both a socket and from /tmp/.nmbd/unexpected simultaneously
 2011-01-07 13:28:04 +01:00
Volker Lendecke
d801d4da2d s3: Add packet_trn_id() 2011-01-07 13:28:04 +01:00
Volker Lendecke
5297f3fcff s3: Make nmbd listen on the unexpected socket 2011-01-07 13:28:04 +01:00
Volker Lendecke
b2c62d639d s3: Basic infrastructure for /tmp/.nmbd/unexpected 
This provides the framework to replace the unexpected.tdb file. Nmbd will
listen on /tmp/.nmbd/unexpected. A client interested in unexpected packets
connects there. It sends a nb_packet_query plus a potential mailslot name for
dgram packets. It waits for a single ack byte to avoid races. After that has
happened, nmbd will pass down all matching packets through that socket.

nb_packet_server_create and nb_packet_dispatch are the nmbd routines,
nb_packet_reader_send/recv and nb_packet_read_send/recv are the client ones.
 2011-01-07 13:28:03 +01:00
Günther Deschner
2187c49013 s3-waf: fix winbind_krb5_locator.so realname. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan  7 11:13:29 CET 2011 on sn-devel-104
 2011-01-07 11:13:29 +01:00
Günther Deschner
f405384ad8 s3-waf: make the --with-Xdir options work more like in the classic build. 
Also remove duplicates and sort the tables.

Still not sure if I understand the reason of processing the flags table after
the diroptions table, as every option you give it via configure was overwritten
immediately.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan  7 00:57:10 CET 2011 on sn-devel-104
 2011-01-07 00:57:10 +01:00
Günther Deschner
fa1fd85eea s3-net: Fix bug #7690: retry DNS updates when connection to one nameserver has failed. 
Initial patch from Patrik Martinsson <patrik.martinsson@smhi.se>.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Jan  6 17:29:11 CET 2011 on sn-devel-104
 2011-01-06 17:29:11 +01:00
Günther Deschner
7ee75c9548 lib/addns: move DNS client library to the main directory. 
Guenther
 2011-01-06 16:42:56 +01:00
Günther Deschner
2958a43fad s3-waf: no need to compile librpc/gen_ndr/cli_dfs.c anymore. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Jan  6 15:20:14 CET 2011 on sn-devel-104
 2011-01-06 15:20:14 +01:00
Günther Deschner
577b4e527c s3-build: no need to compile librpc/gen_ndr/cli_dfs.c anymore. 
Guenther
 2011-01-06 14:35:18 +01:00
Günther Deschner
7888108e89 s3-rpcclient: use dcerpc_dfs_X functions. 
Guenther
 2011-01-06 14:35:18 +01:00
Volker Lendecke
4de4703bb9 s3: Fix some nonempty blank lines 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Jan  5 16:03:24 CET 2011 on sn-devel-104
 2011-01-05 16:03:24 +01:00
Stefan Metzmacher
899adcaec9 s3:build: don't use cli_dssetup.c any more 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Jan  4 22:21:48 CET 2011 on sn-devel-104
 2011-01-04 22:21:48 +01:00
Stefan Metzmacher
4c37257f16 s3:net_utils: use dcerpc_dssetup_DsRoleGetPrimaryDomainInformation() 
metze
 2011-01-04 21:29:03 +01:00
Stefan Metzmacher
f016e4d4bd s3:winbindd: use dcerpc_dssetup_DsRoleGetPrimaryDomainInformation() 
metze
 2011-01-04 21:29:01 +01:00
Stefan Metzmacher
c6aedc9750 s3:rpcclient: use dcerpc_binding_handle based client stubs in cmd_dssetup.c 
metze
 2011-01-04 21:28:59 +01:00
Stefan Metzmacher
62aa019a1b s3:build: don't use cli_epmapper.c anymore 
metze
 2011-01-04 21:28:58 +01:00
Stefan Metzmacher
6dd5ccd041 s3:rpcclient: improve "epmmap" output 
metze
 2011-01-04 21:28:56 +01:00
Stefan Metzmacher
697d4ea8ff s3:rpcclient: use dcerpc_binding_handle bases client stubs in cmd_epmapper.c 
metze
 2011-01-04 21:28:54 +01:00
Stefan Metzmacher
fba2fdf265 s3:rpc_client: use dcerpc_epm_Map() and don't ignore 'result' anymore. 
metze
 2011-01-04 21:28:49 +01:00
Andreas Schneider
8925b03b59 s3-rpcecho: Only register rpcecho in the developer build. 
Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Tue Jan  4 18:56:38 CET 2011 on sn-devel-104
 2011-01-04 18:56:38 +01:00
Stefan Metzmacher
e1e8693525 s3:build: don't use cli_ntsvcs.c any more. 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Jan  4 17:23:17 CET 2011 on sn-devel-104
 2011-01-04 17:23:17 +01:00
Stefan Metzmacher
d99e9c389b s3:rpcclient: use dcerpc_binding_handle client stubs in cmd_ntsvcs.c 
metze
 2011-01-04 16:37:19 +01:00
Stefan Metzmacher
fbcbeabd65 s3:build: don't use cli_wbint.c any more 
metze
 2011-01-04 16:37:19 +01:00
Günther Deschner
4ebf2f9745 s3-waf: convert SAMBA_VERSION into a subsystem. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Jan  4 15:10:52 CET 2011 on sn-devel-104
 2011-01-04 15:10:52 +01:00
Günther Deschner
589d1bf57e s3-waf: convert PASSCHANGE into a subsystem. 
Guenther
 2011-01-04 13:05:51 +01:00
Günther Deschner
34596493ba s3-waf: add UTIL_TDB subsystem. 
Guenther
 2011-01-04 12:56:29 +01:00
Andreas Schneider
d2e93cce88 s3-waf: Fixed the static rpc service build. 
Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Tue Jan  4 12:09:48 CET 2011 on sn-devel-104
 2011-01-04 12:09:48 +01:00
Andreas Schneider
d4f5bf0c36 s3-smbd: Call the rpc service shutdown functions. 2011-01-04 11:23:21 +01:00
Andreas Schneider
8ece780d1b s3-build: Remove broken RPC modules support. 
With the current module support for rpc we're not able to call the init
functions with the rpc callback structure. So init functions and
shutdown functions aren't called. These init functions are needed to
setup pre requirements like migrating the printer databases and register
at the endpoint mapper. The shutdown functions cleanup memory and
deregister from the endpoint mapper.
 2011-01-04 11:23:21 +01:00
Andreas Schneider
9aa8763976 s3-smbd: Call all the rpc services in the right order. 2011-01-04 11:23:21 +01:00
Stefan Metzmacher
ddbbc7b12a s3:net_rpc_vampire_keytab: don't return -1 on success (bug #7899) 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Jan  3 19:05:11 CET 2011 on sn-devel-104
 2011-01-03 19:05:11 +01:00
Günther Deschner
4316895bc7 s3-waf: fix the build. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Jan  3 18:19:01 CET 2011 on sn-devel-104
 2011-01-03 18:19:01 +01:00
Stefan Metzmacher
2d466b41cd s3:librpc: use netsec_outgoing_sig_size() instead of a hardcoded signature 
size

metze
 2011-01-03 16:44:29 +01:00
Michael Adam
3e52b99a31 s3:winbindd/idmap_ad.c: update my C 
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Mon Jan  3 09:19:07 CET 2011 on sn-devel-104
 2011-01-03 09:19:07 +01:00
Michael Adam
55f7a0417f s3:winbindd/idmap_util.c: add my C 2011-01-03 08:34:04 +01:00
Michael Adam
5f969d7a94 s3:winbindd/idmap.c: add my C 2011-01-03 08:34:04 +01:00
Stefan Metzmacher
81a167b5df s3: Happy New Year 2011 
metze
 2011-01-02 17:55:05 +01:00
Volker Lendecke
593c004b74 s3: Fix a memleak in receive_getdc_response 
It's the free_packet() that was missing. On the way, I've changed the
"return false;" to a "goto fail;", which makes the patch a bit larger.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jan  2 14:27:56 CET 2011 on sn-devel-104
 2011-01-02 14:27:56 +01:00
Michael Adam
45cb9bba37 s3:net: make idmap_store_secret static. 
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Sun Jan  2 13:41:07 CET 2011 on sn-devel-104
 2011-01-02 13:41:07 +01:00
Michael Adam
7f256a740c s3:net: fix the usage for net idmap secret (removing alloc) 2011-01-02 12:51:55 +01:00
Michael Adam
11016f2a6b s3:net: remove alloc parameter from idmap_store_secret() (net idmap store). 2011-01-02 12:51:55 +01:00
Michael Adam
2d3a8b196f s3:idmap_ldap: remove special handling of alloc secret (not used any more). 2011-01-02 12:51:54 +01:00
Michael Adam
52b37de5d8 s3:idmap_ldap: remove unused idmap_ldap_alloc_context. 2011-01-02 12:51:54 +01:00
Michael Adam
91e7430817 s3:idmap_ldap: remove alloc context member from ldap_idmap_context 2011-01-02 12:51:54 +01:00
Michael Adam
5908bd62b5 s3:idmap_ldap: remove use of alloc context from idmap_ldap_allocate_id(). 2011-01-02 12:51:54 +01:00
Michael Adam
510bf2d591 s3:idmap_ldap: remove unused idmap_ldap_alloc_close_destructor(). 2011-01-02 12:51:54 +01:00
Michael Adam
f83fa1ec20 s3:idmap_ldap: remove unused idmap_ldap_alloc_init(). 2011-01-02 12:51:54 +01:00
Michael Adam
632e232fc4 s3:idmap_ldap: don't call idmap_ldap_alloc_init in idmap_ldap_init. 
Call verify_idpool() instead.
 2011-01-02 12:51:54 +01:00
Michael Adam
58508c9726 s3:idmap_ldap: remove use of the ldap_idmap_alloc_context from verify_idpool(). 
Allocation is now subsumed in the idmap ldap config.
This is the beginning of the removal of the idmap ldap alloc parameters.
 2011-01-02 12:51:54 +01:00
Jeremy Allison
9d754da112 Fix memory leak I introduced when refactoring unexpected packet code. 
Found by Volker.

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sun Jan  2 06:11:13 CET 2011 on sn-devel-104
 2011-01-02 06:11:13 +01:00
Volker Lendecke
9ccef4e62b s3: Remove unused mem_ctx arg from set_getdc_request 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Jan  1 23:00:24 CET 2011 on sn-devel-104
 2011-01-01 23:00:24 +01:00
Volker Lendecke
b2ba2b956e s3: Factor out prep_getdc_request 2011-01-01 22:14:19 +01:00
Volker Lendecke
e0abc5c15f s3: cli_send_mailslot -> cli_prep_mailslot 2011-01-01 22:14:19 +01:00
Volker Lendecke
bb6da9f06c s3: Fix some nonempty blank lines 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Jan  1 16:03:23 CET 2011 on sn-devel-104
 2011-01-01 16:03:23 +01:00
Volker Lendecke
659bb646e4 s3: Add some const to receive_getdc_response 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Dec 31 14:48:57 CET 2010 on sn-devel-104
 2010-12-31 14:48:57 +01:00
Volker Lendecke
ba15b7af07 s3: Add some const to send_getdc_request 2010-12-31 14:02:04 +01:00
Volker Lendecke
8e861852c0 s3: Fix some nonempty blank lines 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Dec 31 10:58:31 CET 2010 on sn-devel-104
 2010-12-31 10:58:31 +01:00
Stefan Metzmacher
f1d15ea54c s3:lib/netapi: don't set SAMR_FIELD_FULL_NAME if we just want to set the account name (bug #7896) 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Dec 30 18:09:13 CET 2010 on sn-devel-104
 2010-12-30 18:09:13 +01:00
Volker Lendecke
d05fb4b7b7 s3: Fix two uninitialized variables 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Dec 30 12:52:47 CET 2010 on sn-devel-104
 2010-12-30 12:52:47 +01:00
Volker Lendecke
86ff8cf227 s3: Allow more control over smbsock_[any_]connect 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Dec 29 23:30:44 CET 2010 on sn-devel-104
 2010-12-29 23:30:44 +01:00
Jeremy Allison
9b31f6ab6c Fix bug #7892 - open_file_fchmod() leaves a stale lock. 
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Dec 29 02:15:23 CET 2010 on sn-devel-104
 2010-12-29 02:15:23 +01:00
Volker Lendecke
4622812a41 s3: Make name_query return NTSTATUS 
Also use talloc for the result

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Dec 28 18:21:05 CET 2010 on sn-devel-104
 2010-12-28 18:21:05 +01:00
Volker Lendecke
28d997a890 s3: AllowDebugChange is gone 2010-12-28 17:18:14 +01:00
Volker Lendecke
5717114318 s3: Make node_status_query return NTSTATUS 
Also make the result talloc'ed

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Dec 28 13:46:59 CET 2010 on sn-devel-104
 2010-12-28 13:46:59 +01:00
Volker Lendecke
e1ab3c3470 s3: Remove an ancient typedef 2010-12-28 12:59:11 +01:00
Volker Lendecke
b0ff97d8d3 s3: Fix some typos 2010-12-28 12:59:11 +01:00
Stefan Metzmacher
c604388ec3 s3:winbindd: remove useless ';' 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Dec 28 12:45:20 CET 2010 on sn-devel-104
 2010-12-28 12:45:20 +01:00
Stefan Metzmacher
e1de884eaa s3:selftest: mark samba3.posix_s3.smb2.lock (dc).rw-exclusive as known to fail 
This sometimes fails like this:

[218/271 in 22m22s] samba3.posix_s3.smb2.lock (dc)
UNEXPECTED(failure): samba3.posix_s3.smb2.lock (dc).rw-exclusive
REASON: _StringException: _StringException: ../torture/smb2/lock.c:406: status was NT_STATUS_END_OF_FILE, expected NT_STATUS_OK: (../torture/smb2/lock.c:406)

command: LD_LIBRARY_PATH=/memdisk/tridge/flakey/b18675/source3/source3/bin/shared:/memdisk/tridge/flakey/b18675/source3/source3/bin: bin/smbtorture4 --configfile=$SMB_CONF_PATH --maximum-runtime=1200 --target=samba3 --basedir=/memdisk/tridge/flakey/b18675/source3/source3/st --option="torture:winbindd_netbios_name=$SERVER" --option="torture:winbindd_netbios_domain=$DOMAIN" --option=torture:localdir=/memdisk/tridge/flakey/b18675/source3/source3/st/dc/share --option=torture:sharedelay=100000 //$SERVER_IP/tmp -U$USERNAME%$PASSWORD smb2.lock 2>&1 | ../selftest/filter-subunit --prefix "samba3.posix_s3.smb2.lock (dc)."
expanded command: LD_LIBRARY_PATH=/memdisk/tridge/flakey/b18675/source3/source3/bin/shared:/memdisk/tridge/flakey/b18675/source3/source3/bin: bin/smbtorture4 --configfile=/memdisk/tridge/flakey/b18675/source3/source3/st/client/client.conf --maximum-runtime=1200 --target=samba3 --basedir=/memdisk/tridge/flakey/b18675/source3/source3/st --option="torture:winbindd_netbios_name=LOCALDC2" --option="torture:winbindd_netbios_domain=SAMBA-TEST" --option=torture:localdir=/memdisk/tridge/flakey/b18675/source3/source3/st/dc/share --option=torture:sharedelay=100000 //127.0.0.2/tmp -Utridge%localdc2pass smb2.lock 2>&1 | ../selftest/filter-subunit --prefix "samba3.posix_s3.smb2.lock (dc)."
ERROR: Testsuite[samba3.posix_s3.smb2.lock (dc)]
REASON: Exit code was 1

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Dec 27 12:08:51 CET 2010 on sn-devel-104
 2010-12-27 12:08:51 +01:00
Stefan Metzmacher
e9dddc55e3 s3:libsmb: use 16 zero bytes as channel binding checksum in the gssapi checksum (bug #7883) 
This fixes SMB session setups with kerberos against some closed
source SMB servers.

The new behavior matches heimdal and mit.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Dec 23 09:38:43 CET 2010 on sn-devel-104
 2010-12-23 09:38:43 +01:00
Jeremy Allison
30d29e64cb All calls to event_add_to_select_args() call GetTimeOfDay() and 
pass this in as the &now parameter. Push this call inside of
event_add_to_select_args() to the correct point so it doesn't
get called unless needed.

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Dec 23 01:08:11 CET 2010 on sn-devel-104
 2010-12-23 01:08:11 +01:00
Volker Lendecke
03b8b8e199 s3: Remove unused open_any_socket_out 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Dec 22 17:27:29 CET 2010 on sn-devel-104
 2010-12-22 17:27:29 +01:00
Volker Lendecke
5d4ac40f69 s3: Use smbsock_any_connect in winbind 2010-12-22 16:39:15 +01:00
Volker Lendecke
d5188fcd18 s3: Retry *SMBSERVER in nb_connect 2010-12-22 16:39:15 +01:00
Volker Lendecke
3ae7ef73b0 s3: Test smbsock_any_connect 2010-12-22 16:39:15 +01:00
Volker Lendecke
d8e3d0af9e s3: Add smbsock_any_connect 2010-12-22 16:39:15 +01:00
Volker Lendecke
49cd92b218 s3: Add an async smbsock_connect 
This connects to 445 and after 5 milliseconds also to 139. It treats a netbios
session setup failure as equivalent as a TCP connect failure. So if 139 is
faster but fails the nb session setup, the 445 still has the chance to succeed.
 2010-12-22 16:39:15 +01:00
Volker Lendecke
02a74fd36d s3: Add async cli_session_request 
This does not do the redirects, but I think that might be obsolete anyway
 2010-12-22 16:39:15 +01:00
Volker Lendecke
444dcc59c2 s3: Add some const to name_mangle() 2010-12-22 16:39:14 +01:00
Günther Deschner
87934d8c79 s3-waf: fix the build. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Dec 22 15:55:11 CET 2010 on sn-devel-104
 2010-12-22 15:55:11 +01:00
Stefan Metzmacher
d9be7e9368 s3:lib/gencache: fix memory leak in error path 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Dec 22 15:08:30 CET 2010 on sn-devel-104
 2010-12-22 15:08:30 +01:00
Günther Deschner
94e83e385e s3-printing: fix crash bug in print_spool_open(). 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Dec 22 14:21:58 CET 2010 on sn-devel-104
 2010-12-22 14:21:58 +01:00
Günther Deschner
d0e164458d s3-spoolss: handle NTTIME(0) as "01/01/1601" REG_SZ in driver dates. 
Guenther
 2010-12-22 13:33:18 +01:00
Stefan Metzmacher
2c657d8705 s3:libsmb/namequery.c: don't leak 'pserver' 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Dec 22 09:54:31 CET 2010 on sn-devel-104
 2010-12-22 09:54:30 +01:00
Jeremy Allison
88c3e505e9 Fix a warning message. 
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Dec 22 03:59:18 CET 2010 on sn-devel-104
 2010-12-22 03:59:18 +01:00
Jeremy Allison
e8f7c60ec2 My algorithm for determining whan an incoming sequence number can be allowed is incorrect. 
(I based it on the text in MS-SMB2, silly me :-). Fix it so incoming sequence numbers
can range over the entire allowable bitmap range. This fixes a repeatable
disconnect against Win7.

Jeremy.
 2010-12-21 18:07:52 -08:00
Stefan Metzmacher
7a47aed770 s3:cli_np_tstream: if SMBtrans is desired, the readv needs to wait for the last writev chunk. 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Dec 21 17:43:06 CET 2010 on sn-devel-104
 2010-12-21 17:43:06 +01:00
Matthias Dieter Wallnöfer
13fa6743d8 s3/s4:auth SPNEGO - adaptions for the removed "const" from OIDs 
This is needed in order to suppress warnings.
 2010-12-21 15:10:37 +11:00
Jeremy Allison
0a5f4f523f Keep track of the sparse status of an open file handle. Allows bypass of 
strict allocation on sparse files. Files opened as POSIX opens are always
sparse.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Dec 21 04:12:22 CET 2010 on sn-devel-104
 2010-12-21 04:12:22 +01:00
Jeremy Allison
8998f4b013 Added call out to a Linux-compatible fallocate() when we need to extend a file 
allocation extent without changing end-of-file size.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Dec 21 02:41:24 CET 2010 on sn-devel-104
 2010-12-21 02:41:23 +01:00
Ken Harris
09aea03813 CREATE in a compound CREATE/NOTIFY sequence was being passed through set_operation_credits() 
twice (ultimately perhaps because of bug 7331 involving this compound sequence and the need
to be ready for any incoming CANCEL of the NOTIFY). This had the server thinking it had
granted more credit than it actually had, which lead to zero-credits being granted in interim
NOTIFY responses.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Dec 20 20:59:55 CET 2010 on sn-devel-104
 2010-12-20 20:59:55 +01:00
Jeremy Allison
e7707d5abd From metze's work on sparse attributes. FILE_ATTRIBUTE_SPARSE is valid on get but not on set. 
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Dec 20 20:11:22 CET 2010 on sn-devel-104
 2010-12-20 20:11:22 +01:00
David Disseldorp
139e2cbb13 s3-printing: fix printer_list_traverse() 
The tdb traverse function returns the number of elements traversed, or
less than zero on error, printer_list_traverse() is incorrectly checking
for non-zero return.

Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Mon Dec 20 18:44:41 CET 2010 on sn-devel-104
 2010-12-20 18:44:41 +01:00
Volker Lendecke
bfc4fe4012 s3: Remove unused "retry" from cli_start_connection 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Dec 20 17:58:33 CET 2010 on sn-devel-104
 2010-12-20 17:58:33 +01:00
Volker Lendecke
d096de56b1 s3: Remove unused "retry" from cli_full_connection 2010-12-20 17:10:58 +01:00
Volker Lendecke
660190632e s3: Always retry the DC connection in auth_domain 
The only condition that cli_full_connection marks as non-retryable is the basic
name lookup and TCP connect. To me this is pretty fishy. For example if the
negprot fails, this is supposed to be more retryable than a NetBIOS name lookup
failure? I'd rather think the opposite is true.

Jeremy, this is code from 2002, 389a16d9d5. If you have any comments from
back then, let me know :-)

Volker
 2010-12-20 17:10:57 +01:00
Volker Lendecke
09cccee273 s3: Remove some unused variables 2010-12-20 17:10:57 +01:00
Volker Lendecke
fd49ed238c s3: "make etags" should not grow TAGS infinitely... 2010-12-19 23:25:07 +01:00
Volker Lendecke
c6b5136f02 s3: Fix bug 7066 -- wbcAuthenticateEx gives unix times 
We might eventually want to change this, but right now we get unix times
out of the winbind pipe struct
 2010-12-19 23:25:06 +01:00
Volker Lendecke
92e138f920 s3: Use the right uid winbindd_raw_kerberos_login() 2010-12-19 23:25:06 +01:00
Volker Lendecke
a881d6ab86 wb_reqtrans is not used in libwbclient 2010-12-19 23:25:06 +01:00
Volker Lendecke
c0a7c9f991 Move wbc_async.[ch] to its only user: smbtorture3 2010-12-19 23:25:06 +01:00
Volker Lendecke
6bfd745c61 libwbclient: Put the wb_reqtrans definitions into wb_reqtrans.h 2010-12-19 23:25:06 +01:00
Volker Lendecke
a159958065 s3: wcache_invalidate_samlogon only needs the SID 2010-12-19 23:25:06 +01:00
Volker Lendecke
e113b1c64f s3: netsamlogon_clear_cached_user only needs the SID 2010-12-19 23:25:06 +01:00