1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-15 23:24:37 +03:00

534 Commits

Author SHA1 Message Date
Jeremy Allison
0551426657 Ensure that dup_sec_desc copies the 'type' field correctly. This caused
me to expose a type arguement to make_sec_desc(). We weren't copying
the SE_DESC_DACL_AUTO_INHERITED flag which could cause errors on
auto inherited checks.
Jeremy.
(This used to be commit 28b315a7501f42928d73efaa75f74146ba95cf2d)
2003-09-19 21:57:43 +00:00
Gerald Carter
8ce241cb80 fix unitiailized timestamp where merging print_jobs and lpq listing
(This used to be commit 8382cd6796992e55bf10f381089cb740052a0bca)
2003-09-11 17:01:26 +00:00
Jeremy Allison
ca1c6ebb11 Fix a nasty mess, and also bug #296. passdb/pdb_ldap.c was not converting
to/from utf8 for some calls. The libads code gets this right. Wonder why
the passdb code doesn't use it ?
Jeremy.
(This used to be commit 910d21d3164c2c64773031fddaad35ea88e72a04)
2003-09-10 22:33:06 +00:00
Jeremy Allison
94f59f5492 More tuning from cachegrind. Change most trim_string() calls to trim_char(0,
as that's what they do. Fix string_replace() to fast-path ascii.
Jeremy.
(This used to be commit f35e9a8b909d3c74be47083ccc4a4e91a14938db)
2003-09-05 19:59:55 +00:00
Gerald Carter
14eb5f108e make sure the printer data value exists before saying you deleted it
(This used to be commit 017133ea0c3eb0579710727379585df2b585614d)
2003-08-25 13:05:48 +00:00
Gerald Carter
983b4e7011 it never amazes me when some new things crawls out of the windows
spooler. :-(

When installing the Adobe PS driver onto a Samba printer via cupsaddsmb,
I noticed a WIN2k client sending DeletePrinterData("DependentFiles")
pver and over.  I also noticed that we never checked to see if the
value was valid.  No now we do and return WERR_BADFILE which I think
is correct.

Next, I noticed that we never wrote the updated printer out to disk
after a succesfully DeletePrinterData[Ex]().

Finally, I found a driver (Canon BJC 1000 using the Adobe PS drivers
and foomatic PPD file) that was destroying the device name string
in the devmode.  So now get_a_printer_2() always writes out the
device name in \\server\share form.

I think these changes might fix bug 294.
(This used to be commit deb25780874b66e68ac597db24fbc50e7f7458b5)
2003-08-23 03:34:24 +00:00
Gerald Carter
bd886acab8 stupid...stupid...stupid....fix bug 294 by looking at the right arch string
(This used to be commit 584df6b8d691b30d6ead485cfc8dce7bb30cd8bb)
2003-08-16 01:40:38 +00:00
Herb Lewis
aa39cc37da get rid of more compiler warnings
(This used to be commit 398bd14fc6e2f8ab2f34211270e179b8928a6669)
2003-08-15 04:42:05 +00:00
Gerald Carter
9b80349a2f fix bug 294; win9x driver lookups should always use version 0
(This used to be commit 8cc1a49c13b24e8fe501caa0d7d695d34a58d08d)
2003-08-14 20:51:41 +00:00
Tim Potter
7d833de662 More printf portability fixes. Got caught out by some gcc'isms last
time.  )-:
(This used to be commit 59dae1da66a5eb7e128263bd578f167d8746e9f0)
2003-07-25 04:24:40 +00:00
Tim Potter
77373f1f8e More printf fixes - size_t is long on some architectures.
(This used to be commit ba4d334b822248d8ab929c9568533431603d967e)
2003-07-24 23:46:27 +00:00
Jeremy Allison
a9c0fcfa37 Some fclose -> x_fclose found by Tony Jago.
Jeremy.
(This used to be commit 919078cf397155ede0169ce95a726d0fdbef696a)
2003-07-24 07:02:55 +00:00
Gerald Carter
eb2b683022 fix cache coherency bug in print handle print_info_2 cache.
Needs to be rewritten to use a reference counter, but this
will work for now.

also the memory allocation in the printing code needs to be cleaned
up to use talloc exclusively.
(This used to be commit 3d293027563b36411b7f84ed9d8f47f926271c6f)
2003-07-14 19:51:34 +00:00
Gerald Carter
c674e411c7 i guess i'm the only one this ever annyoed...
fix the confusion when we tdb_lock_bystring() but
we retrieve an entry using tdb_fetch_by_string.
It's now always tdb.*bystring()
(This used to be commit 66359531b89368939f0e8f584a45844b5f2f99e7)
2003-07-10 20:37:01 +00:00
Jeremy Allison
ce72beb2b5 Removed strupper/strlower macros that automatically map to strupper_m/strlower_m.
I really want people to think about when they're using multibyte strings.
Jeremy.
(This used to be commit ff222716a08af65d26ad842ce4c2841cc6540959)
2003-07-03 19:11:31 +00:00
Gerald Carter
fb5a006c09 fix typos in log messages and comments.
(This used to be commit fd24183ec30688f3699e466bd4d908b24918e328)
2003-07-01 05:45:16 +00:00
Jeremy Allison
0e983b32fd Some const correctness. Stop tdb being used as a remote backend. If an
idmap backend is specified cause smbd to ask winbindd (use winbindd if
you want a consistant remote backend solution).
Should work well enough for next beta now...
Jeremy.
(This used to be commit 8f830c509af5976d988a30f0b0aee4ec61dd97a3)
2003-06-27 20:55:48 +00:00
Gerald Carter
f414539d86 ifdef out some functions that are not used when HAVE_ADS is not defined
(This used to be commit 2d192e0431c7b754cf9db2306acb01fbe4068a14)
2003-06-25 19:49:27 +00:00
Gerald Carter
f51d769dd3 large change:
*)  consolidates the dc location routines again (dns
    and netbios)  get_dc_list() or get_sorted_dc_list()
    is the authoritative means of locating DC's again.

    (also inludes a flag to get_dc_list() to define
     if this should be a DNS only lookup or not)

    (however, if you set "name resolve order = hosts wins"
     you could still get DNS queries for domain name IFF
     ldap_domain2hostlist() fails.  The answer?  Fix your DNS
     setup)

*)  enabled DOMAIN<0x1c> lookups to be funneled through
    resolve_hosts resulting in a call to ldap_domain2hostlist()
    if lp_security() == SEC_ADS

*)  enables name cache for winbind ADS backend

*)  enable the negative connection cache for winbind
    ADS backend

*)  removes some old dead code

*)  consolidates some duplicate code

*)  moves the internal_name_resolve() to use an IP/port pair
    to deal with SRV RR dns replies.  The namecache code
    also supports the IP:port syntax now as well.

*)  removes 'ads server' and moves the functionality back
    into 'password server' (which can support "hostname:port"
    syntax now but works fine with defaults depending on
    the value of lp_security())
(This used to be commit d7f7fcda425bef380441509734eca33da943c091)
2003-06-25 17:41:05 +00:00
Tim Potter
add20d8f8f Squash another compiler warning.
(This used to be commit 8b208834354db39797e45fd041c408c7ab6eb314)
2003-05-27 07:29:13 +00:00
Alexander Bokovoy
bc2a3748e9 Prefix VFS API macros with SMB_ for consistency and to avoid problems with VFS_ macros at system side. We currently have one clash with AIX and its VFS_LOCK. Compiled and tested -- no new functionality or code, just plain rename of macros for yet-unreleased VFS API version. Needs to be done before a24 is out
(This used to be commit c2689ed118b490e49497a76ed6a2251262018769)
2003-05-14 10:59:01 +00:00
Alexander Bokovoy
e7c8c15888 Fix VFS layer:
1. Finally work with cascaded modules with private data storage per module
2. Convert VFS API to macro calls to simplify cascading
3. Add quota support to VFS layer (prepare to NT quota support)

Patch by Stefan (metze) Metzemacher, with review of Jelmer and me
Tested in past few weeks. Documentation to new VFS API for third-party developers to follow
(This used to be commit 91984ef5caa2d13c5d52e1f535bd3bbbae1ec978)
2003-05-11 23:34:18 +00:00
Andrew Bartlett
376b8d57ee Elsewhere, we use a #define for this environment variable name, so do the
same here.

Andrew Bartlett
(This used to be commit a4556786d28724309321a02afbf5005158440258)
2003-05-09 09:37:12 +00:00
Gerald Carter
6760896739 removing printing = SOFTQ since no one knows what it is
(This used to be commit 283953472229952f7f2613a207515580cd0919c3)
2003-04-29 05:06:18 +00:00
Jim McDonough
fda7b4b226 Get credentials before publishing printers.
(This used to be commit 674174fcca234a44d1778ee092998338cbd7a553)
2003-04-25 21:51:26 +00:00
Andrew Bartlett
2a3a9f0bf4 Merge the 'safe' parts of my StrnCpy patch - many of the users really wanted
a pstrcpy/fstrcpy or at most a safe_strcpy().

These have the advantage of being compiler-verifiable.

Get these out of the way, along with a rewrite of 'get_short_archi' in the
spoolss client and server.  (This pushes around const string pointers, rather
than copied strings).

Andrew Bartlett
(This used to be commit 32fb801ddc035e8971e9911ed4b6e51892e9d1cc)
2003-04-23 13:27:35 +00:00
Jeremy Allison
30418a47c6 Limit the number of outstanding print notify messages for a process to
1000.
Jeremy.
(This used to be commit 2e5e4c10d2377493913554e7dab79d97a4d16d87)
2003-04-23 00:19:30 +00:00
Jeremy Allison
cf00ce3e87 Fix mem leak. Spotted by tpot (thanks Tim).
Jeremy.
(This used to be commit 03a1f46e3448913cc21ed89aafaa22818d4026d0)
2003-04-16 08:46:03 +00:00
Tim Potter
862c88d810 Array size fixup for construct_nt_devicemode() from HEAD.
(This used to be commit 5d1e8cca03b3908e2266e39f4b50ef16ef4ef2b2)
2003-04-14 03:50:38 +00:00
Jeremy Allison
6e0bd81f44 Grr. Get rid of one of the extra NULL's that crept in from app-head.
Spotted by Andrew Esh.
Jeremy.
(This used to be commit 9e6e6c3f50844cf4322d6dd193c4e24b76bae9ba)
2003-04-10 19:34:52 +00:00
Jeremy Allison
7c735eabc9 Ensure we're not filtering our essential delete messages.
Added jobid debug when unpacking message.
Jeremy.
(This used to be commit 8a6f3313e69c6d47e20838f42ebc9f8a2ce9ddc4)
2003-04-10 18:43:13 +00:00
Jeremy Allison
4b5548d8dc Ensure print queue array is zeroed out before returning.
Jeremy.
(This used to be commit f0fac6a1e3574d2d0419968b8e806b5de91f5a81)
2003-04-09 00:00:08 +00:00
Jeremy Allison
7991cf1e52 Fix the new storage code to correctly convert from system queue info to
pjob info. Ensure we retrieve more than one job from the storage code.
Jeremy.
(This used to be commit 59be98401c5a8b419597c18acbe996b469bbe89a)
2003-04-04 01:02:20 +00:00
Jeremy Allison
a9b39993fa Subtle changes to message handling after ENUMJOBS.
Jeremy.
(This used to be commit e5e83544dc0acf812bfa5ea17960b5a6be954ca1)
2003-04-02 02:31:51 +00:00
Jeremy Allison
5ab2abd707 Fix extra NULL arg added during app-head merge.
Jeremy.
(This used to be commit b2ef052adad01c37f0fd4b9b82a16a9989d57082)
2003-03-26 19:35:37 +00:00
Jeremy Allison
67df8fb300 Merge of new appliance-head scalable printing fixes.
Jeremy.
(This used to be commit 331e621b580f997592892be0226fb452c67ae9e1)
2003-03-21 22:00:21 +00:00
Jeremy Allison
3be18a1fba lib/messages.c: Check return from chainlock before modifying message queue.
Apply the job returned limit across all requests for job queues.
Jeremy.
(This used to be commit bf795b684e608f82db822e0759e7b69afd451b65)
2003-03-20 00:52:37 +00:00
Jeremy Allison
a3d7a1ea20 Fix off by one bug noticed by Andrew Bartlett.
Jeremy.
(This used to be commit 759aab9944e8dc5c38e224ace738b75ded07ee54)
2003-03-14 02:10:26 +00:00
Gerald Carter
ccb58b303a add #define for the max device name length in a DEVICEMODE
(This used to be commit 52ef84b53495db1eac6ecfb0b926ef8df7ea5cc5)
2003-03-06 16:09:11 +00:00
Jeremy Allison
d45fe965ef Writable string const fixes.
Jeremy.
(This used to be commit c832e95c2f4daf175954a60f3c56420cf2f35b45)
2003-03-05 01:30:15 +00:00
Jeremy Allison
6626fef5d4 Fix for little-used lpq parser.
Jeremy.
(This used to be commit 75b36459ab1797bdff98ed91d7870bd48adebb54)
2003-03-05 00:54:47 +00:00
Jeremy Allison
0bf15545dd Ensure added jobs increment total_jobs.
Jeremy.
(This used to be commit a75d9fc4e1c26e3ae15a97508f6f1cf69fe54148)
2003-03-01 00:49:00 +00:00
Gerald Carter
23b3b29eec Progress on CR 601
cache the printer_info_2 with the open printer handle.
cache is invalidated on a mod_a_printer() call **on that smbd**.

Yes, this means that the window for admins to step on each other
from different clients just got larger, but since handles a generally
short lived this is probably ok.
(This used to be commit 31272d3b6bb9ec62fd666301c7adfa0c1720a99b)
2003-02-25 20:53:53 +00:00
Andrew Bartlett
e075e1dfa9 Missed one in the previous merge - user_ok() and user_in_group() now take
an optional list of groups the user is in.
(This used to be commit 39f3bec0f62520e49a087403287330ed5f3a79c5)
2003-02-24 02:47:14 +00:00
Jeremy Allison
647d65e08b Bit of a hack job to prevent smbprn.XXX jobs appearing in the queue if the
jobid is below the UNIX_JOB_START number.
Jeremy.
(This used to be commit 7ec1c8869d3df9af77ff95942beba34f56a06b73)
2003-02-19 01:43:33 +00:00
Gerald Carter
940fcdf095 * set PRINTER_ATTRIBUTE_RAW_ONLY; CR 1736
* never save a pointer to an automatic variable (they go away)
  implement a deep copy for SPOOLSS_NOTIFY_MSG to correct
  messages being sent that have junk for strings;
  fix in response to changes for CR 1504
(This used to be commit ffda9e2480414c7ed6156958f516e0d1f3c61350)
2003-02-15 23:33:30 +00:00
Gerald Carter
89d480a933 off by one bug in string length; CR 1159
(This used to be commit aaefa889ad9a065f976275a748be1011d66aa37e)
2003-02-14 22:25:12 +00:00
Andrew Bartlett
7ceed4213a Merge from HEAD: Fix NULL pointer de-reference in arguments to tdb_pack.
Andrew Bartlet
(This used to be commit 0809670d0f85405c1e58d7317cc7a6ca67c8ad16)
2003-02-12 10:57:39 +00:00
Andrew Bartlett
8a20407442 Cleanups: (merge from HEAD)
- use safe_strcpy() instead of pstrcpy() for malloc()ed strings

 - CUPS: a failure in an attempt to automaticly add a printer is not level 0 stuff.

 - Fix up a possible Realloc() failure segfault

Andrew Bartlett
(This used to be commit c1cfc296c2efdb2b5972202146e80f0e3b6a3da4)
2003-02-10 11:47:21 +00:00
Jeremy Allison
4703248a8e Ensure we return NOSPACE if we can't fast allocate a print job.
Jeremy.
(This used to be commit 82cf8aa74794649fb16c336011ca48d549d6abb8)
2003-02-08 01:04:43 +00:00