1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-15 23:24:37 +03:00

16908 Commits

Author SHA1 Message Date
Andrew Bartlett
ee23a4237d r1121: Fix memory leak in the trans2 signing code.
We would start the trans2 state, which is fine, but never pull the
expected reply off the packet queue.

I'm not sure if this is still a major problem after jra's recent 'no
duplicate mids on the list' change, but I think this is correct
anyway.
2007-10-10 10:51:56 -05:00
Jeremy Allison
1745ce4e2c r1117: Doh ! Remember to turn off signing when sending a "break to level II" oplock
message, or we mess up the signing sequence number.... Also improve sign error
reporting. Also when deferring an open that had been deferred due to an oplock
break, don't re-add the mid to the pending sign queue or we increment the sequence
number twice and mess up signing again...
I can now bounce between 2 WinXP/Win2003 boxes opening Excel spreadsheets with
signing turned on and get correct "file in use" messages.
Jeremy.
2007-10-10 10:51:56 -05:00
Jeremy Allison
5e8237e306 r1115: Fix for #1427. Catch bad path errors at the right point. Ensure all
our pathname parsing is consistent.
Jeremy.
2007-10-10 10:51:56 -05:00
Jelmer Vernooij
9f1c978088 r1111: Rename vsnprintf to smb_vsnprintf so we don't get duplicate symbol errors
when linking against an app that does have vsnprintf() (bug #478)
2007-10-10 10:51:55 -05:00
Volker Lendecke
c0bf8425f4 r1108: Index: pdb_ldap.c
===================================================================
--- pdb_ldap.c	(revision 1095)
+++ pdb_ldap.c	(working copy)
@@ -1134,6 +1134,19 @@
 	return NT_STATUS_OK;
 }

+static void append_attr(char ***attr_list, const char *new_attr)
+{
+	int i;
+
+	for (i=0; (*attr_list)[i] != NULL; i++)
+		;
+
+	(*attr_list) = Realloc((*attr_list), sizeof(**attr_list) * (i+2));
+	SMB_ASSERT((*attr_list) != NULL);
+	(*attr_list)[i] = strdup(new_attr);
+	(*attr_list)[i+1] = NULL;
+}
+
 /**********************************************************************
 Get SAM_ACCOUNT entry from LDAP by username.
 *********************************************************************/
@@ -1149,6 +1162,7 @@
 	int rc;

 	attr_list = get_userattr_list( ldap_state->schema_ver );
+	append_attr(&attr_list, MODIFY_TIMESTAMP_STRING);
 	rc = ldapsam_search_suffix_by_name(ldap_state, sname, &result, attr_list);
 	free_attr_list( attr_list );

@@ -1194,6 +1208,7 @@
 	switch ( ldap_state->schema_ver ) {
 		case SCHEMAVER_SAMBASAMACCOUNT:
 			attr_list = get_userattr_list(ldap_state->schema_ver);
+			append_attr(&attr_list, MODIFY_TIMESTAMP_STRING);
 			rc = ldapsam_search_suffix_by_sid(ldap_state, sid, result, attr_list);
 			free_attr_list( attr_list );

Index: login_cache.c
===================================================================
--- login_cache.c	(revision 1095)
+++ login_cache.c	(working copy)
@@ -95,10 +95,13 @@
 			&entry->bad_password_count,
 			&entry->bad_password_time) == -1) {
 		DEBUG(7, ("No cache entry found\n"));
+		SAFE_FREE(entry);
 		SAFE_FREE(databuf.dptr);
 		return NULL;
 	}

+	SAFE_FREE(databuf.dptr);
+
 	DEBUG(5, ("Found login cache entry: timestamp %12u, flags 0x%x, count %d, time %12u\n",
 		  (unsigned int)entry->entry_timestamp, entry->acct_ctrl,
 		  entry->bad_password_count, (unsigned int)entry->bad_password_time));
2007-10-10 10:51:55 -05:00
Volker Lendecke
69e8c65f1f r1106: Lars Mueller <lmuelle@suse.de> asked me to apply this patch, as this is needed
for their build environment. The AFS stuff is linux 2.4 only currently, it
works for me on this platform, so apply it.

Volker
2007-10-10 10:51:55 -05:00
Volker Lendecke
5f482df169 r1104: get_called_name is used in the printing subsystem. In case of multi-homed
servers we need to make sure that the clients are given back the IP address
they connected to.

Volker
2007-10-10 10:51:55 -05:00
Herb Lewis
d8a545368c r1103: need to leave empty dacl so we can remove last ACE 2007-10-10 10:51:55 -05:00
Volker Lendecke
473dd03833 r1101: Implement 'rpcclient setprintername'.
Thanks to Guenther Deschner <gd@sernet.de>.

This needs to be generalized somewhat. Jerry, which of the parameters in the
printer_info_2 struct are settable via cli_spoolss_setprinter?

Volker
2007-10-10 10:51:55 -05:00
Jeremy Allison
c8a55e92dd r1097: Fix errno being incorrectly set. Noticed by Richard.
Jeremy.
2007-10-10 10:51:54 -05:00
Jeremy Allison
c1b06deb57 r1093: Ensure we clear any cached errors on a deferred open call so
we don't return the wrong error code on the next packet.
Jeremy.
2007-10-10 10:51:54 -05:00
Jeremy Allison
7e2a5c3661 r1089: Removed spurious oplock message in deferred open processing.
Fix smb signing sequence counts.
Jeremy.
2007-10-10 10:51:54 -05:00
Gerald Carter
b0739b073a r1087: BUG 1221: revert old change that used single and double quotes as delimters in next_token(), and change print_parameter() to print out parm values surrounded by double quotes (instead of single quotes) 2007-10-10 10:51:54 -05:00
Jeremy Allison
894cc6d162 r1085: Now it's had some proper user testing, merge in the deferred open fix. I'm
still doing more testing, but it fixes a behaviour that we've been wrong
on ever since the start of Samba.
Jeremy.
2007-10-10 10:51:54 -05:00
Gerald Carter
e65564ab4a r1011: fix bad merge (from a few months ago) and ensure that we always use tdb_open_log() instead of tdb_open_ex() 2007-10-10 10:51:53 -05:00
Stefan Metzmacher
98e6c3105d r1007: merge from SAMBA_4_0:
print out the SVN revision by configure,
so that the build farm can use it

metze
2007-10-10 10:51:53 -05:00
Jeremy Allison
7ac7cd4162 r998: Arrrgggh. Do it right this time :-(.
Jeremy.
2007-10-10 10:51:53 -05:00
Jeremy Allison
6bd6359090 r996: Fix error in change to queuing code (dlink).
Jeremy.
2007-10-10 10:51:53 -05:00
Gerald Carter
82f3fee595 r993: BUG 703 -- finishing patch by Eric Boehm <boehm@nortelnetworks.com> for netgroup case lookups 2007-10-10 10:51:53 -05:00
Gerald Carter
e9f109d1b3 r991: Allow winbindd to use the domain trust account password
for setting up an schannel connection.  This solves the problem
of a Samba DC running winbind, trusting a native mode AD domain,
and needing to enumerate AD users via wbinfo -u.
2007-10-10 10:51:53 -05:00
Volker Lendecke
5070c1b68f r989: Calling sid_to_gid from within winbind makes no sense, as this calls
winbind_sid_to_gid. For the consistency check, local_sid_to_gid must set the
name_type it found.

Volker
2007-10-10 10:51:52 -05:00
Volker Lendecke
98e10d1497 r988: When adding local aliases' gids to the user token, don't do a idmap_sid_to_gid
on the user sid. This might lead to a user SID entered as a GID in the idmap.

Volker
2007-10-10 10:51:52 -05:00
Jeremy Allison
40c77dddc6 r984: Ensure memmove & memcpy aren't called with len == 0.
Jeremy.
2007-10-10 10:51:52 -05:00
Volker Lendecke
148dc71ea5 r979: Implement the 'cups server' option. This makes it possible to have virtual
smbd's connect to different cups daemons.

Volker
2007-10-10 10:51:52 -05:00
Volker Lendecke
9ceff80327 r977: Implement 'net rpc group rename' -- rename domain groups.
Volker
2007-10-10 10:51:52 -05:00
Jeremy Allison
5ec4f4e4e6 r974: Fix open code to pass more torture tests. We now pass the Samba4
oplock test. We do this be changing the algorithm when breaking
oplocks slightly. Previously we broke an oplock, then re-loaded
the share modes and re-iterated. Now we break all oplocks, then
re-load the share modes and check the share details - then iterate.
This seems to match the way Win2k3 does it.
Jeremy.
2007-10-10 10:51:51 -05:00
Jeremy Allison
9de6b25c9e r971: Auto remove store dos attributes if underlying filesystem
doesn't support EA's.
Jeremy.
2007-10-10 10:51:51 -05:00
Gerald Carter
f614991544 r966: fixing package dependencies 2007-10-10 10:51:51 -05:00
Volker Lendecke
d7239c2611 r964: The max_size field in cli_samr_enum_als_groups is more like an account_control
field with indiviual bits what to retrieve. Set this to 0xffff as NT4
usrmgr.exe does to get everything. I'm too lazy (sorry) to get this through to
rpc_parse/ etc.

Volker
2007-10-10 10:51:51 -05:00
Jeremy Allison
2db0c4ca7b r957: Fixup moribund unix extensions mknod code path. Don't add in
configure test yet. Also allow unix domain socket create.
Jeremy.
2007-10-10 10:51:51 -05:00
Jelmer Vernooij
e6dcda2b10 r947: Patch from Fabian Franz <FabianFranz@gmx.de> that allows you
to specify a port in the device URL.
2007-10-10 10:51:51 -05:00
Jeremy Allison
d8177a42d4 r945: "Correct" (as in, more correct) way to handle stat opens. Doesn't regress
the torture tester. Passes OPEN tests in Samba3 and Samba4 and oplock tests
in Samba4. Last thing to check, can an "attribute only" open actually create
a file. I think it can....
Jeremy.
2007-10-10 10:51:50 -05:00
Volker Lendecke
3093ab1006 r942: If using DOS error codes, we need to return ERRDOS/ERRbadpath for chkpth even
if only the last component failed. I'm not sure if all the other cases of
NT_STATUS_OBJECT_NAME_NOT_FOUND also need to be fixed, this at least helps
with 'copy test1.txt test2.txt' from DOS within a subdirectory.

Yes, I do have someone who needs this :-)

Jeremy, could you take a look at this?

Thanks,

Volker
2007-10-10 10:51:50 -05:00
Herb Lewis
4a5a122b3a r938: on an error save the original errno before calling iconv to reset
the conversion state
2007-10-10 10:51:50 -05:00
Andrew Bartlett
d626b5c6d4 r936: Fix a rather weird error that crippled my site, when we upgraded to
Samba 3.0.4.

If we fail a query for the members of the 'administrators' group (and we may well just have the IDL wrong), this destroys later parts of the domain logon process.

For reasons I can't understand, the client-side 'heck, what happened'
bailout causes the connection to the DC to be dropped, and causes the
mandetory profile not to be loaded.  (This also only occours after a reboot)

Return the members of 'administrators', and it all works fine.

The reason we hit this is because we run winbindd (to support
pam_winbind) on our DC, and the winbindd lookup in sid_to_gid was
messing things up.  As we don't care what type of thing this is,
provided it exists in the group mapping db, we should not bother
winbindd here.

Andrew Bartlett
2007-10-10 10:51:50 -05:00
Jeremy Allison
b562fe9fbc r933: When using widelinks = no, use realpath to canonicalize the
connection path on connection create for the user. We'll be
checking all symlinked paths are below this directory.
Jeremy.
2007-10-10 10:51:50 -05:00
Jeremy Allison
1d3fd1a58e r931: Ensure we push 16 bytes (including null termination)
not 15.
2007-10-10 10:51:50 -05:00
Jeremy Allison
409eef2be7 r928: Ensure we're calling send_mailslot() with a UNIX charset
target name.
Jeremy.
2007-10-10 10:51:50 -05:00
Gerald Carter
066b9c4276 r925: add changes frpm trunk (r841 and r842) -- enable background queue update process and allow printers to have different sharenames from printernames 2007-10-10 10:51:49 -05:00
John Terpstra
c5dc3da340 r923: Fixes so tdbtool and tdbtest can be built. Added build specs for tdbdump and tdbbackup. 2007-10-10 10:51:49 -05:00
John Terpstra
1b0fd9b5bc r922: Adding notes regarding location of documentation. 2007-10-10 10:51:49 -05:00
John Terpstra
032a827c32 r921: Change notice from CVS to SVN. 2007-10-10 10:51:49 -05:00
Jeremy Allison
c336ccf4e8 r916: Memory leak fix from kawasa_r@itg.hitachi.co.jp.
Jeremy.
2007-10-10 10:51:49 -05:00
Jeremy Allison
14cf55abb8 r914: Fix from "Jerome Borsboom" <j.borsboom@erasmusmc.nl> to ensure
correct sid type returned for builtin sids.
Jeremy.
2007-10-10 10:51:48 -05:00
Jeremy Allison
735e49ddc3 r911: Patch from "Jerome Borsboom" <j.borsboom@erasmusmc.nl>, don't
overwrite error code.
Jeremy.
2007-10-10 10:51:48 -05:00
Jeremy Allison
455ed258b3 r910: Fix for bug #1385 found by Jason Mader <jason@ncac.gwu.edu>.
Don't use non-consts in a structure initialization.
Jeremy.
2007-10-10 10:51:48 -05:00
Gerald Carter
c9bef86b8b r907: fixing browse.dat bug -- don't include the resouce byte from the netbios name when pulling a string from a packet (jra, please double check this 2007-10-10 10:51:48 -05:00
Gerald Carter
1dda922c10 r885: more packaging fixes 2007-10-10 10:51:48 -05:00
Gerald Carter
591abc5b21 r881: BUG 1357: add pam-devel to build requirements 2007-10-10 10:51:48 -05:00
Gerald Carter
7590f18055 r878: fixing bug in packaging that crep back in 2007-10-10 10:51:48 -05:00