sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-15 23:24:37 +03:00
Code
86,294 Commits 60 Branches 1,145 Tags
Commit Graph

43553 Commits

Author SHA1 Message Date
Michael Adam
f7112e07cc build: get rid of source strings from source3/passdb/wscript_build 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2013-09-24 23:00:38 +02:00
Michael Adam
9f15535821 build: get rid of source variables and vars=locals() in source3/libgpo/gpext/wscript_build 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2013-09-24 23:00:35 +02:00
Michael Adam
7e974dbd92 build: get rid of vars=locals() in source3/auth/wscript_build 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2013-09-24 23:00:31 +02:00
Michael Adam
c6e16183e1 build: get rid of source-variables in source3/auth/wscript_build 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2013-09-24 23:00:21 +02:00
Michael Adam
f575b5c531 build: get rid of source file variables in source3/modules/wscript_build 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2013-09-24 22:58:48 +02:00
Michael Adam
658fbefef7 libsmbconf:registry: add "state directory" to the list of forbidden parameters 
At the time when the registry configuration was introduced,
the registry database file was placed in the "lock directory".
So the "lock directory" was added to the list of parameters
that may not be changed in the registry configuration
(because the next config reload would then load a different
 registry and drop all the original seetings).

Later, "state directory" and "cache directory" were introduced,
both defaulting to "lock directory". And the registry's location
was changed to "state directory".

It slipped my attention that the forbidden parameters for the
should have been adapted at the time.

So this patch adds "state directory" to the list.
It keeps the lock directory, to catch the case
where the state directory is not explicitly set, hence
defaulting to the "lock directory".

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-24 07:44:29 +02:00
Michael Adam
7cfab6bc8d selftest: include "state directory" in invalid parameters in registry roundtrip test 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-24 07:44:29 +02:00
Michael Adam
11ca7d9d60 selftest: add "state directory" to the forbidden parameters test in net conf 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-24 07:44:29 +02:00
Michael Adam
21be539590 selftest: add regression test for setting invalid parameters in registry config via "net [rpc] conf" 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-24 07:44:29 +02:00
Michael Adam
dc222d8b94 selftest: update SED_INVALID_PARAMS in the registry.roundtrip test 
and add an explaining comment.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-24 07:44:29 +02:00
Michael Adam
8d67082adb selftest: remove unused variables (copy'n'paste...) from test_net_conf.sh 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-24 07:44:29 +02:00
Michael Adam
1d9f281543 s3:net conf: add the same parameter checks to "setparm" as in "net rpc conf". 
In "net rpc conf" these checks are necessary, since the that command
uses the plain rpc-registry interface at this moment, and so unfortunately
it has to duplicate the checks from the smbconf library.

Since "net conf" uses the registry, these checks are not necessary in
this command. I add them nonetheless to make the output more similar
to "net rpc conf". It is also a little more user friendy than just
printing "INVALID_PARAMETER" as handed back from libsmbconf.

Implement these checks by calling the new net_conf_param_valid() function.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-24 07:44:29 +02:00
Michael Adam
d16c2aabd7 s3:net: check for GLOBAL_NAME net_conf_param_valid() 
instead of checking for literal "global"

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-24 07:44:28 +02:00
Michael Adam
f7cf09e661 s3:net rpc conf: factor validation of parameter out for re-use. 
This goes into a new module net_conf_util to be shared
between net conf and net rpc conf.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-24 07:44:28 +02:00
Michael Adam
349bcafe09 s3:net rpc conf: rename canon_valname->canon_param_name for clarity in setparm. 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-24 07:44:28 +02:00
Michael Adam
a00f97a392 s3:net rpc conf: setparm: introduce variables service_name, param_name, valstr for clarity 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-24 07:44:28 +02:00
Michael Adam
3e53097689 s3:net rpc conf: reorganize the validity check and canonicalization of the input in "setparm" 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-24 07:44:28 +02:00
Michael Adam
429ab4ed02 libsmbconf:registry: clarify the appearance of "includes" in forbidden_names 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-24 07:44:28 +02:00
Michael Adam
76a008cd18 libsmbconf:registry: reorganize the validity check and canonicalization of the input in "setparm" 
- first check that the name is an smbconf parameter
- then check that the parameter is allowed in the registry config
- then check that a global parameter is not to be set in a service section
- then canonicalize the parameter and value name, thereby checking that the
  value has valid format

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-24 07:44:28 +02:00
Michael Adam
b7db29eb2a s3:net rpc conf: print the provided parameter name on error, not the canonicalized one 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-24 07:44:28 +02:00
Michael Adam
bceb34543e s3:net rpc conf: remove the (now) unused rpc_conf_reg_valname_forbidden() 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-24 07:44:28 +02:00
Michael Adam
0c4e5fcc53 s3:net rpc conf: use the published smbconf_reg_parameter_is_valid() 
Instead of the duplicated rpc_conf_reg_valname_forbidden()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-24 07:44:28 +02:00
Michael Adam
c1be069be9 libsmbconf:registry: publish smbconf_reg_parameter_is_valid() 
So that this does not need to be duplicated..

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-24 07:44:28 +02:00
Michael Adam
4a65969e11 libsmbconf:registry: rework smbconf_reg_parameter_forbidden(), renaming it. 
The logic is inverted, the lp_parameter_is_invalid call of
smbconf_reg_valname_valid() is included, and the function
is renamed to smbconf_reg_parameter_is_valid().

Use the new function everywhere in smbconf registry backend.
And remove corresponding reverse function smbconf_reg_valname_valid().

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-24 07:44:28 +02:00
Michael Adam
c9a6805f3d s3:modules: vfs_afsacl has the afs_syscall prototype via proto.h 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
 2013-09-23 20:55:29 +02:00
Michael Adam
0fc53a1324 s3:include: remove duplicate prototypes from afs functions from proto.h 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-23 20:49:39 +02:00
Michael Adam
5fd4fd7c01 afs: implement afs_syscall() always, returning -1 if FAKE_KASERVER is not defined. 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
 2013-09-23 20:49:02 +02:00
Michael Adam
771b7779b0 afs: format afs_syscall() properly 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-23 20:26:47 +02:00
Michael Adam
49179ec808 build: remove remaining occurrences of vars=locals() of source3/wscript_build 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-23 20:26:44 +02:00
Michael Adam
9ccca6397c build: list source of binary split_tokens directly in def, remove vars=locals() 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-23 20:26:41 +02:00
Michael Adam
ba68add806 build: list source of dbwrap_torture directly in def, remove vars=locals() 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-23 20:26:38 +02:00
Michael Adam
e05a7a207e build: list source of binary dbwrap_tool directly in def, remove vars=locals() 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-23 20:26:35 +02:00
Michael Adam
2dc6174c70 build: list source of binary rpc_open_tcp directly in dev, remove vars=locals() 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-23 20:26:32 +02:00
Michael Adam
636b7111c0 build: list source of binary vlp directly in dev, remove vars=locals() 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-23 20:26:29 +02:00
Michael Adam
ecb3c92b25 build: list sources of binary ntlm_auth directly in dev, remove vars=locals() 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-23 20:26:26 +02:00
Michael Adam
54b31d1f09 build: list sources of library nss_wins directly in dev 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-23 20:26:23 +02:00
Michael Adam
8c75910447 build: list source of binary smbfilter directly in def, remove vars=locals() 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-23 20:26:20 +02:00
Michael Adam
bc4aad7ae6 build: list sources of binary debug2html directly in def, remove vars=locals() 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-23 20:26:17 +02:00
Michael Adam
7059e00920 build: list source of binary sharesec() directly in def, remove vars=locals() 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-23 20:26:13 +02:00
Michael Adam
351bf39de4 build: list source of binary eventlogadm directly in def, remove vars=locals() 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-23 20:26:10 +02:00
Michael Adam
02b3eed492 build: list source of binary smbcquotas directly in def, remove vars=locals() 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-23 20:26:07 +02:00
Michael Adam
045e4c0a54 build: list source of binary smbcacls directly in def, remove vars=locals() 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-23 20:26:03 +02:00
Michael Adam
b7cce8ca9d build: list source of binary locktest2 directly in def, remove vars=locals() 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-23 20:26:00 +02:00
Michael Adam
46f31157ca build: list source of binary log2pcap directly in def, remove vars=locals() 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-23 20:25:57 +02:00
Michael Adam
74970a4caf build: list sources of binary vfstest directly in def, remove vars=locals() 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-23 20:25:53 +02:00
Michael Adam
f70f3a0601 build: list source of binary pdbtest directly in def, remove vars=locals() 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-23 20:25:49 +02:00
Michael Adam
d15064adf2 build: list source of binary msgtest direcly in def, remove vars=locals() 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-23 20:25:46 +02:00
Michael Adam
26bc1d5e66 build: list sources of smbtorture(3) directly in dev, remove vars=locals() 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-23 20:25:43 +02:00
Michael Adam
351d7686a1 build: list source of binary nmblookup directly in source, remove vars=locals() 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-23 20:25:39 +02:00
Michael Adam
a0ec8b5040 build: list source of binary smbspool directly in def, remove vars=locals() 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-09-23 20:25:37 +02:00