Stefan Metzmacher
b738e092a2
librpc/rpc: move dcerpc_binding_handle stuff to rpc_common.h
...
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Mar 11 12:28:08 CET 2011 on sn-devel-104
2011-03-11 12:28:08 +01:00
Stefan Metzmacher
c774a50aaf
s4:librpc/rpc: s/struct dcerpc_connection/struct dcecli_connection/g
...
The name 'struct dcerpc_connection' will be used in the new generic
dcerpc code. It will be used for client and server.
metze
2011-03-11 11:02:23 +01:00
Günther Deschner
c8098246be
waf-selftest: allow to call "make test SUBUNIT_FORMATTER=cat".
...
Guenther
2011-03-10 23:25:04 +01:00
Matthias Dieter Wallnöfer
22fcb8e494
s4:lib/tls/wscript - exclude known broken GNUTLS releases
...
This definitely fixes bug #7218 .
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Mar 10 11:58:27 CET 2011 on sn-devel-104
2011-03-10 11:58:27 +01:00
Matthias Dieter Wallnöfer
e00893d839
s4:extended_dn_store LDB module - use the new request as generic memory contexts
...
To prevent memory leaks under valgrind.
2011-03-10 11:12:05 +01:00
Matthias Dieter Wallnöfer
0cec6107d8
s4:repl_meta_data LDB module - always ask manually for the current partition control
...
Otherwise the "partition" LDB module doesn't give it back anymore.
2011-03-10 11:12:05 +01:00
Matthias Dieter Wallnöfer
68fbfa2237
s4:partition LDB module - the current partition control should only be added if requested
...
That means if the informations before a request are unknown
("repl_meta_data" LDB module) then an empty control (no data) has to be sent.
2011-03-10 11:12:05 +01:00
Matthias Dieter Wallnöfer
78b46c533a
s4:partition LDB module - extended operations - make the initialisation check consistent
...
To the other operations.
2011-03-10 11:12:05 +01:00
Matthias Dieter Wallnöfer
e52c900b63
s4:partition LDB module - move the "data" check a bit higher
...
It can be performed a bit earlier.
2011-03-10 11:12:05 +01:00
Matthias Dieter Wallnöfer
4e6b8e0a18
s4:partition LDB module - "partition_replicate" doesn't handle the search requests
...
That is done by "partition_search".
2011-03-10 11:12:05 +01:00
Matthias Dieter Wallnöfer
210cab9bf0
s4:partition LDB module - "partition_sequence_number" - remove meaningless "if"s
...
These current partition controls are always added for the two EXOP operations.
2011-03-10 11:12:05 +01:00
Matthias Dieter Wallnöfer
96600e5df1
s4:simple_ldap_map LDB module - enhance current partition control checks
...
Don't stop the server if it hasn't been filled in correctly. An LDB
error should be enough.
Modified by request of tridge: errorcodes changed to ERR_PROTOCOL_ERROR
2011-03-10 11:12:05 +01:00
Matthias Dieter Wallnöfer
e669295a37
s4:repl_meta_data LDB module - don't remove the partition control twice
...
"controls" is already the controls list which has the partition control
removed. It is generated by "ldb_controls_except_specified" in line 378.
2011-03-10 11:12:05 +01:00
Matthias Dieter Wallnöfer
e754f0c5c6
s4:repl_meta_data LDB module - remove the current partition control unless it was requested
2011-03-10 11:12:05 +01:00
Matthias Dieter Wallnöfer
42da193c37
s4:new_partition LDB module - splitting up an "if" operation
...
- let the first "if" in place
- uninstantiated partitions are handled by the second "if" (previously
they have been handled twice)
Has been corrected by request of tridge.
2011-03-10 11:12:05 +01:00
Matthias Dieter Wallnöfer
83517d2e59
s4:instancetype LDB module - perform here only the "instanceType" constraint checks
...
The boilerplate entries (when this support has been implemented) should
be provided by the "new_partition" LDB module. These are for example the
deleted object and lost and found container.
2011-03-10 11:12:04 +01:00
Matthias Dieter Wallnöfer
8ce131431c
s4:instancetype LDB module - don't impede control requests
2011-03-10 11:12:04 +01:00
Matthias Dieter Wallnöfer
f68d54269c
s4:instancetype LDB module - use "ldb" pointer for referencing the LDB context
2011-03-10 11:12:04 +01:00
Matthias Dieter Wallnöfer
8872a62266
s4:partition LDB module - fill in parent requests for inheriting the flags
...
Probably it doesn't matter in this cases but just for consistency.
2011-03-10 11:12:04 +01:00
Matthias Dieter Wallnöfer
b7ecc33ef9
ldb:ldb_controls.c - "ldb_save_controls" - allow that "saver" can also be NULL
...
Suggested by Tridge
2011-03-10 11:12:04 +01:00
Matthias Dieter Wallnöfer
78c9eb1a06
ldb:ldb_controls.c - always allocate enough space
...
The size for an additional "struct ldb_control" shouldn't hurt and so
the excluded control can also be NULL.
Added an ending "talloc_realloc" to resize the chunk to the
effective needed size (requested by tridge).
2011-03-10 11:12:04 +01:00
Matthias Dieter Wallnöfer
851396a627
s4:partition LDB module - add some comments
2011-03-10 11:12:04 +01:00
Matthias Dieter Wallnöfer
79c65cc99b
s4:new_partition LDB module - fix comments
2011-03-10 11:12:04 +01:00
Matthias Dieter Wallnöfer
d2acd72994
s4:partition_init LDB module - fix a typo
2011-03-10 11:12:04 +01:00
Matthias Dieter Wallnöfer
82067b1a61
s4:partition LDB module - fix typo
2011-03-10 11:12:04 +01:00
Matthias Dieter Wallnöfer
7aa0219be8
s4:setup/provision - fix an output message
...
Mention that Windows 2000 function level is supported as well.
2011-03-10 11:12:04 +01:00
Stefan Metzmacher
494aed59a5
s4:lib/socket: use sockaddr_in6 in ipv6_tcp_accept()
...
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Mar 9 14:36:42 CET 2011 on sn-devel-104
2011-03-09 14:36:42 +01:00
Stefan Metzmacher
5a59dcc26c
s4:samba-tool: improve help messages for samba-tool password
...
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Mar 9 12:06:53 CET 2011 on sn-devel-104
2011-03-09 12:06:53 +01:00
Matthias Dieter Wallnöfer
eade61ae03
s4:operational LDB module - fix attribute names to be right up/down-cased
...
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Mar 4 23:56:07 CET 2011 on sn-devel-104
2011-03-04 23:56:07 +01:00
Matthias Dieter Wallnöfer
5a722f187f
s4:ldap.py - rootdse tests should search for the rootDSE not the default DN
...
Reviewed by: Tridge
2011-03-04 23:09:53 +01:00
Matthias Dieter Wallnöfer
71df279f92
s4:ldap.py - add a test in order to show the operational module fixed
...
Reviewed by: Tridge
2011-03-04 23:09:44 +01:00
Matthias Dieter Wallnöfer
05d1d0d8a6
s4:operational LDB module - fix display of some constructed attributes
...
"structuralObjectClass", "createTimestamp" and "modifyTimestamp" weren't
displayed anymore.
Reviewed by: Tridge
2011-03-04 23:09:35 +01:00
Matthias Dieter Wallnöfer
5a98979e0c
s4:operational LDB module - add "groupToken" as unsigned int (uint32_t)
...
Reviewed by: Tridge
2011-03-04 23:09:27 +01:00
Matthias Dieter Wallnöfer
1ff28a2986
s4:operational LDB module - readd "structuralObjectClass" -> "objectClass" mapping
...
This has been removed accidentally by commit
a093e10896a4768dba0cd793a04b7d5d1366fee2.
Reviewed by: Tridge
2011-03-04 23:09:17 +01:00
Matthias Dieter Wallnöfer
75706a627d
ldb:ldb_msg.c - use LDB result constants for checking return values
...
Reviewed by: Tridge
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Mar 4 22:51:57 CET 2011 on sn-devel-104
2011-03-04 22:51:57 +01:00
Matthias Dieter Wallnöfer
dabed32ffe
s4:ldap.py - other important RDN check testcases
...
Reviewed by: Tridge
2011-03-04 22:07:24 +01:00
Matthias Dieter Wallnöfer
2275bfb82d
s4:ldap.py - remove a debug output
...
This has only been needed for developing this testcase and has been
forgotten to be removed afterwards.
Reviewed by: Tridge
2011-03-04 22:07:24 +01:00
Matthias Dieter Wallnöfer
736a462c3e
ldb:rdn_name LDB module - more RDN constraint checks (from AD)
...
Reviewed by: Tridge
2011-03-04 22:07:24 +01:00
Matthias Dieter Wallnöfer
ea12adf544
s4/ldb - remove now superflous "ldb_dn_validate" checks
...
If we immediately afterwards perform an LDB base operation then we don't
need an explicit "ldb_dn_validate" check anymore (only OOM makes sense).
Reviewed by: Tridge
2011-03-04 22:07:24 +01:00
Matthias Dieter Wallnöfer
349b9b72ec
s4:dsdb - we don't need to check if a DN != NULL if we call "ldb_dn_validate"
...
"ldb_dn_validate" is NULL-safe and does the check implicitly.
Reviewed by: Tridge
2011-03-04 22:07:24 +01:00
Matthias Dieter Wallnöfer
746194cfc4
Revert "s4:objectclass LDB module - if we cannot find DN's parent then the DN itself is invalid"
...
This is not needed anymore with the new DN checking.
This reverts commit 5896b7299331aedd065397d2078c62d85bcf68f6.
Reviewed by: Tridge
2011-03-04 22:07:24 +01:00
Matthias Dieter Wallnöfer
76fb23064e
ldb:ldb_request - handle here the DN checks
...
This is a much better solution than we had before - so all important DN
checks are enforced for each type of LDB database (and not limited to DSDB).
Many "ldb_dn_validate" checks will now become obsolete.
Reviewed by: Tridge
2011-03-04 22:07:24 +01:00
Matthias Dieter Wallnöfer
86707c7cc4
s4:objectclass LDB module - fix a comment
...
Reviewed by: Tridge
2011-03-04 22:07:24 +01:00
Matthias Dieter Wallnöfer
e4b5bce151
s4:libnet/libnet_site.c - make use of LDB return constants
...
Reviewed by: Tridge
2011-03-04 22:07:24 +01:00
Christian Ambach
23810dca45
s4:waf-build fix disable-shared build for smbtorture
...
building smbtorture4 with configure --disable-shared failed
with an error that ldb.h could not be found
Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Reviewed by: Tridge
2011-03-04 22:07:24 +01:00
Stefan Metzmacher
4b86beb98b
s4:selftest: test using the machine account of the rodc against itself
...
This should test the non proxy rodc kdc path.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Mar 4 22:06:10 CET 2011 on sn-devel-104
2011-03-04 22:06:10 +01:00
Stefan Metzmacher
8002406c51
s4:kdc: split the kdc_tcp_proxy() logic from the main kdc logic
...
By having kdc_tcp_proxy_send/recv(), which just asks any writeable
dc for a reponse blob, we simplify the interaction between
client-local and local-writeable sockets.
This allows us to make kdc_socket, kdc_process_fn_t, kdc_tcp_call and kdc_tcp_socket
private to kdc.c again.
metze
2011-03-04 21:19:05 +01:00
Stefan Metzmacher
e70b09e8f8
s4:kdc: split the kdc_udp_proxy() logic from the main kdc logic
...
By having kdc_udp_proxy_send/recv(), which just asks any writeable
dc for a reponse blob, we simplify the interaction between
client-local and local-writeable sockets.
This allows us to make kdc_udp_call and kdc_udp_socket private to
kdc.c again.
metze
2011-03-04 21:19:05 +01:00
Stefan Metzmacher
ad9ac99afd
s4:kdc: add a kdc_proxy_unavailable_error() helper function
...
metze
2011-03-04 21:19:05 +01:00
Stefan Metzmacher
0c78640e67
s4:kdc: fix calculation of the rodc kvno
...
Bit shifting is non-trivial in C:-)
This
int32_t a = 0x12340000;
uint32_t b = (a >> 16);
results in 0x00001234, but this
int32_t a = 0xEDCB0000;
uint32_t b = (a >> 16);
results in 0xFFFFEDCB, while we expected 0x0000EDCB.
metze
2011-03-04 21:19:05 +01:00