Matthias Dieter Wallnöfer
0939ba4488
Revert "s4:util_samr.c - also here we've now the default primaryGroupID detection working"
...
This reverts commit 7e9e35db4126f953e8a2579d992c63b274011119.
Sorry, the logic is working differently here. We do still need this.
2010-09-12 22:25:37 +02:00
Matthias Dieter Wallnöfer
eaa55b4123
s4:torture/rpc/samr.c - fix typos in outputs
2010-09-12 22:10:06 +02:00
Matthias Dieter Wallnöfer
7e9e35db41
s4:util_samr.c - also here we've now the default primaryGroupID detection working
2010-09-12 21:19:27 +02:00
Matthias Dieter Wallnöfer
4a2941535d
s4:ldap.py - tests the primary group detection by the "userAccountControl"
2010-09-12 19:23:06 +02:00
Matthias Dieter Wallnöfer
4fd8ce42ce
s4:setup/provision_self_join.ldif - now the samldb LDB module detects automatically that this is a DC account
2010-09-12 19:23:06 +02:00
Matthias Dieter Wallnöfer
7f424155e6
s4:samldb LDB module - "samldb_check_primaryGroupID" - support RID derivation from "userAccountControl"
...
Specified in MS-SAMR 3.1.1.8.1 and probably fixes also bug #7441 .
2010-09-12 19:23:06 +02:00
Matthias Dieter Wallnöfer
22d42432ac
s4:samldb LDB module - free the "ac" context after the delete checks
2010-09-12 19:23:05 +02:00
Matthias Dieter Wallnöfer
1d94bb3ad4
s4:samldb LDB module - simplify the message handling on add and modify operations
...
We perform always only one shallow copy operation of the message on the "req"
context. This allows to free the "ac" context when we've prepared all our
changes.
2010-09-12 19:23:05 +02:00
Matthias Dieter Wallnöfer
79f22e5d70
s4:samldb LDB module - move "samldb_prim_group_users_check" more down to see that it is only in use by the delete operation
...
add and modify helpers will stay on the top of the add and modify operation
since they will likely be shared as much as possible.
2010-09-12 19:23:05 +02:00
Matthias Dieter Wallnöfer
bb1da645ed
s4:samldb LDB module - add a comment to mark the beginning of the extended operation handler
2010-09-12 19:23:05 +02:00
Matthias Dieter Wallnöfer
dad7cdad22
s4:samldb LDB module - refactor "samldb_find_for_defaultObjectCategory" to be again synchronous
...
Also to make it easier to comprehend
2010-09-12 19:23:05 +02:00
Matthias Dieter Wallnöfer
6aca09b0b7
s4:samldb LDB module - refactor the "primaryGroupID" check on user creation
...
This looks more straight-forward now.
2010-09-12 19:23:05 +02:00
Matthias Dieter Wallnöfer
e1de425cb8
s4:samldb LDB module - get rid of the SID context variable
...
Since we get more and more rid of async stuff we don't need this in the context
anymore.
2010-09-12 19:23:05 +02:00
Matthias Dieter Wallnöfer
79a98b893a
s4:samldb LDB module - use also here the real attribute denomination "sAMAccountName"
...
Purely cosmetic - but nicer to read
2010-09-12 19:23:05 +02:00
Matthias Dieter Wallnöfer
0eb281d8f2
s4:samldb LDB module - rename "check_SamAccountType" into "check_sAMAccountType"
...
And a small cosmetic change.
I like to have the real attribute names in the function denominations
2010-09-12 19:23:04 +02:00
Matthias Dieter Wallnöfer
4ef9760db1
s4:samldb LDB module - make "samldb_check_sAMAccountName" synchronous again
...
To make it more understandable
2010-09-12 19:23:04 +02:00
Matthias Dieter Wallnöfer
64af772b38
s4:fsmo.py - fix an obvious typo
2010-09-12 19:23:04 +02:00
Matthias Dieter Wallnöfer
1ddd63bddb
ldb:tools/cmdline.c - reorganise imports
2010-09-11 18:07:47 +02:00
Matthias Dieter Wallnöfer
b5d872704c
s4:param/secrets.c - reorganise imports
2010-09-11 18:04:50 +02:00
Matthias Dieter Wallnöfer
7e710c4de9
s4:rpc_server/common/common.h - introduce two forward declarations to suppress parameter declaration warnings
...
Always Tru64 in file "param/loadparm.c" and possibly others.
2010-09-11 18:04:48 +02:00
Matthias Dieter Wallnöfer
5f98d31fc0
ldb:tools/cmdline.c - make a counter unsigned where appropriate
2010-09-11 17:43:44 +02:00
Matthias Dieter Wallnöfer
c0a863b6f3
s4:ldb_register_samba_handlers - fix up and convert result codes to LDB/LDAP results
2010-09-11 17:41:38 +02:00
Matthias Dieter Wallnöfer
83cd3f7630
s4:dcesrv_samr_GetGroupsForUser - also universal group memberships are returned here
...
Tested using User Manager for Domains against Windows Server 2008.
MS-SAMR 3.1.5.9.1 is wrong in this case therefore I've informed the dochelp team.
2010-09-11 14:34:37 +02:00
Andrew Bartlett
e84ab1b35f
s4-privs Fix enum privileges in LSARPC server
...
We were returning the index, not the LUID value
Andrew Bartlett
2010-09-11 22:32:43 +10:00
Andrew Bartlett
e13ed6fc78
s4:gensec Put the "NTLM" string for NTLMSSP's SASL name in a header
2010-09-11 22:32:43 +10:00
Andrew Tridgell
2921a888dc
s4-param: removed the lp_ varients of the functions
...
these made debugging much harder. We should replace these with
generated macros
2010-09-11 22:32:43 +10:00
Andrew Tridgell
2a93814592
s4-param: move back to auto-generation of loadparm prototypes
2010-09-11 22:32:43 +10:00
Andrew Tridgell
837230f85e
s4-credentials: get all attributes in cli_credentials_set_secrets()
...
This ensures we get whenChanged, which is needed by the s3 winbind
code to ensure we don't repeatedly try to change the password
2010-09-11 22:32:43 +10:00
Andrew Bartlett
a02a2c3557
libcli/security Use talloc_zero when making a struct security_token
2010-09-11 18:46:14 +10:00
Andrew Bartlett
0eea8ecfe2
s4-privs Seperate rights and privileges
...
These are related, but slightly different concepts. The biggest difference
is that rights are not enumerated as a system-wide list.
This moves the rights to security.idl due to dependencies.
Andrew Bartlett
2010-09-11 18:46:13 +10:00
Andrew Bartlett
da9bca6282
s4-rpc_server Put all 'logon failure' messages at the same debug level 4
...
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2010-09-11 18:46:12 +10:00
Andrew Tridgell
45aecc2833
s4-lsa: privilege IDs should use the enum, not an int
...
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-09-11 18:46:12 +10:00
Andrew Bartlett
a32cdadb7c
libcli/security Make sec_privilege_from_index() return SEC_PRIV_INVALID on failure
...
This is clearer and more consistent than using a magic -1 return
Andrew Bartlett
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2010-09-11 18:46:11 +10:00
Andrew Bartlett
6d78e11e17
libcli/security make sec_privilege_id() return SEC_PRIV_INVALID on failure.
...
Andrew Bartlett
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2010-09-11 18:46:10 +10:00
Andrew Bartlett
dbee98d30f
libcli/security Move source4/ privileges code into the common libcli/security
...
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2010-09-11 18:46:07 +10:00
Andrew Bartlett
9abfd8fe3b
s4-privs Add a lookup by index of privilages
...
Now that privileges are no longer given luid values sequentially,
we need another way to look them up for enumeration.
Andrew Bartlett
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2010-09-11 18:46:05 +10:00
Andrew Bartlett
e113af6fb1
privs Add my Copyright
...
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2010-09-11 18:46:05 +10:00
Andrew Bartlett
e655e9f676
s4-privs Remove link between enum sec_privilege and the privilege bitmap
...
This allows us to set the enum sec_privilege constants to the LUID
values that are seen from windows, which we need to match, in order
to preserve the support for the NT Print Migrator tool after a merge
with the source3/ privileges code.
Andrew Bartlett
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2010-09-11 18:46:04 +10:00
Björn Jacke
3eda2815f6
s4/pvfs: use monotonic time for this timeout
2010-09-10 23:10:26 +02:00
Björn Jacke
d320aa1212
s4/ldap: use time_mono for reconnect timeout
2010-09-10 23:10:26 +02:00
Björn Jacke
54ca77183b
s4/torture: use time_mono for timeouts
2010-09-10 23:10:25 +02:00
Björn Jacke
478ac36b9c
s4/torture: use time_mono for delta time
2010-09-10 23:10:25 +02:00
Matthias Dieter Wallnöfer
07af8f2514
s4:client/client.c - fix wrong return codes in "do_connect"
...
Detected by the Solaris cc compiler.
2010-09-10 22:45:50 +02:00
Matthias Dieter Wallnöfer
9d4dc69627
s4:lib/policy/gp_filesys.c - remove dead code
...
Found out by Solaris cc
2010-09-10 22:45:50 +02:00
Matthias Dieter Wallnöfer
55bc079b9a
s4:torture/locktest.c - add a cast in order to quiet a warning on Solaris cc
2010-09-10 22:45:50 +02:00
Matthias Dieter Wallnöfer
ace43d4ccd
s4:libcli/wrepl/winsrepl.c - add more "char *" casts in order to suppress Solaris warnings
2010-09-10 22:45:49 +02:00
Matthias Dieter Wallnöfer
ece428f02c
s4:torture/ntp/ntp_signd.c - add more "char *" casts in order to suppress Solaris warnings
2010-09-10 22:45:49 +02:00
Matthias Dieter Wallnöfer
55598c4746
s4:torture/rpc/winreg.c - hopefully this attempt fixes Solaris "cc" on the buildfarm
...
The Solaris "cc" incompatiblity on this codepart seems to be harder to fix than
it looks like.
2010-09-10 20:20:26 +02:00
Matthias Dieter Wallnöfer
4fc1319db9
s4:getncchanges_change_master - also in this call "i" needs to be unsigned
2010-09-10 20:20:26 +02:00
Stefan Metzmacher
88f96578cd
s4-errormap: map ERRSRV/ERRbaduid to NT_STATUS_USER_SESSION_DELETED
...
metze
2010-09-10 17:21:31 +02:00