1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-11 05:18:09 +03:00
Commit Graph

11275 Commits

Author SHA1 Message Date
Andrew Bartlett
d0bebea521 Patch from ab, to make findsmb omit -r most of the time.
(original mail follows)
--
From:	Alexander Bokovoy <a.bokovoy@sam-solutions.net>
Greetings!

I propose to make an optional argument '-r' for findsmb utility to pass
'-r' option to nmblookup optionally and default to omit it. The reason is
to have findsmb working more user-friendly in contemporary office
environments where Windows 95/98 boxes are rare and also to allow usage of
the utility under non-priviledged accounts when Windows95/98 boxes are in
minority or even absent in network neighbourhood.

An attached patch provides this change for HEAD together with
documentation changes.

--
/ Alexander Bokovoy
0001-01-01 00:00:00 +00:00
Andrew Bartlett
b6641badcb Updates to our NTLMSSP code:
This tries to extract our server-side code out of sessetup.c, and into a more
general lib.  I hope this is only a temporay resting place - I indend to
refactor it again into an auth-subsystem independent lib, using callbacks.

Move some of our our NTLMSSP #defines into a new file, and add two that I found
in the COMsource docs - we seem to have a double-up, but I've verified from
traces that the NTLMSSP_TARGET_TYPE_{DOMAIN,SERVER} is real.

This code also copes with ASCII clients - not that we will ever see any here,
but I hope to use this for HTTP, were we can get them.  Win2k authenticates
fine under forced ASCII, btw.

Tested with Win2k, NTLMv2 and Samba's smbclient.

Andrew Bartlett
0001-01-01 00:00:00 +00:00
Andrew Bartlett
6e821285a4 Accessing data after it's been free()ed really is a no-no...
Andrew Bartlett
0001-01-01 00:00:00 +00:00
Andrew Bartlett
7abca6d281 Fix to debian bug #171071 - we had the wrong dereference on the pointer to be
Realloc()ed, causing it to fail.

Big thanks to Sandor Sonfeld <sonf@linuxmail.org> for the debug, stack and
valgrind traces!

Andrew Bartlett
0001-01-01 00:00:00 +00:00
Andrew Bartlett
c6535836f2 Don't force the DOS password into a 14 char space, as this would imply null
termination - the password will not be null terminated before hashing if
len >= 14.

related to debian bug #157432

Andrew Bartlett
0001-01-01 00:00:00 +00:00
Andrew Bartlett
f8d9880c5f Ensure we do not pass uninitialised data to the kernel. (Picked up by
valgrind).

Andrew Bartlett
0001-01-01 00:00:00 +00:00
Martin Pool
26660f939f Fix typo in comment. 0001-01-01 00:00:00 +00:00
Tim Potter
089729c02c Merge of remove "winbindd holding pattern" from appliance. It's a bit
simpler as the rescanning of trusted domains helps us out a bit.
0001-01-01 00:00:00 +00:00
Andrew Bartlett
f087fe546f Keep all the const warnings in one place, by adding a utility function to
make the TDB_DATA.

Andrew Bartlett
0001-01-01 00:00:00 +00:00
Andrew Bartlett
ef9c7586ac Oops, this is the change to use an fstring for the incoming service buffer -
the commit to reply.c just matches a pstrcpy for the pstring.  (harmless, fixes
it for the automated test).

Andrew Bartlett
0001-01-01 00:00:00 +00:00
Andrew Bartlett
7854a439ac Make the 'service' in make_connection() use an fstrcpy(), and an fstring,
becouse that is what it's input (reply_tcon_and_x) uses, and becouse we really
don't want supprises for service names.

Also remove a legacy #define, in favor of the lp_ equiv.

Andrew Bartlett
0001-01-01 00:00:00 +00:00
Andrew Bartlett
7b92d26d47 While the usage is most bisarre, this fixes up another fstring/pstring mixup.
(In this case, an fstrcpy() into a pstring, ie harmless).

Andrew Bartlett
0001-01-01 00:00:00 +00:00
Andrew Bartlett
f42cf0783f Use size_t for the counter vars, to match the type they are assigned from
(signed/unsigned mixup).

Andrew Bartlett
0001-01-01 00:00:00 +00:00
Andrew Bartlett
9b76123732 A couple more fstring/pstring issues - and move from sizeof(fstring) to
sizeof(var) in slprintf statements, so as to ensure we don't get mixups there.

Also remove fstrcpy() into a variable that is about to be printed into anyway.

Andrew Bartlett
0001-01-01 00:00:00 +00:00
Andrew Bartlett
5ff5f540cc Remove an unused paramter for our old LM-only password change code, and fix a
(harmless) fstring/pstring mixup.

Andrew Bartlett
0001-01-01 00:00:00 +00:00
Andrew Bartlett
fe1cc779d5 Fix a number of client-side fstring/pstring mixups.
Andrew Bartlett
0001-01-01 00:00:00 +00:00
Andrew Bartlett
a66ced2cf6 Patch from Nik Conwell <nik@bu.edu>. Don't reference free()ed data when trying
to figure out if we have got our ticket yet.

Andrew Bartlett
0001-01-01 00:00:00 +00:00
Andrew Bartlett
90d0517653 Return the 'freindly' NT error message if at all possible.
Andrew Bartlett
0001-01-01 00:00:00 +00:00
Andrew Bartlett
3b2e5f68cd No point having this for both parts of the 'if' statement.
Andrew Bartlett
0001-01-01 00:00:00 +00:00
Gerald Carter
f8a915b14d [merge] make sure to update print queue cache during timeout_processing() to send notify events; CR 1491 0001-01-01 00:00:00 +00:00
Gerald Carter
1f33b4acb3 typo from merge 0001-01-01 00:00:00 +00:00
Gerald Carter
d1c97738ba fix tdb_append() prototype 0001-01-01 00:00:00 +00:00
Gerald Carter
df6e455992 fix tdb_append() prototype 0001-01-01 00:00:00 +00:00
Gerald Carter
142c5029c7 [merge] make sure to updatre print queue cache during timeout_processing() to send notify events; CR 1491 0001-01-01 00:00:00 +00:00
Jeremy Allison
ee0ceeff99 Added new message_send_pid() code that uses tdb append to reduce locking
contention on the messaging tdb.
Jeremy.
0001-01-01 00:00:00 +00:00
Jeremy Allison
5b8cf0810a Added new message_send_pid() code that uses tdb append to reduce locking
contention on the messaging tdb.
Jeremy.
0001-01-01 00:00:00 +00:00
Jeremy Allison
724cefabb0 Added tdb_append() call. Efficiently adds to an entry. Used by new messaging
code. Also added torture tests for it.
Jeremy.
0001-01-01 00:00:00 +00:00
Jeremy Allison
b515525a06 Added tdb_append() call. Efficiently adds to an entry. Used by new messaging
code. Also added torture tests for it.
Jeremy.
0001-01-01 00:00:00 +00:00
Jeremy Allison
04243e39cf First part of efficiency fixes for message sending to pid's (cutting down
the amount of time we hold tdb locks). Gulp down all messages at once rather
than reading/re-writing one at a time. NOTE: All dispatch routines *must*
be able to cope with incoming message on *odd* byte boundaries (all current
handlers do).
Jeremy.
0001-01-01 00:00:00 +00:00
Jeremy Allison
b752c0340f First part of efficiency fixes for message sending to pid's (cutting down
the amount of time we hold tdb locks). Gulp down all messages at once rather
than reading/re-writing one at a time. NOTE: All dispatch routines *must*
be able to cope with incoming message on *odd* byte boundaries (all current
handlers do).
Jeremy.
0001-01-01 00:00:00 +00:00
Jeremy Allison
21c8acd25a Fix lpq_cache time check (missed from yesterday).
Jeremy.
0001-01-01 00:00:00 +00:00
Jeremy Allison
6cb9f6ccb1 Don't delete jobs subitted after the lpq time.
Jeremy.
0001-01-01 00:00:00 +00:00
Gerald Carter
3442c270f1 a 0 length printer data value is not a memory allocation error; fix CR601 0001-01-01 00:00:00 +00:00
Gerald Carter
47c1709425 a 0 length printer data value is not a memory allocation error; fix CR601 0001-01-01 00:00:00 +00:00
Martin Pool
575908cb06 tdb_chainlock_with_timeout: Add TODO: If we time out waiting for a
lock, it might be nice to use F_GETLK to get the pid of the process
currently holding the lock and print that as part of the debugging
message.

I'd like to have this in appliance_head, but the code is too different
so I won't worry for now.
0001-01-01 00:00:00 +00:00
Tim Potter
88eb9e9486 Remove read_with_timeout() and replaced its only caller (the passwd chat
stuff) with a call to read_socket_with_timeout() which does the same thing.

Passwd chat still works but I couldn't figure out the right arguments to
passwd chat to get it to work right but data was definitely getting
through.
0001-01-01 00:00:00 +00:00
Herb Lewis
9151cd7d64 Moved smbd process counting functions from smbd/server.c to smbd/process.c
so that bin/vfstest can link.  merge from head
0001-01-01 00:00:00 +00:00
Tim Potter
6ed4d80baa Remove dead function. 0001-01-01 00:00:00 +00:00
Tim Potter
812ce0368c Moved smbd process counting functions from smbd/server.c to smbd/process.c
so that bin/vfstest can link.
0001-01-01 00:00:00 +00:00
Martin Pool
be835d01e1 Correct misleading comment: winbindd_lookupname gets the SID for a
name, not vice versa.
0001-01-01 00:00:00 +00:00
Jeremy Allison
6a2b7fd82c Ensure we return disk full by default on short writes.
Jeremy.
0001-01-01 00:00:00 +00:00
Jeremy Allison
2a974bc284 Ensure we return disk full by default on short writes.
Jeremy.
0001-01-01 00:00:00 +00:00
Jeremy Allison
e048259472 Ensure we don't get an invalid number for total smbd's if the tdb update
fails.
Jeremy.
0001-01-01 00:00:00 +00:00
Jeremy Allison
99e69fd74d Ensure we don't get an invalid number for total smbd's if the tdb update
fails.
Jeremy.
0001-01-01 00:00:00 +00:00
Herb Lewis
947042007d reran autoconf 0001-01-01 00:00:00 +00:00
Richard Sharpe
490ff93bbf Some fixes to editreg. Clientgen should not be touched, and an update to configure that Herb needs. 0001-01-01 00:00:00 +00:00
Jeremy Allison
48774e77ac Fix erroneous free of SAM_ACCOUNT (make clearer when allocated
memory is being returned).
Jeremy.
0001-01-01 00:00:00 +00:00
Jeremy Allison
b0d547b739 Fix erroneous free of SAM_ACCOUNT (make clearer when allocated
memory is being returned).
Jeremy
0001-01-01 00:00:00 +00:00
Tim Potter
db24489eb4 Removed pointless null statement in signal handler. 0001-01-01 00:00:00 +00:00
Tim Potter
451286febd Display an error message when the server cannot be resolved when running at
debug level 0.
0001-01-01 00:00:00 +00:00