Günther Deschner
d19ea55e9e
s3-includes: avoid global include of gssapi headers.
...
Guenther
2011-03-16 10:11:16 +01:00
Günther Deschner
6c8d802391
s3-libsmb: move smb encryption structs into own header.
...
Guenther
2011-03-16 10:11:16 +01:00
Günther Deschner
e1f84330ba
libcli/security: move display_sec headers to own header file and add to
...
security.h grouping header.
Guenther
2011-03-16 10:11:08 +01:00
Volker Lendecke
9bc14afe96
s3: Fix a cut&paste error in pdb_ads_connect
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 16 08:22:28 CET 2011 on sn-devel-104
2011-03-16 08:22:28 +01:00
Volker Lendecke
831ff4519e
s3: Use jenkins hash for str_checksum, fix bug 8010
...
From the bugreport:
I have a folder with ~90 photos: IMG_XXXX.JPG where XXXX is a four digit
number, almost consecutive (photos from camera for one day).
Current implementation gives about 30 different checksums for this set of
files.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Mar 16 01:15:41 CET 2011 on sn-devel-104
2011-03-16 01:15:41 +01:00
Günther Deschner
5e3da3fc50
s3-build: try to silence annoying "Ignoring invalid value 'vlp' for parameter 'printing'"
...
warning on the buildfarm.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Mar 15 23:38:43 CET 2011 on sn-devel-104
2011-03-15 23:38:43 +01:00
Günther Deschner
7a91282c9f
s3-libsmb: only include rap client when needed.
...
Guenther
2011-03-15 21:16:35 +01:00
Günther Deschner
c91b897caa
s3-build: share smbtorture4 build rules with s3-waf build.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Mar 15 16:10:17 CET 2011 on sn-devel-104
2011-03-15 16:10:16 +01:00
Volker Lendecke
d9a58791b0
s3: Fix Coverity ID 2278: Uninitialized read
...
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
2011-03-15 11:10:46 +01:00
Volker Lendecke
f0d491205c
s3: Fix Coverity ID 2279: Uninitialized read
...
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
2011-03-15 11:10:46 +01:00
Volker Lendecke
c98c36e38b
s3: Fix Coverity ID 2280: Uninitialized read
...
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
2011-03-15 11:10:46 +01:00
Volker Lendecke
6b584e0e9a
s3: Fix Coverity ID 2281: Uninitialized read
...
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
2011-03-15 11:10:45 +01:00
Volker Lendecke
e68cf5e9bf
s3: Fix Coverity ID 2282: Uninitialized read
...
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
2011-03-15 11:10:45 +01:00
Volker Lendecke
b753b0ab82
s3: Fix Coverity ID 2283: Uninitialized read
...
We passed the structure including the uninitialized elements to
dcerpc_winreg_OpenKey.
2011-03-15 11:10:45 +01:00
Volker Lendecke
2992ccfe9c
s3: Fix Coverity ID 2284: Uninitialized read
...
We passed the structure including the uninitialized elements to
dcerpc_winreg_DeleteValue.
2011-03-15 11:10:45 +01:00
Volker Lendecke
2b26c86fe6
s3: Fix Coverity ID 2285: Uninitialized read
...
We passed the structure including the uninitialized elements to
dcerpc_winreg_DeleteValue.
2011-03-15 11:10:45 +01:00
Volker Lendecke
c09877113d
s3: Fix Coverity ID 2286: Uninitialized read
...
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
2011-03-15 11:10:44 +01:00
Volker Lendecke
31ff8f38e7
s3: Fix Coverity ID 2287: Uninitialized read
...
We passed the structure including the uninitialized elements to
dcerpc_winreg_CreateKey.
2011-03-15 11:10:43 +01:00
Volker Lendecke
09677d664f
s3: Fix Coverity ID 2288: Uninitialized read
...
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
2011-03-15 11:10:43 +01:00
Volker Lendecke
cc90415062
s3: Fix Coverity ID 2289: Uninitialized read
...
We passed the structure including the uninitialized elements to
dcerpc_winreg_OpenKey.
2011-03-15 11:10:42 +01:00
Volker Lendecke
4f34955e2c
s3: Fix Coverity ID 2290: Uninitialized read
...
We passed the structure including the uninitialized elements to
dcerpc_winreg_DeleteKey.
2011-03-15 11:10:42 +01:00
Volker Lendecke
420be02a60
s3: Read uidNumber/gidNumber in pdb_ads_sid_to_id
...
Question: How shall we allocate those? Something like the rid allocator?
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Mar 15 09:59:55 CET 2011 on sn-devel-104
2011-03-15 09:59:55 +01:00
Volker Lendecke
b0667f7fda
s3: Remove some unused code
2011-03-15 09:15:36 +01:00
Volker Lendecke
a4d7b3a1df
s3: "hex_encode" does the same as "binary_string"
2011-03-15 09:15:35 +01:00
Andrew Tridgell
af28facc03
s3-waf: enable public_headers_allow_broken
2011-03-15 12:22:20 +11:00
Andrew Tridgell
7a57f72ef4
s3-waf: enable public header building in s3
2011-03-15 12:22:20 +11:00
Jeremy Allison
a6d07a8e69
Re-enable base.tcondev test for S3, now we pass it correctly.
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Mar 15 00:59:37 CET 2011 on sn-devel-104
2011-03-15 00:59:37 +01:00
Jeremy Allison
e59a950c04
Fix bug #8005 - smbtorture4 BASE-TCONDEV fails when tested on Samba
...
When pulling non-aligned ucs2 strings, we neglected to add in the
pad byte to the buffer length we've eaten. This caused the device
string in TCONX (which seems to be one of the few places that uses
non-aligned ucs2 strings) to be incorrectly read.
Volker please check.
Jeremy.
2011-03-14 16:12:31 -07:00
Volker Lendecke
8dfa224c13
s3: Change tldap_entry_attributes to the "array,count" convention
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Mar 14 22:02:35 CET 2011 on sn-devel-104
2011-03-14 22:02:35 +01:00
Volker Lendecke
e818090e24
s3: Fix bug 8009 - net rap session cannot get username
...
Looking in [MS-RAP].pdf - these strings are always 4 bytes as an
offset in the rparam area, the string length is the size in the rdata area.
Se we must always return we have consumed 4 param bytes.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Mar 14 20:09:09 CET 2011 on sn-devel-104
2011-03-14 20:09:09 +01:00
Volker Lendecke
746b299ec1
s3: Fix the talloc hierarchy in shadow_copy2_connectpath
...
We have to return on talloc_tos() because we don't have a mem_ctx given to us.
So we have to create a separate temporary talloc context.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Mar 14 19:21:11 CET 2011 on sn-devel-104
2011-03-14 19:21:11 +01:00
Volker Lendecke
43e343be81
s3: This module needs rewriting...
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Mar 14 17:47:32 CET 2011 on sn-devel-104
2011-03-14 17:47:32 +01:00
Stefan Metzmacher
72c1fe0081
librpc/rpc: move DCERPC_ flags to rpc_common.h
...
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sun Mar 13 20:45:53 CET 2011 on sn-devel-104
2011-03-13 20:45:53 +01:00
Stefan Metzmacher
f7840b3293
s3:librpc/rpc: add DCERPC_ANON_FALLBACK flag
...
With this they're in sync with source4.
metze
2011-03-13 19:24:57 +01:00
Stefan Metzmacher
08dca92499
librpc/rpc: move struct dcerpc_binding to rpc_common.h
...
metze
2011-03-13 16:53:05 +01:00
Stefan Metzmacher
7b7baecf1a
s3:librpc/rpc: add target_principal to struct dcerpc_binding
...
This brings the source3 copy in sync with the source4 copy
of struct dcerpc_binding.
metze
2011-03-13 16:52:59 +01:00
Stefan Metzmacher
83c55ac67e
librpc/rpc: move enum dcerpc_transport_t to rpc_common.h
...
metze
2011-03-13 16:33:06 +01:00
Volker Lendecke
51ebaac75b
s3: Enhance error messages in idmap_tdb2_init_hwm
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Mar 13 12:59:37 CET 2011 on sn-devel-104
2011-03-13 12:59:37 +01:00
Volker Lendecke
f84d439ff6
Revert "s3: Fix bug 8009"
...
This reverts commit 1829891391
.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Mar 13 10:33:25 CET 2011 on sn-devel-104
2011-03-13 10:33:25 +01:00
Volker Lendecke
1829891391
s3: Fix bug 8009
...
Jeremy, please check!
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Mar 12 11:39:41 CET 2011 on sn-devel-104
2011-03-12 11:39:41 +01:00
Volker Lendecke
70c75b9ddf
s3: Fix a typo
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Mar 11 13:15:00 CET 2011 on sn-devel-104
2011-03-11 13:15:00 +01:00
Stefan Metzmacher
b738e092a2
librpc/rpc: move dcerpc_binding_handle stuff to rpc_common.h
...
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Mar 11 12:28:08 CET 2011 on sn-devel-104
2011-03-11 12:28:08 +01:00
Stefan Metzmacher
5657c96714
s3:librpc/rpc: remove unused dcerpc_pipe define hack
...
metze
2011-03-11 11:02:24 +01:00
Michael Adam
0726b29e59
s3:idmap_ldap: fix a few typos in a comment
...
and use the chance to reformat the comment properly...
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Mar 11 01:29:09 CET 2011 on sn-devel-104
2011-03-11 01:29:09 +01:00
Günther Deschner
8953c7dc26
s3-selftest: add another flaky s3-torture test to knownfail, this time OPLOCK4.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Mar 11 00:42:27 CET 2011 on sn-devel-104
2011-03-11 00:42:27 +01:00
Günther Deschner
af2538d16f
s3-build: remove -I../lib/addns.
...
Guenther
2011-03-10 23:25:04 +01:00
Günther Deschner
c8098246be
waf-selftest: allow to call "make test SUBUNIT_FORMATTER=cat".
...
Guenther
2011-03-10 23:25:04 +01:00
Günther Deschner
88ff230ae9
s3-waf: fix typo.
...
Guenther
2011-03-10 23:25:04 +01:00
Günther Deschner
6076f4b472
s3-selftest: run a couple of dgram NBT tests against s3.
...
Guenther
2011-03-10 23:25:03 +01:00
Volker Lendecke
257f0491cb
s3: sid->domain_sid in winbindd_samr sam_rids_to_names
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Mar 10 19:33:47 CET 2011 on sn-devel-104
2011-03-10 19:33:46 +01:00
Volker Lendecke
16b007c223
Quite some callers of sid_split_rid do not care about the rid
2011-03-10 18:48:34 +01:00
Volker Lendecke
8d0e241530
s3: Fix paranoia check in sam_rids_to_names
2011-03-10 18:48:34 +01:00
Günther Deschner
12f2170a2b
s3-selftest: properly move connect to seal options.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 9 13:13:06 CET 2011 on sn-devel-104
2011-03-09 13:13:06 +01:00
Günther Deschner
286530b3fe
s3-selftest: no point in testing smb2 via ncacn_ip_tcp.
...
Guenther
2011-03-09 12:27:26 +01:00
Günther Deschner
05b447b26f
s3-selftest: remove *ncacn_ip_tcp* from knownfail list.
...
Guenther
2011-03-09 12:27:26 +01:00
Günther Deschner
f0d59bb3cf
s3-rpc_server: handle DCERPC_AUTH_LEVEL_CONNECT in api_pipe_bind_req().
...
Guenther
2011-03-09 12:27:25 +01:00
Volker Lendecke
dec9d03e25
libsmbclient: Fix a typo
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 9 11:19:36 CET 2011 on sn-devel-104
2011-03-09 11:19:35 +01:00
Andreas Schneider
fb3e4d2be5
s3-rpc_server: Remove unused _rpc_ep_register.
...
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Wed Mar 9 10:32:32 CET 2011 on sn-devel-104
2011-03-09 10:32:32 +01:00
Andreas Schneider
8df4f4fd41
s3-rpc_server: Use the new endpoint register functions.
2011-03-09 09:28:42 +01:00
Andreas Schneider
71f613e9d5
s3-rpc_server: Add tevent based endpoint setup functions.
2011-03-09 09:28:42 +01:00
Andreas Schneider
133ed1cc64
s3-rpc_server: Change irritating debug message.
2011-03-09 09:28:42 +01:00
Andreas Schneider
038042363a
s3-rpc_client: Don't ask endpoint mapper for its own port.
2011-03-09 09:28:42 +01:00
Andreas Schneider
b181cd8465
s3-smbd: Increase debug level von context messages.
2011-03-09 09:28:42 +01:00
Volker Lendecke
c4b52fbc46
s3: Use talloc_tos() in idmap_nss_sids_to_unixids
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Mar 8 21:51:58 CET 2011 on sn-devel-104
2011-03-08 21:51:58 +01:00
Volker Lendecke
a3ef79b6cf
s3: "dom_name" is not needed in idmap_nss_sids_to_unixids
2011-03-08 21:04:32 +01:00
Volker Lendecke
8cda1d9797
s3: "ctx" is not needed in idmap_nss_unixids_to_sids
2011-03-08 21:04:32 +01:00
Günther Deschner
a200bac093
s3-selftest: only run smbtorture4 tests when smbtorture4 is available.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Mar 8 14:51:18 CET 2011 on sn-devel-104
2011-03-08 14:51:18 +01:00
Günther Deschner
1605563b14
s3-selftest: add pattern test of dcerpc binding options (using rpc.lsa.lookupsids).
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Mar 8 12:29:21 CET 2011 on sn-devel-104
2011-03-08 12:29:21 +01:00
Günther Deschner
12f10a9182
s3-waf: fix the build.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:31 +01:00
Günther Deschner
19117db52c
s3-epmd: remove some unused variables.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:31 +01:00
Günther Deschner
d92e060dd9
s3-epmap: fix uninitialized variable in ep_register()
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:31 +01:00
Günther Deschner
b7c692bae7
s3-selftest: no need to run rpc.samba3.netlogon twice.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:31 +01:00
Andreas Schneider
794e0f5f0c
s3-rpc_server: Added IPv6 support for epmapper.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:31 +01:00
Andreas Schneider
a955c53843
s3-rpc_server: Free unused memory.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:31 +01:00
Andreas Schneider
bb201fac2b
s3-winbind: Fixed the accept() for new_connection.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:31 +01:00
Andreas Schneider
69a9b9b8d0
s3-rpc_server: Fixed the accept() for ncalrpc_listener.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:31 +01:00
Andreas Schneider
07e8904a5b
s3-rpc_server: Fixed the accept() for tcpip_listener.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:30 +01:00
Andreas Schneider
9dc27cb5b2
s3-rpc_server: Fixed the accept() for named_pipe_listener.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:30 +01:00
Andreas Schneider
ce491edcad
s3-librpc: Register NCALRPC pipes.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:30 +01:00
Andreas Schneider
50de20979b
s3-rpc_server: Create the ncalrpc endpoints.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:30 +01:00
Andreas Schneider
4b8dd08a38
s3-rpc_server: Add server support for NCALRPC system user pipe.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:30 +01:00
Andreas Schneider
5ce12e0beb
s3-rpc_server: Improved the dcerpc_ncacn_accept switch.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:30 +01:00
Andreas Schneider
42e9dde646
s3-rpc_server: Remove unneeded ncacn wrappers.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:30 +01:00
Andreas Schneider
0f97f789b2
s3-rpc_server: Fixed ncalrpc connection accept.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:30 +01:00
Andreas Schneider
53018dc37d
s3-rpc_server: Only allow epm insert and delete on NCALRPC.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:30 +01:00
Andreas Schneider
cc5b88545d
s3-rpc_server: Introduce transport in pipe_struct.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:30 +01:00
Andreas Schneider
bd66fc81b6
s3-rpc_server: Start the Endpoint Mapper Dameon if enabled.
...
Endpoint Mapper is still disabled by default!
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:29 +01:00
Andreas Schneider
55296edb09
s3-rpc_server: Created an Endpoint Mapper Daemon.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:29 +01:00
Andreas Schneider
148ed2c3f9
s3-librpc: Register endpoints using ncalrpc.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:29 +01:00
Andreas Schneider
d343409d6b
s3-rpc_client: Added DCERPC_AUTH_TYPE_NCALRPC bind.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:29 +01:00
Andreas Schneider
917a5eaf18
s3-rpc_server: Added prototype to setup a ncalrpc socket.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:29 +01:00
Simo Sorce
1e69dad446
s3-epmap: add ncalrpc listener code
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:29 +01:00
Simo Sorce
6ac34d58a9
sr-epmap: Minor cleanups and fixes
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:29 +01:00
Andreas Schneider
aa777df557
s3-epmap: Return the correct ip address.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:29 +01:00
Andreas Schneider
254c02041c
s3-rpc_server: Added server address to pipes struct.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:29 +01:00
Andreas Schneider
d14de8fd4d
s3-rpc_server: Set client and server connection info.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:28 +01:00
Andreas Schneider
ae67ccfb0d
s3-rpc_server: Added tcpip listener for each rpc service.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:28 +01:00
Andreas Schneider
c80e519cdc
s3-librpc: Free memory we don't need.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:28 +01:00
Andreas Schneider
a45353b3e2
s3-librpc: Added tcpip support for dcerpc_binding_vector_create.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:28 +01:00
Günther Deschner
98443b8b3d
s3-idmap: fix the build of idmap_tdb2.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Mar 8 10:51:04 CET 2011 on sn-devel-104
2011-03-08 10:51:04 +01:00
Volker Lendecke
6013d7589b
s3: state->ev is not needed in winbindd_lookupsid
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Mar 7 20:52:53 CET 2011 on sn-devel-104
2011-03-07 20:52:53 +01:00
Volker Lendecke
233c8bca3b
s3: Remove close_fn from idmap_methods
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Mar 6 13:37:13 CET 2011 on sn-devel-104
2011-03-06 13:37:13 +01:00
Volker Lendecke
82785957f0
s3-idmap-hash: Make "hashed_domains" properly talloced
2011-03-06 12:51:02 +01:00
Volker Lendecke
4daf01f38b
s3: Replace idmap_ad_close by a destructor
2011-03-06 12:51:02 +01:00
Volker Lendecke
41c85650c9
s3-idmap-ad: Make ad_schema properly talloced
2011-03-06 12:51:02 +01:00
Volker Lendecke
6e5726310f
s3-idmap-tdb: private_data is a talloc child of dom
2011-03-06 12:51:02 +01:00
Volker Lendecke
1bf29c7acf
s3-idmap-ldap: private_data is a talloc child of dom
2011-03-06 12:51:02 +01:00
Volker Lendecke
9c5802b841
s3-idmap-rid: private_data is a talloc child of dom
2011-03-06 12:51:01 +01:00
Volker Lendecke
bc940ed4c8
s3: Remove an unnecessary if-statement
2011-03-06 12:51:01 +01:00
Volker Lendecke
4fd4303c64
s3: Remove an obsolete comment
2011-03-06 12:51:01 +01:00
Volker Lendecke
d76b3fd0a8
s3: Remove some unused code
2011-03-06 12:51:01 +01:00
Volker Lendecke
d3ba16a500
s3: Remove unused args from nss_get_info_cached
2011-03-06 12:51:01 +01:00
Volker Lendecke
fff6fa7576
s3: Remove unused args from nss_get_info
2011-03-06 12:51:01 +01:00
Volker Lendecke
99d98e31bc
s3: Remove unused args from get_nss_info
2011-03-06 12:51:01 +01:00
Volker Lendecke
f6f8ec8d8b
s3: Move EXOP definitions to smbldap.h
...
This attempts to fix the build on Solaris
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Mar 6 10:45:16 CET 2011 on sn-devel-104
2011-03-06 10:45:16 +01:00
Volker Lendecke
a40bb91213
s3: Fix uninitialized variables
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Mar 5 17:25:43 CET 2011 on sn-devel-104
2011-03-05 17:25:43 +01:00
Volker Lendecke
c97ea5976c
s3-net: Use wbcSidToStringBuf
2011-03-05 14:29:32 +01:00
Volker Lendecke
181b23ceed
nsswitch: wbcFreeMemory deals fine with NULL
2011-03-05 14:29:32 +01:00
Volker Lendecke
dcbfb6fc0b
s3: Fix a memory leak in check_sam_security_info3
...
Abartlet, this commit makes check_sam_security_info3 use talloc_tos() and also
cleans up the temporary talloc stackframe.
The old code created a temporary talloc context off "mem_ctx" but failed to
clean up the tmp_ctx in all but one return paths.
talloc_stackframe()/talloc_tos() is designed as a defense against exactly this
error: Even if we failed to free the frame when returning from the routine, it
would be cleaned up very soon, in our main event loop.
Please check this patch!
Thanks,
Volker
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Mar 5 14:08:37 CET 2011 on sn-devel-104
2011-03-05 14:08:37 +01:00
Michael Adam
f1a5109565
s3:test: the registry roundtrip test passes now
...
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Sat Mar 5 02:19:33 CET 2011 on sn-devel-104
2011-03-05 02:19:33 +01:00
Michael Adam
916ff0bf55
s3:test: mark vanished parameter "postscript" invalid in net registry roundtrip test
2011-03-05 01:31:33 +01:00
Michael Adam
2fd2e2e75d
s3:test: in net registry roundtrip test, mark "lock dir" as invalid parameter
...
This is a synonym of lock directory which is already marked invalid.
2011-03-05 01:31:33 +01:00
Michael Adam
541c580895
s3:test: in net registry roundtrip test, exclude the files from exclude/logon
...
These files are not samba config files...
2011-03-05 01:31:33 +01:00
Michael Adam
aa8c9ef138
s3:registry: fix invalid write in iconvert_talloc()
...
For a non-preallocated dest-string and sourcestring of len < 2,
(one or both of the) final two two zero-bytes would be written
after the end of the allocated dest-string. The sourcelen did
not include the source string terminator. For longer strings,
this was not a problem because the dest-string would have been
reallocated in the convert-loop. This is fixed now by allocating
two extra bytes for the terminating 0-bytes that are needed anyways
in the initial allocation.
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
2011-03-05 01:31:33 +01:00
Michael Adam
7b4fc4d745
s3:test: correctly react to each failing step in the net registry roundtrip tests
2011-03-05 01:31:33 +01:00
Michael Adam
f5ab9c1e77
s3:test: improve logging in the net registry roundtrip test steps
2011-03-05 01:31:32 +01:00
David Disseldorp
9c342c44a4
s3: add two missing vfs disconnect calls
...
The fix for bug 7976 added a vfs connect call to create_conn_struct.
This change adds two further disconnect calls that were missed by the
original change.
Signed-off-by: Andreas Schneider <asn@samba.org>
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Fri Mar 4 16:33:53 CET 2011 on sn-devel-104
2011-03-04 16:33:53 +01:00
David Disseldorp
2b635949a2
s3-printing: fix cups pcap reload with no printers
...
cups_async_callback() is called to receive new printcap data from a
child process which requests the information from cupsd.
Newly received printcap information is stored in a temporary printcap
cache (tmp_pcap_cache). Once the child process closes the printcap IPC
file descriptor, the system printcap cache is replaced with the newly
populated tmp_pcap_cache, however this only occurs if tmp_pcap_cache is
non null (has at least one printer).
If the printcap cache is empty, which is the case when cups is not
exporting any printers, the printcap cache is not replaced resulting in
stale data.
https://bugzilla.samba.org/show_bug.cgi?id=7915
Signed-off-by: Andreas Schneider <asn@samba.org>
2011-03-04 15:46:23 +01:00
David Disseldorp
624e33f869
s3-printing: remove unneeded local_pcap_copy global
...
The cups local_pcap_copy global served as a temporary buffer during
asynchronous cups printcap cache updates, as well as indicating when
the printcap cache had not yet been filled and printcap cache update
should block.
As smbd printcap reads are now triggered by the parent smbd following
printcap cache update, the variable and blocking mechanism are no longer
needed.
Signed-off-by: Andreas Schneider <asn@samba.org>
2011-03-04 15:46:20 +01:00
David Disseldorp
61bf4699f0
s3-printing: follow force user/group for driver IO
...
Configuring force user/group settings for the print$ share currently has
unexpected results, this is explained by how the driver upload/add
process takes place. Consider the following example:
[print$]
path = /print-drv
write list = $DRIVER_UPLOAD_USER
force group = ntadmin
- the client connects to the [print$] share and uploads all driver
files to the /print-drv/W32X86 directory.
- This is permitted, as /print-drv/W32X86 is owned by group ntadmin, and
the "force group = ntadmin" takes effect for the [print$] session.
- Once all files are uploaded, the client connects to the [ipc$]
share and issues an AddPrinterDriverEx spoolss request.
- In handling this request move_driver_to_download_area() is called,
which attempts to create the directory /print-drv/W32X86/3
- The create directory fails, as it is done as the user connected to
the [ipc$] share which does not have permission to write to the driver
directory. The [print$] "force group = ntadmin" has no effect.
This is a regression from previous behaviour prior to the commit:
783ab04
Convert move_driver_to_download_area to use create_conn_struct.
https://bugzilla.samba.org/show_bug.cgi?id=7921
Signed-off-by: Andreas Schneider <asn@samba.org>
2011-03-04 15:46:14 +01:00
Günther Deschner
e63f0dfba1
s3-waf: add wildcard commands from main wscript.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Mar 4 02:11:11 CET 2011 on sn-devel-104
2011-03-04 02:11:10 +01:00
Günther Deschner
ef87f970b3
s3-nterr: use strcasecmp in nt_status_string_to_code().
...
Guenther
2011-03-04 01:18:42 +01:00
Günther Deschner
d367777352
s3-nterr: within nt_errstr() compare codes using NT_STATUS_V().
...
This is to avoid future very special NT_STATUS_EQUAL semantics within s4.
Guenther
2011-03-04 01:18:42 +01:00
Günther Deschner
199809b3cc
nterr: make sure both nt_err_desc structs are the same.
...
Guenther
2011-03-04 01:18:42 +01:00
Günther Deschner
45710a05c5
nterr: make sure both nt_errs structs are the same.
...
Guenther
2011-03-04 01:18:42 +01:00
Günther Deschner
c1089c130b
s3-nterr: make nt_err_desc static const.
...
Guenther
2011-03-04 01:18:42 +01:00
Günther Deschner
cb8c0e1776
nterr: remove space indents (use tabs instead), following coding standards.
...
Guenther
2011-03-04 01:18:41 +01:00
Günther Deschner
2f46942e08
nterr: remove trailing whitespace.
...
Guenther
2011-03-04 01:18:41 +01:00
Günther Deschner
6b3d68fffd
s3-waf: add check for SEEKDIR_RETURNS_VOID.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Mar 4 01:13:54 CET 2011 on sn-devel-104
2011-03-04 01:13:54 +01:00
Günther Deschner
0fb246ba73
s3-waf: add check for HAVE_FUNCTION_ATTRIBUTE_DESTRUCTOR.
...
Guenther
2011-03-04 00:28:28 +01:00
Günther Deschner
9167d70e77
libreplace: move "struct timespec" checks into libreplace (where timespec is already used).
...
Bjoern, Metze, please check.
Guenther
2011-03-04 00:28:27 +01:00
Volker Lendecke
7b139a49dc
s3: Use dom_sid_string_buf in sid_to_fstring
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Mar 3 22:56:57 CET 2011 on sn-devel-104
2011-03-03 22:56:56 +01:00
Volker Lendecke
f8a13c7dbc
s3: Use dom_sid_string in _lsa_lookup_sids_internal
2011-03-03 22:08:49 +01:00
Volker Lendecke
ae28029f67
s3: Remove an obsolete comment
2011-03-03 22:08:49 +01:00
Volker Lendecke
01da00abfd
s3: Fix some nonempty blank lines
2011-03-03 22:08:49 +01:00
Günther Deschner
875d9b8098
lib/util: LIBCRYPTO is in common already, so add it to samba-util-common.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Mar 3 18:08:30 CET 2011 on sn-devel-104
2011-03-03 18:08:30 +01:00
Günther Deschner
ba7727487e
s3-includes: remove global include of system/readline.h.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 2 23:06:17 CET 2011 on sn-devel-104
2011-03-02 23:06:17 +01:00
Günther Deschner
a460fe8151
s3-proto: fix some inline comments.
...
Guenther
2011-03-02 22:17:52 +01:00
Günther Deschner
93db9489fd
s3-libds: use already existing ../libds/common/flag_mapping.h header.
...
Guenther
2011-03-02 22:17:17 +01:00
Volker Lendecke
4afda9ebf4
s3: Pass the aio_force operation through vfs_gpfs
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 2 19:24:27 CET 2011 on sn-devel-104
2011-03-02 19:24:27 +01:00
Volker Lendecke
6405e341b9
s3: Ask GPFS for the IS_OFFLINE operation
2011-03-02 18:39:21 +01:00
Volker Lendecke
73ce3e156e
s3: Announce HSM in the gpfs module
2011-03-02 18:39:21 +01:00
Volker Lendecke
cf7dac6fbc
s3: Pass smb_filename through the set_offline vfs op
2011-03-02 18:39:21 +01:00
Volker Lendecke
c9d1e16c2c
s3: Pass smb_filename through the is_offline vfs op
2011-03-02 18:39:21 +01:00
Volker Lendecke
48f6b4d6fc
s3: Fix operation names in vfs_full_audit.c
2011-03-02 18:39:21 +01:00
Volker Lendecke
dee53e04ba
s3: Print all flags in "smbclient allinfo"
2011-03-02 18:39:21 +01:00
Michael Adam
d9945e9369
s3:idmap_cache: remove an leftover wip comment
...
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Mar 2 14:55:20 CET 2011 on sn-devel-104
2011-03-02 14:55:20 +01:00
Gregor Beck
8aa69c1f81
s3: adjust loglevel for idmap_cache
...
Signed-off-by: Michael Adam <obnox@samba.org>
2011-03-02 14:10:22 +01:00
Günther Deschner
ea29261186
s3-sessionid: avoid global include of sessionid.h
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 2 12:58:12 CET 2011 on sn-devel-104
2011-03-02 12:58:12 +01:00
Günther Deschner
28acf360be
s3-lanman: talk to srvsvc dcerpc server in api_RNetSessionEnum().
...
Guenther
2011-03-02 12:12:32 +01:00
Günther Deschner
8643683dd8
s3-server_id: only include server_id where needed.
...
Guenther
2011-03-02 12:12:31 +01:00
Volker Lendecke
358f031ccf
s3: GPFS can't deal with mangled names
...
In getrealfilename, avoid calling the GPFS function
2011-03-02 10:46:11 +01:00
David Disseldorp
016a8d214a
s3-printing: vfs_connect prior to driver/dfs IO
...
samba3.posix_s3.rpc.spoolss.driver fails with the xattr_tdb vfs module
loaded as a part of make test. The (now checked) create_directory() call
in move_driver_to_download_area() fails, uncovering another bug in the
printer driver upload code path.
move_driver_to_download_area() creates a new conn_struct for
manipulating files in [print$]. The VFS layer is plumbed through with
the call to create_conn_struct(), however SMB_VFS_CONNECT() is never
called. Many vfs modules expect state stored at connect time with
SMB_VFS_HANDLE_SET_DATA() to be available on any IO operation and fail
if this is not the case.
This fix adds a call to SMB_VFS_CONNECT() in create_conn_struct() prior
to IO.
https://bugzilla.samba.org/show_bug.cgi?id=7976
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Mar 2 01:16:30 CET 2011 on sn-devel-104
2011-03-02 01:16:30 +01:00
David Disseldorp
09b4acfd81
s3-printing: clean up get_correct_cversion error paths
...
Remove an unneeded variable and simplify error paths.
2011-03-02 00:31:22 +01:00
David Disseldorp
14446b5280
s3-printing: fix move_driver_to_download_area() error paths
...
WERR_ACCESS_DENIED errors are mapped to WERR_UNKNOWN_PRINTER_DRIVER,
resulting in incorrect error messages on Windows clients.
move_driver_to_download_area() returns the same error status values
to the caller via the *perr argument as well as the return value.
The create_directory() call is not checked for error.
2011-03-02 00:31:22 +01:00
Gregor Beck
9f6193724e
s3: remove superfluous debug messages from msg_idmap
...
Signed-off-by: Michael Adam <obnox@samba.org>
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Mar 2 00:30:41 CET 2011 on sn-devel-104
2011-03-02 00:30:40 +01:00
Andrew Bartlett
04f5ef83b9
s3-auth struct security_unix_token replaces UNIX_USER_TOKEN
2011-03-01 06:29:04 +01:00
Andrew Bartlett
9900aa4fb4
s3-rpc_server Handle session key as a constant buffer
...
This way, we don't have to check for memory allocation failures.
Andrew Bartlett
2011-03-01 06:29:03 +01:00
Andrew Bartlett
5f5ca913b7
lib/util: new merged debug system
...
This is the s3 debug system, with a number of changes to tidy it up
for common use. The debug class system is simplified by the removal of the
ISSET table, the system no longer attempts to cope with assignment of
DEBUGLEVEL, and the full class table is always available (rather than
just DEBUGLEVEL_CLASS[DBCG_ALL]) from startup. It is also no longer
confusingly described as a hack, but as the initial table.
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Mar 1 04:32:12 CET 2011 on sn-devel-104
2011-03-01 04:32:12 +01:00
Andrew Bartlett
ec1009f7a0
s3-debug Always use C99 true/false rather than True and False
...
This will help with the merge into the common code.
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Mar 1 02:58:55 CET 2011 on sn-devel-104
2011-03-01 02:58:55 +01:00
Andrew Bartlett
243abcb0af
s3-build __FUNCTION__ is always available, always use it
...
This avoids duplication between FUNCTION_NAME and __FUNCTION__
2011-03-01 02:13:22 +01:00
Andrew Bartlett
608c8e7872
lib/util/time: Merge time functions from source3/lib/time.c
2011-03-01 02:13:22 +01:00
Jeremy Allison
87c4ceaf7c
Fix compiler warning on casting -1 to uint32.
2011-02-28 14:56:03 -08:00
Jelmer Vernooij
59a077d8f5
Fix some types
...
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon Feb 28 23:30:06 CET 2011 on sn-devel-104
2011-02-28 23:30:06 +01:00
Jeremy Allison
f7b4209f99
Fix one more warning introduced by changing the size of UNIX_USER_TOKEN->ngroups from size_t to uint32_t.
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Feb 28 22:43:50 CET 2011 on sn-devel-104
2011-02-28 22:43:50 +01:00
Jeremy Allison
8238357ac7
Fix warning introduced by changing the size of UNIX_USER_TOKEN->ngroups from size_t to uint32_t.
2011-02-28 21:58:20 +01:00
Günther Deschner
26321c6010
s3-torture: fix the build of rpc_open_tcp.
...
Guenther
2011-02-28 20:18:33 +01:00
Andreas Schneider
eece80e62c
s3-smbd: Pass tevent context to messaging functions.
...
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Mon Feb 28 19:00:08 CET 2011 on sn-devel-104
2011-02-28 19:00:08 +01:00
Andreas Schneider
bf18403c81
s3-rpc_client: Move client pipe functions to own header.
2011-02-28 18:15:04 +01:00
Michael Adam
e55937cfea
s3:test: fix smbclient test on older systems (usage of mktemp)
...
--tmpdir is not a valid option to mktemp on older systems
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Mon Feb 28 18:12:46 CET 2011 on sn-devel-104
2011-02-28 18:12:46 +01:00
Michael Adam
61c2bcdf20
s3:test: fix registry roundtrip test on older systems (usage of mktemp)
...
--tmpdir is not a valid option to mktemp on older systems
2011-02-28 17:27:18 +01:00
Volker Lendecke
5b26cfe143
s3: Eliminate sys_select from do_smb_resolve() -- untested
2011-02-28 16:40:20 +01:00
Volker Lendecke
b28a2e519a
s3: Eliminate sys_select from do_smb_browse() -- untested
2011-02-28 16:40:19 +01:00
Volker Lendecke
89d81b310e
s3: Eliminate sys_select_intr from smbfilter
2011-02-28 16:40:19 +01:00
Stefan Metzmacher
7eedf69bc9
s3: Remove unused receive_packet
2011-02-28 16:40:19 +01:00
Volker Lendecke
a2970dfaef
s3: Eliminate sys_select_intr from read_fd_with_timeout
2011-02-28 16:40:19 +01:00
Volker Lendecke
e6f8208358
s3: Eliminiate sys_select_intr from client.c
2011-02-28 16:40:19 +01:00
Volker Lendecke
884984ae0a
s3: Add poll_intr_one_fd
2011-02-28 16:40:19 +01:00
Volker Lendecke
81bdaafab3
s3: Eliminate sys_select from g_lock_lock
2011-02-28 16:40:19 +01:00
Volker Lendecke
0f082de561
s3: Eliminate sys_select from fd_is_readable
2011-02-28 16:40:19 +01:00
Volker Lendecke
2b0057c2cb
s3: Eliminate select from packet_fd_read_sync
2011-02-28 16:40:19 +01:00
Volker Lendecke
deb58b2e94
s3: Add poll_one_fd()
2011-02-28 16:40:19 +01:00
Volker Lendecke
cf7d331511
s3: Remove select-based s3 event backend
2011-02-28 16:40:19 +01:00
Volker Lendecke
ada2a5a245
s3: Use poll in nmbd
2011-02-28 16:40:19 +01:00
Volker Lendecke
c6c666aa07
s3: Use poll in winbind
2011-02-28 16:40:19 +01:00
Volker Lendecke
9758afd47e
s3: Use poll in smbd
2011-02-28 16:40:19 +01:00
Volker Lendecke
ea5e1c5ecb
s3: Use poll for the event loop
2011-02-28 16:40:19 +01:00
Volker Lendecke
0fc1650e09
libreplace: poll based on select
2011-02-28 16:40:19 +01:00
Volker Lendecke
5e93e3e88f
s3: Add timeval_to_msec
2011-02-28 16:40:19 +01:00
Michael Adam
9bfbf652b0
s3:msg_idmap: The solaris cc compiler does not like unnamed unions as struct members - fix the build
...
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Mon Feb 28 16:39:15 CET 2011 on sn-devel-104
2011-02-28 16:39:15 +01:00
Michael Adam
c36f93d8ce
s3: fix the waf build after adding smbd/msg_idmap.c
2011-02-28 15:54:04 +01:00
Christian Ambach
3854413c24
s3: Survive an idle child that was killed
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Feb 28 14:53:20 CET 2011 on sn-devel-104
2011-02-28 14:53:20 +01:00
Gregor Beck
58081884f7
s3: smbcontrol to notify smbd about idmap changes
...
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Mon Feb 28 14:07:23 CET 2011 on sn-devel-104
2011-02-28 14:07:23 +01:00
Gregor Beck
42a4a9cbc3
s3: add functions to remove entries from idmap cache
2011-02-28 12:58:43 +01:00
Gregor Beck
6710561c27
s3: add functions to remove entries from idmap memcache
2011-02-28 12:58:43 +01:00
Gregor Beck
01e7611050
s3: add functions to flush the idmap memcache
2011-02-28 12:58:37 +01:00
Volker Lendecke
eeeae97389
s3: Fix a typo
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Feb 27 20:14:20 CET 2011 on sn-devel-104
2011-02-27 20:14:20 +01:00
Volker Lendecke
1f0cd9cb97
s3: Fix a comment
2011-02-27 19:27:44 +01:00
Volker Lendecke
32731db56f
s3: Fix some nonempty blank lines
2011-02-27 19:27:44 +01:00
Volker Lendecke
2c9c8fa036
s3: Use strndup in parse_nss_param
2011-02-27 19:19:05 +01:00
Volker Lendecke
c427b795c7
s3: properly find our standard nss_info backends
...
Right now, the nss_info backends are tied to the idmap backends (which is wrong
IMHO). In the domain child we don't load the idmap backend anymore, so we don't
have the nss info modules. This needs fixing properly.
2011-02-27 19:11:31 +01:00
Volker Lendecke
0decc29b3a
s3: Fix a debug message
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Feb 27 16:59:19 CET 2011 on sn-devel-104
2011-02-27 16:59:19 +01:00
Volker Lendecke
fec0baacb6
s3: Make is_zero_addr take a sockaddr_storage
...
All callers had to cast this anyway
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Feb 27 11:02:53 CET 2011 on sn-devel-104
2011-02-27 11:02:53 +01:00
Volker Lendecke
48200c27ea
s3: Improve a dbg msg in aio_fork
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Feb 26 17:42:37 CET 2011 on sn-devel-104
2011-02-26 17:42:37 +01:00
Volker Lendecke
cfffd0f3a0
s3: Fix pdb_ads_enum_group_memberships args
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Feb 26 11:37:10 CET 2011 on sn-devel-104
2011-02-26 11:37:10 +01:00
Jeremy Allison
c8a242d9fc
dirfd doesn't exist in some platforms.
...
Hack that should get the buildfarm back to green.
Ensure dirfd() needs to be defined before we properly return fdopendir.
This will do until we get a proper dirfd() defined in libreplace.
From http://www.gnu.org/software/hello/manual/gnulib/dirfd.html
This function is missing on some platforms: AIX 7.1, HP-UX 11, OSF/1 5.1, Solaris 10, mingw.
Jeremy.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Feb 26 04:19:55 CET 2011 on sn-devel-104
2011-02-26 04:19:55 +01:00
Jeremy Allison
ebb2fb7efb
Removed unused code check_dos_char_slowly.
2011-02-25 17:49:26 -08:00
Volker Lendecke
242a63e95a
s3: Fix a 64-bit warning in vfs_gpfs.c
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Feb 25 14:56:51 CET 2011 on sn-devel-104
2011-02-25 14:56:51 +01:00
Jonathan Nieder
1fbb3f25e9
s3-param: Make "rlimit_max below minimum Windows limit" notification less scary
...
The fix to bug #6837 results in messages from testparm that look
like a misconfiguration even though they aren't:
rlimit_max: rlimit_max (8192) below minimum Windows limit (16384)
Apply a slight change in wording ("increasing rlimit_max to minimum
Windows limit") to make it clearer that the user has done nothing
wrong. (Similarly for sysctl_max.)
Reported-by: Miguel Medalha <miguelmedalha@sapo.pt>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Feb 25 03:56:40 CET 2011 on sn-devel-104
2011-02-25 03:56:40 +01:00
Justin Maggard
6141b6a49f
Detect Mac OS X as a separate client type.
2011-02-25 01:57:04 +01:00
Jeremy Allison
f92fad101a
Ensure we don't return an incorrect access mask.
...
From the Microsoft test suite @ Connectathon:
Test Case: TestSuite_ScenarioNo009GrantedAccessTestS0
File created with access = 0x7 (Read, Write, Delete)
Query Info on file returns 0x87 (Read, Write, Delete, Read Attributes)
Jeremy.
2011-02-25 01:57:04 +01:00
Günther Deschner
bc1312303d
s3-libads: make ndr_print_ads_auth_flags() static.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Feb 25 01:55:26 CET 2011 on sn-devel-104
2011-02-25 01:55:26 +01:00
Günther Deschner
59e45a979c
s3-vfs: make syncops_connect in modules/vfs_syncops.c static.
...
Guenther
2011-02-25 01:08:52 +01:00
Günther Deschner
313db81ad3
s3-errormap: move (unused) map_nt_error_from_wbcErr out of errormap.
...
Guenther
2011-02-25 01:08:41 +01:00
Günther Deschner
de8b373329
s3-printing: move more printing defines out of includes.h
...
Guenther
2011-02-25 01:08:26 +01:00
Jeremy Allison
ed3ae87830
Implement the SMB2 close flag SMB2_CLOSE_FLAGS_FULL_INFORMATION (and move definition to correct place).
...
Thanks to Nick Meier @ Microsoft for finding this @ Connectathon.
Jeremy.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Feb 25 00:40:52 CET 2011 on sn-devel-104
2011-02-25 00:40:52 +01:00
Jeremy Allison
2d0727bc49
Batch oplocks conflict with exclusive as well as themselves.
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Feb 24 21:44:50 CET 2011 on sn-devel-104
2011-02-24 21:44:50 +01:00
Stefan Metzmacher
1f13d512d4
s3:rpc_client: we need to pass a non-blocking socket to tstream_bsd_existing_socket()
...
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Feb 24 07:43:59 CET 2011 on sn-devel-104
2011-02-24 07:43:59 +01:00
Andrew Tridgell
11a97d60d9
build: moved util_reg.c into a common subsystem
...
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Feb 24 05:53:52 CET 2011 on sn-devel-104
2011-02-24 05:53:52 +01:00
Andrew Tridgell
74947964d9
build: moved spnego_parse.c into a common subsystem
2011-02-24 15:08:50 +11:00
Jeremy Allison
9e93dacfc6
Remember to free the second temporary string.
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Feb 24 04:17:49 CET 2011 on sn-devel-104
2011-02-24 04:17:49 +01:00
Jeremy Allison
916e82823b
Fix bug 7950 - Samba 3.5.x fails BASE-CREATEX_SHAREMODES_DIR smbtorture4 test
...
We need to revalidate the pathname once re-constructed from a root fsp.
Jeremy.
2011-02-23 18:24:41 -08:00
Andrew Tridgell
5ec284d152
build: moved librpc/rpc/*.c into a rpccommon library
...
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Feb 24 02:42:37 CET 2011 on sn-devel-104
2011-02-24 02:42:37 +01:00
Andrew Tridgell
52fe20c310
build: moved lmhosts.c into a common subsystem
...
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-02-24 11:57:48 +11:00
Andrew Tridgell
94c04b10db
build: moved libds/common/flag_mapping.c into a common subsystem
...
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-02-24 11:57:48 +11:00
Andrew Tridgell
8dbe665a0c
build: moved schannel_sign.c into a shared COMMON_SCHANNEL subsystem
...
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-02-24 11:57:48 +11:00
Andrew Tridgell
d37a55548b
build: moved libcli/auth/ntlmssp*.c into a common libcliauth.so library
...
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-02-24 11:57:48 +11:00
Günther Deschner
6b587d74d9
s3-waf: start adding checks for quota support.
...
Guenther
2011-02-23 22:33:52 +01:00
Günther Deschner
6c2c8d9f67
s3-waf: remove more unused variables.
...
Guenther
2011-02-23 22:33:52 +01:00
Günther Deschner
7f5535460a
s3-waf: rename LIBSAMBA subsystem to LIBNTLMSSP (which it is in fact).
...
Guenther
2011-02-23 22:33:52 +01:00
Günther Deschner
bf7f896d55
s3-waf: move GROUPDB into libpassdb.so.
...
Guenther
2011-02-23 22:33:52 +01:00
Christian Ambach
051611256b
s3:libsmb only log a dead connection if it was not closed
...
in case the cli was closed before (e.g. via a dropped ip message)
it can be expected that the read here returns with an error and so
we should not log that a connection is dead when it was closed before
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Feb 23 16:51:03 CET 2011 on sn-devel-104
2011-02-23 16:51:03 +01:00
Volker Lendecke
dfd33bcbb8
s3: Fix 64-bit errors
...
Casting those variables will lead to sscanf believing that it sees pointers to
unsigned longs. These might be 64 bit long, thus sscanf will overwrite memory
it should not overwrite. Assigning the vars later is okay, there we get
automatic type conversion. C can be nasty ...
Christian, please check!
2011-02-23 15:59:11 +01:00
Volker Lendecke
9671615592
s3: Fix an uninitialized variable use
...
The "goto error;" lead to the invalid talloc_free.
Christian, please check!
2011-02-23 15:59:11 +01:00
Christian Ambach
8283cdbb1f
s3:idmap:autorid prevent fatal configuration changes
...
as the autorid module relies on a stable minimum uid/gid value
and rangesize, it now saves the values used at first successful start
and refuses to work if these values get changed in smb.conf later.
Changing the values after the first mapping was done will result
in unpredictable behaviour.
Another check covers the maximum uid value. If this gets decreased
later and domain range mappings already exist that would result
in uid values higher than the new uid value, initialization will
be aborted
2011-02-23 15:59:11 +01:00
Günther Deschner
ab64634a20
s3-proto: remove some prototypes of non-existing functions.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Feb 23 15:42:35 CET 2011 on sn-devel-104
2011-02-23 15:42:35 +01:00
Volker Lendecke
148252331a
s3: Improve an error msg in vfs_gpfs
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Feb 23 14:12:39 CET 2011 on sn-devel-104
2011-02-23 14:12:39 +01:00
Stefan Metzmacher
91099d896b
s3-waf: make use of LIBCLI_CLDAP subsystem
...
metze
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Feb 23 10:17:01 CET 2011 on sn-devel-104
2011-02-23 10:17:01 +01:00
Jeremy Allison
2296871f0c
Torture test added to run_opentest() to ensure we don't regress on
...
the previous change.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Feb 23 03:00:53 CET 2011 on sn-devel-104
2011-02-23 03:00:53 +01:00
Jeremy Allison
7464793c9d
Fix bug found against the new Mac client @ Connectathon. Mac clients
...
don't open with FILE_WRITE_ATTRIBUTES when just doing a write, so updating
the write time on close fails as smb_set_file_time() now (correctly) checks
for FILE_WRITE_ATTRIBUTES in the access_mask before allowing client time
update. This is an internal time update being done on a close, not a handle-based
client request.
2011-02-23 02:17:21 +01:00