sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-27 14:04:05 +03:00
Code
84,054 Commits 60 Branches 1,146 Tags
Commit Graph

42381 Commits

Author SHA1 Message Date
Andreas Schneider
94f11e9d16 s3-net: Fix rpc_service_list_internal() null pointer passing. 
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>

Found by Coverity.

Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Wed Jan  2 14:19:50 CET 2013 on sn-devel-104
 2013-01-02 14:19:50 +01:00
Andreas Schneider
9b0c1ab07c s3-rpcclient: Fix cmd_eventlog_loginfo() null pointer passing. 
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>

Found by Coverity.
 2013-01-02 12:35:37 +01:00
Andreas Schneider
30e1dc08df s3-rpcclient: Fix cmd_eventlog_readlog() null pointer passing. 
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>

Found by Coverity.
 2013-01-02 12:35:36 +01:00
Andreas Schneider
ab14918ea4 s3-idmap: Check return value of string_to_sid(). 
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
Reviewed-by: Christian Ambach <ambi@samba.org>
 2013-01-02 12:35:36 +01:00
Stefan Metzmacher
6f31848370 Happy New Year 2013 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2013-01-01 16:11:18 +01:00
Andreas Schneider
b1548fd944 s3-prefork: Directly fail if tevent_req_is_unix_error() fails. 
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>

Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Fri Dec 21 15:38:19 CET 2012 on sn-devel-104
 2012-12-21 15:38:17 +01:00
Andreas Schneider
93d2847bf4 s3-libsmb: Remove check if array is NULL. 
rdata is an array with data. rdlength defines how big rdata is. So if
rdlength is not set we have a big problem.

Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-21 13:56:01 +01:00
Andreas Schneider
56eb4ab5f6 s3-rpc_server: Fix username and remote check. 
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-21 13:56:01 +01:00
Andreas Schneider
9c273d5ca1 s3-lib: Cleanup transfer_file_internal() a bit. 
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-21 13:56:01 +01:00
Andreas Schneider
ce25c484c1 s3-rpc_server: Make it clear we want to fall trough here. 
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-21 13:56:01 +01:00
Andreas Schneider
3f899daa9e s3-lib: Make it clear that we want to fall trough here. 
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-21 13:56:01 +01:00
Andreas Schneider
96de3e7364 s3-netapi: Add missing break in NetUserSetInfo_r(). 
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-21 13:56:01 +01:00
Andreas Schneider
f7d8aa79ff s3-libsmb: Fix a possible null pointer dereference. 
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-21 13:56:01 +01:00
Andreas Schneider
fd6041a220 s3-rpc_server: Fix null pointer derefs in rpc_pipe_open_interface(). 
Found by Coverity and asn ;)

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-21 13:56:01 +01:00
Andreas Schneider
6168d95817 s3-winbind: Fix null pointer dereference in store_memory_creds(). 
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-21 13:56:01 +01:00
Andreas Schneider
9631e5b1e4 s3-vfs: Fix a null pointer deferference in vfs_media_harmony. 
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-21 13:56:01 +01:00
Andreas Schneider
72e02c73b6 s3-rpc_server: Fix a possible null pointer dereference. 
This variable can be set to NULL in an earlier function call.

Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-21 13:56:01 +01:00
Andreas Schneider
f0454ffb69 s3-vfs: Fix typo in readonly_connect(). 
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-21 13:56:01 +01:00
Andreas Schneider
b26a9eae16 s3-rpc_server: Fix useless check if we still have a valid string. 
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-21 13:56:00 +01:00
Andreas Schneider
d0e20998a2 s3-libads: Fix copy&paste error in ads_keytab_add_entry(). 
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-21 13:56:00 +01:00
Andreas Schneider
3bd8c7dec6 s3-lib: Fix push_ucs2() for-loop. 
ret is a bool and size is what we are looking for here, else the
statement can never be true.

Jeremy please check!

Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-21 13:56:00 +01:00
Andreas Schneider
7f8c8d80ef s3-tldap: Fix dead code in tldap_sasl_bind_send(). 
dn can't be NULL cause it is set to "" in that case.

Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-21 13:56:00 +01:00
Andreas Schneider
e41f0ccdd2 s3-utils: Check return value of secrets_init(). 
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-21 13:56:00 +01:00
Andreas Schneider
15c0594fee s3-net: Check return values of push_reg_sz(). 
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-21 13:56:00 +01:00
Andreas Schneider
3000fc29c3 s3-nmbd: Check if we created the directories correctly. 
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-21 13:56:00 +01:00
Andreas Schneider
6fd4724fb9 s3-eventlog: Make sure the eventlog directory exists. 
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-21 13:55:59 +01:00
Andreas Schneider
a3bbf1bf34 s3-winbind: Check if we created the directories correctly. 
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-21 13:55:59 +01:00
Andreas Schneider
3dda917770 s3-smbd: Check return code of SMB_VFS_{L}STAT. 
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-21 13:55:59 +01:00
Jeremy Allison
2148d86c7a Fix bug #9196 - defer_open is triggered multiple times on the same request. 
get_deferred_open_message_state_smb2() is buggy in that it is checking
the wrong things to determine if an open is in the deferred state.

It checks if (smb2req->async_te == NULL) which is incorrect,
as we're not always async in a deferred open - remove this.

It should check instead state->open_was_deferred as this
is explicity set to 'true' when an open is going deferred,
so add this check.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Dec 18 14:19:13 CET 2012 on sn-devel-104
 2012-12-18 14:19:13 +01:00
Günther Deschner
be43456c94 s3-rpc_server: use netlogon_creds_encrypt_samlogon(). 
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2012-12-15 21:50:36 +01:00
Günther Deschner
563cc67ac6 libcli/auth: rename netlogon_creds_decrypt_samlogon() to netlogon_creds_decrypt_samlogon_validation(). 
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2012-12-15 21:50:36 +01:00
Andreas Schneider
74fb61d496 s3-lib: Don't close the listener twice if we goto failed. 
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-12 23:14:44 +01:00
Volker Lendecke
a44e58a31e s3: Fix a typo in a debug message 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>

Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Wed Dec 12 16:40:23 CET 2012 on sn-devel-104
 2012-12-12 16:40:23 +01:00
Andreas Schneider
880b0f18be s3-printing: Correctly create the printing cache path. 
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-12 15:00:02 +01:00
Andreas Schneider
76ac4d923d s3-registry: Fix counters_directory() dir creation. 
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-12 15:00:02 +01:00
Andreas Schneider
07385a851f s3-ctdb: Make sure addr.sun_path is null terminated. 
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-12 15:00:02 +01:00
Andreas Schneider
b4884dcff7 s3-libsmb: Fix possible comparsion problems. 
This makes the code also easier to understand.

Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-12 15:00:02 +01:00
Andreas Schneider
f670cae69d s3-utils: Correctly handle getenv() for the later system() call. 
The returned string of getenv() has an unknown size. You need to store
the result always in a char array with a certain size to make sure we
don't feed tainted data to the next function call.

Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-12 15:00:02 +01:00
Andreas Schneider
d55c6e7113 s3-utils: Cleanup code in wait_replies(). 
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-12 15:00:02 +01:00
Andreas Schneider
3bcd14c397 s3-nmbd: Cleanup code to make it more readable. 
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-12 15:00:02 +01:00
Andreas Schneider
e5deaa2968 s3-lib: Remove unsused variable from sys_get_nfs_quota(). 
testpath is the same a few lines later.

Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-12 15:00:02 +01:00
Andreas Schneider
62646b7666 winbind: Use talloc in resolve_username_to_alias(). 
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-12 15:00:02 +01:00
Andreas Schneider
d862bbd5dc winbind: Use talloc in resolve_alias_to_username(). 
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-12 15:00:02 +01:00
Günther Deschner
6a59126d59 s3-selftest: make sure to test rpc.samr.passwords.validate over ncacn_ip_tcp. 
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
 2012-12-12 11:29:33 +01:00
Günther Deschner
c9055a0be4 s3-rpc_server: limit allowed transports for samr_ValidatePassword(). 
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
 2012-12-12 11:29:33 +01:00
Andreas Schneider
f1fe877d07 s3-netapi: Initialize group_handle of NetGroupSetUsers_r(). 
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
 2012-12-12 09:42:33 +01:00
Andreas Schneider
7d20934693 s4-netapi: Initialize group_handle of NetGroupGetUsers_r(). 
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
 2012-12-12 09:42:33 +01:00
Andreas Schneider
5bc5761c06 s3-auth: Make sure we work on valid data_blobs. 
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
 2012-12-12 09:42:33 +01:00
Andreas Schneider
d020c51978 s3-netapi: Initialize group_handle of NetUserSetGroups_r. 
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
 2012-12-12 09:42:33 +01:00
Andreas Schneider
33d1d52508 s3-netapi: Fix zeroing policy handles in NetLocalGroupAdd_r(). 
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
 2012-12-12 09:42:32 +01:00