1
0
mirror of https://github.com/samba-team/samba.git synced 2025-03-09 08:58:35 +03:00

29691 Commits

Author SHA1 Message Date
Jeremy Allison
ff547a23ae Factor out common code into vfs_acl_common.c.
Jeremy.
2009-07-24 17:06:41 -07:00
Tim Prouty
cd5133b112 s3: Simplify rename_internals() by passing in smb_filename structs 2009-07-24 15:10:45 -07:00
Tim Prouty
10324b177e s3: Allow filename_convert() to pass through unix_convert_flags and let the caller know if the path has a wildcard
This also eliminates the need for resolve_dfspath().
2009-07-24 15:10:45 -07:00
Jeremy Allison
c472bca42c Make acl_tdb match acl_xattr. Large duplication of
code here needs tidying up. Compiles but not yet tested.
Jeremy.
2009-07-24 14:47:52 -07:00
Jeremy Allison
1bab4fdaaf Fix hash function in acl_xattr to be SHA256, make
the hash function selectable. Upgrade version.
Compiles but not fully tested yet (coming). Make
vfs_acl_tdb.c compile - this needs updating to
match acl_xattr (also coming soon).
Jeremy.
2009-07-24 14:09:42 -07:00
Volker Lendecke
6b801d6c4c add my copyright after the VFS rewrite 2009-07-24 13:21:45 -04:00
Volker Lendecke
d2403dc231 Move the "enum _vfs_op_type" to full_audit
It's only used there now. Someone should now go in and simplify full_audit...
:-)
2009-07-24 11:42:05 -04:00
Volker Lendecke
033185e2a1 Make the smbd VFS typesafe 2009-07-24 11:42:05 -04:00
Volker Lendecke
be5cf23696 Fix the chain2 test 2009-07-24 17:17:08 +02:00
Volker Lendecke
c116652a30 In chain_reply, copy the subrequests' error to the main request 2009-07-24 17:17:08 +02:00
Volker Lendecke
79fd60dd38 Fix a few uninitialized variable warnings
I know those warnings are bogus, but both Coverity and gcc don't get it.
2009-07-24 10:23:04 -04:00
Volker Lendecke
68028a73b6 Some more VFS type errors 2009-07-24 02:16:17 +02:00
Volker Lendecke
4b76f279d1 Fix some nonempty blank lines 2009-07-24 02:16:00 +02:00
Volker Lendecke
19245509fc Fix some C++ warnings 2009-07-24 02:15:28 +02:00
Tim Prouty
07d3b69b55 s3: Change unix_convert to use an smb_filename struct internally
This allows SMB_VFS_[L]STAT to be called directly.  Additionally, I
changed NTSTATUS result to be named status for consistency.

I also removed the stat_cache_add() from build_stream_path() because
stat_cache_lookup() is never actually called on a file with a stream.
There is no reason why the stat cache couldn't be consulted for
streams in the future.

Jeremy/Volker, please take a look at this one when you get a chance.
2009-07-22 11:48:22 -07:00
Tim Prouty
83284e13f9 s3: Convert some callers of vfs_lstat_smb_fname to SMB_VFS_LSTAT() 2009-07-22 11:48:22 -07:00
Tim Prouty
4b42927ec3 s3: Convert some callers of vfs_stat_smb_fname to SMB_VFS_STAT() 2009-07-22 09:51:17 -07:00
Kai Blin
8f5ef10633 Revert "net: Use samba default command line arguments."
This reverts commit fb262f79fab00374023e59476e8d05a1015a7041
and related commits c36031778e1983ddb11d3e1fcab35e738dbf94bc
72fd5fa6bb78a054fad5e5ebe19a0c0387a7d45b and
38cd0e086f50ce54d88a19aa5a6803469af90489

This change caused more trouble than it solved. We need to do this differently.
Reverting so we don't accidently release this.
2009-07-22 13:39:34 +02:00
Tim Prouty
605649edc3 s3: plumb smb_filename through some of the trans2 posix_* functions 2009-07-21 12:04:59 -07:00
Tim Prouty
23c703a01e s3: Remove unnecessary callers of get_full_smb_filename
This often times means explicitly denying certain operations on a stream
as they are not supported or don't make sense at a particular level.  At
some point in the future these can be enabled, but for now it's better to
remove ambiguity
2009-07-21 12:04:59 -07:00
Tim Prouty
00e267008d s3: Remove the now unused fname parameter from filename_convert() 2009-07-21 12:04:59 -07:00
Tim Prouty
4860fc4951 s3: Fix RENAME_FLAG_RENAME path to stop calling unix_convert twice 2009-07-21 12:04:59 -07:00
Tim Prouty
78ce9dd471 s3: Remove unnecessary fname argument from callers of filename_convert 2009-07-21 12:04:59 -07:00
Tim Prouty
6b49f28592 s3: Plumb smb_filename through map_open_params_to_ntcreate 2009-07-21 12:04:58 -07:00
Christian Ambach
8b6ec5b82c do not log chdir with level 0 if reason is access denied
this changes the level of logs caused by users trying to access shares
or subdirectories for which they do not have access to in the ACL

this can fill up the samba log even with log level 0 and is more an
expected kind of logs that IMHO should not be logged with such a high
level.

All other errors while chdir() will still be logged with level 0

Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
2009-07-21 10:05:21 -07:00
Michael Adam
319a97bce9 s3:dbwrap: use the transaction wrapper in dbwrap_trans_store().
Now dbwrap_util.c contains only one call to each of
transaction_start, transaction_commit and transaction_cancel.

Michael
2009-07-21 12:40:34 +02:00
Michael Adam
d5efb38151 s3:dbwrap: use the transaction wrapper in dbwrap_trans_delete().
Michael
2009-07-21 12:40:34 +02:00
Tim Prouty
8e04c69e02 s3: Add some asserts to the filename util functions
In the smb_filename struct stream_name must equal NULL if there
is no stream name.  These asserts should catch any future offenders
of this invariant early.
2009-07-20 17:26:57 -07:00
Tim Prouty
f4530f6d2a s3: Plumb smb_filename through open_fake_file 2009-07-20 17:26:57 -07:00
Tim Prouty
841efce8b5 s3: Separate out a new file: filename_utils.c
This is to ease the linking pain of everything that links LOCKING_OBJ
2009-07-20 17:26:57 -07:00
Tim Prouty
82c3f505fe s3: Move is_ntfs_stream*() to filename.c 2009-07-20 17:26:57 -07:00
Tim Prouty
c9b8a01714 s3: Finish plumbing the fsp->fsp_name smb_fname conversion through the modules. 2009-07-20 17:26:57 -07:00
Tim Prouty
5a8d70d465 s3: Change fsp->fsp_name to be an smb_filename struct! 2009-07-20 17:26:56 -07:00
Tim Prouty
635e5e7ff0 s3 onefs oplocks: Replace static fstring with talloc'd dbg_ctx() 2009-07-20 17:26:56 -07:00
Tim Prouty
12a5db45e2 s3: Change file_structs to be allocated with talloc instead of malloc 2009-07-20 17:26:56 -07:00
Jeremy Allison
9357049171 Make cli_send_mailslot() static. Preparing to do away with unexpected.tdb....
Jeremy.
2009-07-20 15:15:08 -07:00
Volker Lendecke
ce378e7c51 Fix a few type errors in VFS modules 2009-07-19 02:36:59 +02:00
Jeremy Allison
0259a303f4 Fix Coverity CIDs 887, 888. Don't pass NULL's to functions
that deref them.
Jeremy.
2009-07-17 21:50:33 -07:00
Jeremy Allison
0bd13fda76 Fix Coverity CID 928. Removed check as this can never be null.
Jeremy.
2009-07-17 21:40:23 -07:00
Jeremy Allison
3036a9c7c1 Fix Coverity CID 929. Potential NULL deref after code refactoring.
Jeremy.
2009-07-17 21:36:55 -07:00
Jeremy Allison
d654782806 Fix coverity CID 930. Pointer check can never be null here.
Jeremy
2009-07-17 21:29:28 -07:00
Jeremy Allison
7254898bc7 Fix coverity CID 931. This check is redundent as smb_fname can
never be null in this function.
Jeremy.
2009-07-17 21:26:16 -07:00
Jeremy Allison
eba2eb45e2 Fix a typo reading uninitialized memory. Caught by valgrind.
Jeremy.
2009-07-17 18:05:10 -07:00
Jeremy Allison
55b4231c77 Move the initialization of smbd_server_conn from smbd/process,
after the accept and fork, to smbd_init_globals(), so it's
done immediately on server startup. This is needed as some
messages are sent to all active smbd processes (including
the master listening daemon). If it gets a message that
forces it to scan it's current connections (ie. conn_find())
then it discovers that sconn->smb1.tcons.Connections dereferences
null (as sconn == NULL in the parent) and crashes. Yes,
I could fix all cases where sconn is used and explicitly
check for NULL but this fix is easier. It means that
the smbd_event_context() is initialized in the master
daemon and then re-initialized after fork, but that
should be being done correctly in every fork call anyway.
Without this change the previous fix 6a9e0039100b57f9626e87defec6720c476b9789
still panics in the reproducible test case for bug
6564, as this is one case where such a message
(MSG_SMB_CONF_UPDATED) is sent to the parent. Metze
please check. This change passes valgrind.
Jeremy.
2009-07-17 17:57:48 -07:00
Jeremy Allison
6a9e003910 Fix bug #6564 - SetPrinter fails (panics) as non root.
Missing become_root()/unbecome_root() around reload_services.
Jeremy.
2009-07-17 17:36:26 -07:00
Günther Deschner
ffbcf3b491 s3-rpcclient: add createprinteric command.
Guenther
2009-07-17 15:40:18 +02:00
Günther Deschner
3e661d4c8e s3-lsa: let _lsa_Delete return NT_STATUS_NOT_SUPPORTED as w2k3 does.
Guenther
2009-07-17 13:55:29 +02:00
Günther Deschner
2a26b2ac87 s3-lsa: Fix access_mask calculation for new handle in _lsa_CreateAccount().
Guenther
2009-07-17 13:50:34 +02:00
Günther Deschner
3eea254e5b s3-lsa: add (not yet activate) level specific access checks for _lsa_QueryInfoPolicy.
Guenther
2009-07-17 13:50:34 +02:00
Günther Deschner
864e809752 s3-lsa: also implement level 13 in lsa_QueryInfoPolicy.
Guenther
2009-07-17 13:50:34 +02:00