1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-31 17:18:04 +03:00
samba-mirror/selftest
Andrew Bartlett 004e7a1fee s4/rpc_server/dnsserver: Allow parsing of dnsProperty to fail gracefully
On (eg) the

DC=_msdcs.X.Y,CN=MicrosoftDNS,DC=ForestDnsZones,DC=X,DC=Y

record, in domains that have had a Microsoft Windows DC an attribute:

dNSProperty:: AAAAAAAAAAAAAAAAAQAAAJIAAAAAAAAA

000000 00 00 00 00 00 00 00 00 00 00 00 00 01 00 00 00  >................<
000010 92 00 00 00 00 00 00 00                          >........<
000018

We, until samba 4.12, would parse this as:

pull returned Success
    dnsp_DnsProperty: struct dnsp_DnsProperty
        wDataLength              : 0x00000000 (0)
        namelength               : 0x00000000 (0)
        flag                     : 0x00000000 (0)
        version                  : 0x00000001 (1)
        id                       : DSPROPERTY_ZONE_NS_SERVERS_DA (146)
        data                     : union dnsPropertyData(case 0)
        name                     : 0x00000000 (0)
dump OK

However, the wDataLength is 0.  There is not anything in
[MS-DNSP] 2.3.2.1 dnsProperty to describe any special behaviour
for when the id suggests that there is a value, but wDataLength is 0.

https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-dnsp/445c7843-e4a1-4222-8c0f-630c230a4c80

We now fail to parse it, because we expect an entry with id DSPROPERTY_ZONE_NS_SERVERS_DA
to therefore have a valid DNS_ADDR_ARRAY (section 2.2.3.2.3).

As context we changed it in our commit fee5c6a424
because of bug https://bugzilla.samba.org/show_bug.cgi?id=14206
which was due to the artificial environment of the fuzzer.

Microsoft advises that Windows also fails to parse this, but
instead of failing the operation, the value is ignored.

Reported by Alex MacCuish.  Many thanks for your assistance in
tracking down the issue.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14310

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri May 15 07:29:17 UTC 2020 on sn-devel-184
2020-05-15 07:29:16 +00:00
..
flapping.d selftest: add two more nbt.dgram flapping tests 2020-04-06 10:43:18 +00:00
gnupg selftest:gnupg: add a gpg key for Samba Selftest <selftest@samba.example.com> 2016-07-22 16:03:27 +02:00
knownfail.d s4/rpc_server/dnsserver: Allow parsing of dnsProperty to fail gracefully 2020-05-15 07:29:16 +00:00
manage-ca selftest/manage-ca: Add certificiate etc. for DC addcsmb1 2020-04-03 15:08:26 +00:00
ns selftest: use 10.53.57.0/8 instead of 127.0.0.1/8 2020-03-27 09:02:38 +00:00
target s3: selftest: Add share definition [bad_iconv] in fileserver. 2020-05-12 19:53:46 +00:00
checkpassword_arg1.sh selftest: require SAMBA_CPS_ACCOUNT_NAME in checkpassword_arg1.sh 2019-02-11 07:43:32 +01:00
create_smb1_fail_skipfile.txt selftest: Create instructions for generating skip file entries 2020-04-03 15:08:33 +00:00
devel_env.sh selftest: Add a bash env file you can source. 2014-04-17 14:56:05 +02:00
filter-subunit selftest/filter-subunit: use py3 print 2019-03-12 00:42:18 +00:00
flapping s3/selftest: Move tests raw.samba3hide, raw.samba3checkfsp & raw.samba3closeerr 2020-04-03 15:08:32 +00:00
format-subunit PY3: change shebang to python3 in misc dirs 2018-12-14 18:00:40 +01:00
format-subunit-json selftest/format-subunit-json: remove useless py2 print 2019-03-12 00:42:18 +00:00
gdb_backtrace selftest/gdb_*: make use of 'mktemp' 2016-12-01 05:54:21 +01:00
gdb_backtrace_test.c
gdb_run selftest/gdb_*: make use of 'mktemp' 2016-12-01 05:54:21 +01:00
in_screen testenv: No "mktemp" for in_screen 2020-01-21 14:38:44 +00:00
knownfail selftest: split a knownfail entry 2020-05-12 18:15:30 +00:00
knownfail_mit_krb5_pre_1_18 Fix uxsuccess test with new MIT krb5 library 1.18 2020-03-10 13:02:27 +00:00
no-python-tests.txt selftest: Add basic sanity-check tests for nopython target 2019-02-20 02:10:00 +01:00
perf_tests.py perf-tests: rename paged search test for regex disambiguation 2019-04-05 04:41:25 +00:00
quick
README Remove documentation for testsuite-count subunit extension, which is no longer used. 2015-02-17 15:41:10 +01:00
save.env.sh selftest: add save.env.sh helper script. 2016-06-27 05:00:15 +02:00
selftest.pl selftest: use 10.53.57.0/8 instead of 127.0.0.1/8 2020-03-27 09:02:38 +00:00
selftest.pl.1
selftesthelpers.py libsmbclient: Put it back to a known, well-working state 2020-03-10 21:25:33 +00:00
skip s4:torture: Convert samba3.raw.mkdir test to smb2 2020-04-28 19:46:32 +00:00
skip_mit_kdc prefork tests: re-enable restart tests for MIT Kerberos 2019-07-16 10:10:23 +00:00
skip.no-GSS_KRB5_CRED_NO_CI_FLAGS_X script/autobuild.py: try make test TESTS=samba3.*ktest for samba-systemkrb5 2017-01-10 13:54:17 +01:00
slow
slow-none selftest: Avoid running the slowest of the "none" tests in samba-o3 2020-05-15 06:05:30 +00:00
SocketWrapper.pm selftest: enable perl warnings 2020-02-04 05:13:39 +00:00
Subunit.pm selftest: enable perl warnings 2020-02-04 05:13:39 +00:00
subunithelper.py PY3: Only decode when necessary 2018-10-23 05:50:25 +02:00
tap2subunit Add basic tap2subunit converter, rather than relying on the one from subunit-tools. 2015-03-06 04:41:47 +01:00
tests.py lib:util: Add test to verify old and new macros are the same 2020-02-21 02:09:33 +00:00
TODO
todo_smb2_tests_to_port.list s4:torture: Convert samba3.raw.mkdir test to smb2 2020-04-28 19:46:32 +00:00
ubsan.supp selftest: enable undefined behaviour sanitizer 2019-05-14 07:20:28 +00:00
valgrind_run selftest: set valgrind options 2013-12-11 17:14:21 +01:00
wscript selftest: Don't skip smb1 tests and remove associate skip file 2020-04-03 15:08:33 +00:00

# vim: ft=rst

This directory contains test scripts that are useful for running a
bunch of tests all at once.

There are two parts to this:

 * The test runner (selftest/selftest.pl)
 * The test formatter

selftest.pl simply outputs subunit, which can then be formatted or analyzed
by tools that understand the subunit protocol. One of these tools is
format-subunit, which is used by default as part of "make test".

Available testsuites
====================
The available testsuites are obtained from a script, usually
source{3,4}/selftest/tests.py. This script should for each testsuite output
the name of the test, the command to run and the environment that should be
provided. Use the included "plantest" function to generate the required output.

Testsuite behaviour
===================

Exit code
------------
The testsuites should exit with a non-zero exit code if at least one
test failed. Skipped tests should not influence the exit code.

Output format
-------------
Testsuites can simply use the exit code to indicate whether all of their
tests have succeeded or one or more have failed. It is also possible to
provide more granular information using the Subunit protocol.

This protocol works by writing simple messages to standard output. Any
messages that can not be interpreted by this protocol are considered comments
for the last announced test.

For a full description of the subunit protocol, see the README file in the subunit
repository at http://github.com/testing-cabal/subunit.

The following commands are Samba extensions to Subunit:

start-testsuite
~~~~~~~~~~~~~~~
start-testsuite: name

The testsuite name is used as prefix for all containing tests.

skip-testsuite
~~~~~~~~~~~~~~
skip-testsuite: name

Mark the testsuite with the specified name as skipped.

testsuite-success
~~~~~~~~~~~~~~~~~
testsuite-success: name

Indicate that the testsuite has succeeded successfully.

testsuite-fail
~~~~~~~~~~~~~~
testsuite-fail: name

Indicate that a testsuite has failed.

Environments
============
Tests often need to run against a server with particular things set up,
a "environment". This environment is provided by the test "target": Samba 3,
Samba 4 or Windows.

The environments are currently available include

 - none: No server set up, no variables set.
 - dc,s3dc: Domain controller set up. The following environment variables will
   be set:

     * USERNAME: Administrator user name
     * PASSWORD: Administrator password
     * DOMAIN: Domain name
     * REALM: Realm name
     * SERVER: DC host name
     * SERVER_IP: DC IPv4 address
     * SERVER_IPV6: DC IPv6 address
     * NETBIOSNAME: DC NetBIOS name
     * NETIOSALIAS: DC NetBIOS alias

 - member,s4member,s3member: Domain controller and member server that is joined to it set up. The
   following environment variables will be set:

     * USERNAME: Domain administrator user name
     * PASSWORD: Domain administrator password
     * DOMAIN: Domain name
     * REALM: Realm name
     * SERVER: Name of the member server

See Samba.pm, Samba3.pm and Samba4.pm for the full list.

Running tests
=============

To run all the tests use::

   make test

To run a quicker subset run::

   make quicktest

To run a specific test, use this syntax::

   make test TESTS=testname

for example::

   make test TESTS=samba4.BASE-DELETE