1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
samba-mirror/source3/winbindd/winbindd_sid_to_uid.c
Michael Adam 7637c93472 s3:winbindd: use wb_sids2xids instead of wb_sid2uid in winbindd_sid_to_uid
The main purpose of the change is to hand the sid into the
idmap backend and handle responsiblity for handling the
sid-type correctly to the idmap backend instead of failing
directly when the sid is not of type user.

Hence backends like rid who are sid-type agnostic, can
return uids also for sids of other types. This is an important
fix to make sid_to_uid behave the consistently with and without
the presence of cache entries.

We need to additionally filter the result for id type UID
or more general (BOTH) to keep the behaviour.

This is a step towards using only one codepath to id_mapping.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
2012-12-03 08:48:21 +01:00

110 lines
3.2 KiB
C

/*
Unix SMB/CIFS implementation.
async implementation of WINBINDD_SID_TO_UID
Copyright (C) Volker Lendecke 2009
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#include "includes.h"
#include "winbindd.h"
#include "../libcli/security/security.h"
struct winbindd_sid_to_uid_state {
struct dom_sid sid;
uid_t uid;
};
static void winbindd_sid_to_uid_done(struct tevent_req *subreq);
struct tevent_req *winbindd_sid_to_uid_send(TALLOC_CTX *mem_ctx,
struct tevent_context *ev,
struct winbindd_cli_state *cli,
struct winbindd_request *request)
{
struct tevent_req *req, *subreq;
struct winbindd_sid_to_uid_state *state;
req = tevent_req_create(mem_ctx, &state,
struct winbindd_sid_to_uid_state);
if (req == NULL) {
return NULL;
}
/* Ensure null termination */
request->data.sid[sizeof(request->data.sid)-1]='\0';
DEBUG(3, ("sid to uid %s\n", request->data.sid));
if (!string_to_sid(&state->sid, request->data.sid)) {
DEBUG(1, ("Could not get convert sid %s from string\n",
request->data.sid));
tevent_req_nterror(req, NT_STATUS_INVALID_PARAMETER);
return tevent_req_post(req, ev);
}
subreq = wb_sids2xids_send(state, ev, &state->sid, 1);
if (tevent_req_nomem(subreq, req)) {
return tevent_req_post(req, ev);
}
tevent_req_set_callback(subreq, winbindd_sid_to_uid_done, req);
return req;
}
static void winbindd_sid_to_uid_done(struct tevent_req *subreq)
{
struct tevent_req *req = tevent_req_callback_data(
subreq, struct tevent_req);
struct winbindd_sid_to_uid_state *state = tevent_req_data(
req, struct winbindd_sid_to_uid_state);
NTSTATUS status;
struct unixid xid;
status = wb_sids2xids_recv(subreq, &xid);
TALLOC_FREE(subreq);
if (tevent_req_nterror(req, status)) {
return;
}
/*
* We are filtering further down in sids2xids, but that filtering
* depends on the actual type of the sid handed in (as determined
* by lookupsids). Here we need to filter for the type of object
* actually requested, in this case uid.
*/
if (!(xid.type == ID_TYPE_UID || xid.type == ID_TYPE_BOTH)) {
tevent_req_nterror(req, NT_STATUS_NONE_MAPPED);
return;
}
state->uid = (uid_t)xid.id;
tevent_req_done(req);
}
NTSTATUS winbindd_sid_to_uid_recv(struct tevent_req *req,
struct winbindd_response *response)
{
struct winbindd_sid_to_uid_state *state = tevent_req_data(
req, struct winbindd_sid_to_uid_state);
NTSTATUS status;
if (tevent_req_is_nterror(req, &status)) {
DEBUG(5, ("Could not convert sid %s: %s\n",
sid_string_dbg(&state->sid), nt_errstr(status)));
return status;
}
response->data.uid = state->uid;
return NT_STATUS_OK;
}