sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-04 17:47:26 +03:00
Code
samba-mirror/source3/utils
History
Andreas Schneider ef8c8ac54c s3:utils: Fix stack smashing in net offlinejoin 
Cast from 'uint32_t *' (aka 'unsigned int *') to 'size_t *' (aka
'unsigned long *') increases required alignment from 4 to 8

==10343==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7ffdc6784fc0 at pc 0x7f339f1ea500 bp 0x7ffdc6784ed0 sp 0x7ffdc6784ec8
WRITE of size 8 at 0x7ffdc6784fc0 thread T0
    #0 0x7f339f1ea4ff in fd_load ../../lib/util/util_file.c:220
    #1 0x7f339f1ea5a4 in file_load ../../lib/util/util_file.c:245
    #2 0x56363209a596 in net_offlinejoin_requestodj ../../source3/utils/net_offlinejoin.c:267
    #3 0x56363209a9d0 in net_offlinejoin ../../source3/utils/net_offlinejoin.c:74
    #4 0x56363208f61c in net_run_function ../../source3/utils/net_util.c:453
    #5 0x563631fe8a9f in main ../../source3/utils/net.c:1358
    #6 0x7f339b22c5af in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
    #7 0x7f339b22c678 in __libc_start_main_impl ../csu/libc-start.c:381
    #8 0x563631faf374 in _start ../sysdeps/x86_64/start.S:115

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15257

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Dec  5 12:05:24 UTC 2022 on sn-devel-184
2022-12-05 12:05:24 +00:00
..
async-tracker.c
s3/async-tracker: don't ignore unknown options
2021-09-10 15:10:30 +00:00
clirap2.c
lib: Move push_skip_string() to clirap2.c
2020-05-05 11:48:39 +00:00
clirap2.h
libsmb: Move clirap2.c to utils/
2020-04-18 04:12:48 +00:00
conn_tdb.c
conn_tdb: change type of connections_data.start to NTTIME
2022-08-08 12:56:28 +00:00
conn_tdb.h
conn_tdb: change type of connections_data.start to NTTIME
2022-08-08 12:56:28 +00:00
dbwrap_tool.c
s3:utils: Migrate dbwrap_tool to new cmdline option parser
2021-05-25 00:23:37 +00:00
dbwrap_torture.c
s3:utils: Migrate dbwrap_torture to new cmdline option parser
2021-05-25 00:23:37 +00:00
destroy_netlogon_creds_cli.c
s3:utils: Remove unused header and deps from destroy_netlogon_creds_cli
2021-01-13 20:28:34 +00:00
eventlogadm.c
s3: safe_string: do not include string_wrappers.h
2020-08-28 00:56:34 +00:00
interact.c
…
interact.h
…
log2pcaphex.c
log2pcaphex: don't ignore unknown options
2021-09-10 15:10:30 +00:00
mdsearch.c
s3/utils: Add missing poptFreeContext
2022-10-14 12:37:29 +00:00
mvxattr.c
mvxattr: don't ignore unknown options
2021-09-10 15:10:30 +00:00
net_ads_gpo.c
s3:libads: Allocate ADS_STRUCT under a talloc context
2022-06-27 15:50:30 +00:00
net_ads_join_dns.c
s3:libads: Allocate ads->auth.user_name under ADS_STRUCT talloc context
2022-06-27 15:50:30 +00:00
net_ads.c
s3:util: add 'net ads keytab delete'
2022-10-27 21:14:43 +00:00
net_afs.c
s3:afs: Zero memory for afs_keyfile
2022-08-26 07:59:32 +00:00
net_afs.h
…
net_cache.c
gencache: Remove transaction-based tdb
2018-11-06 18:57:26 +01:00
net_conf_util.c
net conf: fix error message
2016-11-23 13:00:21 +01:00
net_conf_util.h
…
net_conf.c
s3:util:net_conf - allow empty path for [homes]
2020-09-24 21:41:12 +00:00
net_dns.c
build: Consolidate --with-dnsupdate with --with-ads (which implied HAVE_KRB5)
2021-03-26 04:06:41 +00:00
net_dns.h
build: Consolidate --with-dnsupdate with --with-ads (which implied HAVE_KRB5)
2021-03-26 04:06:41 +00:00
net_dom.c
s3:utils: Use connection and credentials parser in net util
2021-05-28 02:55:31 +00:00
net_eventlog.c
…
net_file.c
…
net_g_lock.c
s3:g_lock: add callback function to g_lock_lock()
2022-09-20 00:34:35 +00:00
net_group.c
…
net_groupmap.c
s3-utils: Fix typo in error message in net groupmap
2022-10-21 03:57:33 +00:00
net_help_common.c
lib/cmdline: restore s3 option name --max-protocol for MAXPROTOCOL from 4.14
2021-09-10 15:10:30 +00:00
net_help_common.h
…
net_help.c
…
net_idmap_check.c
…
net_idmap_check.h
…
net_idmap.c
lib: relicense smb_strtoul(l) under LGPLv3
2020-08-03 22:21:02 +00:00
net_join.c
…
net_lookup.c
net: Use dns_rr_srv->ss_s in "net lookup ldap"
2020-12-11 18:29:32 +00:00
net_notify.c
lib: Add lib/util/server_id.h
2017-01-22 18:30:11 +01:00
net_offlinejoin.c
s3:utils: Fix stack smashing in net offlinejoin
2022-12-05 12:05:24 +00:00
net_printing.c
Fix spelling s/formated/formatted/
2018-05-12 02:09:26 +02:00
net_proto.h
s3:net: Pass a talloc context to ads_startup()
2022-06-27 15:50:30 +00:00
net_rap.c
libsmb: Move clirap2.c to utils/
2020-04-18 04:12:48 +00:00
net_registry_check.c
net: Align a few integer types
2022-01-18 20:22:38 +00:00
net_registry_check.h
…
net_registry_util.c
werror: replace WERR_INVALID_PARAM with WERR_INVALID_PARAMETER in source3/utils/
2016-09-28 00:04:23 +02:00
net_registry_util.h
…
net_registry.c
s3:g_lock: add callback function to g_lock_lock()
2022-09-20 00:34:35 +00:00
net_rpc_audit.c
…
net_rpc_conf.c
net: Return share name in correct case from net rpc conf showshare
2019-05-23 23:26:14 +00:00
net_rpc_printer.c
printing: move archi_table declarations into nt_printing.h
2020-10-17 09:22:31 +00:00
net_rpc_registry.c
lib: relicense smb_strtoul(l) under LGPLv3
2020-08-03 22:21:02 +00:00
net_rpc_rights.c
net: Align some integer types
2021-08-06 17:22:30 +00:00
net_rpc_samsync.c
net: Use dom_sid_str_buf
2018-12-20 23:40:23 +01:00
net_rpc_service.c
s3: safe_string: do not include string_wrappers.h
2020-08-28 00:56:34 +00:00
net_rpc_sh_acct.c
…
net_rpc_shell.c
s3:utils: Use connection and credentials parser in net util
2021-05-28 02:55:31 +00:00
net_rpc_trust.c
s3:net: always set ctx->opt_user_specified = true when we overwrite opt_user_name
2020-05-28 06:43:37 +00:00
net_rpc.c
net: use correct printf format, fi3_id is an uint32_t
2022-11-24 16:39:12 +00:00
net_sam.c
s3:passdb: Zero password in fetch_ldap_pw() callers
2022-08-26 07:59:32 +00:00
net_serverid.c
smbd: Give smbXsrv_open.c its own header file
2021-11-11 19:08:37 +00:00
net_share.c
net rpc share allowedusers: Allow restricting shares
2018-11-30 03:35:13 +01:00
net_status.c
conn_tdb: change type of connections_data.start to NTTIME
2022-08-08 12:56:28 +00:00
net_tdb.c
net_tdb: Use share_mode_data_dump()
2020-11-10 19:49:35 +00:00
net_time.c
s3/utils: net time always hardcoded to use SMB1
2019-12-05 17:14:46 +00:00
net_user.c
…
net_usershare.c
s3:utils remove documentation of -l as alias for --long
2022-08-17 07:14:21 +00:00
net_util.c
s3:utils: Use connection and credentials parser in net util
2021-05-28 02:55:31 +00:00
net_vfs.c
Revert "vfs: remove dirfsp arg from SMB_VFS_CREATE_FILE()"
2022-04-28 13:12:33 +00:00
net.c
s3:net: Zero password in secrets_fetch_ipc_userpass() callers
2022-08-26 07:59:32 +00:00
net.h
s3:utils: Add cli_credentials and loadparm_context to net_context
2021-05-28 02:55:31 +00:00
netlookup.c
s3:libsmb: Remove signing_state from cli_full_connection_creds()
2020-08-19 16:22:42 +00:00
nmblookup.c
nmblookup: don't ignore unknown options
2021-09-10 15:10:30 +00:00
ntlm_auth_diagnostics.c
ntlm_auth: Adapt --diagnostics mode to expect that the DC does not support LANMAN by default
2022-03-17 01:57:38 +00:00
ntlm_auth_proto.h
ntlm_auth: Adapt --diagnostics mode to expect that the DC does not support LANMAN by default
2022-03-17 01:57:38 +00:00
ntlm_auth.c
s3:utils: Fix old-style function definition
2022-10-27 18:18:36 +00:00
ntlm_auth.h
…
passwd_proto.h
lib: Make stdin_new_passwd() static
2019-12-02 21:23:34 +00:00
passwd_util.c
lib: Remove duplicate get_pass() prototypes
2019-12-02 21:23:34 +00:00
pdbedit.c
s3/utils: Check return of talloc_strdup
2022-10-17 18:46:29 +00:00
profiles.c
profiles: don't ignore unknown options
2021-09-10 15:10:30 +00:00
py_net.c
s3/util/py_net.c: fix samba-tool domain join&leave segfault
2022-05-25 06:19:32 +00:00
py_net.h
s3: Add s3 net python bindings
2021-04-21 20:51:31 +00:00
regedit_dialog.c
lib: relicense smb_strtoul(l) under LGPLv3
2020-08-03 22:21:02 +00:00
regedit_dialog.h
…
regedit_hexedit.c
s3:utils: Fix format error
2021-10-04 10:43:37 +00:00
regedit_hexedit.h
…
regedit_list.c
werror: replace WERR_NOMEM with WERR_NOT_ENOUGH_MEMORY in source3/utils/
2016-09-28 00:04:19 +02:00
regedit_list.h
…
regedit_samba3.c
werror: replace WERR_NOMEM with WERR_NOT_ENOUGH_MEMORY in source3/utils/
2016-09-28 00:04:19 +02:00
regedit_treeview.c
werror: replace WERR_NOMEM with WERR_NOT_ENOUGH_MEMORY in source3/utils/
2016-09-28 00:04:19 +02:00
regedit_treeview.h
…
regedit_valuelist.c
werror: replace WERR_NOMEM with WERR_NOT_ENOUGH_MEMORY in source3/utils/
2016-09-28 00:04:19 +02:00
regedit_valuelist.h
…
regedit_wrap.c
…
regedit.c
regedit: don't ignore unknown options
2021-09-10 15:10:30 +00:00
regedit.h
…
sharesec.c
sharesec: don't ignore unknown options
2021-09-10 15:10:30 +00:00
smbcacls.c
s3: smbcacls: Now cli_resolve_path() and cli_list() can handle DFS names we no longer need local_cli_resolve_path().
2022-09-15 18:43:32 +00:00
smbcontrol.c
smbcontrol: Add rpc-dump-status
2021-12-10 14:02:30 +00:00
smbcquotas.c
smbcquotas: don't ignore unknown options
2021-09-10 15:10:30 +00:00
smbfilter.c
lib: Properly return errno from open_socket_in()
2021-03-19 07:09:37 +00:00
smbget.c
smbget: Adds a rate limiting option --limit-rate in KB/s
2022-11-02 22:47:10 +00:00
smbpasswd.c
lib: Remove init_names()
2021-03-16 17:09:32 +00:00
smbtree.c
smbtree: don't ignore unknown options
2021-09-10 15:10:30 +00:00
split_tokens.c
split_tokens: don't ignore unknown options
2021-09-10 15:10:30 +00:00
status_json_dummy.c
smbstatus: add a method to add profile items to json
2022-08-08 12:56:29 +00:00
status_json.c
s3:utils: Fix NULL check
2022-08-12 21:50:23 +00:00
status_json.h
smbstatus: add a method to add profile items to json
2022-08-08 12:56:29 +00:00
status_profile_dummy.c
smbstatus: add JSON support for smbstatus --profile
2022-08-08 12:56:29 +00:00
status_profile.c
smbstatus: add JSON support for smbstatus --profile
2022-08-08 12:56:29 +00:00
status_profile.h
smbstatus: add JSON support for smbstatus --profile
2022-08-08 12:56:29 +00:00
status.c
smbstatus: add JSON support for smbstatus --profile
2022-08-08 12:56:29 +00:00
status.h
smbstatus: add json items to traverse_struct
2022-08-08 12:56:28 +00:00
testparm.c
s3/utils: check result of talloc_strdup
2022-10-17 19:49:36 +00:00
wscript_build
smbstatus: add frame files for json specific methods
2022-08-08 12:56:28 +00:00