1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-05 09:18:06 +03:00
samba-mirror/source4/torture/libnetapi/libnetapi.c
Samuel Cabrero 8cdb4f2985 netapi: Pass net's cmdline credentials to libnetapi_net_init()
Avoid unnecessary credentials allocation and initialization by passing the
net's cmdline creds to libnetapi_net_init() directly.

Fixes the problem of running cli_credentials_guess() (which runs password
callbacks) twice, one for the net's cmdline creds and a second time for the
creds initialized in libnetapi_net_init(), just to override them immediately
after.

Example:

$ export PASSWD_FD=0
$ ./bin/net offlinejoin composeodj <...>
foo
bar

Password is read from STDIN twice.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2023-09-11 02:42:41 +00:00

95 lines
2.8 KiB
C

/*
Unix SMB/CIFS implementation.
SMB torture tester
Copyright (C) Guenther Deschner 2009
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#include "source3/include/includes.h"
#include "torture/smbtorture.h"
#include "auth/credentials/credentials.h"
#include "lib/cmdline/cmdline.h"
#include "source3/lib/netapi/netapi.h"
#include "source3/lib/netapi/netapi_private.h"
#include "lib/param/param.h"
#include "torture/libnetapi/proto.h"
bool torture_libnetapi_init_context(struct torture_context *tctx,
struct libnetapi_ctx **ctx_p)
{
NET_API_STATUS status;
struct libnetapi_ctx *ctx;
TALLOC_CTX *frame = talloc_stackframe();
struct cli_credentials *creds = samba_cmdline_get_creds();
if (!lp_load_global(lpcfg_configfile(tctx->lp_ctx))) {
fprintf(stderr, "error loading %s\n", lpcfg_configfile(tctx->lp_ctx));
talloc_free(frame);
return W_ERROR_V(WERR_GEN_FAILURE);
}
load_interfaces();
status = libnetapi_net_init(&ctx, tctx->lp_ctx, creds);
if (status != 0) {
talloc_free(frame);
return false;
}
*ctx_p = ctx;
talloc_free(frame);
return true;
}
static bool torture_libnetapi_initialize(struct torture_context *tctx)
{
NET_API_STATUS status;
struct libnetapi_ctx *ctx;
/* We must do this first, as otherwise we fail if we don't
* have an smb.conf in the default path (we need to use the
* torture smb.conf */
torture_assert(tctx, torture_libnetapi_init_context(tctx, &ctx),
"failed to initialize libnetapi");
status = libnetapi_init(&ctx);
torture_assert(tctx, ctx != NULL, "Failed to get a libnetapi_ctx");
torture_assert_int_equal(tctx, status, 0, "libnetapi_init failed despite already being set up");
libnetapi_free(ctx);
return true;
}
NTSTATUS torture_libnetapi_init(TALLOC_CTX *ctx)
{
struct torture_suite *suite;
suite = torture_suite_create(ctx, "netapi");
torture_suite_add_simple_test(suite, "server", torture_libnetapi_server);
torture_suite_add_simple_test(suite, "group", torture_libnetapi_group);
torture_suite_add_simple_test(suite, "user", torture_libnetapi_user);
torture_suite_add_simple_test(suite, "initialize", torture_libnetapi_initialize);
suite->description = talloc_strdup(suite, "libnetapi convenience interface tests");
torture_register_suite(ctx, suite);
return NT_STATUS_OK;
}