Nathaniel W. Turner f55a357c6b dsgetdcname: do not assume local system uses IPv4 ... Return the first IPv4 and the first IPv6 address found for each DC. This is slightly inelegant, but resolves an issue where IPv6-only systems were unable to run "net ads join" against domain controllers that have both A and AAAA records in DNS. While this impacts performance due to the additional LDAP ping attempts, in practice an attempt to connect to an IPv6 address on an IPv4-only system (or vice versa) will fail immediately with NT_STATUS_NETWORK_UNREACHABLE, and thus the performance impact should be negligible. The alternative approach, using an smb.conf setting to control whether the logic prefers a single address of one family or the other ends up being a bit awkward, as it pushes the problem onto admins and tools such as "realm join" that want to dynamically synthesize an smb.conf on the fly. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15325 Signed-off-by: Nathaniel W. Turner <nturner@exagrid.com> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: David Mulder <dmulder@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Mar 9 19:12:15 UTC 2023 on atb-devel-224		2023-03-09 19:12:15 +00:00
..
ABI	s3:libsmb: Use cli_credentials_set_smb_encryption()	2020-08-19 16:22:42 +00:00
async_smb.c
auth_generic.c	s3:libsmb: Check return code of cli_credentials_guess()	2021-06-29 02:19:35 +00:00
cli_smb2_fnum.c	lib: Remove idtree from samba_util.h	2023-01-10 00:28:37 +00:00
cli_smb2_fnum.h	libsmb: Allow listing with posix context	2022-11-29 10:26:37 +00:00
cliconnect.c	s3/libsmb: fix a typo in parameter description	2023-01-17 17:21:38 +00:00
clidfs.c	s3: libsmb: Fix cli_resolve_path() to cope with DFS paths passed in as well as local paths.	2022-09-15 18:43:32 +00:00
clidgram.c	s3: safe_string: do not include string_wrappers.h	2020-08-28 00:56:34 +00:00
clidgram.h
clientgen.c	s3: libsmb: Make cli_state_save_tcon()/cli_state_restore_tcon() static.	2022-09-15 18:43:32 +00:00
clierror.c	libcli: Remove NT_STATUS_INACCESSIBLE_SYSTEM_SHORTCUT error code	2021-11-11 19:08:37 +00:00
clifile.c	libsmb: Convert cli_posix_stat_send/recv() to modern conventions	2023-03-09 18:10:33 +00:00
clifsinfo.c	libsmb: Save a few lines in cli_unix_extensions_version()	2022-08-26 18:54:37 +00:00
clilist.c	libsmb: Simplify clistr_is_previous_version_path()	2022-12-16 08:42:18 +00:00
climessage.c
clioplock.c	libsmb: Use tevent_req_nterror()'s retval	2022-09-19 17:23:31 +00:00
cliprint.c	libsmb: Avoid a call to SMBC_errno()	2022-02-17 17:13:34 +00:00
cliquota.c
clirap.c	libsmb: Move cli_qfilename() to its only user in torture.c	2021-11-11 19:08:37 +00:00
clirap.h	libsmb: Add cli_fsctl_send/recv	2022-10-03 20:03:32 +00:00
clireadwrite.c	libsmb: Remove "trans_oob()" macro	2021-11-11 19:08:37 +00:00
clisecdesc.c	libsmb: Make cli_set_security_descriptor() async	2020-11-16 19:53:45 +00:00
clispnego.c	CVE-2020-10704: lib util asn1: Add ASN.1 max tree depth	2020-05-04 02:59:31 +00:00
clisymlink.c	libsmb: Make readlink issue posix_readlink	2022-12-05 15:06:32 +00:00
clitrans.c
conncache.c
dsgetdcname.c	dsgetdcname: do not assume local system uses IPv4	2023-03-09 19:12:15 +00:00
dsgetdcname.h	s3-dsgetdcname: add dsgetonedcname()	2021-07-14 16:49:30 +00:00
errormap_wbc.c
errormap_wbc.h
errormap.c	lib: Align integer types	2020-01-19 18:29:39 +00:00
libsmb_cache.c
libsmb_compat.c
libsmb_context.c	libsmb: Tab-indent SMBC_module_[init|terminate]()	2022-08-26 18:54:37 +00:00
libsmb_dir.c	libsmb: Convert SMBC_getatr() to NTSTATUS	2022-02-07 19:00:34 +00:00
libsmb_file.c	s3: libsmbclient: Fix smbc_stat() to return ENOENT on a non-existent file.	2022-10-19 00:13:56 +00:00
libsmb_misc.c	libsmb: Make SMBC_dlist_contains return bool	2020-05-25 08:13:27 +00:00
libsmb_path.c	libsmb: Slightly simplify SMBC_parse_path()	2022-08-26 18:54:37 +00:00
libsmb_printjob.c	libsmb: Avoid a call to SMBC_errno()	2022-02-17 17:13:34 +00:00
libsmb_server.c	s3:libsmb: Covscan: unchecked return value for cli_credentials_set_smb_encryption()	2022-05-14 03:49:32 +00:00
libsmb_setget.c
libsmb_stat.c	libsmb: Convert SMBC_getatr() to NTSTATUS	2022-02-07 19:00:34 +00:00
libsmb_thread_impl.c
libsmb_thread_posix.c
libsmb_xattr.c	s3: libsmbclient: Fix smbc_getxattr() to return 0 on success.	2022-11-01 18:31:22 +00:00
libsmb.h
namecache.c	s3:libsmb: Remove unused variable 'i'	2023-02-06 22:51:31 +00:00
namequery_dc.c	s3:libads: Allocate ADS_STRUCT under a talloc context	2022-06-27 15:50:30 +00:00
namequery.c	lib: Move sockaddr_storage_to_samba_sockaddr() to lib/	2021-01-11 13:19:32 +00:00
namequery.h	lib: Move sockaddr_storage_to_samba_sockaddr() to lib/	2021-01-11 13:19:32 +00:00
nmblib.c	fix undefined-shift in put_res_rec fuzz error: ../../source3/libsmb/nmblib.c:451:4: runtime error: left shift of 65312 by 16 places cannot be represented in type 'int'	2021-10-29 20:29:26 +00:00
nmblib.h	s3:libsmb: move cli_set_message() to source3/libsmb/nmblib.c	2020-02-26 19:45:36 +00:00
passchange.c	s3:libsmb: Add dcerpc_samr_chgpasswd_user4 to remote_password_change()	2022-07-28 11:51:29 +00:00
proto.h	libsmb: Convert cli_posix_stat_send/recv() to modern conventions	2023-03-09 18:10:33 +00:00
pylibsmb.c	pylibsmb: Add reparse tag definitions	2023-01-04 08:54:32 +00:00
samlogon_cache.c	s3:winbind: Improve logging in samlogon_cache.c	2022-07-15 14:25:38 +00:00
samlogon_cache.h
smbclient.pc.in
smberr.c
smbsock_connect.c
trusts_util.c	s3:g_lock: add callback function to g_lock_lock()	2022-09-20 00:34:35 +00:00
unexpected.c
unexpected.h
wscript	s3:libsmb: Use cli_credentials_set_smb_encryption()	2020-08-19 16:22:42 +00:00