1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-05 09:18:06 +03:00
samba-mirror/source4/auth
Gary Lockyer 4e624478dc s4 auth ntlm: Fix integer overflow in authsam_password_check_and_record
Fix a ubsan detected integer overflow.
../../source4/auth/ntlm/auth_sam.c:445:56: runtime error:
     signed integer overflow: 60 * 600000000
     cannot be represented in type 'int'

In practice this meant that the default for the smb.conf parameter
"old password allowed period" was approximately 16 seconds, rather than
the intended 60 minutes. Similarly the value used would be 22.5 times
less than the value specified in smd.conf.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jan 13 23:52:38 UTC 2021 on sn-devel-184
2021-01-13 23:52:38 +00:00
..
gensec auth:creds: Rename CRED_USE_KERBEROS values 2020-11-03 15:25:37 +00:00
kerberos auth:creds: Remove unused credentials autoproto header 2020-08-19 16:22:40 +00:00
ntlm s4 auth ntlm: Fix integer overflow in authsam_password_check_and_record 2021-01-13 23:52:38 +00:00
tests auth:creds: Remove unused credentials autoproto header 2020-08-19 16:22:40 +00:00
auth.h s4:auth: add authsam_update_user_info_dc() that implements SID expanding for the local domain 2018-03-19 20:30:51 +01:00
pyauth.c pyauth: add python binding for auth_session_info_set_unix() 2020-06-05 10:32:31 +00:00
pyauth.h pytalloc: Use consistent prefix for functions, add ABI file. 2011-08-10 15:36:21 +02:00
sam.c s4/auth/sam: silence CID 1435849 2019-05-09 22:39:27 +00:00
samba_server_gensec.c s4:auth: use talloc_reparent() in samba_server_gensec_krb5_start() 2017-05-30 08:06:07 +02:00
session.c auth:creds: Rename CRED_USE_KERBEROS values 2020-11-03 15:25:37 +00:00
session.h Fix public header not to include private (not installed) ones. 2011-03-14 17:01:20 +01:00
system_session.c auth4: Use global_sid_Anonymous 2021-01-12 00:10:30 +00:00
unix_token.c s4-auth/unix_token: add new function auth_session_info_set_unix() 2020-06-05 10:32:31 +00:00
wscript_build build: Do not build selftest binaries for builds without --enable-selftest 2019-11-22 11:48:59 +00:00
wscript_configure s4:auth/gensec: remove unused and untested cyrus_sasl module 2015-06-23 22:12:08 +02:00