1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-25 23:21:54 +03:00
samba-mirror/source3/winbindd/idmap_util.c
Michael Adam c21976d4b1 idmap: don't generally forbid id==0 from idmap_unix_id_is_in_range()
If the range allows it, then id==0 should not be forbidden.
This seems to have been taken in from idmap_ldap when the
function was originally created.

See 634cd2e045 .
The other backends don't seem to have had that
extra check for id == 0.

The reasoning for this change is that the range check should
apply to all cases. If the range includes the 0, then it
should be possible to get it as result. In particular,
this way, the function becomes applicable also to the
passdb backend case, e.g. in a samba4-ad-dc setup where
the Admin gets uid == 0.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12155

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2016-08-16 21:27:22 +02:00

141 lines
3.1 KiB
C

/*
Unix SMB/CIFS implementation.
ID Mapping
Copyright (C) Simo Sorce 2003
Copyright (C) Jeremy Allison 2006
Copyright (C) Michael Adam 2010
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.*/
#include "includes.h"
#include "winbindd.h"
#include "winbindd_proto.h"
#include "idmap.h"
#include "idmap_cache.h"
#include "../libcli/security/security.h"
#include "secrets.h"
#undef DBGC_CLASS
#define DBGC_CLASS DBGC_IDMAP
/**
* check whether a given unix id is inside the filter range of an idmap domain
*/
bool idmap_unix_id_is_in_range(uint32_t id, struct idmap_domain *dom)
{
if ((dom->low_id && (id < dom->low_id)) ||
(dom->high_id && (id > dom->high_id)))
{
return false;
}
return true;
}
/**
* Helper for unixids_to_sids: find entry by id in mapping array,
* search up to IDMAP_AD_MAX_IDS entries
*/
struct id_map *idmap_find_map_by_id(struct id_map **maps, enum id_type type,
uint32_t id)
{
int i;
for (i = 0; i < IDMAP_LDAP_MAX_IDS; i++) {
if (maps[i] == NULL) { /* end of the run */
return NULL;
}
if ((maps[i]->xid.type == type) && (maps[i]->xid.id == id)) {
return maps[i];
}
}
return NULL;
}
/**
* Helper for sids_to_unix_ids: find entry by SID in mapping array,
* search up to IDMAP_AD_MAX_IDS entries
*/
struct id_map *idmap_find_map_by_sid(struct id_map **maps, struct dom_sid *sid)
{
int i;
for (i = 0; i < IDMAP_LDAP_MAX_IDS; i++) {
if (maps[i] == NULL) { /* end of the run */
return NULL;
}
if (dom_sid_equal(maps[i]->sid, sid)) {
return maps[i];
}
}
return NULL;
}
char *idmap_fetch_secret(const char *backend, const char *domain,
const char *identity)
{
char *tmp, *ret;
int r;
r = asprintf(&tmp, "IDMAP_%s_%s", backend, domain);
if (r < 0)
return NULL;
/* make sure the key is case insensitive */
if (!strupper_m(tmp)) {
SAFE_FREE(tmp);
return NULL;
}
ret = secrets_fetch_generic(tmp, identity);
SAFE_FREE(tmp);
return ret;
}
struct id_map **id_map_ptrs_init(TALLOC_CTX *mem_ctx, size_t num_ids)
{
struct id_map **ptrs;
struct id_map *maps;
struct dom_sid *sids;
size_t i;
ptrs = talloc_array(mem_ctx, struct id_map *, num_ids+1);
if (ptrs == NULL) {
return NULL;
}
maps = talloc_array(ptrs, struct id_map, num_ids);
if (maps == NULL) {
TALLOC_FREE(ptrs);
return NULL;
}
sids = talloc_zero_array(ptrs, struct dom_sid, num_ids);
if (sids == NULL) {
TALLOC_FREE(ptrs);
return NULL;
}
for (i=0; i<num_ids; i++) {
maps[i] = (struct id_map) { .sid = &sids[i] };
ptrs[i] = &maps[i];
}
ptrs[num_ids] = NULL;
return ptrs;
}