mirror of
https://github.com/samba-team/samba.git
synced 2024-12-25 23:21:54 +03:00
5ba377f3df
The trigger for this is that Coverity got confused by the dual use of &xid as an array with the implicit length equality between wb_sids2xids_send and the array passed in to wb_sids2xids_recv for the result. I don't want to start doing things just for the Coverity scan, but this makes the code clearer to me by removing this implicit expected array length equality. Signed-off-by: Volker Lendecke <vl@samba.org> Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Sat Mar 7 15:28:59 CET 2015 on sn-devel-104
110 lines
3.2 KiB
C
110 lines
3.2 KiB
C
/*
|
|
Unix SMB/CIFS implementation.
|
|
async implementation of WINBINDD_SID_TO_UID
|
|
Copyright (C) Volker Lendecke 2009
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "includes.h"
|
|
#include "winbindd.h"
|
|
#include "../libcli/security/security.h"
|
|
|
|
struct winbindd_sid_to_uid_state {
|
|
struct dom_sid sid;
|
|
uid_t uid;
|
|
};
|
|
|
|
static void winbindd_sid_to_uid_done(struct tevent_req *subreq);
|
|
|
|
struct tevent_req *winbindd_sid_to_uid_send(TALLOC_CTX *mem_ctx,
|
|
struct tevent_context *ev,
|
|
struct winbindd_cli_state *cli,
|
|
struct winbindd_request *request)
|
|
{
|
|
struct tevent_req *req, *subreq;
|
|
struct winbindd_sid_to_uid_state *state;
|
|
|
|
req = tevent_req_create(mem_ctx, &state,
|
|
struct winbindd_sid_to_uid_state);
|
|
if (req == NULL) {
|
|
return NULL;
|
|
}
|
|
|
|
/* Ensure null termination */
|
|
request->data.sid[sizeof(request->data.sid)-1]='\0';
|
|
|
|
DEBUG(3, ("sid to uid %s\n", request->data.sid));
|
|
|
|
if (!string_to_sid(&state->sid, request->data.sid)) {
|
|
DEBUG(1, ("Could not get convert sid %s from string\n",
|
|
request->data.sid));
|
|
tevent_req_nterror(req, NT_STATUS_INVALID_PARAMETER);
|
|
return tevent_req_post(req, ev);
|
|
}
|
|
|
|
subreq = wb_sids2xids_send(state, ev, &state->sid, 1);
|
|
if (tevent_req_nomem(subreq, req)) {
|
|
return tevent_req_post(req, ev);
|
|
}
|
|
tevent_req_set_callback(subreq, winbindd_sid_to_uid_done, req);
|
|
return req;
|
|
}
|
|
|
|
static void winbindd_sid_to_uid_done(struct tevent_req *subreq)
|
|
{
|
|
struct tevent_req *req = tevent_req_callback_data(
|
|
subreq, struct tevent_req);
|
|
struct winbindd_sid_to_uid_state *state = tevent_req_data(
|
|
req, struct winbindd_sid_to_uid_state);
|
|
NTSTATUS status;
|
|
struct unixid xids[1];
|
|
|
|
status = wb_sids2xids_recv(subreq, xids, ARRAY_SIZE(xids));
|
|
TALLOC_FREE(subreq);
|
|
if (tevent_req_nterror(req, status)) {
|
|
return;
|
|
}
|
|
|
|
/*
|
|
* We are filtering further down in sids2xids, but that filtering
|
|
* depends on the actual type of the sid handed in (as determined
|
|
* by lookupsids). Here we need to filter for the type of object
|
|
* actually requested, in this case uid.
|
|
*/
|
|
if (!(xids[0].type == ID_TYPE_UID || xids[0].type == ID_TYPE_BOTH)) {
|
|
tevent_req_nterror(req, NT_STATUS_NONE_MAPPED);
|
|
return;
|
|
}
|
|
|
|
state->uid = (uid_t)xids[0].id;
|
|
tevent_req_done(req);
|
|
}
|
|
|
|
NTSTATUS winbindd_sid_to_uid_recv(struct tevent_req *req,
|
|
struct winbindd_response *response)
|
|
{
|
|
struct winbindd_sid_to_uid_state *state = tevent_req_data(
|
|
req, struct winbindd_sid_to_uid_state);
|
|
NTSTATUS status;
|
|
|
|
if (tevent_req_is_nterror(req, &status)) {
|
|
DEBUG(5, ("Could not convert sid %s: %s\n",
|
|
sid_string_dbg(&state->sid), nt_errstr(status)));
|
|
return status;
|
|
}
|
|
response->data.uid = state->uid;
|
|
return NT_STATUS_OK;
|
|
}
|