mirror of
https://github.com/samba-team/samba.git
synced 2024-12-28 07:21:54 +03:00
20d17b8057
preparation for the full share modes and ntcreatex code that I am
working on.
highlights include:
- changed the way a backend determines if it is allowed to process a
request asynchronously. The previous method of looking at the
send_fn caused problems when an intermediate ntvfs module disabled
it, and the caller then wanted to finished processing using this
function. The new method is a REQ_CONTROL_MAY_ASYNC flag in
req->control_flags, which is also a bit easier to read
- fixed 2 bugs in the readbraw server code. One related to trying to
answer a readbraw with smb signing (which can't work, and crashed
our signing code), the second related to error handling, which
attempted to send a normal SMB error packet, when readbraw must
send a 0 read reply (as it has no header)
- added several more ntvfs_generic.c generic mapping functions. This
means that backends no longer need to implement such esoteric
functions as SMBwriteunlock() if they don't want to. The backend
can just request the mapping layer turn it into a write followed by
an unlock. This makes the backends considerably simpler as they
only need to implement one style of each function for lock, read,
write, open etc, rather than the full host of functions that SMB
provides. A backend can still choose to implement them
individually, of course, and the CIFS backend does that.
- simplified the generic structures to make them identical to the
principal call for several common SMB calls (such as
RAW_WRITE_GENERIC now being an alias for RAW_WRITE_WRITEX).
- started rewriting the pvfs_open() code in preparation for the full
ntcreatex semantics.
- in pvfs_open and ipc_open, initially allocate the open file
structure as a child of the request, so on error we don't need to
clean up. Then when we are going to succeed the open steal the
pointer into the long term backend context. This makes for much
simpler error handling (and fixes some bugs)
- use a destructor in the ipc backend to make sure that everthing is
cleaned up on receive error conditions.
- switched the ipc backend to using idtree for fnum allocation
- in the ntvfs_generic mapping routines, use a allocated secondary
structure not a stack structure to ensure the request pointer
remains valid even if the backend replies async.
(This used to be commit
|
||
|---|---|---|
| .. | ||
| clioplock.c | ||
| clisession.c | ||
| clisocket.c | ||
| clitransport.c | ||
| clitree.c | ||
| rawacl.c | ||
| rawdate.c | ||
| raweas.c | ||
| rawfile.c | ||
| rawfileinfo.c | ||
| rawfsinfo.c | ||
| rawioctl.c | ||
| rawnegotiate.c | ||
| rawnotify.c | ||
| rawreadwrite.c | ||
| rawrequest.c | ||
| rawsearch.c | ||
| rawsetfileinfo.c | ||
| rawtrans.c | ||
| README | ||
| smb_signing.c | ||
Design notes for client library restructure: 1 - no references to cli_state should exist in libcli/raw. 2 - all interfaces to functions in this directory should use cli_session or cli_tree as the primary context structure