1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-28 07:21:54 +03:00
samba-mirror/source3/winbindd
Günther Deschner 17ae9974f3 Fix gcc11 compiler issue "-Werror=stringop-overflow="
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14699

[3548/3991] Compiling source3/winbindd/winbindd_pam.c
../../source3/winbindd/winbindd_pam.c: In function ‘winbindd_dual_pam_auth_cached’:
../../source3/winbindd/winbindd_pam.c:1069:18: error: ‘winbindd_get_creds’ accessing 128 bytes in a region of size 8 [-Werror=stringop-overflow=]
 1069 |         result = winbindd_get_creds(domain,
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~
 1070 |                                     state->mem_ctx,
      |                                     ~~~~~~~~~~~~~~~
 1071 |                                     &sid,
      |                                     ~~~~~
 1072 |                                     &my_info3,
      |                                     ~~~~~~~~~~
 1073 |                                     &cached_nt_pass,
      |                                     ~~~~~~~~~~~~~~~~
 1074 |                                     &cached_salt);
      |                                     ~~~~~~~~~~~~~
../../source3/winbindd/winbindd_pam.c:1069:18: note: referencing argument 5 of type ‘const uint8_t **’ {aka ‘const unsigned char **’}
../../source3/winbindd/winbindd_pam.c:1069:18: error: ‘winbindd_get_creds’ accessing 128 bytes in a region of size 8 [-Werror=stringop-overflow=]
../../source3/winbindd/winbindd_pam.c:1069:18: note: referencing argument 6 of type ‘const uint8_t **’ {aka ‘const unsigned char **’}
In file included from ../../source3/winbindd/winbindd.h:359,
                 from ../../source3/winbindd/winbindd_pam.c:26:
../../source3/winbindd/winbindd_proto.h:251:10: note: in a call to function ‘winbindd_get_creds’
  251 | NTSTATUS winbindd_get_creds(struct winbindd_domain *domain,
      |          ^~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2021-05-07 06:23:32 +00:00
..
idmap_hash s3:idmap_hash: reliable return ID_TYPE_BOTH 2021-01-22 11:32:46 +00:00
idmap_ad_nss.c winbindd/idmap: apply const to struct nss_info_methods pointers 2020-10-23 03:25:35 +00:00
idmap_ad.c winbindd/idmap: apply const to struct idmap_methods pointers 2020-10-23 03:25:35 +00:00
idmap_autorid_tdb.c s3: safe_string: do not include string_wrappers.h 2020-08-28 00:56:34 +00:00
idmap_autorid.c winbindd: allow idmap backends to mark entries with ID_[TYPE_WB_]REQUIRE_TYPE 2020-10-23 03:25:37 +00:00
idmap_ldap.c lib: give global_contexts.c its own header file 2021-01-08 20:31:33 +00:00
idmap_nss.c idmap_nss: Do not return SID from unixids_to_sids on type mismatch 2021-03-11 08:38:41 +00:00
idmap_passdb.c winbindd/idmap: apply const to struct idmap_methods pointers 2020-10-23 03:25:35 +00:00
idmap_proto.h winbindd/idmap: apply const to struct idmap_methods pointers 2020-10-23 03:25:35 +00:00
idmap_rfc2307.c idmap_rfc2307: Do not return SID from unixids_to_sids on type mismatch 2021-03-11 07:28:37 +00:00
idmap_rid.c winbindd/idmap: apply const to struct idmap_methods pointers 2020-10-23 03:25:35 +00:00
idmap_rw.c winbindd: allow idmap backends to mark entries with ID_[TYPE_WB_]REQUIRE_TYPE 2020-10-23 03:25:37 +00:00
idmap_rw.h
idmap_script.c winbindd/idmap: apply const to struct idmap_methods pointers 2020-10-23 03:25:35 +00:00
idmap_tdb2.c winbindd/idmap: apply const to struct idmap_methods pointers 2020-10-23 03:25:35 +00:00
idmap_tdb_common.c winbindd: allow idmap backends to mark entries with ID_[TYPE_WB_]REQUIRE_TYPE 2020-10-23 03:25:37 +00:00
idmap_tdb_common.h
idmap_tdb.c winbindd/idmap: apply const to struct idmap_methods pointers 2020-10-23 03:25:35 +00:00
idmap_util.c
idmap.c winbindd/idmap: apply const to struct idmap_methods pointers 2020-10-23 03:25:35 +00:00
nss_info_template.c
nss_info.c winbindd/idmap: apply const to struct nss_info_methods pointers 2020-10-23 03:25:35 +00:00
wb_dsgetdcname.c winbind: Fix an error path memleak 2019-02-27 01:35:18 +01:00
wb_getgrsid.c
wb_getpwsid.c s3: safe_string: do not include string_wrappers.h 2020-08-28 00:56:34 +00:00
wb_gettoken.c
wb_group_members.c
wb_lookupname.c
wb_lookupsid.c winbindd: Use dom_sid_str_buf 2018-12-20 23:40:25 +01:00
wb_lookupsids.c
wb_lookupuseraliases.c
wb_lookupusergroups.c
wb_next_grent.c
wb_next_pwent.c
wb_query_group_list.c
wb_query_user_list.c
wb_queryuser.c wb_queryuser: explain why wb_parent_idmap_setup_send/recv is not needed 2020-10-23 03:25:36 +00:00
wb_seqnum.c
wb_seqnums.c
wb_sids2xids.c wb_sids2xids: defer/skip wb_lookupsids* unless we get ID_TYPE_WB_REQUIRE_TYPE 2020-10-23 04:47:26 +00:00
wb_xids2sids.c wb_xids2sids: make use of the new wb_parent_idmap_setup_send/recv() helpers 2020-10-23 03:25:36 +00:00
winbindd_ads.c winbindd: remove obsolete sequence_number from struct winbindd_methods 2021-04-29 15:49:16 +00:00
winbindd_ads.h
winbindd_allocate_gid.c winbindd: Fix a startup race with allocate_gid 2021-03-24 20:31:30 +00:00
winbindd_allocate_uid.c
winbindd_async.c
winbindd_cache.c s3:winbindd: Simplfy sequence number caching 2021-04-29 15:01:29 +00:00
winbindd_ccache_access.c
winbindd_change_machine_acct.c
winbindd_check_machine_acct.c
winbindd_cm.c s3:winbindd: Simplfy sequence number caching 2021-04-29 15:01:29 +00:00
winbindd_cred_cache.c lib: give global_contexts.c its own header file 2021-01-08 20:31:33 +00:00
winbindd_creds.c Fix gcc11 compiler issue "-Werror=stringop-overflow=" 2021-05-07 06:23:32 +00:00
winbindd_domain_info.c lib: give global_contexts.c its own header file 2021-01-08 20:31:33 +00:00
winbindd_domain.c
winbindd_dsgetdcname.c winbind: Align integer types 2020-11-30 22:24:37 +00:00
winbindd_dual_ndr.c librpc: Make "dcesrv_context->callbacks" a pointer 2021-03-16 17:09:32 +00:00
winbindd_dual_srv.c idmap_rfc2307: Do not return SID from unixids_to_sids on type mismatch 2021-03-11 07:28:37 +00:00
winbindd_dual.c winbind: handle MSG_SMB_CONF_UPDATED in the winbinds children 2021-01-21 21:48:30 +00:00
winbindd_endgrent.c
winbindd_endpwent.c
winbindd_getdcname.c s3: safe_string: do not include string_wrappers.h 2020-08-28 00:56:34 +00:00
winbindd_getgrent.c
winbindd_getgrgid.c winbindd: handling missing idmap in getgrgid() 2020-02-05 17:56:58 +00:00
winbindd_getgrnam.c s3: safe_string: do not include string_wrappers.h 2020-08-28 00:56:34 +00:00
winbindd_getgroups.c winbindd: allow idmap backends to mark entries with ID_[TYPE_WB_]REQUIRE_TYPE 2020-10-23 03:25:37 +00:00
winbindd_getpwent.c
winbindd_getpwnam.c winbindd: Use dom_sid_str_buf 2018-12-20 23:40:25 +01:00
winbindd_getpwsid.c winbindd: Use dom_sid_str_buf 2018-12-20 23:40:25 +01:00
winbindd_getpwuid.c winbindd: Use dom_sid_str_buf 2018-12-20 23:40:25 +01:00
winbindd_getsidaliases.c
winbindd_getuserdomgroups.c
winbindd_getusersids.c winbindd: Use dom_sid_str_buf 2018-12-20 23:40:25 +01:00
winbindd_gpupdate.c lib: give global_contexts.c its own header file 2021-01-08 20:31:33 +00:00
winbindd_group.c
winbindd_idmap.c lib: give global_contexts.c its own header file 2021-01-08 20:31:33 +00:00
winbindd_irpc.c lib: give global_contexts.c its own header file 2021-01-08 20:31:33 +00:00
winbindd_list_groups.c winbind: honor WBFLAG_FROM_NSS along with winbind enum users/groups 2018-12-22 03:11:14 +01:00
winbindd_list_users.c winbind: honor WBFLAG_FROM_NSS along with winbind enum users/groups 2018-12-22 03:11:14 +01:00
winbindd_locator.c
winbindd_lookupname.c winbind: Use dom_sid_str_buf 2018-12-20 23:40:24 +01:00
winbindd_lookuprids.c s3: safe_string: do not include string_wrappers.h 2020-08-28 00:56:34 +00:00
winbindd_lookupsid.c s3: safe_string: do not include string_wrappers.h 2020-08-28 00:56:34 +00:00
winbindd_lookupsids.c CVE-2020-14323 winbind: Fix invalid lookupsids DoS 2020-10-29 10:25:37 +00:00
winbindd_misc.c s3: safe_string: do not include string_wrappers.h 2020-08-28 00:56:34 +00:00
winbindd_msrpc.c winbindd: remove obsolete sequence_number from struct winbindd_methods 2021-04-29 15:49:16 +00:00
winbindd_ndr.c
winbindd_pam_auth_crap.c lib: give global_contexts.c its own header file 2021-01-08 20:31:33 +00:00
winbindd_pam_auth.c lib: give global_contexts.c its own header file 2021-01-08 20:31:33 +00:00
winbindd_pam_chauthtok.c lib: give global_contexts.c its own header file 2021-01-08 20:31:33 +00:00
winbindd_pam_chng_pswd_auth_crap.c lib: give global_contexts.c its own header file 2021-01-08 20:31:33 +00:00
winbindd_pam_logoff.c lib: give global_contexts.c its own header file 2021-01-08 20:31:33 +00:00
winbindd_pam.c winbindd: Fix a typo 2021-04-19 18:18:31 +00:00
winbindd_ping_dc.c
winbindd_proto.h Fix gcc11 compiler issue "-Werror=stringop-overflow=" 2021-05-07 06:23:32 +00:00
winbindd_reconnect_ads.c winbindd: remove obsolete sequence_number from struct winbindd_methods 2021-04-29 15:49:16 +00:00
winbindd_reconnect.c winbindd: remove obsolete sequence_number from struct winbindd_methods 2021-04-29 15:49:16 +00:00
winbindd_rpc.c s3:winbindd: Remove unused rpc_sequence_number() 2021-04-29 15:01:29 +00:00
winbindd_rpc.h s3:winbindd: Remove unused rpc_sequence_number() 2021-04-29 15:01:29 +00:00
winbindd_samr.c winbindd: remove obsolete sequence_number from struct winbindd_methods 2021-04-29 15:49:16 +00:00
winbindd_setgrent.c
winbindd_setpwent.c
winbindd_show_sequence.c
winbindd_sids_to_xids.c
winbindd_util.c winbindd: Apply some const to normalize_name_map() 2021-03-09 23:45:51 +00:00
winbindd_wins_byip.c s3: libsmb: Convert node_status_query() and associated functions and callers to expect a size_t * return. 2020-09-15 10:09:36 +00:00
winbindd_wins_byname.c s3: libsmb: Convert the WINS and broadcast name functions to return size_t * num addresses. 2020-09-15 10:09:36 +00:00
winbindd_xids_to_sids.c winbind: Enhance xids2sids debugging 2019-02-08 08:51:19 +01:00
winbindd.c s3:winbind: For 'security = ADS' require realm/workgroup to be set 2021-04-29 04:48:37 +00:00
winbindd.h winbindd: remove obsolete sequence_number from struct winbindd_methods 2021-04-29 15:49:16 +00:00
wscript_build s3:winbind: Migrate winbindd to new cmdline option parser 2021-04-29 03:58:37 +00:00