Stefan Metzmacher 759416582c s3:smbd: only pass UCF_PREP_CREATEFILE to filename_convert() if we may create a new file ...

This fixes a regression introduced by commit
f98d10af2a05f0261611f4cabdfe274cd9fe91c0
(smbd: Always use UCF_PREP_CREATEFILE for filename_convert calls to resolve a path for open)

The main problem was that Windows client seem to verify
the access to user.V2\ntuser.ini is rejected with NT_STATUS_ACCESS_DENIED,
using the machine credentials.

Passing UCF_PREP_CREATEFILE to filename_convert() triggers a code path
that implements a dropbox behaviour. A dropbox is a directory with only -wx permissions,
so get_real_filename fails with EACCESS, it needs to list the directory.
EACCESS is ignored with UCF_PREP_CREATEFILE.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10297

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Oct 25 05:33:36 CEST 2016 on sn-devel-144

2016-10-25 05:33:36 +02:00

..

notifyd

notifyd: Don't trust remote pointers

2016-09-09 11:58:07 +02:00

aio.c

s3: smbd: Use common function setup_readX_header() in aio read code.

2016-06-18 15:32:18 +02:00

avahi_register.c

s3-param Remove special case for global_myname(), rename to lp_netbios_name()

2011-06-09 12:40:09 +02:00

blocking.c

dlist: remove unneeded type argument from DLIST_ADD_END()

2016-02-06 21:48:17 +01:00

close.c

Update smbrun to allow for settings environment variables.

2016-10-13 04:26:26 +02:00

conn_idle.c

Fix bug #9733 - smbcontrol close-share is not working.

2013-03-22 20:10:11 +01:00

conn_msg.c

s3:smbd/conn_msg: use talloc_get_type_abort() as private_data can't be NULL

2011-12-14 12:00:07 +01:00

conn.c

Add uint32_t share_access to vuid_cache_entry.

2013-01-09 15:28:48 +11:00

connection.c

s3:smbd: remove unused claim_connection/yield_connection

2012-10-19 12:15:03 +02:00

dfree.c

smbd: get a valid file stat to disk_quotas

2016-08-13 01:53:15 +02:00

dir.c

s3: Filenames: Add uint32_t flags parameter to synthetic_smb_fname().

2016-03-24 22:57:16 +01:00

dmapi.c

Convert all uses of uint8/16/32 to _t in source3/smbd.

2015-05-06 04:14:14 +02:00

dnsregister.c

s3: include smbd/smbd.h where needed.

2011-03-30 01:13:08 +02:00

dosmode.c

s3/vfs: merge offline functionality into DOS attributes handling

2016-10-11 11:01:10 +02:00

durable.c

s3: Filenames: Add uint32_t flags parameter to synthetic_smb_fname().

2016-03-24 22:57:16 +01:00

error.c

Convert all uses of uint8/16/32 to _t in source3/smbd.

2015-05-06 04:14:14 +02:00

fake_file.c

Convert three include files from uint32/16/8 to _t types as well as the source that includes them.

2015-05-01 19:15:10 +02:00

file_access.c

s3: Filenames: Add uint32_t flags parameter to synthetic_smb_fname().

2016-03-24 22:57:16 +01:00

fileio.c

smbd: Fix line length & whitespace in write_file

2016-02-23 22:03:16 +01:00

filename.c

s3:smbd: only pass UCF_PREP_CREATEFILE to filename_convert() if we may create a new file

2016-10-25 05:33:36 +02:00

files.c

smbd: Add "path" to notify_remove

2016-07-20 05:21:06 +02:00

globals.c

printing: use housekeeping period that matches cache time

2016-04-19 09:37:14 +02:00

globals.h

vfs: Remove link to asys_

2016-08-24 01:33:49 +02:00

ipc.c

Convert all uses of uint8/16/32 to _t in source3/smbd.

2015-05-06 04:14:14 +02:00

lanman.c

werror: replace WERR_USER_NOT_FOUND with WERR_NERR_USERNOTFOUND in source3/smbd/lanman.c

2016-09-28 00:04:26 +02:00

mangle_hash2.c

lib/util: move memcache.[ch] to the toplevel 'samba-util' library

2014-07-18 15:43:33 +02:00

mangle_hash.c

smbd: Convert valid.dat to C code

2015-03-24 00:00:20 +01:00

mangle.c

param: rename lp function and variable from 'defaultcase' to 'default_case'

2014-02-07 16:19:10 -08:00

message.c

Update smbrun to allow for settings environment variables.

2016-10-13 04:26:26 +02:00

msdfs.c

s3: smbd: DFS: Pass uint32_t ucf_flags through into unix_convert().

2016-03-26 00:08:40 +01:00

negprot.c

smbd: Adjust debug level of "No protocol supported" message

2016-09-10 14:57:11 +02:00

notify_fam.c

smbd: Allow passing notify filter from inotify and fam

2016-07-18 15:14:11 +02:00

notify_inotify.c

notify_inotify: Map inotify mask back to filter

2016-07-18 18:50:55 +02:00

notify_msg.c

smbd: Log which notifyd was found

2016-07-20 05:21:07 +02:00

notify.c

smbd: Re-register notify requests

2016-07-20 05:21:07 +02:00

ntquotas.c

smbd: free talloc context if no quota records are available

2016-10-04 02:00:22 +02:00

nttrans.c

s3:smbd: only pass UCF_PREP_CREATEFILE to filename_convert() if we may create a new file

2016-10-25 05:33:36 +02:00

open.c

smbd: Reset O_NONBLOCK on open files

2016-09-15 20:21:41 +02:00

oplock_irix.c

param: rename lp function and variable from 'lockdir' to 'lock_directory'

2014-02-07 16:19:10 -08:00

oplock_linux.c

Wrap setting leases in become_root()/unbecome_root() to ensure correct delivery of signals.

2013-07-31 17:07:58 -07:00

oplock.c

smbd: oplock: Factor out internals of remove_oplock() into new remove_oplock_under_lock().

2016-08-11 19:55:11 +02:00

password.c

loadparm: rename lp[cfg]_pathname to lp[cfg]_path for consistency with docs

2014-02-03 13:26:13 +13:00

perfcount.c

loadparm: make the source3/ lp_ functions take an explicit TALLOC_CTX *.

2012-07-18 15:07:23 +09:30

pipes.c

s3: smbd: In reply_read_and_X() SMB1 server is overwriting part of the 'reserved' zero fields with reply data length.

2016-06-18 15:32:18 +02:00

posix_acls.c

smbd: add an option to inherit only the UNIX owner

2016-08-10 08:18:17 +02:00

process.c

s3: server: s3_tevent_context_init() -> samba_tevent_context_init()

2016-09-24 19:52:08 +02:00

proto.h

s3:smbd: only pass UCF_PREP_CREATEFILE to filename_convert() if we may create a new file

2016-10-25 05:33:36 +02:00

pysmbd.c

s3: Filenames: Add uint32_t flags parameter to synthetic_smb_fname().

2016-03-24 22:57:16 +01:00

quotas.c

smbd: use owner uid for free disk calculation if owner is inherited

2016-08-13 01:53:15 +02:00

reply.c

s3:smbd: only pass UCF_PREP_CREATEFILE to filename_convert() if we may create a new file

2016-10-25 05:33:36 +02:00

scavenger.c

smbd: Fix/simplify scavenger routines

2015-10-30 22:53:56 +01:00

scavenger.h

s3:smbd: add a scavenger process for disconnected durable handles

2013-04-18 13:15:13 +02:00

seal.c

s3:smbd: remove unused spnego related includes

2015-12-17 14:45:13 +01:00

sec_ctx.c

s3:smbprofile: improve profiling for the security context switching.

2014-11-19 20:51:37 +01:00

server_exit.c

Revert "s3: smbd: Tear down global_smbXsrv_client in the correct order."

2015-12-07 21:09:04 +01:00

server_reload.c

s3:smbd: use lp_load_with_shares() in reload_services().

2015-04-22 13:57:29 +02:00

server.c

s3: server: s3_tevent_context_init() -> samba_tevent_context_init()

2016-09-24 19:52:08 +02:00

service.c

Update smbrun to allow for settings environment variables.

2016-10-13 04:26:26 +02:00

session.c

s3:smbd/session: Added a routine find_sessions()

2013-09-10 11:32:46 -07:00

sesssetup.c

s3:smbd: fix anonymous authentication if signing is mandatory

2016-05-18 15:49:46 +02:00

share_access.c

smbd: remove redundant comment (with typo) from token_contains_name()

2016-08-04 18:26:07 +02:00

signing.c

s3:smbd: move sconn->smb1.signing_state to xconn->smb1.signing_state

2014-08-06 09:51:11 +02:00

smb2_break.c

smbXsrv: rename smb2srv_session_lookup -> smb2srv_session_lookup_conn

2015-07-29 18:26:07 +02:00

smb2_close.c

smbd:smb2_close: remove an irritating blank line

2016-01-22 01:55:09 +01:00

smb2_create.c

s3:smbd: only pass UCF_PREP_CREATEFILE to filename_convert() if we may create a new file

2016-10-25 05:33:36 +02:00

smb2_flush.c

s3/vfs: wrap async io function args inside struct vfs_aio_state

2016-03-02 01:22:13 +01:00

smb2_getinfo.c

s3:smbd: mask security_information input values with SMB_SUPPORTED_SECINFO_FLAGS

2014-08-22 00:28:08 +02:00

smb2_glue.c

smbd: allow reading files based on FILE_EXECUTE access right

2016-08-18 18:58:22 +02:00

smb2_ioctl_dfs.c

smb2_ioctl: split ioctl handler code on device type

2013-01-16 23:15:06 +01:00

smb2_ioctl_filesys.c

smbd: Fix a comment

2016-10-14 05:31:07 +02:00

smb2_ioctl_named_pipe.c

smbd: Fix CID 1035550 Structurally dead code

2013-08-12 17:25:54 +12:00

smb2_ioctl_network_fs.c

smbd: look only at handle readability for COPYCHUNK dest

2016-08-16 15:21:03 +02:00

smb2_ioctl_private.h

smb2_ioctl: split ioctl handler code on device type

2013-01-16 23:15:06 +01:00

smb2_ioctl.c

s3:smb2_server: pass smbXsrv_connection to smbd_server_connection_terminate*()

2014-08-06 09:51:13 +02:00

smb2_keepalive.c

s3:smb2_keepalive: make use of smbd_smb2_generate_outbody()

2014-03-05 13:59:22 -08:00

smb2_lock.c

smbd: Fix CID 1273096 Dereference before null check

2015-06-23 22:12:09 +02:00

smb2_negprot.c

smbd: use remote arch caching

2016-05-04 01:28:22 +02:00

smb2_notify.c

s3:smb2_server: use async smbprofile macros

2014-11-19 20:51:37 +01:00

smb2_query_directory.c

s3: smbd: Change dptr_create() to take a const struct smb_filename * instead of const char *.

2016-03-01 18:34:24 +01:00

smb2_read.c

lib: Move sys_rw* to lib/util

2015-10-13 01:23:07 +02:00

smb2_server.c

s3:smbd remove todo comments

2016-05-04 05:00:36 +02:00

smb2_sesssetup.c

smbd: use remote arch caching

2016-05-04 01:28:22 +02:00

smb2_setinfo.c

smbd: Convert locking.tdb to new dbwrap_watch

2016-07-15 16:56:13 +02:00

smb2_tcon.c

s3:smb2_server: convert encryption desired and required bools to flags

2016-01-22 07:52:20 +01:00

smb2_write.c

s3:smb2_write: add simplified support for SMB2_WRITEFLAG_WRITE_UNBUFFERED

2015-05-08 13:00:28 +02:00

smbd_cleanupd.c

s3/smbd: remove a misleading error message

2016-09-16 16:43:16 +02:00

smbd_cleanupd.h

smbd: Implement a cleanup daemon

2015-11-16 14:51:33 +01:00

smbd.h

Convert all uses of uint8/16/32 to _t in source3/smbd.

2015-05-06 04:14:14 +02:00

smbXsrv_client.c

smbd: Remove a reference to dbwrap_watch_db()

2016-07-15 20:32:19 +02:00

smbXsrv_open.c

smbd: Avoid an "else"

2016-03-09 21:51:52 +01:00

smbXsrv_session.c

smbd: Convert smbXsrv_open_global.tdb to new dbwrap_watch

2016-07-15 16:56:13 +02:00

smbXsrv_tcon.c

smbXsrv_tcon: factor fetch-locking of local record into function

2016-02-28 05:03:22 +01:00

smbXsrv_version.c

smbXsrv: don't leak lock_path onto talloc tos

2014-11-03 23:46:05 +01:00

srvstr.c

Convert all uses of uint8/16/32 to _t in source3/smbd.

2015-05-06 04:14:14 +02:00

statcache.c

lib: Move "message_send_all" to serverid.c

2016-07-28 05:00:19 +02:00

statvfs.c

s3/statvfs: expose FILE_SUPPORTS_SPARSE_FILES capability

2015-03-09 21:27:07 +01:00

trans2.c

s3/smbd: use stat from smb_fname if valid in refuse_symlink()

2016-09-11 23:52:16 +02:00

uid.c

smbd: Change logging level for denied share access

2014-07-31 01:17:30 +02:00

utmp.c

param: rename lp function and variable from 'wtmpdir' to 'wtmp_directory'

2014-02-07 16:19:11 -08:00

vfs.c

s3/vfs: remove now unused is_offline/set_offline VFS functions

2016-10-11 14:44:01 +02:00