mirror of
https://github.com/samba-team/samba.git
synced 2025-01-11 05:18:09 +03:00
257b7b0929
The libsmbclient interface has suffered from difficulty of improvement and
feature enrichment without causing ABI breakage. Although there were a number
of issues, the primary ones were:
(a) the user of the library would manually manipulate the context structure
members, meaning that nothing in the context structure could change other
than adding stuff at the end;
(b) there were three methods of setting options: setting bits in a flags field
within the context structure, setting explicit options variables within an
options structure in the context structure, and by calling the
smbc_option_set() function;
(c) the authentication callback did not traditionally provide enough
information to the callee which required adding an option for a callback
with a different signature, and now there are requests for even more
information at the callback, requiring yet a third signature and option to
set it (if we implement that feature).
This commit provides a reorganization of the code which fixes (a) and (b).
The context structure is now entirely opaque, and there are setter and getter
functions for manipulating it. This makes maintaining ABI consistency much,
much easier.
Additionally, the options setting/getting has been unified into a single
mechanism using smbc_option_set() and smbc_option_get().
Yet to be completed is a refactoring of the authentication callback (c).
The test programs in examples/libsmbclient have been modified (if necessary;
some applications require no changes at all) for the new API and a few have
been minimally tested.
Derrell
(This used to be commit
|
||
|---|---|---|
| .. | ||
| auth | ||
| client | ||
| codepages | ||
| exports | ||
| groupdb | ||
| include | ||
| iniparser | ||
| iniparser_build | ||
| intl | ||
| lib | ||
| libaddns | ||
| libads | ||
| libgpo | ||
| libnet | ||
| librpc | ||
| libsmb | ||
| locking | ||
| m4 | ||
| modules | ||
| nmbd | ||
| nsswitch | ||
| pam_smbpass | ||
| param | ||
| passdb | ||
| pkgconfig | ||
| po | ||
| popt | ||
| printing | ||
| profile | ||
| registry | ||
| rpc_client | ||
| rpc_parse | ||
| rpc_server | ||
| rpcclient | ||
| script | ||
| services | ||
| smbd | ||
| stf | ||
| tests | ||
| torture | ||
| utils | ||
| web | ||
| winbindd | ||
| .dmallocrc | ||
| .indent.pro | ||
| autogen.sh | ||
| change-log | ||
| config.guess | ||
| config.sub | ||
| configure.developer | ||
| configure.in | ||
| Doxyfile | ||
| dynconfig.c | ||
| install-sh | ||
| library-versions.in | ||
| mainpage.dox | ||
| Makefile.in | ||
| smbadduser.in | ||
| VERSION | ||