mirror of
https://github.com/samba-team/samba.git
synced 2025-03-12 20:58:37 +03:00
We would sometimes see the auth_log test hang during a CI run. The CI job would eventually fail after consuming a costly 10 hours of CI runtime. We believe the problem is around the test creating multiple instances of the Messaging() context. This is a similar race condition to what was seen in 19f34b2161dee26. Currently a new Messaging() context is created for every test case. By using classmethods instead, the Messaging context is only created once per python test file execution (i.e. creation of the python class, rather than initialization of the python object, which happens for every test-case). This means the test will only create one Messaging() context, which should avoid any race conditions. Changes: + removed msg_ctxs - this wasn't actually used for anything. + use classmethods to setup and tear-down the Messaging() context (and tweak lp initialization accordingly). + fix discardMessages() - the loop wasn't actually discarding any messages previously (this may also have been the cause of the test hanging). Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz> Signed-off-by: Tim Beale <timbeale@catalyst.net.nz> Reviewed-by: Noel Power <npower@samba.org> Autobuild-User(master): Noel Power <npower@samba.org> Autobuild-Date(master): Tue Mar 5 13:10:43 UTC 2019 on sn-devel-144
156 lines
5.5 KiB
Python
156 lines
5.5 KiB
Python
# Unix SMB/CIFS implementation.
|
|
# Copyright (C) Andrew Bartlett <abartlet@samba.org> 2017
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
#
|
|
|
|
from __future__ import print_function
|
|
"""Tests for the Auth and AuthZ logging.
|
|
"""
|
|
|
|
import samba.tests
|
|
from samba.messaging import Messaging
|
|
from samba.dcerpc.messaging import MSG_AUTH_LOG, AUTH_EVENT_NAME
|
|
from samba.param import LoadParm
|
|
import time
|
|
import json
|
|
import os
|
|
import re
|
|
from samba import param
|
|
|
|
|
|
class AuthLogTestBase(samba.tests.TestCase):
|
|
|
|
@classmethod
|
|
def setUpClass(self):
|
|
# connect to the server's messaging bus (we need to explicitly load a
|
|
# different smb.conf here, because in all other respects this test
|
|
# wants to act as a separate remote client)
|
|
server_conf = os.getenv('SERVERCONFFILE')
|
|
if server_conf:
|
|
lp_ctx = LoadParm(filename_for_non_global_lp=server_conf)
|
|
else:
|
|
samba.tests.env_loadparm()
|
|
self.msg_ctx = Messaging((1,), lp_ctx=lp_ctx)
|
|
self.msg_ctx.irpc_add_name(AUTH_EVENT_NAME)
|
|
|
|
# Now switch back to using the client-side smb.conf. The tests will
|
|
# use the first interface in the client.conf (we need to strip off
|
|
# the subnet mask portion)
|
|
lp_ctx = samba.tests.env_loadparm()
|
|
client_ip_and_mask = lp_ctx.get('interfaces')[0]
|
|
client_ip = client_ip_and_mask.split('/')[0]
|
|
|
|
# the messaging ctx is the server's view of the world, so our own
|
|
# client IP will be the remoteAddress when connections are logged
|
|
self.remoteAddress = client_ip
|
|
|
|
def messageHandler(context, msgType, src, message):
|
|
# This does not look like sub unit output and it
|
|
# makes these tests much easier to debug.
|
|
print(message)
|
|
jsonMsg = json.loads(message)
|
|
context["messages"].append(jsonMsg)
|
|
|
|
self.context = {"messages": []}
|
|
self.msg_handler_and_context = (messageHandler, self.context)
|
|
self.msg_ctx.register(self.msg_handler_and_context,
|
|
msg_type=MSG_AUTH_LOG)
|
|
|
|
self.remoteAddress = None
|
|
self.server = os.environ["SERVER"]
|
|
self.connection = None
|
|
|
|
@classmethod
|
|
def tearDownClass(self):
|
|
if self.msg_handler_and_context:
|
|
self.msg_ctx.deregister(self.msg_handler_and_context,
|
|
msg_type=MSG_AUTH_LOG)
|
|
self.msg_ctx.irpc_remove_name(AUTH_EVENT_NAME)
|
|
|
|
def setUp(self):
|
|
super(AuthLogTestBase, self).setUp()
|
|
self.discardMessages()
|
|
|
|
def waitForMessages(self, isLastExpectedMessage, connection=None):
|
|
"""Wait for all the expected messages to arrive
|
|
The connection is passed through to keep the connection alive
|
|
until all the logging messages have been received.
|
|
"""
|
|
|
|
def completed(messages):
|
|
for message in messages:
|
|
if isRemote(message) and isLastExpectedMessage(message):
|
|
return True
|
|
return False
|
|
|
|
def isRemote(message):
|
|
if self.remoteAddress is None:
|
|
return True
|
|
|
|
remote = None
|
|
if message["type"] == "Authorization":
|
|
remote = message["Authorization"]["remoteAddress"]
|
|
elif message["type"] == "Authentication":
|
|
remote = message["Authentication"]["remoteAddress"]
|
|
else:
|
|
return False
|
|
|
|
try:
|
|
addr = remote.split(":")
|
|
return addr[1] == self.remoteAddress
|
|
except IndexError:
|
|
return False
|
|
|
|
self.connection = connection
|
|
|
|
start_time = time.time()
|
|
while not completed(self.context["messages"]):
|
|
self.msg_ctx.loop_once(0.1)
|
|
if time.time() - start_time > 1:
|
|
self.connection = None
|
|
return []
|
|
|
|
self.connection = None
|
|
return list(filter(isRemote, self.context["messages"]))
|
|
|
|
# Discard any previously queued messages.
|
|
@classmethod
|
|
def discardMessages(self):
|
|
self.msg_ctx.loop_once(0.001)
|
|
while len(self.context["messages"]):
|
|
self.context["messages"] = []
|
|
self.msg_ctx.loop_once(0.001)
|
|
|
|
# Remove any NETLOGON authentication messages
|
|
# NETLOGON is only performed once per session, so to avoid ordering
|
|
# dependencies within the tests it's best to strip out NETLOGON messages.
|
|
#
|
|
def remove_netlogon_messages(self, messages):
|
|
def is_not_netlogon(msg):
|
|
if "Authentication" not in msg:
|
|
return True
|
|
sd = msg["Authentication"]["serviceDescription"]
|
|
return sd != "NETLOGON"
|
|
|
|
return list(filter(is_not_netlogon, messages))
|
|
|
|
GUID_RE = "[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}"
|
|
|
|
#
|
|
# Is the supplied GUID string correctly formatted
|
|
#
|
|
def is_guid(self, guid):
|
|
return re.match(self.GUID_RE, guid)
|