1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
samba-mirror/libcli/smb/smb2cli_ioctl.c
Stefan Metzmacher 91e12e04fc libcli/smb: make sure we have a body size of 0x31 before dereferencing an ioctl response
Found by valgrind, reported by Noel Power <nopower@suse.com>:

==7913== Invalid read of size 1
==7913==    at 0xC4F23EE: smb2cli_ioctl_done (smb2cli_ioctl.c:245)
==7913==    by 0x747A744: _tevent_req_notify_callback (tevent_req.c:112)
==7913==    by 0x747A817: tevent_req_finish (tevent_req.c:149)
==7913==    by 0x747A93C: tevent_req_trigger (tevent_req.c:206)
==7913==    by 0x7479B2B: tevent_common_loop_immediate
(tevent_immediate.c:135)
==7913==    by 0xA9CB4BE: run_events_poll (events.c:192)
==7913==    by 0xA9CBB32: s3_event_loop_once (events.c:303)
==7913==    by 0x7478C72: _tevent_loop_once (tevent.c:533)
==7913==    by 0x747AACD: tevent_req_poll (tevent_req.c:256)
==7913==    by 0x505315D: tevent_req_poll_ntstatus (tevent_ntstatus.c:109)
==7913==    by 0xA7201F2: cli_tree_connect (cliconnect.c:2764)
==7913==    by 0x165FF7: cm_prepare_connection (winbindd_cm.c:1276)
==7913==  Address 0x16ce24ec is 764 bytes inside a block of size 813 alloc'd
==7913==    at 0x4C29110: malloc (in
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==7913==    by 0x768A0C1: __talloc_with_prefix (talloc.c:668)
==7913==    by 0x768A27E: _talloc_pool (talloc.c:721)
==7913==    by 0x768A41E: _talloc_pooled_object (talloc.c:790)
==7913==    by 0x747A594: _tevent_req_create (tevent_req.c:66)
==7913==    by 0xCF6E2FA: read_packet_send (async_sock.c:414)
==7913==    by 0xCF6EB54: read_smb_send (read_smb.c:54)
==7913==    by 0xC4DA146: smbXcli_conn_receive_next (smbXcli_base.c:1027)
==7913==    by 0xC4DA02D: smbXcli_req_set_pending (smbXcli_base.c:978)
==7913==    by 0xC4DF776: smb2cli_req_compound_submit (smbXcli_base.c:3166)
==7913==    by 0xC4DFC1D: smb2cli_req_send (smbXcli_base.c:3268)
==7913==    by 0xC4F2210: smb2cli_ioctl_send (smb2cli_ioctl.c:149)
==7913==

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11622

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2015-12-01 00:38:23 +01:00

435 lines
11 KiB
C

/*
Unix SMB/CIFS implementation.
smb2 lib
Copyright (C) Stefan Metzmacher 2011
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#include "includes.h"
#include "system/network.h"
#include "lib/util/tevent_ntstatus.h"
#include "smb_common.h"
#include "smbXcli_base.h"
struct smb2cli_ioctl_state {
uint8_t fixed[0x38];
uint8_t dyn_pad[1];
uint32_t max_input_length;
uint32_t max_output_length;
struct iovec *recv_iov;
bool out_valid;
DATA_BLOB out_input_buffer;
DATA_BLOB out_output_buffer;
uint32_t ctl_code;
};
static void smb2cli_ioctl_done(struct tevent_req *subreq);
struct tevent_req *smb2cli_ioctl_send(TALLOC_CTX *mem_ctx,
struct tevent_context *ev,
struct smbXcli_conn *conn,
uint32_t timeout_msec,
struct smbXcli_session *session,
struct smbXcli_tcon *tcon,
uint64_t in_fid_persistent,
uint64_t in_fid_volatile,
uint32_t in_ctl_code,
uint32_t in_max_input_length,
const DATA_BLOB *in_input_buffer,
uint32_t in_max_output_length,
const DATA_BLOB *in_output_buffer,
uint32_t in_flags)
{
struct tevent_req *req, *subreq;
struct smb2cli_ioctl_state *state;
uint8_t *fixed;
uint8_t *dyn;
size_t dyn_len;
uint32_t input_buffer_offset = 0;
uint32_t input_buffer_length = 0;
uint32_t output_buffer_offset = 0;
uint32_t output_buffer_length = 0;
uint32_t pad_length = 0;
uint64_t tmp64;
uint32_t max_dyn_len = 0;
req = tevent_req_create(mem_ctx, &state,
struct smb2cli_ioctl_state);
if (req == NULL) {
return NULL;
}
state->ctl_code = in_ctl_code;
state->max_input_length = in_max_input_length;
state->max_output_length = in_max_output_length;
tmp64 = in_max_input_length;
tmp64 += in_max_output_length;
if (tmp64 > UINT32_MAX) {
max_dyn_len = UINT32_MAX;
} else {
max_dyn_len = tmp64;
}
if (in_input_buffer) {
input_buffer_offset = SMB2_HDR_BODY+0x38;
input_buffer_length = in_input_buffer->length;
}
if (in_output_buffer) {
output_buffer_offset = SMB2_HDR_BODY+0x38;
output_buffer_length = in_output_buffer->length;
if (input_buffer_length > 0 && output_buffer_length > 0) {
uint32_t tmp;
output_buffer_offset += input_buffer_length;
tmp = output_buffer_offset;
output_buffer_offset = NDR_ROUND(output_buffer_offset, 8);
pad_length = output_buffer_offset - tmp;
}
}
fixed = state->fixed;
SSVAL(fixed, 0x00, 0x39);
SSVAL(fixed, 0x02, 0); /* reserved */
SIVAL(fixed, 0x04, in_ctl_code);
SBVAL(fixed, 0x08, in_fid_persistent);
SBVAL(fixed, 0x10, in_fid_volatile);
SIVAL(fixed, 0x18, input_buffer_offset);
SIVAL(fixed, 0x1C, input_buffer_length);
SIVAL(fixed, 0x20, in_max_input_length);
SIVAL(fixed, 0x24, output_buffer_offset);
SIVAL(fixed, 0x28, output_buffer_length);
SIVAL(fixed, 0x2C, in_max_output_length);
SIVAL(fixed, 0x30, in_flags);
SIVAL(fixed, 0x34, 0); /* reserved */
if (input_buffer_length > 0 && output_buffer_length > 0) {
size_t avail = UINT32_MAX - (input_buffer_length + pad_length);
size_t ofs = output_buffer_offset - input_buffer_offset;
if (avail < output_buffer_length) {
tevent_req_nterror(req, NT_STATUS_INVALID_PARAMETER_MIX);
return tevent_req_post(req, ev);
}
dyn_len = input_buffer_length + output_buffer_length + pad_length;
dyn = talloc_zero_array(state, uint8_t, dyn_len);
if (tevent_req_nomem(dyn, req)) {
return tevent_req_post(req, ev);
}
memcpy(dyn, in_input_buffer->data,
in_input_buffer->length);
memcpy(dyn + ofs, in_output_buffer->data,
in_output_buffer->length);
} else if (input_buffer_length > 0) {
dyn = in_input_buffer->data;
dyn_len = in_input_buffer->length;
} else if (output_buffer_length > 0) {
dyn = in_output_buffer->data;
dyn_len = in_output_buffer->length;
} else {
dyn = state->dyn_pad;
dyn_len = sizeof(state->dyn_pad);
}
subreq = smb2cli_req_send(state, ev, conn, SMB2_OP_IOCTL,
0, 0, /* flags */
timeout_msec,
tcon,
session,
state->fixed, sizeof(state->fixed),
dyn, dyn_len,
max_dyn_len);
if (tevent_req_nomem(subreq, req)) {
return tevent_req_post(req, ev);
}
tevent_req_set_callback(subreq, smb2cli_ioctl_done, req);
return req;
}
static void smb2cli_ioctl_done(struct tevent_req *subreq)
{
struct tevent_req *req =
tevent_req_callback_data(subreq,
struct tevent_req);
struct smb2cli_ioctl_state *state =
tevent_req_data(req,
struct smb2cli_ioctl_state);
NTSTATUS status;
struct iovec *iov;
uint8_t *fixed;
uint8_t *dyn;
size_t dyn_len;
uint32_t dyn_ofs = SMB2_HDR_BODY + 0x30;
uint32_t input_buffer_offset;
uint32_t input_buffer_length;
uint32_t output_buffer_offset;
uint32_t output_buffer_length;
static const struct smb2cli_req_expected_response expected[] = {
{
.status = NT_STATUS_OK,
.body_size = 0x31
},
{
.status = STATUS_BUFFER_OVERFLOW,
.body_size = 0x31
},
{
/*
* We need to make sure that
* a response with NT_STATUS_FILE_CLOSED
* without signing generates NT_STATUS_ACCESS_DENIED
* if the request was signed.
*/
.status = NT_STATUS_FILE_CLOSED,
.body_size = 0x09,
},
{
/*
* a normal error
*/
.status = NT_STATUS_INVALID_PARAMETER,
.body_size = 0x09
},
{
/*
* a special case for FSCTL_SRV_COPYCHUNK_*
*/
.status = NT_STATUS_INVALID_PARAMETER,
.body_size = 0x31
},
};
status = smb2cli_req_recv(subreq, state, &iov,
expected, ARRAY_SIZE(expected));
TALLOC_FREE(subreq);
if (NT_STATUS_EQUAL(status, NT_STATUS_INVALID_PARAMETER)) {
switch (state->ctl_code) {
case FSCTL_SRV_COPYCHUNK:
case FSCTL_SRV_COPYCHUNK_WRITE:
break;
default:
tevent_req_nterror(req, status);
return;
}
if (iov[1].iov_len != 0x30) {
tevent_req_nterror(req,
NT_STATUS_INVALID_NETWORK_RESPONSE);
return;
}
} else if (NT_STATUS_EQUAL(status, STATUS_BUFFER_OVERFLOW)) {
/* no error */
} else {
if (tevent_req_nterror(req, status)) {
return;
}
}
/*
* At this stage we're sure that got a body size of 0x31,
* either with NT_STATUS_OK, STATUS_BUFFER_OVERFLOW or
* NT_STATUS_INVALID_PARAMETER.
*/
state->recv_iov = iov;
fixed = (uint8_t *)iov[1].iov_base;
dyn = (uint8_t *)iov[2].iov_base;
dyn_len = iov[2].iov_len;
input_buffer_offset = IVAL(fixed, 0x18);
input_buffer_length = IVAL(fixed, 0x1C);
output_buffer_offset = IVAL(fixed, 0x20);
output_buffer_length = IVAL(fixed, 0x24);
if ((input_buffer_offset > 0) && (input_buffer_length > 0)) {
uint32_t ofs;
if (input_buffer_offset != dyn_ofs) {
tevent_req_nterror(
req, NT_STATUS_INVALID_NETWORK_RESPONSE);
return;
}
ofs = input_buffer_length;
ofs = NDR_ROUND(ofs, 8);
if (state->max_input_length == 0) {
/*
* If max_input_length is 0 we ignore
* the input_buffer_length, because
* Windows 2008 echos the DCERPC request
* from the requested input_buffer
* to the response input_buffer.
*/
input_buffer_length = 0;
}
if (input_buffer_length > dyn_len) {
tevent_req_nterror(
req, NT_STATUS_INVALID_NETWORK_RESPONSE);
return;
}
if (input_buffer_length > state->max_input_length) {
tevent_req_nterror(
req, NT_STATUS_INVALID_NETWORK_RESPONSE);
return;
}
state->out_input_buffer.data = dyn;
state->out_input_buffer.length = input_buffer_length;
if (ofs > dyn_len) {
tevent_req_nterror(
req, NT_STATUS_INVALID_NETWORK_RESPONSE);
return;
}
dyn_ofs += ofs;
dyn += ofs;
dyn_len -= ofs;
}
if ((output_buffer_offset > 0) && (output_buffer_length > 0)) {
if (output_buffer_offset != dyn_ofs) {
tevent_req_nterror(
req, NT_STATUS_INVALID_NETWORK_RESPONSE);
return;
}
if (state->max_output_length == 0) {
/*
* We do the same logic as for
* max_input_length.
*/
output_buffer_length = 0;
}
if (output_buffer_length > dyn_len) {
tevent_req_nterror(
req, NT_STATUS_INVALID_NETWORK_RESPONSE);
return;
}
if (output_buffer_length > state->max_output_length) {
tevent_req_nterror(
req, NT_STATUS_INVALID_NETWORK_RESPONSE);
return;
}
state->out_output_buffer.data = dyn;
state->out_output_buffer.length = output_buffer_length;
}
state->out_valid = true;
if (tevent_req_nterror(req, status)) {
return;
}
tevent_req_done(req);
}
NTSTATUS smb2cli_ioctl_recv(struct tevent_req *req,
TALLOC_CTX *mem_ctx,
DATA_BLOB *out_input_buffer,
DATA_BLOB *out_output_buffer)
{
struct smb2cli_ioctl_state *state =
tevent_req_data(req,
struct smb2cli_ioctl_state);
NTSTATUS status = NT_STATUS_OK;
if (tevent_req_is_nterror(req, &status) && !state->out_valid) {
if (out_input_buffer) {
*out_input_buffer = data_blob_null;
}
if (out_output_buffer) {
*out_output_buffer = data_blob_null;
}
tevent_req_received(req);
return status;
}
talloc_steal(mem_ctx, state->recv_iov);
if (out_input_buffer) {
*out_input_buffer = state->out_input_buffer;
}
if (out_output_buffer) {
*out_output_buffer = state->out_output_buffer;
}
tevent_req_received(req);
return status;
}
NTSTATUS smb2cli_ioctl(struct smbXcli_conn *conn,
uint32_t timeout_msec,
struct smbXcli_session *session,
struct smbXcli_tcon *tcon,
uint64_t in_fid_persistent,
uint64_t in_fid_volatile,
uint32_t in_ctl_code,
uint32_t in_max_input_length,
const DATA_BLOB *in_input_buffer,
uint32_t in_max_output_length,
const DATA_BLOB *in_output_buffer,
uint32_t in_flags,
TALLOC_CTX *mem_ctx,
DATA_BLOB *out_input_buffer,
DATA_BLOB *out_output_buffer)
{
TALLOC_CTX *frame = talloc_stackframe();
struct tevent_context *ev;
struct tevent_req *req;
NTSTATUS status = NT_STATUS_NO_MEMORY;
if (smbXcli_conn_has_async_calls(conn)) {
/*
* Can't use sync call while an async call is in flight
*/
status = NT_STATUS_INVALID_PARAMETER_MIX;
goto fail;
}
ev = samba_tevent_context_init(frame);
if (ev == NULL) {
goto fail;
}
req = smb2cli_ioctl_send(frame, ev, conn, timeout_msec,
session, tcon,
in_fid_persistent,
in_fid_volatile,
in_ctl_code,
in_max_input_length,
in_input_buffer,
in_max_output_length,
in_output_buffer,
in_flags);
if (req == NULL) {
goto fail;
}
if (!tevent_req_poll_ntstatus(req, ev, &status)) {
goto fail;
}
status = smb2cli_ioctl_recv(req, mem_ctx,
out_input_buffer,
out_output_buffer);
fail:
TALLOC_FREE(frame);
return status;
}