mirror of
https://github.com/samba-team/samba.git
synced 2025-01-11 05:18:09 +03:00
2d0766a48b
We were creating the getnc_state (and storing it on the connection) before we had done some basic checks that the request was valid. If the request was not valid and we returned early with an error, then the partially-initialized getnc_state was left hanging on the connection. The next request that got sent on the connection would try to use this, rather than creating a new getnc_state from scratch. The main side-effect of this was if you sent an invalid GetNCChanges request twice, then it could be rejected the first time and accepted the second time. Note that although an invalid request was accepted, it would typically not return any objects, so it would not actually leak any secure information. Signed-off-by: Tim Beale <timbeale@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> |
||
|---|---|---|
| .. | ||
| backupkey | ||
| browser | ||
| common | ||
| dnsserver | ||
| drsuapi | ||
| echo | ||
| epmapper | ||
| eventlog | ||
| lsa | ||
| netlogon | ||
| remote | ||
| samr | ||
| srvsvc | ||
| unixinfo | ||
| winreg | ||
| wkssvc | ||
| dcerpc_server.c | ||
| dcerpc_server.h | ||
| dcerpc_server.pc.in | ||
| dcesrv_auth.c | ||
| dcesrv_mgmt.c | ||
| handles.c | ||
| service_rpc.c | ||
| wscript_build | ||