1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-05 09:18:06 +03:00
samba-mirror/source4/auth/ntlmssp
Andrew Tridgell 69c7cd98ce r10669: reverted jelmers commit 10663 as it was causing lots of panics in 'make test'
I also think the method of getting rid of pstring isn't the right
one. I certainly do want to get rid of pstring/fstring, but the reason
for removing them is the use of arbitrary sized fixed length strings
on the stack and in structures. Changing to another fixed length stack
string format isn't really a win, and moving to use strncpy() is
actually worse than pstrcpy() as strncpy() has the absolutely awful
semantics of always zeroing all remaining bytes, so it ends up taking
a lot of cpu doing pointless memory writes.

I'd rather move to more use of asprintf()/talloc_asprintf() and
similar functions for dynamic string allocation.

You also have to be very careful about some of these system defined
string limits. One some systems PATH_MAX could be 64k or even larger,
which can quickly blow the stack out when you allocate a few of them.
(This used to be commit 194efd26e4)
2007-10-10 13:39:16 -05:00
..
config.mk r6810: Rename auth/{ntlmssp,gensec,kerberos} mk and m4 files to be called 2007-10-10 13:16:46 -05:00
ntlmssp_client.c r10402: Make the RPC-SAMLOGON test pass against Win2k3 SP0 again. 2007-10-10 13:38:39 -05:00
ntlmssp_parse.c r10669: reverted jelmers commit 10663 as it was causing lots of panics in 'make test' 2007-10-10 13:39:16 -05:00
ntlmssp_server.c r10669: reverted jelmers commit 10663 as it was causing lots of panics in 'make test' 2007-10-10 13:39:16 -05:00
ntlmssp_sign.c r10153: This patch adds a new parameter to gensec_sig_size(), the size of the 2007-10-10 13:38:04 -05:00
ntlmssp.c r9505: Work on GENSEC and the code that calls it, for tighter interface 2007-10-10 13:34:24 -05:00
ntlmssp.h r9416: Cleanups inspired by jra's work to migrate Samba4's NTLMSSP code back 2007-10-10 13:33:36 -05:00